[clang] [sanitizer] Fix empty string in unsupported argument error for -fsanitize-trap (PR #136549)

2025-05-15 Thread Sinkevich Artem via cfe-commits
ArtSin wrote: @thurstond can you please merge this? I don't have write access. https://github.com/llvm/llvm-project/pull/136549 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [sanitizer] Fix empty string in unsupported argument error for -fsanitize-trap (PR #136549)

2025-05-15 Thread Sinkevich Artem via cfe-commits
ArtSin wrote: > Perhaps a better fix would be to correct the toString function I agree, but adding groups to `toString` breaks its other uses. What do you think about separate `toStringWithGroups`? https://github.com/llvm/llvm-project/pull/136549 ___

[clang] [sanitizer] Fix empty string in unsupported argument error for -fsanitize-trap (PR #136549)

2025-05-15 Thread Sinkevich Artem via cfe-commits
https://github.com/ArtSin updated https://github.com/llvm/llvm-project/pull/136549 >From 626d7e1fa3ce19c0bed7273f07439ff85f3de58c Mon Sep 17 00:00:00 2001 From: Artem Sinkevich Date: Mon, 21 Apr 2025 12:48:51 +0400 Subject: [PATCH] [sanitizer] Fix empty string in unsupported argument error for

[clang] [sanitizer] Fix empty string in unsupported argument error for -fsanitize-trap (PR #136549)

2025-05-15 Thread Sinkevich Artem via cfe-commits
https://github.com/ArtSin edited https://github.com/llvm/llvm-project/pull/136549 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [sanitizer] Fix empty string in unsupported argument error for -fsanitize-trap (PR #136549)

2025-05-14 Thread Sinkevich Artem via cfe-commits
ArtSin wrote: Ping @vitalybuka https://github.com/llvm/llvm-project/pull/136549 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [sanitizer] Fix empty string in unsupported argument error for -fsanitize-trap (PR #136549)

2025-05-08 Thread Sinkevich Artem via cfe-commits
ArtSin wrote: PTAL @thurstond https://github.com/llvm/llvm-project/pull/136549 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [sanitizer] Fix empty string in unsupported argument error for -fsanitize-trap (PR #136549)

2025-05-06 Thread Sinkevich Artem via cfe-commits
ArtSin wrote: Ping https://github.com/llvm/llvm-project/pull/136549 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [sanitizer] Fix empty string in unsupported argument error for -fsanitize-trap (PR #136549)

2025-05-06 Thread Sinkevich Artem via cfe-commits
https://github.com/ArtSin updated https://github.com/llvm/llvm-project/pull/136549 >From f5c8b4ea6539976e759e8fe183e009475d895052 Mon Sep 17 00:00:00 2001 From: Artem Sinkevich Date: Mon, 21 Apr 2025 12:48:51 +0400 Subject: [PATCH] [sanitizer] Fix empty string in unsupported argument error for

[clang] [sanitizer] Fix empty string in unsupported argument error for -fsanitize-trap (PR #136549)

2025-04-21 Thread Sinkevich Artem via cfe-commits
ArtSin wrote: PTAL @vitalybuka https://github.com/llvm/llvm-project/pull/136549 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [sanitizer] Fix empty string in unsupported argument error for -fsanitize-trap (PR #136549)

2025-04-21 Thread Sinkevich Artem via cfe-commits
https://github.com/ArtSin created https://github.com/llvm/llvm-project/pull/136549 When using `-fsanitize-trap` with a sanitizer group that doesn't support trapping, an empty argument is passed to `err_drv_unsupported_option_argument`. Expand groups for the diagnostic. >From 459d375073093ebec

[clang] [compiler-rt] [profile] Add `%b` `LLVM_PROFILE_FILE` option for binary ID (PR #123963)

2025-02-06 Thread Sinkevich Artem via cfe-commits
ArtSin wrote: @ZequanWu can you please merge this? https://github.com/llvm/llvm-project/pull/123963 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [compiler-rt] [profile] Add `%b` `LLVM_PROFILE_FILE` option for binary ID (PR #123963)

2025-02-06 Thread Sinkevich Artem via cfe-commits
https://github.com/ArtSin updated https://github.com/llvm/llvm-project/pull/123963 >From 3ebeb7bac943e447adecbefcebbd1f4f5b8d03aa Mon Sep 17 00:00:00 2001 From: Artem Sinkevich Date: Thu, 6 Feb 2025 13:56:56 +0400 Subject: [PATCH] [profile] Add `%b` `LLVM_PROFILE_FILE` option for binary ID Add

[clang] [compiler-rt] [profile] Add `%b` `LLVM_PROFILE_FILE` option for binary ID (PR #123963)

2025-02-05 Thread Sinkevich Artem via cfe-commits
@@ -2917,7 +2918,7 @@ instrumentation: $ LLVM_PROFILE_FILE="code-%m.profraw" ./code See `this `_ section - about the ``%t``, and ``%c`` modifiers. + about the ``%b``, ``%t``, and ``%c`` modifiers. ArtSin wrote: Done https://github.com/llvm/llvm-

[clang] [compiler-rt] [profile] Add `%b` `LLVM_PROFILE_FILE` option for binary ID (PR #123963)

2025-02-05 Thread Sinkevich Artem via cfe-commits
https://github.com/ArtSin updated https://github.com/llvm/llvm-project/pull/123963 >From 1d1b66d11cddbb2d663879a9bd23bc4eadf6beba Mon Sep 17 00:00:00 2001 From: Artem Sinkevich Date: Wed, 5 Feb 2025 15:14:25 +0400 Subject: [PATCH] [profile] Add `%b` `LLVM_PROFILE_FILE` option for binary ID Add

[clang] [compiler-rt] [profile] Add `%b` `LLVM_PROFILE_FILE` option for binary ID (PR #123963)

2025-02-04 Thread Sinkevich Artem via cfe-commits
@@ -855,6 +856,15 @@ static int parseFilenamePattern(const char *FilenamePat, FilenamePat); return -1; } + } else if (FilenamePat[I] == 'b') { +if (!NumBinaryIds++) { + if (__llvm_write_binary_ids(NULL) <= 0) { ---

[clang] [compiler-rt] [profile] Add `%b` `LLVM_PROFILE_FILE` option for binary ID (PR #123963)

2025-02-04 Thread Sinkevich Artem via cfe-commits
@@ -0,0 +1,37 @@ +// REQUIRES: linux +// RUN: split-file %s %t.dir +// RUN: %clang_profgen -Wl,--build-id=sha1 -o %t.dir/foo %t.dir/foo.c +// RUN: %clang_profgen -Wl,--build-id=sha1 -o %t.dir/bar %t.dir/bar.c + +// Check that foo and bar have the same signatures. +// RUN: rm -rf %

[clang] [compiler-rt] [profile] Add `%b` `LLVM_PROFILE_FILE` option for binary ID (PR #123963)

2025-02-04 Thread Sinkevich Artem via cfe-commits
https://github.com/ArtSin updated https://github.com/llvm/llvm-project/pull/123963 >From 462b70cfc9f9ad3cafc0dbf595ce758181ecb2a5 Mon Sep 17 00:00:00 2001 From: Artem Sinkevich Date: Tue, 4 Feb 2025 16:27:51 +0400 Subject: [PATCH] [profile] Add `%b` `LLVM_PROFILE_FILE` option for binary ID Add

[clang] [compiler-rt] [profile] Add `%b` `LLVM_PROFILE_FILE` option for binary ID (PR #123963)

2025-02-02 Thread Sinkevich Artem via cfe-commits
ArtSin wrote: PTAL @ZequanWu @david-xl https://github.com/llvm/llvm-project/pull/123963 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [compiler-rt] [profile] Add `%b` `LLVM_PROFILE_FILE` option for binary ID (PR #123963)

2025-01-22 Thread Sinkevich Artem via cfe-commits
https://github.com/ArtSin updated https://github.com/llvm/llvm-project/pull/123963 >From e7f3e39cbb912b45fad7ef243af7872332ba0c9d Mon Sep 17 00:00:00 2001 From: Artem Sinkevich Date: Wed, 22 Jan 2025 20:20:56 +0400 Subject: [PATCH] [profile] Add `%b` `LLVM_PROFILE_FILE` option for binary ID Ad

[clang] [compiler-rt] [profile] Add `%b` `LLVM_PROFILE_FILE` option for binary ID (PR #123963)

2025-01-22 Thread Sinkevich Artem via cfe-commits
https://github.com/ArtSin created https://github.com/llvm/llvm-project/pull/123963 Add support for expanding `%b` in `LLVM_PROFILE_FILE` to the binary ID (build ID). It can be used with `%m` to avoid its signature collisions. This is supported on all platforms where writing binary IDs into pro