[PATCH] D121816: [Clang][VE] Add vector mask intrinsics to clang

simoll added a comment. In D121816#3388748 , @kaz7 wrote: > Having timeout errors on lldb-aarch64-ubuntu builder... I'm not sure what > modification on this patch causes a such error. There's another commit tested in the failing run: https://lab.llvm.

[PATCH] D121586: [Clang][VE] Add the rest of intrinsics to clang

simoll added a comment. @kaz7 With rG0aab34410403 in tree you should be able to enable the masked intrinsics now. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121586/new/ http

[PATCH] D88905: [Clang] Allow "ext_vector_type" applied to Booleans

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG0aab34410403: [Clang] Allow "ext_vector_type" applied to Booleans (authored by simoll). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST AC

[PATCH] D88905: [Clang] Allow "ext_vector_type" applied to Booleans

simoll added inline comments. Comment at: clang/test/SemaCXX/constexpr-vectors.cpp:680 +using FourBoolsExtVec __attribute__((ext_vector_type(4))) = bool; +void BoolVecUsage() { @erichkeane This is the constexpr test you were looking for Repository: rG LLVM

[PATCH] D88905: [Clang] Allow "ext_vector_type" applied to Booleans

simoll updated this revision to Diff 415509. simoll added a comment. Check IR generated for constexpr of bool vectors. This actually revealed a bug in the bool vector sema (bool vector comparisons would result in byte sized elements). Thx! Repository: rG LLVM Github Monorepo CHANGES SINCE L

[PATCH] D88905: [Clang] Allow "ext_vector_type" applied to Booleans

simoll added a comment. In D88905#3382309 , @aaron.ballman wrote: > Thanks! Sema bits now LGTM Awesome! Who would be a good fit for the codegen parts of this patch? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm

[PATCH] D88905: [Clang] Allow "ext_vector_type" applied to Booleans

simoll updated this revision to Diff 415400. simoll added a comment. Make the sema check for bool vector arithmetic specific to ext_vector_type bool. This assures that we do not interfere with scalar bool + int vector arithmetic sema (`vector.cpp` test was failing before). Repository: rG LLV

[PATCH] D88905: [Clang] Allow "ext_vector_type" applied to Booleans

simoll updated this revision to Diff 415392. simoll added a comment. Blocking of arithmetic on bool vectors extends to the case where only one operand is a bool vector (and the other is, eg, a vector of int). This was still caught before during sema because the integer vector operand would have

[PATCH] D88905: [Clang] Allow "ext_vector_type" applied to Booleans

simoll added inline comments. Comment at: clang/lib/Sema/SemaExpr.cpp:10244-10245 + // This operation may not be performed on boolean vectors. + if (!AllowBoolOperation && (isBoolOrExtVectorBoolType(LHSType) && + isBoolOrExtVectorBoolType(RHSType)))

[PATCH] D88905: [Clang] Allow "ext_vector_type" applied to Booleans

simoll updated this revision to Diff 415153. simoll marked an inline comment as done. simoll added a comment. Simplify following comments. Thx :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88905/new/ https://reviews.llvm.org/D88905 Files: cla

[PATCH] D121586: [Clang][VE] Add the rest of intrinsics to clang

simoll accepted this revision. simoll added a comment. This revision is now accepted and ready to land. Thx Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121586/new/ https://reviews.llvm.org/D121586 ___

[PATCH] D88905: [Clang] Allow "ext_vector_type" applied to Booleans

simoll updated this revision to Diff 415079. simoll added a comment. Rebased Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88905/new/ https://reviews.llvm.org/D88905 Files: clang/docs/LanguageExtensions.rst clang/include/clang/AST/Type.h cla

[PATCH] D121586: [Clang][VE] Add the rest of intrinsics to clang

simoll added inline comments. Comment at: clang/include/clang/Basic/BuiltinsVEVL.gen.def:1242 +#if 0 +BUILTIN(__builtin_ve_vl_andm_mmm, "V256bV256bV256b", "n") +BUILTIN(__builtin_ve_vl_andm_MMM, "V512bV512bV512b", "n") Could you comment at the top of this file (i

[PATCH] D88905: [Clang] Allow "ext_vector_type" applied to Booleans

simoll added a comment. In D88905#3375676 , @aaron.ballman wrote: > In D88905#3362347 , @kaz7 wrote: > >> At the beginning, this implementation extends `vector_type` attribute which >> is GCC's attribute. So, thi

[PATCH] D120644: [clang][tests] Fix ve-toolchain tests with CLANG_DEFAULT_UNWINDLIB

simoll accepted this revision. simoll added a comment. This revision is now accepted and ready to land. LGTM. For the record, this is related to the issues with the `-fuse-ld` option in that a cmake flag globally overrides a toolchain default: https://reviews.llvm.org/D115045. Repository: rG

[PATCH] D88905: [Clang] Allow "ext_vector_type" applied to Booleans

simoll updated this revision to Diff 398115. simoll added a comment. Rebased onto vector conditionals changes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88905/new/ https://reviews.llvm.org/D88905 Files: clang/docs/LanguageExtensions.rst cla

[PATCH] D115045: [Clang] Ignore CLANG_DEFAULT_LINKER for custom-linker toolchains

simoll added a comment. In D115045#3175648 , @phosek wrote: > I don't think the updated logic is correct. For example, in the case of > Fuchsia we don't want to take `CLANG_DEFAULT_LINKER` into account, that's why > we override `getDefaultLinker`. I ass

[PATCH] D115045: [Clang] Ignore CLANG_DEFAULT_LINKER for custom-linker toolchains

simoll updated this revision to Diff 392297. simoll added a comment. Formatting / Cleanup Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115045/new/ https://reviews.llvm.org/D115045 Files: clang/include/clang/Driver/ToolChain.h clang/lib/Driver

[PATCH] D115045: [Clang] Ignore CLANG_DEFAULT_LINKER for custom-linker toolchains

simoll updated this revision to Diff 392067. simoll added a comment. Herald added subscribers: abrachet, kerbowa, ormris, atanasyan, jrtc27, aheejin, jgravelle-google, sbc100, nhaehnle, jvesely, sdardis, dschuff. Use the `-DCLANG_DEFAULT_LINKER` linker in all toolchains but VE. Since toolchains

[PATCH] D115045: [Clang] Ignore CLANG_DEFAULT_LINKER for custom-linker toolchains

simoll reopened this revision. simoll added a comment. This revision is now accepted and ready to land. I've reverted the patch for now, this may show up for other toolchains, too. This patch has pushed down the responsibility for handling `-DCLANG_DEFAULT_LINKER` to the toolchains. However, I d

[PATCH] D115045: [Clang] Ignore CLANG_DEFAULT_LINKER for custom-linker toolchains

This revision was automatically updated to reflect the committed changes. Closed by commit rG34a43f2115af: [Clang] Ignore CLANG_DEFAULT_LINKER for custom-linker toolchains (authored by simoll). Changed prior to commit: https://reviews.llvm.org/D115045?vs=391998&id=392022#toc Repository: rG L

[PATCH] D114527: [VE] Support multiple architectures installation

simoll accepted this revision. simoll added a comment. This revision is now accepted and ready to land. I will configure the `clang-ve-staging` bot to start testing libcxx/libcxxabi Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114527/new/ https://

[PATCH] D115045: [Clang] Ignore CLANG_DEFAULT_LINKER for custom-linker toolchains

simoll updated this revision to Diff 391998. simoll marked an inline comment as done. simoll added a comment. Simplified empty-string check as suggested Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115045/new/ https://reviews.llvm.org/D115045 Fil

[PATCH] D115045: [Clang] Ignore CLANG_DEFAULT_LINKER for custom-linker toolchains

simoll created this revision. simoll added reviewers: kaz7, MaskRay, phosek. simoll requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Before, the CLANG_DEFAULT_LINKER cmake option was a global override for the linker that shall be used on all

[PATCH] D108908: [clang] Add gcc-toolset-10 support (RHEL/CentOS 8)

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. simoll marked an inline comment as done. Closed by commit rGa5791badde32: [clang] Add gcc-toolset-10 support (RHEL/CentOS 8) (authored by simoll). Changed prior to com

[PATCH] D108908: [clang] Add gcc-toolset-10 support (RHEL/CentOS 8)

simoll created this revision. simoll added a project: clang. simoll requested review of this revision. Herald added a subscriber: cfe-commits. Clang only adds GCC paths for RHEL <= 7 'devtoolset-' Software Collections (SCL). This generalizes this support to also include the 'gcc-toolset-10' SCL

[PATCH] D88905: [Clang] Allow "ext_vector_type" applied to Booleans

simoll added a comment. ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88905/new/ https://reviews.llvm.org/D88905 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bi

[PATCH] D88905: [Clang] Allow "ext_vector_type" applied to Booleans

simoll added a comment. ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88905/new/ https://reviews.llvm.org/D88905 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bi

[PATCH] D94076: [VE] Change clang to support SjLj Loweirng

simoll added a comment. You might want to fix the typo in the title before committing this. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94076/new/ https://reviews.llvm.org/D94076 ___ cfe-commits mailin

[PATCH] D88905: [Clang] Allow "ext_vector_type" applied to Booleans

simoll updated this revision to Diff 314568. simoll marked an inline comment as done. simoll added a comment. NFC - Use `bool4` in docs. - Rebased, Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88905/new/ https://reviews.llvm.org/D88905 Files:

[PATCH] D88905: [Clang] Allow "ext_vector_type" applied to Booleans

simoll added a comment. AFAIK all comments were addressed. Could you have another look at/LGTM this? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88905/new/ https://reviews.llvm.org/D88905 ___ cfe-commi

[PATCH] D92386: [VE] Add standard include path and library path for C++

simoll accepted this revision. simoll added a comment. This revision is now accepted and ready to land. Thx! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92386/new/ https://reviews.llvm.org/D92386 ___ c

[PATCH] D92386: [VE] Add standard include path and library path for C++

simoll added inline comments. Comment at: clang/lib/Driver/ToolChains/VEToolchain.cpp:109 +return; + if (const char *cl_include_dir = getenv("NCC_CPLUS_INCLUDE_PATH")) { +SmallVector Dirs; Do we want a test for this code path? Ie, checking system include

[PATCH] D88905: [Clang] Allow "ext_vector_type" applied to Booleans

simoll added a comment. ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88905/new/ https://reviews.llvm.org/D88905 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-b

[PATCH] D71341: [VE,#4] Target vector intrinsics

simoll abandoned this revision. simoll added a comment. Herald added subscribers: dang, sstefan1. Herald added a reviewer: libc++. Herald added projects: libc++abi, libunwind. Herald added a reviewer: libc++abi. Herald added a reviewer: libunwind. A good share of VE vector intrinsics have been ups

[PATCH] D88905: [Clang] Allow "ext_vector_type" applied to Booleans

simoll added a comment. Any comments for this one? Is this good to go? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88905/new/ https://reviews.llvm.org/D88905 ___ cfe-commits mailing list cfe-commits@li

[PATCH] D81083: [Clang] Allow "vector_size" applied to Booleans

simoll abandoned this revision. simoll added a comment. Taking this off the review queues - we will use the `ext_vector_type` attribute instead (D88905 ). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81083/new/ ht

[PATCH] D88905: [Clang] Allow "ext_vector_type" applied to Booleans

simoll added inline comments. Comment at: clang/docs/LanguageExtensions.rst:488-489 + +The memory representation of a dense boolean vector is the smallest fitting +integer. The alignment is the number of bits rounded up to the next +power-of-two but at most the maximum vector al

[PATCH] D88905: [Clang] Allow "ext_vector_type" applied to Booleans

simoll updated this revision to Diff 302559. simoll marked 13 inline comments as done. simoll added a comment. - Addressed comments. - Made ext_vector_type bool un-castable (as any other ext_vector_type) - with tests. - Made bool vector element access illegal - with tests. - Rebased. Repository

[PATCH] D90396: [VE] Change to use integrated assembly by defualt

simoll accepted this revision. simoll added a comment. This revision is now accepted and ready to land. Great work! Thanks :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90396/new/ https://reviews.llvm.org/D90396

[PATCH] D81083: [Clang] Allow "vector_size" applied to Booleans

simoll added a comment. D88905 uses ext_vector_type instead of vector_size following up on @rsmith 's suggestion . The review should continue there. I'll keep D81083 around for reference

[PATCH] D88905: [Clang] Allow "ext_vector_type" applied to Booleans

simoll created this revision. simoll added reviewers: hfinkel, erichkeane, craig.topper, rsandifo-arm, kaz7, k-ishizaka, rengolin. Herald added subscribers: cfe-commits, pengfei, kristof.beyls. Herald added a project: clang. simoll requested review of this revision. This is the `ext_vector_type`

[PATCH] D81083: [Clang] Allow "vector_size" applied to Booleans

simoll updated this revision to Diff 296137. simoll added a comment. (wrong Diff attached in earlier update) - rebased Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81083/new/ https://reviews.llvm.org/D81083 Files: clang/docs/LanguageExtensions

[PATCH] D81083: [Clang] Allow "vector_size" applied to Booleans

simoll updated this revision to Diff 296135. simoll added a comment. Herald added subscribers: llvm-commits, nikic, pengfei, hiraditya, mgorny. Herald added a project: LLVM. fixed for privatized ElementCount members. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://revi

[PATCH] D81083: [Clang] Allow "vector_size" applied to Booleans

simoll added a comment. I'd like to hear your feedback on how to proceed with this patch. Here is what i would do: For this patch, we switch to ext_vector_type for bool vectors to not clash head on with GCC should GCC decide to allow vector_size bool with a different semantics in the future. F

[PATCH] D81083: [Clang] Allow "vector_size" applied to Booleans

simoll updated this revision to Diff 289893. simoll added a comment. Rebased Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81083/new/ https://reviews.llvm.org/D81083 Files: clang/docs/LanguageExtensions.rst clang/include/clang/AST/Type.h cla

[PATCH] D81083: [Clang] Allow "vector_size" applied to Booleans

simoll added a comment. In D81083#2237284 , @rsmith wrote: > Thanks for dropping by! > Have you considered using the `ext_vector_type` attribute instead of > `vector_size` for this? That would have a couple of advantages: > > - It's not a GCC attribute

[PATCH] D81083: [Clang] Allow "vector_size" applied to Booleans

simoll updated this revision to Diff 287692. simoll added a comment. NFC. Make clang-tidy happy. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81083/new/ https://reviews.llvm.org/D81083 Files: clang/docs/LanguageExtensions.rst clang/include/cl

[PATCH] D81083: [Clang] Allow "vector_size" applied to Booleans

simoll updated this revision to Diff 287658. simoll added a comment. - made bool-vector layout target dependent (one byte per bool element on Hexagon, one bit everywhere else). - Added hvx-specific debug info test. - Updated docs. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D81083: [Clang] Allow "vector_size" applied to Booleans

simoll added a comment. The Hexagon builtins explicitly require bool vectors to have 8-bit wide bool elements. That clashes with our new vector type because bool vectors in builtin functions and vector_size bool vectors have the same internal representation in Clang. However, AFAIK Hexagon is t

[PATCH] D81083: [Clang] Allow "vector_size" applied to Booleans

simoll added a comment. In D81083#2227760 , @rsandifo-arm wrote: > I'm not qualified to review the CodeGen stuff (or accept the patch, obvs. > :-)) but FWIW, here are some comments on the doc and Sema side. Thanks for your comments! Maybe you know peopl

[PATCH] D81083: [Clang] Allow "vector_size" applied to Booleans

simoll updated this revision to Diff 286971. simoll edited the summary of this revision. simoll added a comment. - Rebased. - Allow comparisons on boolean vectors. - Restored result type for vector comparisons on other types. - Added operator, alignment and constexpr tests. Repository: rG LLVM

[PATCH] D81083: [Clang] Allow "vector_size" applied to Booleans

simoll marked 4 inline comments as done. simoll added inline comments. Comment at: clang/docs/LanguageExtensions.rst:492 + +The memory representation of a boolean vector is the smallest fitting +power-of-two integer. The alignment is the alignment of that integer type. This ---

[PATCH] D81083: [Clang] Allow "vector_size" applied to Booleans

simoll planned changes to this revision. simoll marked 6 inline comments as done. simoll added inline comments. Comment at: clang/docs/LanguageExtensions.rst:492 + +The memory representation of a boolean vector is the smallest fitting +power-of-two integer. The alignment is the a

[PATCH] D81083: [Clang] Allow "vector_size" applied to Booleans

simoll updated this revision to Diff 285282. simoll added a comment. - Fixed type printing & added type printing test. - Rebased. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81083/new/ https://reviews.llvm.org/D81083 Files: clang/docs/Language

[PATCH] D85507: [VE] Remove obsoleted getVEAsmModeForCPU function

simoll accepted this revision. simoll added a comment. This revision is now accepted and ready to land. Feel free to commit something like this without review Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85507/new/ https://reviews.llvm.org/D85507

[PATCH] D81083: [Clang] Allow "vector_size" applied to Booleans

simoll updated this revision to Diff 283636. simoll added a comment. NFC. Cleanup. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81083/new/ https://reviews.llvm.org/D81083 Files: clang/docs/LanguageExtensions.rst clang/include/clang/AST/Type.h

[PATCH] D81083: [Clang] Allow "vector_size" applied to Booleans

simoll updated this revision to Diff 283632. simoll added a comment. Fixed debug info representation for bool vectors. Interpret 8*N with the N in vector_size(N) as the bool numbers of bits. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81083/new/

[PATCH] D81083: [Clang] Allow "vector_size" applied to Booleans

simoll planned changes to this revision. simoll added a comment. Thanks for the feedback! Planned change: interpret the `N` in `vector_size(N)` as the number of bytes in the type, such that, for example, a `vector_size(2)` bool vector holds 16 bits Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D81083: [Clang] Allow "vector_size" applied to Booleans

simoll added inline comments. Comment at: clang/docs/LanguageExtensions.rst:473 +architectures. The size parameter of a boolean vector type is the number of +bits in the vector (for all non-bool vectors, the number refers to the number +of bytes in the vector).

[PATCH] D81083: [Clang] Allow "vector_size" applied to Booleans

simoll added inline comments. Comment at: clang/docs/LanguageExtensions.rst:473 +architectures. The size parameter of a boolean vector type is the number of +bits in the vector (for all non-bool vectors, the number refers to the number +of bytes in the vector).

[PATCH] D81083: [Clang] Allow "vector_size" applied to Booleans

simoll added inline comments. Comment at: clang/docs/LanguageExtensions.rst:473 +architectures. The size parameter of a boolean vector type is the number of +bits in the vector (for all non-bool vectors, the number refers to the number +of bytes in the vector).

[PATCH] D81083: [Clang] Allow "vector_size" applied to Booleans

simoll updated this revision to Diff 281878. simoll added a comment. NFC - Style updates - Rebased Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81083/new/ https://reviews.llvm.org/D81083 Files: clang/docs/LanguageExtensions.rst clang/include

[PATCH] D81083: [Clang] Allow "vector_size" applied to Booleans

simoll updated this revision to Diff 281844. simoll added a comment. Updated clang test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81083/new/ https://reviews.llvm.org/D81083 Files: clang/docs/LanguageExtensions.rst clang/include/clang/AST/A

[PATCH] D81083: [Clang] Allow "vector_size" applied to Booleans

simoll updated this revision to Diff 281322. simoll added a comment. - Rebased - Implement `EmitFromMemory` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81083/new/ https://reviews.llvm.org/D81083 Files: clang/docs/LanguageExtensions.rst clang

[PATCH] D71339: [VE,#2] Clang toolchain for SX-Aurora

simoll abandoned this revision. simoll added a comment. Basic Clang support for VE is now upstream: rG96d4ccf0 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71339/new/ https://r

[PATCH] D79411: [VE] Clang toolchain for VE

This revision was automatically updated to reflect the committed changes. Closed by commit rG96d4ccf00c8f: [VE] Clang toolchain for VE (authored by kaz7, committed by simoll). Changed prior to commit: https://reviews.llvm.org/D79411?vs=272632&id=272932#toc Repository: rG LLVM Github Monorepo

[PATCH] D79411: [VE] Clang toolchain for VE

simoll updated this revision to Diff 272632. simoll marked an inline comment as done. simoll added a comment. Removed `getEHDataRegisterNumber`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79411/new/ https://reviews.llvm.org/D79411 Files: clan

[PATCH] D81083: [Clang] Allow "vector_size" applied to Booleans

simoll updated this revision to Diff 268488. simoll added a comment. - Improved documentation for the size argument of vector_size. - Rebased Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81083/new/ https://reviews.llvm.org/D81083 Files: clang/d

[PATCH] D81083: [Clang] Allow "vector_size" applied to Booleans

simoll marked an inline comment as done. simoll added inline comments. Comment at: clang/docs/LanguageExtensions.rst:473 +architectures. The size parameter of a boolean vector type is the number of +bits in the vector (for all non-bool vectors, the number refers to the number +o

[PATCH] D81083: [Clang] Allow "vector_size" applied to Booleans

simoll marked 2 inline comments as done. simoll added inline comments. Comment at: clang/lib/CodeGen/CGExprScalar.cpp:4710 if (!CGF.CGM.getCodeGenOpts().PreserveVec3Type) { - auto *Vec4Ty = llvm::FixedVectorType::get( + auto Vec4Ty = llvm::VectorType::get(

[PATCH] D81083: [Clang] Allow "vector_size" applied to Booleans

simoll updated this revision to Diff 268140. simoll added a comment. NFC. Undid stray change. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81083/new/ https://reviews.llvm.org/D81083 Files: clang/docs/LanguageExtensions.rst clang/include/clang

[PATCH] D81083: [Clang] Allow "vector_size" applied to Booleans

simoll created this revision. simoll added reviewers: hfinkel, erichkeane, craig.topper, rsandifo-arm, kaz7, k-ishizaka. simoll added a project: clang. Herald added subscribers: cfe-commits, kristof.beyls. Herald added a reviewer: rengolin. simoll updated this revision to Diff 268140. simoll added

[PATCH] D79411: [VE] Clang toolchain for VE

simoll added a comment. Ping. Anything i can do to get this reviewed? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79411/new/ https://reviews.llvm.org/D79411 ___ cfe-commits mailing list cfe-commits@l

[PATCH] D79411: [VE] Clang toolchain for VE

simoll added a comment. Leaving a note: https://reviews.llvm.org/D79084 depends on this patch to build compiler-rt. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79411/new/ https://reviews.llvm.org/D79411 ___

[PATCH] D79411: [VE] Clang toolchain for VE

simoll updated this revision to Diff 263638. simoll added a comment. - Simplified: stripped down to a basic C GNU Linux toolchain hard-float, no C++ stdlib. - rebased. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79411/new/ https://reviews.llvm.o

[PATCH] D79411: [VE] Clang toolchain for VE

simoll added a comment. FYI This passes all tests on the mergebot. There are some obscure lint suggestions that make it report a failure. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79411/new/ https://reviews.llvm.org/D79411 _

[PATCH] D79411: [VE] Clang toolchain for VE

simoll created this revision. simoll added reviewers: arsenm, k-ishizaka, kaz7. simoll added a project: VE. Herald added subscribers: cfe-commits, jfb, krytarowski, mgorny, wdng. Herald added a project: clang. This patch enables compilation of C code for the VE target with Clang. Repository: r

[PATCH] D75467: [instcombine] remove fsub to fneg hacks; only emit fneg

This revision was automatically updated to reflect the committed changes. Closed by commit rGd871ef4e6ade: [instcombine] remove fsub to fneg hacks; only emit fneg (authored by simoll). Changed prior to commit: https://reviews.llvm.org/D75467?vs=249396&id=249409#toc Repository: rG LLVM Github

[PATCH] D75467: [instcombine] remove fsub to fneg hacks; only emit fneg

simoll updated this revision to Diff 249396. simoll marked 5 inline comments as done. simoll added a comment. - NFC - Fixed code comments - Rebased Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75467/new/ https://reviews.llvm.org/D75467 Files: c

[PATCH] D75467: [instcombine] remove fsub to fneg hacks; only emit fneg

simoll added a comment. Herald added a reviewer: aartbik. ping. Is this good to go? (merge bot failures are due to the `m_UnOp` syntax, which goes against the coding standard). Repository: rG LLVM Github Mon

[PATCH] D75467: [instcombine] remove fsub to fneg hacks; only emit fneg

simoll updated this revision to Diff 247850. simoll added a comment. NFC - rebased - formatting Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75467/new/ https://reviews.llvm.org/D75467 Files: clang/test/CodeGen/fma-builtins-constrained.c llvm

[PATCH] D75467: [instcombine] remove fsub to fneg hacks; only emit fneg

simoll marked an inline comment as done. simoll added inline comments. Comment at: llvm/lib/Transforms/InstCombine/InstCombineAddSub.cpp:2137 + if (match(&I, m_FNeg(m_Value(Op +return UnaryOperator::CreateFNegFMF(Op, &I); cameron.mcinally wrote: > Just

[PATCH] D75467: [instcombine] remove fsub to fneg hacks; only emit fneg

simoll updated this revision to Diff 247820. simoll marked an inline comment as done. simoll added a comment. Herald added a project: clang. Herald added a subscriber: cfe-commits. Thanks for the review! - rebased - fixed clang test - added FIXME for correct DTZ, DAZ handling Repository: rG L

[PATCH] D75130: Remove BinaryOperator::CreateFNeg

This revision was automatically updated to reflect the committed changes. Closed by commit rGddd11273d9d0: Remove BinaryOperator::CreateFNeg (authored by simoll). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75130/new/ https://reviews.llvm.org/D751

[PATCH] D75130: Remove BinaryOperator::CreateFNeg

simoll updated this revision to Diff 246974. simoll added a comment. - rebased Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75130/new/ https://reviews.llvm.org/D75130 Files: clang/test/CodeGen/complex-math.c llvm/include/llvm/IR/InstrTypes.h

[PATCH] D75130: Remove BinaryOperator::CreateFNeg

simoll marked an inline comment as done. simoll added inline comments. Comment at: llvm/lib/Transforms/InstCombine/InstCombineSelect.cpp:341 Value *NewSel = Builder.CreateSelect(Cond, X, Y, SI.getName() + ".v", &SI); // TODO: Remove the hack for the binop form when the

[PATCH] D75130: Remove BinaryOperator::CreateFNeg

simoll updated this revision to Diff 246544. simoll added a comment. Herald added a project: clang. Herald added a subscriber: cfe-commits. - rebased - fixed clang complex-math test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75130/new/ https://r

[PATCH] D72467: [WIP] Remove "mask" operand from shufflevector.

simoll added inline comments. Comment at: llvm/lib/Analysis/InstructionSimplify.cpp:4413 unsigned MaxRecurse) { - if (isa(Mask)) + if (all_of(Mask, [](int Elem) { return Elem == -1; })) return UndefValue::get(RetTy); ---

[PATCH] D71339: [VE,#2] Clang toolchain for SX-Aurora

simoll updated this revision to Diff 26. simoll added a comment. Trimmed to Clang changes only Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71339/new/ https://reviews.llvm.org/D71339 Files: clang/lib/Basic/CMakeLists.txt clang/lib/Basic/T

[PATCH] D71340: [VE,#3] Runtime libraries

simoll updated this revision to Diff 233328. simoll added a comment. Trimmed down to library changes only. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71340/new/ https://reviews.llvm.org/D71340 Files: compiler-rt/cmake/Modules/CompilerRTUtils.

[PATCH] D71341: [VE,#4] Target vector intrinsics

simoll created this revision. Herald added subscribers: llvm-commits, openmp-commits, libcxx-commits, Sanitizers, cfe-commits, jdoerfert, s.egerton, jfb, arphaman, dexonsmith, christof, simoncook, fedor.sergeev, aheejin, hiraditya, krytarowski, mgorny, dschuff, qcolombet. Herald added a reviewer

[PATCH] D71341: [VE,#4] Target vector intrinsics

simoll added a comment. In D71341#1779419 , @nhaehnle wrote: > As a general rule, I think it would be preferable for patches such as this > one to be split up further, especially when they touch common code. For > example, why does a patch by the name "T

[PATCH] D71339: [VE,#2] Clang toolchain for SX-Aurora

simoll added a comment. To clarify: this patch is not intended to be committed as-is but gives an overview of the required changes. It's the a patch of a series for the VE backend and includes all the earlier patches. Repository: rG LLVM Github Mono

[PATCH] D71340: [VE,#3] Runtime libraries

simoll added a comment. To clarify: this patch is not intended to be committed as-is but gives an overview of the required changes. It's the a patch of a series for the VE backend and includes all the earlier patches. Repository: rG LLVM Github Mono

[PATCH] D71340: [VE,#3] Runtime libraries

simoll created this revision. Herald added subscribers: llvm-commits, openmp-commits, libcxx-commits, Sanitizers, cfe-commits, jdoerfert, s.egerton, jfb, dexonsmith, christof, simoncook, fedor.sergeev, aheejin, hiraditya, krytarowski, mgorny. Herald added a reviewer: jdoerfert. Herald added proje

[PATCH] D71339: [VE,#2] Clang toolchain for SX-Aurora

simoll created this revision. Herald added subscribers: llvm-commits, cfe-commits, tschuett, jdoerfert, jfb, dexonsmith, fedor.sergeev, hiraditya, krytarowski, mgorny. Herald added projects: clang, LLVM. This is patch #2 in the patch series for the VE backend for NEC-SX Aurora. This patch builds