[PATCH] D53608: [builtins] Build float128 soft float builtins for x86_64.

2021-12-14 Thread Siddhartha Bagaria via Phabricator via cfe-commits
starsid planned changes to this revision. starsid added a comment. Thanks. I missed that in the comment thread. Will send back for review once ready. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D53608/new/ https://reviews.llvm.org/D53608 ___

[PATCH] D53608: [builtins] Build float128 soft float builtins for x86_64.

2021-12-09 Thread Siddhartha Bagaria via Phabricator via cfe-commits
starsid added a comment. I have tried my best to follow the conversation here and complete this patch. Please let me know if it is missing something, or if I need to assign new reviewers. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D53608/new/ h

[PATCH] D53608: [builtins] Build float128 soft float builtins for x86_64.

2021-12-09 Thread Siddhartha Bagaria via Phabricator via cfe-commits
starsid updated this revision to Diff 393340. starsid added a comment. fix commit author name and email Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D53608/new/ https://reviews.llvm.org/D53608 Files: compiler-rt/lib/builtins/extendhftf2.c comp

[PATCH] D53608: [builtins] Build float128 soft float builtins for x86_64.

2021-12-09 Thread Siddhartha Bagaria via Phabricator via cfe-commits
starsid updated this revision to Diff 393335. starsid added a comment. rebase and resurrect Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D53608/new/ https://reviews.llvm.org/D53608 Files: compiler-rt/lib/builtins/extendhftf2.c compiler-rt/lib/

[PATCH] D48989: -fdebug-prefix-map option for cc1as

2018-07-09 Thread Siddhartha Bagaria via Phabricator via cfe-commits
starsid updated this revision to Diff 154669. starsid marked an inline comment as done. starsid added a comment. Test improvements Repository: rC Clang https://reviews.llvm.org/D48989 Files: include/clang/Driver/Options.td lib/Driver/ToolChains/Clang.cpp test/Driver/debug-prefix-map.S

[PATCH] D48989: -fdebug-prefix-map option for cc1as

2018-07-05 Thread Siddhartha Bagaria via Phabricator via cfe-commits
starsid added a comment. In https://reviews.llvm.org/D48989#1153773, @compnerd wrote: > However, please add a test to ensure that the paths are mapped when invoking > the assembler I added the tests to check the mapping logic through llvm-mc in https://reviews.llvm.org/D48988. In this revisio

[PATCH] D48989: -fdebug-prefix-map option for cc1as

2018-07-05 Thread Siddhartha Bagaria via Phabricator via cfe-commits
starsid updated this revision to Diff 154354. starsid added a comment. add a test for the Driver passing the new flag Repository: rC Clang https://reviews.llvm.org/D48989 Files: include/clang/Driver/Options.td lib/Driver/ToolChains/Clang.cpp test/Driver/debug-prefix-map.S tools/drive

[PATCH] D48989: -fdebug-prefix-map option for cc1as

2018-07-05 Thread Siddhartha Bagaria via Phabricator via cfe-commits
starsid updated this revision to Diff 154285. starsid added a comment. include generator input file for flag property change Repository: rC Clang https://reviews.llvm.org/D48989 Files: include/clang/Driver/Options.td lib/Driver/ToolChains/Clang.cpp tools/driver/cc1as_main.cpp Index:

[PATCH] D48989: -fdebug-prefix-map option for cc1as

2018-07-05 Thread Siddhartha Bagaria via Phabricator via cfe-commits
starsid created this revision. starsid added a reviewer: compnerd. Herald added a subscriber: cfe-commits. Depends on https://reviews.llvm.org/D48988. Repository: rC Clang https://reviews.llvm.org/D48989 Files: lib/Driver/ToolChains/Clang.cpp tools/driver/cc1as_main.cpp Index: tools/dr