[PATCH] D156771: [clang][hexagon] Handle library path arguments earlier

sidneym added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156771/new/ https://reviews.llvm.org/D156771 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi

[PATCH] D113638: [xray] Add support for hexagon architecture

sidneym added a comment. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113638/new/ https://reviews.llvm.org/D113638 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cg

[PATCH] D108178: [PATCH 8/8] [clang] enable sanitizers for hexagon

sidneym added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108178/new/ https://reviews.llvm.org/D108178 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi

[PATCH] D108083: add sanitizer support to hexagon

sidneym added inline comments. Comment at: compiler-rt/lib/sanitizer_common/sanitizer_syscall_linux_hexagon.inc:124 + +bool internal_iserror(uptr retval, int *rverrno) { + if (retval == (uptr)-1) { bcain wrote: > @sidneym Can you confirm that this implementatio

[PATCH] D106737: DRAFT - [clang] [hexagon] Add resource include dir

sidneym added inline comments. Comment at: clang/lib/Driver/ToolChains/Hexagon.cpp:604 + const bool HasSysRoot = !D.SysRoot.empty(); + if (HasSysRoot) { SmallString<128> P(D.SysRoot); bcain wrote: > MaskRay wrote: > > To match Linux.cpp, this code block sh

[PATCH] D98436: [Hexagon] Support inlined use of cs0 and cs1

sidneym updated this revision to Diff 330032. sidneym added a comment. Same patch, just added full context. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98436/new/ https://reviews.llvm.org/D98436 Files: clang/lib/Basic/Targets/Hexagon.cpp llv

[PATCH] D98436: [Hexagon] Support inlined use of cs0 and cs1

sidneym created this revision. sidneym added reviewers: bcain, kparzysz. Herald added a subscriber: hiraditya. sidneym requested review of this revision. Herald added projects: clang, LLVM. Herald added a subscriber: cfe-commits. Allow inline assembly to reference cs0 and cs1 registers. Reposito

[PATCH] D77684: [Hexagon] Remove testcases that check for default linker.

This revision was automatically updated to reflect the committed changes. Closed by commit rG9bda29ab0fdf: [Hexagon] Default linker tests can fail if CLANG_DEFAULT_LINKER is used. (authored by sidneym). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D7

[PATCH] D77498: [Hexagon] Select lld as the default linker for linux-musl target

sidneym added a comment. Since this isn't something that can be always known in advance I think the testcase should just be removed. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77498/new/ https://reviews.llvm.org/D77498 __

[PATCH] D77684: [Hexagon] Remove testcases that check for default linker.

sidneym created this revision. sidneym added reviewers: bcain, kparzysz, nathanchance, bcahoon. Herald added a project: clang. Herald added a subscriber: cfe-commits. These values are not always known since there is a configuration option to set the default linker, CLANG_DEFAULT_LINKER. Reposit

[PATCH] D77498: [Hexagon] Select lld as the default linker for linux-musl target

sidneym added a comment. These are new tests how do you get the generic lld driver to work? When I invoke it using just "lld" I need to add -flavor gnu or I get this error: Invoke ld.lld (Unix), ld64.lld (macOS), lld-link (Windows), wasm-ld (WebAssembly) instead Repository: rG LLVM Github M

[PATCH] D77440: [Hexagon] Update include paths for linux/musl

This revision was automatically updated to reflect the committed changes. Closed by commit rGaed2fdb1671c: [Hexagon] Update paths for linux/musl (authored by sidneym). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77440/new/ https://reviews.llvm.org

[PATCH] D77440: [Hexagon] Update include paths for linux/musl

sidneym updated this revision to Diff 255680. sidneym added a comment. Fix formatting issues. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77440/new/ https://reviews.llvm.org/D77440 Files: clang/lib/Driver/ToolChains/Hexagon.cpp clang/lib/Dri

[PATCH] D77440: [Hexagon] Update include paths for linux/musl

sidneym updated this revision to Diff 255655. sidneym added a comment. Herald added a subscriber: ormris. Break out linux parts of hexagon-toolchain-elf.c into hexagon-toolchain-linux.c Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77440/new/ https

[PATCH] D77498: [Hexagon] Select lld as the default linker for linux-musl target

This revision was automatically updated to reflect the committed changes. Closed by commit rG2c5d6dfda98e: [Hexagon] Make lld be the default linker for linux/musl (authored by sidneym). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77498/new/ https:

[PATCH] D77498: [Hexagon] Select lld as the default linker for linux-musl target

sidneym created this revision. sidneym added reviewers: adasgupt, bcain, kparzysz, bcahoon, shankare. Herald added a project: clang. Herald added a subscriber: cfe-commits. When the target is hexagon-unknown-linux-musl select lld as the default linker. Repository: rG LLVM Github Monorepo http

[PATCH] D77440: [Hexagon] Update include paths for linux/musl

sidneym created this revision. sidneym added reviewers: kparzysz, bcain, bcahoon, adasgupt. Herald added a project: clang. Herald added a subscriber: cfe-commits. Update CXX paths for linux/musl. And update the sysroot expectation to match other targets. At this point I might pull out th

[PATCH] D76546: [Hexagon] MaxAtomicPromoteWidth, MaxAtomicInlineWidth are not getting set.

This revision was automatically updated to reflect the committed changes. Closed by commit rG81194bfeea7b: [Hexagon] MaxAtomicPromoteWidth and MaxAtomicInlineWidth are not getting set. (authored by sidneym). Changed prior to commit: https://reviews.llvm.org/D76546?vs=251896&id=253640#toc Repos

[PATCH] D75638: [Hexagon] Support for Linux/Musl ABI.

This revision was automatically updated to reflect the committed changes. Closed by commit rGb0da09498394: [Hexagon] Add support for Linux/Musl ABI (part 2) (authored by sidneym). Changed prior to commit: https://reviews.llvm.org/D75638?vs=252950&id=253000#toc Repository: rG LLVM Github Mono

[PATCH] D75638: [Hexagon] Support for Linux/Musl ABI.

sidneym updated this revision to Diff 252950. sidneym added a comment. update for new tidy checks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75638/new/ https://reviews.llvm.org/D75638 Files: clang/include/clang/Basic/TargetInfo.h clang/lib

[PATCH] D76582: [Hexagon] Don't clear libpath when target is linux-musl

sidneym created this revision. sidneym added reviewers: kparzysz, bcain, adasgupt. Herald added a project: clang. Herald added a subscriber: cfe-commits. Use the default libpath when the target is linux-musl Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D76582 Files: clang/l

[PATCH] D76546: [Hexagon] MaxAtomicPromoteWidth, MaxAtomicInlineWidth are not getting set.

sidneym updated this revision to Diff 251896. sidneym added a comment. remove extra line break. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76546/new/ https://reviews.llvm.org/D76546 Files: clang/lib/Basic/Targets/Hexagon.h clang/test/Prepro

[PATCH] D76546: [Hexagon] MaxAtomicPromoteWidth, MaxAtomicInlineWidth are not getting set.

sidneym marked an inline comment as done. sidneym added inline comments. Comment at: clang/test/Preprocessor/hexagon-predefines.c:117 + + +// RUN: %clang_cc1 -E -dM -triple hexagon-unknown-linux-musl \ The extra line break? Repository: rG LLVM Github Monorepo

[PATCH] D76546: [Hexagon] MaxAtomicPromoteWidth, MaxAtomicInlineWidth are not getting set.

sidneym created this revision. sidneym added reviewers: kparzysz, adasgupt, bcain. Herald added subscribers: cfe-commits, jfb. Herald added a project: clang. Seeing errors while building the c++ library: atomic:2756:16: error: use of undeclared identifier '__libcpp_signed_lock_free' typedef ato

[PATCH] D76310: [Hexagon] Add linux #defines when linux triple is selected

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rG430c9a80c17b: [Hexagon] Enable linux #defines (authored by sidneym). Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D76310: [Hexagon] Add linux #defines when linux triple is selected

sidneym created this revision. sidneym added reviewers: bcain, kparzysz, adasgupt. Herald added subscribers: cfe-commits, krytarowski. Herald added a project: clang. Add Linux default defines when the triple includes -linux-musl. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D7

[PATCH] D76079: [Hexagon] Enable init_arrays when target is linux-musl

This revision was automatically updated to reflect the committed changes. Closed by commit rG6174fddbe3d4: [Hexagon] Enable init_arrays when target is linux-musl (authored by sidneym). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76079/new/ https:/

[PATCH] D76079: [Hexagon] Enable init_arrays when target is linux-musl

sidneym updated this revision to Diff 24. sidneym added a comment. Drop ternary. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76079/new/ https://reviews.llvm.org/D76079 Files: clang/lib/Driver/ToolChains/Hexagon.cpp clang/test/Driver/hexagon-toolchain-elf.c Index: clang/test

[PATCH] D76079: [Hexagon] Enable init_arrays when target is linux-musl

sidneym created this revision. sidneym added reviewers: kparzysz, bcain, adasgupt. Herald added a project: clang. Herald added a subscriber: cfe-commits. linux/musl will use init arrays by default. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D76079 Files: clang/lib/Driver/

[PATCH] D75638: [Hexagon] Support for Linux/Musl ABI.

sidneym created this revision. sidneym added reviewers: kparzysz, bcain, adasgupt. Herald added a project: clang. Herald added a subscriber: cfe-commits. The clang driver updates needed to support Hexagon's Linux ABI. This builds on what was added by https://reviews.llvm.org/rG7fee4fed4c75c13d0c

[PATCH] D75139: [hexagon] Pickup the default crt and libs when the musl target is selected

This revision was automatically updated to reflect the committed changes. Closed by commit rGd481e59863ac: [hexagon] Add default paths to support musl target (authored by sidneym). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75139/new/ https://rev

[PATCH] D75139: [hexagon] Pickup the default crt and libs when the musl target is selected

sidneym updated this revision to Diff 247724. sidneym added a comment. address clang-tidy issues Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75139/new/ https://reviews.llvm.org/D75139 Files: clang/lib/Driver/ToolChains/Hexagon.cpp clang/test

[PATCH] D75139: [hexagon] Pickup the default crt and libs when the musl target is selected

sidneym updated this revision to Diff 247711. sidneym added a comment. Update testcase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75139/new/ https://reviews.llvm.org/D75139 Files: clang/lib/Driver/ToolChains/Hexagon.cpp clang/test/Driver/h

[PATCH] D75139: [hexagon] Pickup the default crt and libs when the musl target is selected

This revision was automatically updated to reflect the committed changes. Closed by commit rG637767665141: Add default paths to support musl target (authored by sidneym). Changed prior to commit: https://reviews.llvm.org/D75139?vs=247251&id=247701#toc Repository: rG LLVM Github Monorepo CHA

[PATCH] D75139: [hexagon] Pickup the default crt and libs when the musl target is selected

sidneym updated this revision to Diff 247251. sidneym added a comment. Move selection of the dynamic linker before user args are added. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75139/new/ https://reviews.llvm.org/D75139 Files: clang/lib/Dri

[PATCH] D75139: [hexagon] Pickup the default crt and libs when the musl target is selected

sidneym marked an inline comment as done. sidneym added inline comments. Comment at: clang/lib/Driver/ToolChains/Hexagon.cpp:290 +} +if (!Args.hasArg(options::OPT_shared)) + CmdArgs.push_back("-dynamic-linker=/lib/ld-musl-hexagon.so.1"); the default

[PATCH] D75139: [hexagon] Pickup the default crt and libs when the musl target is selected

sidneym created this revision. sidneym added reviewers: kparzysz, bcain, adasgupt. Herald added a project: clang. Herald added a subscriber: cfe-commits. Pickup the default crt and libs when the musl target is selected. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D75139 File

[PATCH] D74972: [hexagon] Define __ELF__ by default.

This revision was automatically updated to reflect the committed changes. Closed by commit rGd37cbda5f9a4: [Hexagon] Define __ELF__ by default. (authored by sidneym). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74972/new/ https://reviews.llvm.org/

[PATCH] D74972: [hexagon] Define __ELF__ by default.

sidneym created this revision. sidneym added reviewers: kparzysz, bcain. Herald added subscribers: Sanitizers, cfe-commits, mgorny. Herald added projects: clang, Sanitizers, LLVM. __ELF__ is not enabled by default. Correcting an issue in compiler-rt's cmake revealed that __ELF__ was not defined.

[PATCH] D74776: [Hexagon] clang driver should consider --sysroot option when looking for includes

This revision was automatically updated to reflect the committed changes. Closed by commit rGfaa889b23587: [Hexagon] clang driver should consider --sysroot option (authored by sidneym). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74776/new/ https:

[PATCH] D74776: [Hexagon] clang driver should consider --sysroot option when looking for includes

sidneym created this revision. sidneym added reviewers: kparzysz, bcain. Herald added a project: clang. Herald added a subscriber: cfe-commits. Consider --sysroot when building the system c include paths. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D74776 Files: clang/lib/

[PATCH] D74260: Change default relocation model for hexagon when triple includes musl

sidneym created this revision. sidneym added reviewers: kparzysz, bcain, martell, dalias. Herald added a project: clang. Herald added a subscriber: cfe-commits. Right now if the triple includes musl, saying something like: "--target=x86_64--linux-musl" then the default relocation model is pic. W

[PATCH] D70919: [Hexagon] Avoid passing unsupported options to lld when -fuse-ld=lld is used

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rGd567b0ba841d: Avoid unsupported LLD options (authored by sidneym). Repository: rG LLVM Github Monorepo CHANGES SINCE L

[PATCH] D70919: [Hexagon] Avoid passing unsupported options to lld when -fuse-ld=lld is used

sidneym updated this revision to Diff 234174. sidneym added a comment. Remove quotes. Also add ld.lld file so that configurations that don't enable lld will still pass this test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70919/new/ https://re

[PATCH] D70919: [Hexagon] Avoid passing unsupported options to lld when -fuse-ld=lld is used

sidneym updated this revision to Diff 233864. sidneym added a comment. OK, Yes Fuchsia is a good example. Using that pattern Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70919/new/ https://reviews.llvm.org/D70919 Files: clang/lib/Driver/ToolCh

[PATCH] D70919: [Hexagon] Avoid passing unsupported options to lld when -fuse-ld=lld is used

sidneym updated this revision to Diff 233687. sidneym added a comment. Herald added a project: LLVM. make check for lld more generic. Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70919/new/ https://reviews.llvm.org/D70919 Files: clang/lib/Driver/ToolChains/Hex

[PATCH] D70919: [Hexagon] Avoid passing unsupported options to lld when -fuse-ld=lld is used

sidneym updated this revision to Diff 232374. sidneym added a comment. Remove quotes around check-not. -fuse-ld=lld is the correct usage. -fuse-ld=ld.lld results in an error message: error: invalid linker name in argument '-fuse-ld=ld.lld' Repository: rG LLVM Github Monorepo CHANGES SINCE L

[PATCH] D70919: [Hexagon] Avoid passing unsupported options to lld when -fuse-ld=lld is used

sidneym updated this revision to Diff 231765. sidneym added a comment. Update testcase. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70919/new/ https://reviews.llvm.org/D70919 Files: clang/lib/Driver/ToolChains/Hexagon.cpp clang/test/Driver/hexagon-toolchain-elf.c Index: clang/t

[PATCH] D70919: [Hexagon] Avoid passing unsupported options to lld when -fuse-ld=lld is used

sidneym created this revision. sidneym added reviewers: kparzysz, bcain, ruiu. Herald added a project: clang. Herald added a subscriber: cfe-commits. sidneym added a subscriber: llvm-commits. Avoid passing unsupported options to lld when -fuse-ld=lld is used. Repository: rG LLVM Github Monorep

[PATCH] D61130: [llvm-mc] Add reportWarning() to MCContext

sidneym accepted this revision. sidneym added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61130/new/ https://reviews.llvm.org/D61130 _

[PATCH] D53327: [Hexagon] Use -fuse-ld update checks.

sidneym created this revision. sidneym added reviewers: phosek, rsmith, kparzysz, bcain. Herald added a subscriber: cfe-commits. Use -fuse-ld to explicitly name the linker. Replace checks for hexagon-link | ld to just "hexagon-link", the name of the explicitly chosen linker. Repository: rC C

[PATCH] D53249: Force Hexagon to use default (hexagon-link) linker

sidneym added a comment. https://reviews.llvm.org/D53219 added a check for either hexagon-ld or ld. I merged that change earlier today. I can change the test to pass -fuse-ld, let me know. Thanks, Repository: rC Clang https://reviews.llvm.org/D53249 ___

[PATCH] D53219: Update hexagon driver tests

This revision was automatically updated to reflect the committed changes. Closed by commit rL344482: [Hexagon] Update tests account for non-hardcoded linker name. (authored by sidneym, committed by ). Changed prior to commit: https://reviews.llvm.org/D53219?vs=169491&id=169608#toc Repository:

[PATCH] D53038: [Hexagon] Use GetLinkerPath method instead of hard-coded linker name.

sidneym added a comment. I updated the tests: https://reviews.llvm.org/D53219 Repository: rC Clang https://reviews.llvm.org/D53038 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D53219: Update hexagon driver tests

sidneym created this revision. sidneym added reviewers: bcain, davezarzycki, kparzysz, shankare. Herald added a subscriber: cfe-commits. Don't assume the linker is hexagon-link. https://reviews.llvm.org/D53038 removed the hard-coded name so now it is possible for the other named linkers to be u

[PATCH] D53038: [Hexagon] Use GetLinkerPath method instead of hard-coded linker name.

sidneym added a comment. Seems like the test cases do not consider the possibility of CLANG_DEFAULT_LINKER being set. If CLANG_DEFAULT_LINKER was set to "hexagon-link" these tests would probably pass. I'm checking this out now. Repository: rC Clang https://reviews.llvm.org/D53038 _

[PATCH] D53038: [Hexagon] Use GetLinkerPath method instead of hard-coded linker name.

This revision was automatically updated to reflect the committed changes. Closed by commit rC344147: [Hexagon] Use GetLinkerPath instead of hard-coded string. (authored by sidneym, committed by ). Repository: rC Clang https://reviews.llvm.org/D53038 Files: lib/Driver/ToolChains/Hexagon.cpp

[PATCH] D53038: [Hexagon] Use GetLinkerPath method instead of hard-coded linker name.

sidneym created this revision. sidneym added reviewers: shankare, ruiu, kparzysz, bcain. Herald added a subscriber: cfe-commits. Use GetLinkerPath method instead of hard-coding linker name. Change should allow -fuse-ld to work on the Hexagon target. Repository: rC Clang https://reviews.llvm.