[PATCH] D119209: [clang] Add cc1 option -fctor-dtor-return-this

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG3933c43d9008: [clang] Add cc1 option -fctor-dtor-return-this (authored by scw). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION h

[PATCH] D119209: [clang] Add cc1 option -fctor-dtor-return-this

scw marked an inline comment as done. scw added inline comments. Comment at: clang/include/clang/Driver/Options.td:5608 +def fctor_dtor_return_this : Flag<["-"], "fctor-dtor-return-this">, + HelpText<"Change the C++ ABI to returning `this` pointer from constructors " +

[PATCH] D119209: [clang] Add cc1 option -fctor-dtor-return-this

scw updated this revision to Diff 464809. scw marked 2 inline comments as done. scw retitled this revision from "Implement -fctor_dtor_return_this ABI option." to "[clang] Add cc1 option -fctor-dtor-return-this". Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.l

[PATCH] D119209: Implement -fctor_dtor_return_this ABI option.

scw updated this revision to Diff 464801. scw added a comment. Remove unnecessary curly braces. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119209/new/ https://reviews.llvm.org/D119209 Files: clang/include/clang/Basic/CodeGenOptions.def clan

[PATCH] D119209: Implement -fctor_dtor_return_this ABI option.

scw updated this revision to Diff 464793. scw retitled this revision from "Implement -mctor_dtor_return_this ABI option. " to "Implement -fctor_dtor_return_this ABI option.". scw edited the summary of this revision. scw added a comment. - Made the option cc1-onl

[PATCH] D119209: Implement -mctor_dtor_return_this ABI option.

scw updated this revision to Diff 463722. scw edited the summary of this revision. scw added a comment. Herald added a subscriber: MaskRay. Herald added a project: All. Rebased and updated comments and option explain text to only affect Itanium C++ ABI. Repository: rG LLVM Github Monorepo CH

[PATCH] D119209: Implement -mctor_dtor_return_this ABI option.

scw created this revision. Herald added subscribers: dexonsmith, dang, kristof.beyls. scw requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This option forces constructors and non-deleting destructors to return `this` pointer. This is simila

[PATCH] D100450: [libTooling] Add smart pointer support to the `access` Stencil

scw added inline comments. Comment at: clang/unittests/Tooling/StencilTest.cpp:410 + StringRef Id = "id"; + testExpr(Id, Snippet, access(Id, "field"), "(*x).field"); +} ymandel wrote: > Hmm. Looks like we could use smart pointer support in tooling::buildAddress

[PATCH] D100450: [libTooling] Add smart pointer support to the `access` Stencil

This revision was automatically updated to reflect the committed changes. Closed by commit rG1c5717225e89: [libTooling] Add smart pointer support to the `access` Stencil (authored by scw). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100450/new/ ht

[PATCH] D100450: [libTooling] Add smart pointer support to the `access` Stencil

scw created this revision. scw requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This extends smart pointer support beyond the existing `maybeDeref` and `maybeAddressOf`. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D1004