[PATCH] D144831: Rebase D41416 on top of master

SAtacker updated this revision to Diff 548263. SAtacker added a comment. Fix call to lazyTemplateSpecialization in Function Template Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144831/new/ https://reviews.llvm.org/D144831 Files: clang/include/

[PATCH] D144831: Rebase D41416 on top of master

SAtacker updated this revision to Diff 548183. SAtacker added a comment. Herald added a subscriber: cfe-commits. [Clang][Modules] Optimized template arguments ODR hash search for modules/PCH Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144831/new/

[PATCH] D41416: [modules] [pch] Do not deserialize all lazy template specializations when looking for one.

SAtacker added inline comments. Comment at: clang/lib/Serialization/ASTWriterDecl.cpp:288 + } + for (auto &SpecInfo : LazySpecializations) { +Record.push_back(SpecInfo.DeclID); ChuanqiXu wrote: > v.g.vassilev wrote: > > We should not store the l

[PATCH] D120331: [clang-tidy][run-clang-tidy.py] Add --config-file= option

SAtacker marked an inline comment as done. SAtacker added a comment. Gentle reminder @JonasToth @alexfh @aaron.ballman @njames93 @LegalizeAdulthood Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120331/new/ https://reviews.llvm.org/D

[PATCH] D120331: [clang-tidy][run-clang-tidy.py] Add --config-file= option

SAtacker marked an inline comment as done. SAtacker added a comment. Gentle ping @alexfh @JonasToth Thank you. Comment at: clang-tools-extra/clang-tidy/tool/run-clang-tidy.py:228 'default') - parser.add_argument('-config', default=None, + group = parse

[PATCH] D120331: [clang-tidy][run-clang-tidy.py] Add --config-file= option

SAtacker updated this revision to Diff 412397. SAtacker added a comment. [clang-tidy][run-clang-tidy.py] Rename `group` to `config_group` Signed-off-by: Shreyas Atre Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120331/new/ https://reviews.llvm.o

[PATCH] D120331: [clang-tidy][run-clang-tidy.py] Add --config-file= option

SAtacker added a comment. In D120331#3354021 , @JonasToth wrote: > LGTM, but please adjust the naming nit to a better name. Thanks for the review again. Will rename the `group` to `config_group` as you suggested and I feel that too. > do you have commi

[PATCH] D120331: [clang-tidy][run-clang-tidy.py] Add --config-file= option

SAtacker added a comment. @JonasToth Could you please review it? Comment at: clang-tools-extra/clang-tidy/tool/run-clang-tidy.py:236 'each source file in its parent directories.') + parser.add_argument('-config-file', default=None, +

[PATCH] D120385: [clang-tidy][run-clang-tidy.py] Mutual exclusion of -config and -config-file

SAtacker added a comment. In D120385#3340474 , @Eugene.Zelenko wrote: > About procedure :-) You could not approve patches yourself, this is task for > reviewers. If content of this patch will be merged to another one, just > abandon this one. Yes sorr

[PATCH] D120331: [clang-tidy][run-clang-tidy.py] Add --config-file= option

SAtacker updated this revision to Diff 410736. SAtacker marked an inline comment as done. SAtacker added a comment. Squash commits D120385 , D120387 into D120331 Repository: rG LLVM Github

[PATCH] D120387: [clang-tidy][run-clang-tidy.py] Whitespace addition

SAtacker updated this revision to Diff 410719. SAtacker added a comment. Attempt to update this commit appropriately Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120387/new/ https://reviews.llvm.org/D120387 Files: clang-tools-extra/clang-tidy/t

[PATCH] D120387: [clang-tidy][run-clang-tidy.py] Whitespace addition

SAtacker updated this revision to Diff 410718. SAtacker added a comment. Removed whitespace Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120387/new/ https://reviews.llvm.org/D120387 Files: clang-tools-extra/clang-tidy/tool/run-clang-tidy.py I

[PATCH] D120387: [clang-tidy][run-clang-tidy.py] Whitespace addition

SAtacker updated this revision to Diff 410717. SAtacker added a comment. Suspected reason why the patch isn't applied: trailing space Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120387/new/ https://reviews.llvm.org/D120387 Files: clang-tools-e

[PATCH] D120387: [clang-tidy][run-clang-tidy.py] Whitespace addition

SAtacker updated this revision to Diff 410715. SAtacker retitled this revision from "[clang-tidy][run-clang-tidy.py] Whitespace addition Depends on D120385" to "[clang-tidy][run-clang-tidy.py] Whitespace addition". SAtacker edited the summary of this revision. SAtacker added a comment. Fix CI bu

[PATCH] D120387: [clang-tidy][run-clang-tidy.py] Whitespace addition Depends on D120385

SAtacker created this revision. SAtacker added a reviewer: JonasToth. Herald added subscribers: carlosgalvezp, xazax.hun. SAtacker requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. - spaces: - Consistent with the rest of the opt

[PATCH] D120385: [clang-tidy][run-clang-tidy.py] Mutual exclusion of -config and -config-file

SAtacker accepted this revision. SAtacker added a comment. This revision is now accepted and ready to land. In D120385#3339440 , @Eugene.Zelenko wrote: > I think will be good to merge these changes to D120331 > . Thank

[PATCH] D120385: [clang-tidy][run-clang-tidy.py] Mutual exclusion of -config and -config-file

SAtacker created this revision. SAtacker added a reviewer: JonasToth. Herald added subscribers: carlosgalvezp, xazax.hun. SAtacker published this revision for review. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. Depends on D120331

[PATCH] D120331: [clang-tidy][run-clang-tidy.py] Add --config-file= option

SAtacker created this revision. SAtacker added a reviewer: JonasToth. Herald added subscribers: carlosgalvezp, xazax.hun. SAtacker requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. - Link to the GitHub Issue: https://github.com/ll