https://github.com/Sh0g0-1758 edited
https://github.com/llvm/llvm-project/pull/81183
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Sh0g0-1758 wrote:
Please merge if no further changes are required.
https://github.com/llvm/llvm-project/pull/81183
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -117,6 +117,10 @@ Changes in existing checks
options `HeaderFileExtensions` and `ImplementationFileExtensions` by the
global options of the same name.
+- Improved :doc:`bugprone-too-small-loop-variable
+ ` check by correctly
+ implementing the check for const loop va
https://github.com/Sh0g0-1758 updated
https://github.com/llvm/llvm-project/pull/81183
>From 88dac6713284ee4f0b7ce73c944f78085412645f Mon Sep 17 00:00:00 2001
From: Sh0g0-1758
Date: Fri, 9 Feb 2024 01:21:14 +0530
Subject: [PATCH 01/12] Fix : bugprone-too-small-loop-variable
---
.../bugprone/To
@@ -28,6 +28,8 @@ In a real use case size means a container's size which
depends on the user input
This algorithm works for a small amount of objects, but will lead to freeze for
a larger user input.
+It's recommended to enable the compiler warning
-Wtautological-constant-ou
https://github.com/Sh0g0-1758 updated
https://github.com/llvm/llvm-project/pull/81183
>From 88dac6713284ee4f0b7ce73c944f78085412645f Mon Sep 17 00:00:00 2001
From: Sh0g0-1758
Date: Fri, 9 Feb 2024 01:21:14 +0530
Subject: [PATCH 01/11] Fix : bugprone-too-small-loop-variable
---
.../bugprone/To
Sh0g0-1758 wrote:
I believe all the issues are addressed now.
https://github.com/llvm/llvm-project/pull/81183
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -156,6 +156,10 @@ Changes in existing checks
`AllowStringArrays` option, enabling the exclusion of array types with
deduced
length initialized from string literals.
+- Improved :doc:`bugprone-too-small-loop-variable
Sh0g0-1758 wrote:
Ah, that's what y
https://github.com/Sh0g0-1758 updated
https://github.com/llvm/llvm-project/pull/81183
>From 88dac6713284ee4f0b7ce73c944f78085412645f Mon Sep 17 00:00:00 2001
From: Sh0g0-1758
Date: Fri, 9 Feb 2024 01:21:14 +0530
Subject: [PATCH 01/10] Fix : bugprone-too-small-loop-variable
---
.../bugprone/To
@@ -82,10 +82,14 @@ void
TooSmallLoopVariableCheck::registerMatchers(MatchFinder *Finder) {
// We are interested in only those cases when the loop bound is a variable
// value (not const, enum, etc.).
StatementMatcher LoopBoundMatcher =
- expr(ignoringParenImpCasts(
Sh0g0-1758 wrote:
The changes in LibASTMatcher that you suggested resulted in test failures so I
did not incorporate them. As far as doc change is considered, please elaborate
on it.
https://github.com/llvm/llvm-project/pull/81183
___
cfe-commits ma
https://github.com/Sh0g0-1758 deleted
https://github.com/llvm/llvm-project/pull/81183
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -82,10 +82,14 @@ void
TooSmallLoopVariableCheck::registerMatchers(MatchFinder *Finder) {
// We are interested in only those cases when the loop bound is a variable
// value (not const, enum, etc.).
StatementMatcher LoopBoundMatcher =
- expr(ignoringParenImpCasts(
https://github.com/Sh0g0-1758 updated
https://github.com/llvm/llvm-project/pull/81183
>From 88dac6713284ee4f0b7ce73c944f78085412645f Mon Sep 17 00:00:00 2001
From: Sh0g0-1758
Date: Fri, 9 Feb 2024 01:21:14 +0530
Subject: [PATCH 1/9] Fix : bugprone-too-small-loop-variable
---
.../bugprone/TooS
@@ -82,10 +82,14 @@ void
TooSmallLoopVariableCheck::registerMatchers(MatchFinder *Finder) {
// We are interested in only those cases when the loop bound is a variable
// value (not const, enum, etc.).
StatementMatcher LoopBoundMatcher =
- expr(ignoringParenImpCasts(
@@ -156,6 +156,10 @@ Changes in existing checks
`AllowStringArrays` option, enabling the exclusion of array types with
deduced
length initialized from string literals.
+- Improved :doc:`bugprone-too-small-loop-variable
Sh0g0-1758 wrote:
I don't think I u
https://github.com/Sh0g0-1758 updated
https://github.com/llvm/llvm-project/pull/81183
>From 88dac6713284ee4f0b7ce73c944f78085412645f Mon Sep 17 00:00:00 2001
From: Sh0g0-1758
Date: Fri, 9 Feb 2024 01:21:14 +0530
Subject: [PATCH 1/8] Fix : bugprone-too-small-loop-variable
---
.../bugprone/TooS
Sh0g0-1758 wrote:
done. Please review and suggest further changes.
https://github.com/llvm/llvm-project/pull/81183
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -82,10 +82,14 @@ void
TooSmallLoopVariableCheck::registerMatchers(MatchFinder *Finder) {
// We are interested in only those cases when the loop bound is a variable
// value (not const, enum, etc.).
StatementMatcher LoopBoundMatcher =
- expr(ignoringParenImpCasts(
@@ -44,3 +44,5 @@ a larger user input.
for (unsigned i = 0; i < size; ++i) {} // no warning with
MagnitudeBitsUpperLimit = 31 on a system where unsigned is 32-bit
for (int i = 0; i < size; ++i) {} // warning with MagnitudeBitsUpperLimit
= 31 on a system where int is 32
@@ -169,6 +169,9 @@ Miscellaneous
option is specified. Now ``clang-apply-replacements`` applies formatting
only with
the option.
+- Fixed incorrect implementation of ``too-small-loop-variable`` check when a
const loop
+ variable is initialized with a function declaratio
https://github.com/Sh0g0-1758 updated
https://github.com/llvm/llvm-project/pull/81183
>From 88dac6713284ee4f0b7ce73c944f78085412645f Mon Sep 17 00:00:00 2001
From: Sh0g0-1758
Date: Fri, 9 Feb 2024 01:21:14 +0530
Subject: [PATCH 1/4] Fix : bugprone-too-small-loop-variable
---
.../bugprone/TooS
https://github.com/Sh0g0-1758 updated
https://github.com/llvm/llvm-project/pull/81183
>From 88dac6713284ee4f0b7ce73c944f78085412645f Mon Sep 17 00:00:00 2001
From: Sh0g0-1758
Date: Fri, 9 Feb 2024 01:21:14 +0530
Subject: [PATCH 1/3] Fix : bugprone-too-small-loop-variable
---
.../bugprone/TooS
https://github.com/Sh0g0-1758 created
https://github.com/llvm/llvm-project/pull/81183
Fixes: #79580
**PR SUMMARY**: Changed LibASTMatcher to give an appropriate warning when a
const loop bound is initialized with a function declaration.
>From 88dac6713284ee4f0b7ce73c944f78085412645f Mon Sep
Sh0g0-1758 wrote:
Great, pre-commits tests passed.
https://github.com/llvm/llvm-project/pull/81015
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Sh0g0-1758 wrote:
The build is failing because of a formatting error which I don't think is
related to the changes that I made. Any thoughts as to why it is failing?
https://github.com/llvm/llvm-project/pull/81015
___
cfe-commits mailing list
cfe-com
https://github.com/Sh0g0-1758 edited
https://github.com/llvm/llvm-project/pull/81015
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -21124,6 +21124,8 @@ Sema::ActOnOpenMPDependClause(const
OMPDependClause::DependDataTy &Data,
ExprTy = ATy->getElementType();
else
ExprTy = BaseType->getPointeeType();
+if (ExprTy.isNull())
+ continue;
---
https://github.com/Sh0g0-1758 updated
https://github.com/llvm/llvm-project/pull/81015
>From c8ada809964eac64f6cb0c103593748b86932163 Mon Sep 17 00:00:00 2001
From: Sh0g0-1758
Date: Wed, 7 Feb 2024 21:11:58 +0530
Subject: [PATCH 1/5] Add a Null Check
---
clang/lib/Sema/SemaOpenMP.cpp | 2 ++
1
https://github.com/Sh0g0-1758 edited
https://github.com/llvm/llvm-project/pull/81015
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/Sh0g0-1758 created
https://github.com/llvm/llvm-project/pull/81015
Fixes : #69085 , #69200
**PR SUMMARY**: "Added Null check for negative sized array and a test for the
same"
>From c8ada809964eac64f6cb0c103593748b86932163 Mon Sep 17 00:00:00 2001
From: Sh0g0-1758
Date: Wed
https://github.com/Sh0g0-1758 closed
https://github.com/llvm/llvm-project/pull/80838
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/Sh0g0-1758 updated
https://github.com/llvm/llvm-project/pull/78338
>From b98f02d4c155b5be9bd4f5b2e4bf73720a81f39a Mon Sep 17 00:00:00 2001
From: Sh0g0-1758
Date: Wed, 17 Jan 2024 01:24:17 +0530
Subject: [PATCH 01/22] Fix : more detailed no expected directive message
---
cla
Sh0g0-1758 wrote:
Any idea why the build is failing? I have just changed the py regex.
https://github.com/llvm/llvm-project/pull/80838
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -179,7 +179,7 @@ def err_verify_invalid_no_diags : Error<
"%select{expected|'expected-no-diagnostics'}0 directive cannot follow "
"%select{'expected-no-diagnostics' directive|other expected directives}0">;
Sh0g0-1758 wrote:
Thanks a lot for looking o
https://github.com/Sh0g0-1758 edited
https://github.com/llvm/llvm-project/pull/78338
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/Sh0g0-1758 updated
https://github.com/llvm/llvm-project/pull/78338
>From b98f02d4c155b5be9bd4f5b2e4bf73720a81f39a Mon Sep 17 00:00:00 2001
From: Sh0g0-1758
Date: Wed, 17 Jan 2024 01:24:17 +0530
Subject: [PATCH 01/20] Fix : more detailed no expected directive message
---
cla
https://github.com/Sh0g0-1758 updated
https://github.com/llvm/llvm-project/pull/78338
>From b98f02d4c155b5be9bd4f5b2e4bf73720a81f39a Mon Sep 17 00:00:00 2001
From: Sh0g0-1758
Date: Wed, 17 Jan 2024 01:24:17 +0530
Subject: [PATCH 01/19] Fix : more detailed no expected directive message
---
cla
https://github.com/Sh0g0-1758 updated
https://github.com/llvm/llvm-project/pull/80838
>From b98f02d4c155b5be9bd4f5b2e4bf73720a81f39a Mon Sep 17 00:00:00 2001
From: Sh0g0-1758
Date: Wed, 17 Jan 2024 01:24:17 +0530
Subject: [PATCH 01/21] Fix : more detailed no expected directive message
---
cla
https://github.com/Sh0g0-1758 ready_for_review
https://github.com/llvm/llvm-project/pull/80838
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Sh0g0-1758 wrote:
I hope the number of commits can be overlooked. Ran into some rebasing issues.
Added a PR summary for the merge commit.
https://github.com/llvm/llvm-project/pull/80838
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://
https://github.com/Sh0g0-1758 updated
https://github.com/llvm/llvm-project/pull/80838
>From b98f02d4c155b5be9bd4f5b2e4bf73720a81f39a Mon Sep 17 00:00:00 2001
From: Sh0g0-1758
Date: Wed, 17 Jan 2024 01:24:17 +0530
Subject: [PATCH 01/21] Fix : more detailed no expected directive message
---
cla
https://github.com/Sh0g0-1758 edited
https://github.com/llvm/llvm-project/pull/80838
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/Sh0g0-1758 created
https://github.com/llvm/llvm-project/pull/80838
Fixes: #64803
**PR SUMMARY**: Updated Regex to now accept colon endings in GitHub automation.
>From b98f02d4c155b5be9bd4f5b2e4bf73720a81f39a Mon Sep 17 00:00:00 2001
From: Sh0g0-1758
Date: Wed, 17 Jan 2024
@@ -179,7 +179,7 @@ def err_verify_invalid_no_diags : Error<
"%select{expected|'expected-no-diagnostics'}0 directive cannot follow "
"%select{'expected-no-diagnostics' directive|other expected directives}0">;
Sh0g0-1758 wrote:
Yes I understand. I made a
@@ -179,7 +179,7 @@ def err_verify_invalid_no_diags : Error<
"%select{expected|'expected-no-diagnostics'}0 directive cannot follow "
"%select{'expected-no-diagnostics' directive|other expected directives}0">;
Sh0g0-1758 wrote:
Ah really sorry about that
@@ -179,7 +179,7 @@ def err_verify_invalid_no_diags : Error<
"%select{expected|'expected-no-diagnostics'}0 directive cannot follow "
"%select{'expected-no-diagnostics' directive|other expected directives}0">;
Sh0g0-1758 wrote:
@AaronBallman , please cor
https://github.com/Sh0g0-1758 edited
https://github.com/llvm/llvm-project/pull/78338
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Sh0g0-1758 wrote:
gentle ping. Please check the mergeability of this PR.
https://github.com/llvm/llvm-project/pull/78338
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/Sh0g0-1758 edited
https://github.com/llvm/llvm-project/pull/78338
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Sh0g0-1758 wrote:
gentle ping regarding this :
> @AaronBallman, I don't think it needs templating. After a careful look I
> believe that the current implementation is for `-verify` only. Also the error
> says `err_verify_invalid_no_diags` which implicitly means that we are passing
> no `-ver
https://github.com/Sh0g0-1758 edited
https://github.com/llvm/llvm-project/pull/78338
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -179,7 +179,7 @@ def err_verify_invalid_no_diags : Error<
"%select{expected|'expected-no-diagnostics'}0 directive cannot follow "
"%select{'expected-no-diagnostics' directive|other expected directives}0">;
Sh0g0-1758 wrote:
@AaronBallman, I don't thi
@@ -179,7 +179,7 @@ def err_verify_invalid_no_diags : Error<
"%select{expected|'expected-no-diagnostics'}0 directive cannot follow "
"%select{'expected-no-diagnostics' directive|other expected directives}0">;
Sh0g0-1758 wrote:
Okay, sure thing, I will d
https://github.com/Sh0g0-1758 updated
https://github.com/llvm/llvm-project/pull/78338
>From b98f02d4c155b5be9bd4f5b2e4bf73720a81f39a Mon Sep 17 00:00:00 2001
From: Sh0g0-1758
Date: Wed, 17 Jan 2024 01:24:17 +0530
Subject: [PATCH 01/18] Fix : more detailed no expected directive message
---
cla
@@ -179,7 +179,7 @@ def err_verify_invalid_no_diags : Error<
"%select{expected|'expected-no-diagnostics'}0 directive cannot follow "
"%select{'expected-no-diagnostics' directive|other expected directives}0">;
def err_verify_no_directives : Error<
-"no expected direc
Sh0g0-1758 wrote:
Hey @AaronBallman, I have added a test for the same in
```clang/test/Frontend/verify.c``` and made the necessary changes as well. I
have added a short **PR SUMMARY** to the top-level comment as you instructed.
As for changes in other error messages, I think its best to merge
https://github.com/Sh0g0-1758 edited
https://github.com/llvm/llvm-project/pull/78338
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/Sh0g0-1758 updated
https://github.com/llvm/llvm-project/pull/78338
>From b98f02d4c155b5be9bd4f5b2e4bf73720a81f39a Mon Sep 17 00:00:00 2001
From: Sh0g0-1758
Date: Wed, 17 Jan 2024 01:24:17 +0530
Subject: [PATCH 01/17] Fix : more detailed no expected directive message
---
cla
@@ -1098,7 +1098,14 @@ void VerifyDiagnosticConsumer::CheckDiagnostics() {
// Produce an error if no expected-* directives could be found in the
// source file(s) processed.
if (Status == HasNoDirectives) {
- Diags.Report(diag::err_verify_no_directives).setForc
https://github.com/Sh0g0-1758 updated
https://github.com/llvm/llvm-project/pull/78338
>From b98f02d4c155b5be9bd4f5b2e4bf73720a81f39a Mon Sep 17 00:00:00 2001
From: Sh0g0-1758
Date: Wed, 17 Jan 2024 01:24:17 +0530
Subject: [PATCH 01/15] Fix : more detailed no expected directive message
---
cla
@@ -179,7 +179,7 @@ def err_verify_invalid_no_diags : Error<
"%select{expected|'expected-no-diagnostics'}0 directive cannot follow "
"%select{'expected-no-diagnostics' directive|other expected directives}0">;
Sh0g0-1758 wrote:
I see, that can be done ea
Sh0g0-1758 wrote:
gentle ping @reviewers
https://github.com/llvm/llvm-project/pull/78338
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -179,7 +179,7 @@ def err_verify_invalid_no_diags : Error<
"%select{expected|'expected-no-diagnostics'}0 directive cannot follow "
"%select{'expected-no-diagnostics' directive|other expected directives}0">;
Sh0g0-1758 wrote:
Can you please elaborate o
@@ -179,7 +179,7 @@ def err_verify_invalid_no_diags : Error<
"%select{expected|'expected-no-diagnostics'}0 directive cannot follow "
"%select{'expected-no-diagnostics' directive|other expected directives}0">;
def err_verify_no_directives : Error<
-"no expected direc
https://github.com/Sh0g0-1758 updated
https://github.com/llvm/llvm-project/pull/78338
>From b98f02d4c155b5be9bd4f5b2e4bf73720a81f39a Mon Sep 17 00:00:00 2001
From: Sh0g0-1758
Date: Wed, 17 Jan 2024 01:24:17 +0530
Subject: [PATCH 01/15] Fix : more detailed no expected directive message
---
cla
Sh0g0-1758 wrote:
@asl @tbaederr @AaronBallman, can you please review this PR and merge it if
everything seems fine.
https://github.com/llvm/llvm-project/pull/78338
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-b
https://github.com/Sh0g0-1758 updated
https://github.com/llvm/llvm-project/pull/78338
>From b98f02d4c155b5be9bd4f5b2e4bf73720a81f39a Mon Sep 17 00:00:00 2001
From: Sh0g0-1758
Date: Wed, 17 Jan 2024 01:24:17 +0530
Subject: [PATCH 01/11] Fix : more detailed no expected directive message
---
cla
@@ -1098,7 +1098,16 @@ void VerifyDiagnosticConsumer::CheckDiagnostics() {
// Produce an error if no expected-* directives could be found in the
// source file(s) processed.
if (Status == HasNoDirectives) {
- Diags.Report(diag::err_verify_no_directives).setForc
@@ -1098,7 +1098,13 @@ void VerifyDiagnosticConsumer::CheckDiagnostics() {
// Produce an error if no expected-* directives could be found in the
// source file(s) processed.
if (Status == HasNoDirectives) {
- Diags.Report(diag::err_verify_no_directives).setForc
@@ -1098,7 +1098,13 @@ void VerifyDiagnosticConsumer::CheckDiagnostics() {
// Produce an error if no expected-* directives could be found in the
// source file(s) processed.
if (Status == HasNoDirectives) {
- Diags.Report(diag::err_verify_no_directives).setForc
https://github.com/Sh0g0-1758 deleted
https://github.com/llvm/llvm-project/pull/78338
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -1098,7 +1098,13 @@ void VerifyDiagnosticConsumer::CheckDiagnostics() {
// Produce an error if no expected-* directives could be found in the
// source file(s) processed.
if (Status == HasNoDirectives) {
- Diags.Report(diag::err_verify_no_directives).setForc
@@ -1098,7 +1098,13 @@ void VerifyDiagnosticConsumer::CheckDiagnostics() {
// Produce an error if no expected-* directives could be found in the
// source file(s) processed.
if (Status == HasNoDirectives) {
- Diags.Report(diag::err_verify_no_directives).setForc
https://github.com/Sh0g0-1758 updated
https://github.com/llvm/llvm-project/pull/78338
>From b98f02d4c155b5be9bd4f5b2e4bf73720a81f39a Mon Sep 17 00:00:00 2001
From: Sh0g0-1758
Date: Wed, 17 Jan 2024 01:24:17 +0530
Subject: [PATCH 01/10] Fix : more detailed no expected directive message
---
cla
@@ -1098,7 +1098,13 @@ void VerifyDiagnosticConsumer::CheckDiagnostics() {
// Produce an error if no expected-* directives could be found in the
// source file(s) processed.
if (Status == HasNoDirectives) {
- Diags.Report(diag::err_verify_no_directives).setForc
https://github.com/Sh0g0-1758 updated
https://github.com/llvm/llvm-project/pull/78338
>From b98f02d4c155b5be9bd4f5b2e4bf73720a81f39a Mon Sep 17 00:00:00 2001
From: Sh0g0-1758
Date: Wed, 17 Jan 2024 01:24:17 +0530
Subject: [PATCH 1/9] Fix : more detailed no expected directive message
---
clang
https://github.com/Sh0g0-1758 edited
https://github.com/llvm/llvm-project/pull/78338
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -1098,7 +1098,16 @@ void VerifyDiagnosticConsumer::CheckDiagnostics() {
// Produce an error if no expected-* directives could be found in the
// source file(s) processed.
if (Status == HasNoDirectives) {
- Diags.Report(diag::err_verify_no_directives).setForc
https://github.com/Sh0g0-1758 deleted
https://github.com/llvm/llvm-project/pull/78338
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -1098,7 +1098,16 @@ void VerifyDiagnosticConsumer::CheckDiagnostics() {
// Produce an error if no expected-* directives could be found in the
// source file(s) processed.
if (Status == HasNoDirectives) {
- Diags.Report(diag::err_verify_no_directives).setForc
@@ -1098,7 +1098,16 @@ void VerifyDiagnosticConsumer::CheckDiagnostics() {
// Produce an error if no expected-* directives could be found in the
// source file(s) processed.
if (Status == HasNoDirectives) {
- Diags.Report(diag::err_verify_no_directives).setForc
@@ -1098,7 +1098,16 @@ void VerifyDiagnosticConsumer::CheckDiagnostics() {
// Produce an error if no expected-* directives could be found in the
// source file(s) processed.
if (Status == HasNoDirectives) {
- Diags.Report(diag::err_verify_no_directives).setForc
Sh0g0-1758 wrote:
Ah really sorry. Pardon my enthu (ó﹏ò｡)
https://github.com/llvm/llvm-project/pull/78338
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Sh0g0-1758 wrote:
gentle ping @tbaederr .
https://github.com/llvm/llvm-project/pull/78338
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/Sh0g0-1758 updated
https://github.com/llvm/llvm-project/pull/78338
>From b98f02d4c155b5be9bd4f5b2e4bf73720a81f39a Mon Sep 17 00:00:00 2001
From: Sh0g0-1758
Date: Wed, 17 Jan 2024 01:24:17 +0530
Subject: [PATCH 1/8] Fix : more detailed no expected directive message
---
clang
Sh0g0-1758 wrote:
Please see the desired behavior in this screenshot :
With `-verify=` we get `expected-no-diagnostics` and with `-verify=foo` we get
`foo-no-dia
@@ -11,7 +11,7 @@
#error
// expected-error@-1 {{}}
-// CHECK: error: no expected directives found: consider use of
'expected-no-diagnostics'
+// CHECK: error: no expected directives found: consider use of
'{{.*}}-no-diagnostics'
Sh0g0-1758 wrote:
https://github.com/Sh0g0-1758 updated
https://github.com/llvm/llvm-project/pull/78338
>From b98f02d4c155b5be9bd4f5b2e4bf73720a81f39a Mon Sep 17 00:00:00 2001
From: Sh0g0-1758
Date: Wed, 17 Jan 2024 01:24:17 +0530
Subject: [PATCH 1/7] Fix : more detailed no expected directive message
---
clang
@@ -11,7 +11,7 @@
#error
// expected-error@-1 {{}}
-// CHECK: error: no expected directives found: consider use of
'expected-no-diagnostics'
+// CHECK: error: no expected directives found: consider use of
'{{.*}}-no-diagnostics'
Sh0g0-1758 wrote:
@@ -11,7 +11,7 @@
#error
// expected-error@-1 {{}}
-// CHECK: error: no expected directives found: consider use of
'expected-no-diagnostics'
+// CHECK: error: no expected directives found: consider use of
'{{.*}}-no-diagnostics'
Sh0g0-1758 wrote:
@@ -11,7 +11,7 @@
#error
// expected-error@-1 {{}}
-// CHECK: error: no expected directives found: consider use of
'expected-no-diagnostics'
+// CHECK: error: no expected directives found: consider use of
'{{.*}}-no-diagnostics'
Sh0g0-1758 wrote:
Sh0g0-1758 wrote:
@tbaederr, please review the changes.
https://github.com/llvm/llvm-project/pull/78338
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -179,7 +179,7 @@ def err_verify_invalid_no_diags : Error<
"%select{expected|'expected-no-diagnostics'}0 directive cannot follow "
"%select{'expected-no-diagnostics' directive|other expected directives}0">;
def err_verify_no_directives : Error<
-"no expected direc
@@ -5,5 +5,5 @@
# `.ii` file and `-verify` triggers extra diagnostics generation. Clangd should
# strip those.
# RUN: clangd-indexer %t.cpp -- -Xclang -verify --save-temps -- 2>&1 |
FileCheck %s
-# CHECK-NOT: error: no expected directives found: consider use of
'expected-no-d
https://github.com/Sh0g0-1758 updated
https://github.com/llvm/llvm-project/pull/78338
>From b98f02d4c155b5be9bd4f5b2e4bf73720a81f39a Mon Sep 17 00:00:00 2001
From: Sh0g0-1758
Date: Wed, 17 Jan 2024 01:24:17 +0530
Subject: [PATCH 1/6] Fix : more detailed no expected directive message
---
clang
@@ -9,7 +9,7 @@
/// \file
/// Defines the Diagnostic-related interfaces.
//
-//===--===//
+//===--===//]
Sh0g0-1758 wrote:
d
Sh0g0-1758 wrote:
@asl, I have checked all the files I changed and I have removed the unrelated
changes and the changes related to another issue. Really sorry for this, I hope
you can overlook it since this is my very first PR in LLVM.
https://github.com/llvm/llvm-project/pull/78338
_
https://github.com/Sh0g0-1758 updated
https://github.com/llvm/llvm-project/pull/78338
>From b98f02d4c155b5be9bd4f5b2e4bf73720a81f39a Mon Sep 17 00:00:00 2001
From: Sh0g0-1758
Date: Wed, 17 Jan 2024 01:24:17 +0530
Subject: [PATCH 1/5] Fix : more detailed no expected directive message
---
clang
Sh0g0-1758 wrote:
Here is a working implementation of the second issue that I aim to solve.
https://github.com/llvm/llvm-project/pull/78338
___
1 - 100 of 104 matches
Mail list logo
