[clang] [llvm] [TargetParser] Fix flaky installs of generated headers (PR #137853)

2025-04-29 Thread Shoaib Meenai via cfe-commits
https://github.com/smeenai closed https://github.com/llvm/llvm-project/pull/137853 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [TargetParser] Fix flaky installs of generated headers (PR #137853)

2025-04-29 Thread Shoaib Meenai via cfe-commits
https://github.com/smeenai created https://github.com/llvm/llvm-project/pull/137853 The `llvm-headers` target wasn't depending on the generated TargetParser headers, so they'd be flakily installed or not installed depending on which order the build steps ran in. Add an explicit dependency to fix

[clang] [FatLTO] Detect LLD linker more reliably (PR #128285)

2025-02-22 Thread Shoaib Meenai via cfe-commits
@@ -862,13 +862,12 @@ void tools::addLTOOptions(const ToolChain &ToolChain, const ArgList &Args, const llvm::Triple &Triple = ToolChain.getTriple(); smeenai wrote: Yeah, I think it's best to keep the old check as well as adding the new one. https://github.co

[clang] [CIR] Cleanup: mlirContext and astContext (PR #119450)

2024-12-10 Thread Shoaib Meenai via cfe-commits
https://github.com/smeenai approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/119450 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [CIR] Integral types; simple global variables (PR #118743)

2024-12-05 Thread Shoaib Meenai via cfe-commits
@@ -0,0 +1,27 @@ +//===- CIRTypes.h - MLIR CIR Types --*- C++ -*-===// smeenai wrote: Per https://github.com/llvm/llvm-project/commit/e2c3d16282aca0f7e13f58170140647632d627c9, we should remove the name and description and C++ from t

[clang] [CIR] Integral types; simple global variables (PR #118743)

2024-12-05 Thread Shoaib Meenai via cfe-commits
@@ -74,6 +75,32 @@ class LLVMLoweringInfo { class CIR_Op traits = []> : Op, LLVMLoweringInfo; +//===--===// +// GlobalOp +//===--===// +

[clang] [CMake] Add a cache file for building a highly-optimized LLVM toolchain (PR #117802)

2024-11-26 Thread Shoaib Meenai via cfe-commits
https://github.com/smeenai commented: The runtimes build already builds the toolchain and then builds the runtimes with the just-built toolchain. Can we build the LTO-optimized libc++ as part of stage1 and have stage2 be what the current stage3 is, to avoid any redundancy? I really like the di

[clang] [clang] Only build static analyzer sources if requested (PR #71653)

2024-11-26 Thread Shoaib Meenai via cfe-commits
smeenai wrote: I think this makes sense in that case, though I'd wait for @llvm-beanz and @petrhosek too. https://github.com/llvm/llvm-project/pull/71653 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/li

[clang] [clang][CIR] Fix missing dependency of MLIRCIR (PR #116221)

2024-11-14 Thread Shoaib Meenai via cfe-commits
https://github.com/smeenai closed https://github.com/llvm/llvm-project/pull/116221 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][CIR] Fix missing dependency of MLIRCIR (PR #116221)

2024-11-14 Thread Shoaib Meenai via cfe-commits
https://github.com/smeenai approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/116221 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][CIR] Fix missing dependency of MLIRCIR (PR #116221)

2024-11-14 Thread Shoaib Meenai via cfe-commits
smeenai wrote: Do you need me to merge this for you? Could you also fix the message about private email addresses above? https://github.com/llvm/llvm-project/pull/116221 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cg

[clang] [clang][CIR] Change buildX functions to emitX (PR #115568)

2024-11-12 Thread Shoaib Meenai via cfe-commits
https://github.com/smeenai closed https://github.com/llvm/llvm-project/pull/115568 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][CIR] Change buildX functions to emitX (PR #115568)

2024-11-08 Thread Shoaib Meenai via cfe-commits
https://github.com/smeenai created https://github.com/llvm/llvm-project/pull/115568 The buildX naming convention originated when the CIRGen implementation was planned to be substantially different from original CodeGen. CIRGen is now a much closer adaption of CodeGen, and the emitX to buildX ren

[clang] [clang][CIR] Move CIRGen types into clang::CIRGen (PR #115385)

2024-11-07 Thread Shoaib Meenai via cfe-commits
smeenai wrote: Stack from [ghstack](https://github.com/ezyang/ghstack) (oldest at bottom): * (to be filled) https://github.com/llvm/llvm-project/pull/115385 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/

[clang] [clang][CIR] Move CIRGen types into clang::CIRGen (PR #115385)

2024-11-07 Thread Shoaib Meenai via cfe-commits
https://github.com/smeenai created https://github.com/llvm/llvm-project/pull/115385 https://github.com/llvm/clangir/issues/1025 explains why we want to move the CIR dialect from the `mlir::cir` to the `cir` namespace. To avoid overloading the `cir` namespace too much afterwards, move all symbols

[clang] [CIR] Call code gen; create empty cir.func op (PR #113483)

2024-11-05 Thread Shoaib Meenai via cfe-commits
smeenai wrote: I created https://github.com/llvm/clangir/issues/1062 to track the location discussion in the incubator so that we can come back to it when the time is right. https://github.com/llvm/llvm-project/pull/113483 ___ cfe-commits mailing lis

[clang] [CIR] Call code gen; create empty cir.func op (PR #113483)

2024-10-28 Thread Shoaib Meenai via cfe-commits
@@ -24,9 +27,149 @@ CIRGenModule::CIRGenModule(mlir::MLIRContext &context, clang::ASTContext &astctx, const clang::CodeGenOptions &cgo, DiagnosticsEngine &diags) -: astCtx(astctx), langOpts(ast

[clang] [CIR] Call code gen; create empty cir.func op (PR #113483)

2024-10-28 Thread Shoaib Meenai via cfe-commits
@@ -37,14 +40,39 @@ class CIRGenConsumer : public clang::ASTConsumer { const LangOptions &LangOptions, const FrontendOptions &FEOptions, std::unique_ptr OS) - : OutputStream(std::move(OS)), FS(VFS), + : Action(Action)

[clang] [CIR] Call code gen; create empty cir.func op (PR #113483)

2024-10-28 Thread Shoaib Meenai via cfe-commits
https://github.com/smeenai edited https://github.com/llvm/llvm-project/pull/113483 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [CIR] Call code gen; create empty cir.func op (PR #113483)

2024-10-28 Thread Shoaib Meenai via cfe-commits
https://github.com/smeenai commented: Very minor nits :) Is it at all possible to write a test to exercise the new functionality, or will it just run into an NYI? https://github.com/llvm/llvm-project/pull/113483 ___ cfe-commits mailing list cfe-commi

[clang] [CIR] Build out AST consumer patterns to reach the entry point into CIRGen (PR #91007)

2024-08-31 Thread Shoaib Meenai via cfe-commits
@@ -2900,7 +2900,7 @@ defm clangir : BoolFOption<"clangir", PosFlag, NegFlag LLVM pipeline to compile">, BothFlags<[], [ClangOption, CC1Option], "">>; -def emit_cir : Flag<["-"], "emit-cir">, Visibility<[CC1Option]>, +def emit_cir : Flag<["-"], "emit-cir">, Visibility<[C

[clang] [compiler-rt] [llvm] [CMake][compiler-rt] Support for using compiler-rt atomic library (PR #106603)

2024-08-29 Thread Shoaib Meenai via cfe-commits
https://github.com/smeenai approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/106603 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Add support for omitting only global destructors (PR #104899)

2024-08-26 Thread Shoaib Meenai via cfe-commits
https://github.com/smeenai closed https://github.com/llvm/llvm-project/pull/104899 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Add support for omitting only global destructors (PR #104899)

2024-08-20 Thread Shoaib Meenai via cfe-commits
https://github.com/smeenai updated https://github.com/llvm/llvm-project/pull/104899 >From e0a1a4d57d2801f68adc0f4fe26d33d509956490 Mon Sep 17 00:00:00 2001 From: Shoaib Meenai Date: Mon, 19 Aug 2024 18:05:52 -0700 Subject: [PATCH 1/2] [clang] Add support for omitting only global destructors Fo

[clang] [hmaptool] Add JSON dump option (PR #102648)

2024-08-09 Thread Shoaib Meenai via cfe-commits
https://github.com/smeenai created https://github.com/llvm/llvm-project/pull/102648 The idea is that the output of `hmaptool dump --json` can be fed directly back to `hmaptool write` for easy round-tripping. >From 140a930607b34d2795defee00bbac59baf4c23c5 Mon Sep 17 00:00:00 2001 From: Shoaib M

[clang] [hmaptool] Fix for empty prefixes and suffixes (PR #102571)

2024-08-08 Thread Shoaib Meenai via cfe-commits
https://github.com/smeenai created https://github.com/llvm/llvm-project/pull/102571 The previous logic could fail in some edge cases. >From 28297fc4e0b3b21990f1d614115b8eb946989479 Mon Sep 17 00:00:00 2001 From: Shoaib Meenai Date: Wed, 13 Dec 2023 18:59:25 -0800 Subject: [PATCH] [hmaptool] F

[clang] [CodeGen] Make non-COMDAT relative vtable internal instead of private (PR #102056)

2024-08-06 Thread Shoaib Meenai via cfe-commits
https://github.com/smeenai closed https://github.com/llvm/llvm-project/pull/102056 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[lldb] [clang] [libc] [flang] [lld] [clang-tools-extra] [llvm] [libcxx] [compiler-rt] [lld-macho] Find objects in library search path (PR #78628)

2024-01-20 Thread Shoaib Meenai via cfe-commits
@@ -0,0 +1,14 @@ +# REQUIRES: x86 +# RUN: mkdir -p %t +# RUN: llvm-mc -filetype=obj -triple=x86_64-apple-darwin %p/Inputs/libhello.s -o %t/hello.o +# RUN: llvm-mc -filetype=obj -triple=x86_64-apple-darwin %s -o %t/main.o +# RUN: %lld -L %t %t/main.o %t/hello.o -o %t/a.out ---

[llvm] [lld] [libcxxabi] [clang] [libcxx] [mlir] [openmp] [compiler-rt] [runtimes] Use LLVM libunwind from libc++abi by default (PR #77687)

2024-01-11 Thread Shoaib Meenai via cfe-commits
@@ -22,6 +22,9 @@ set(LIBCXX_ENABLE_ABI_LINKER_SCRIPT OFF CACHE BOOL "") set(LIBCXX_STATICALLY_LINK_ABI_IN_SHARED_LIBRARY ON CACHE BOOL "") set(LIBCXXABI_ENABLE_SHARED OFF CACHE BOOL "") +# Android uses its own unwinder library +set(LIBCXXABI_USE_LLVM_UNWINDER OFF CACHE BOOL "

[clang] [clang] Add getClangVendor() and use it in CodeGenModule.cpp (PR #75935)

2023-12-20 Thread Shoaib Meenai via cfe-commits
https://github.com/smeenai approved this pull request. LGTM, thanks! https://github.com/llvm/llvm-project/pull/75935 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][CodeGen] Always use CLANG_VENDOR as a quoted string (PR #75935)

2023-12-19 Thread Shoaib Meenai via cfe-commits
https://github.com/smeenai requested changes to this pull request. IIRC, applying definitions like this only to a small set of files was an intentional decision, to minimize rebuilding when their values changed. It matters much more for the commit hash than the vendor, but passing defines like

[libcxx] [clang] [llvm] [compiler-rt] [libc] [compiler-rt]Add lld into dependency for apple builds now that lld Mach-O backend is available (PR #75884)

2023-12-18 Thread Shoaib Meenai via cfe-commits
https://github.com/smeenai approved this pull request. LGTM, thanks! https://github.com/llvm/llvm-project/pull/75884 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 863b938 - [clang] Remove stale release note

2023-12-11 Thread Shoaib Meenai via cfe-commits
Author: Shoaib Meenai Date: 2023-12-11T15:37:49-08:00 New Revision: 863b9388687d01c67de1248e48cee0df698515c0 URL: https://github.com/llvm/llvm-project/commit/863b9388687d01c67de1248e48cee0df698515c0 DIFF: https://github.com/llvm/llvm-project/commit/863b9388687d01c67de1248e48cee0df698515c0.diff

[clang] [clang] Only build static analyzer sources if requested (PR #71653)

2023-11-13 Thread Shoaib Meenai via cfe-commits
@@ -23,7 +23,9 @@ add_subdirectory(Tooling) add_subdirectory(DirectoryWatcher) add_subdirectory(Index) add_subdirectory(IndexSerialization) -add_subdirectory(StaticAnalyzer) +if(CLANG_ENABLE_STATIC_ANALYZER) smeenai wrote: I agree with Chris in general. This c

Re: [clang] cd7ba9f - [Clang] Generate test checks (NFC)

2023-11-11 Thread Shoaib Meenai via cfe-commits
This is breaking tests when building without assertions enabled, e.g. https://lab.llvm.org/buildbot/#/builders/67/builds/13266/steps/7/logs/stdio, I think because the initial entry: label isn’t generated in such builds. Could you please take a look? From: cfe-commits on behalf of Nikita Popov

[clang] 3bb7ecc - Revert "[Clang] Generate test checks (NFC)"

2023-11-10 Thread Shoaib Meenai via cfe-commits
Author: Shoaib Meenai Date: 2023-11-10T17:08:35-08:00 New Revision: 3bb7ecc5a515d2ddd2708257096e14e3fe3b839d URL: https://github.com/llvm/llvm-project/commit/3bb7ecc5a515d2ddd2708257096e14e3fe3b839d DIFF: https://github.com/llvm/llvm-project/commit/3bb7ecc5a515d2ddd2708257096e14e3fe3b839d.diff

[clang] 8ee07a4 - Revert "[IR] Mark lshr and ashr constant expressions as undesirable"

2023-11-10 Thread Shoaib Meenai via cfe-commits
Author: Shoaib Meenai Date: 2023-11-10T17:08:35-08:00 New Revision: 8ee07a4be7f7d8654ecf25e7ce0a680975649544 URL: https://github.com/llvm/llvm-project/commit/8ee07a4be7f7d8654ecf25e7ce0a680975649544 DIFF: https://github.com/llvm/llvm-project/commit/8ee07a4be7f7d8654ecf25e7ce0a680975649544.diff

[clang] bdd396f - [Analysis] Make test require asserts

2023-11-10 Thread Shoaib Meenai via cfe-commits
Author: Shoaib Meenai Date: 2023-11-10T17:29:32-08:00 New Revision: bdd396f353582b50d0a9af5e5e809aeacc2848bf URL: https://github.com/llvm/llvm-project/commit/bdd396f353582b50d0a9af5e5e809aeacc2848bf DIFF: https://github.com/llvm/llvm-project/commit/bdd396f353582b50d0a9af5e5e809aeacc2848bf.diff

[clang] c5dd1bb - Revert "Revert "[IR] Mark lshr and ashr constant expressions as undesirable""

2023-11-10 Thread Shoaib Meenai via cfe-commits
Author: Shoaib Meenai Date: 2023-11-10T17:26:14-08:00 New Revision: c5dd1bbcc37e8811e7c6050159014d084eac6438 URL: https://github.com/llvm/llvm-project/commit/c5dd1bbcc37e8811e7c6050159014d084eac6438 DIFF: https://github.com/llvm/llvm-project/commit/c5dd1bbcc37e8811e7c6050159014d084eac6438.diff

[clang] 55ac332 - Revert "Revert "[Clang] Generate test checks (NFC)""

2023-11-10 Thread Shoaib Meenai via cfe-commits
Author: Shoaib Meenai Date: 2023-11-10T17:24:39-08:00 New Revision: 55ac33235db3635a797f98f4539d665bfacf92df URL: https://github.com/llvm/llvm-project/commit/55ac33235db3635a797f98f4539d665bfacf92df DIFF: https://github.com/llvm/llvm-project/commit/55ac33235db3635a797f98f4539d665bfacf92df.diff

[clang] [clang] Enable Wenum-constexpr-conversion also in system headers and … (PR #67528)

2023-10-16 Thread Shoaib Meenai via cfe-commits
Carlos =?utf-8?q?G=C3=A1lvez?= Message-ID: In-Reply-To: smeenai wrote: https://github.com/boostorg/mpl/issues/69 is still a problem, unfortunately. https://github.com/llvm/llvm-project/pull/67528 ___ cfe-commits mailing list cfe-commits@lists.llvm.o

[clang] [diag] Silence `-Wfixed-enum-extension` in C23 (PR #68060)

2023-10-03 Thread Shoaib Meenai via cfe-commits
https://github.com/smeenai closed https://github.com/llvm/llvm-project/pull/68060 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [diag] Silence `-Wfixed-enum-extension` in C23 (PR #68060)

2023-10-03 Thread Shoaib Meenai via cfe-commits
https://github.com/smeenai updated https://github.com/llvm/llvm-project/pull/68060 >From b931e047168d2312f05c0fbf2813915cc4e06ae8 Mon Sep 17 00:00:00 2001 From: Shoaib Meenai Date: Mon, 2 Oct 2023 17:50:36 -0700 Subject: [PATCH 1/4] [diag] Silence `-Wfixed-enum-extension` in C23 The C23 standa

[clang] [diag] Silence `-Wfixed-enum-extension` in C23 (PR #68060)

2023-10-03 Thread Shoaib Meenai via cfe-commits
https://github.com/smeenai updated https://github.com/llvm/llvm-project/pull/68060 >From b931e047168d2312f05c0fbf2813915cc4e06ae8 Mon Sep 17 00:00:00 2001 From: Shoaib Meenai Date: Mon, 2 Oct 2023 17:50:36 -0700 Subject: [PATCH 1/4] [diag] Silence `-Wfixed-enum-extension` in C23 The C23 standa

[clang] [diag] Silence `-Wfixed-enum-extension` in C23 (PR #68060)

2023-10-03 Thread Shoaib Meenai via cfe-commits
https://github.com/smeenai updated https://github.com/llvm/llvm-project/pull/68060 >From b931e047168d2312f05c0fbf2813915cc4e06ae8 Mon Sep 17 00:00:00 2001 From: Shoaib Meenai Date: Mon, 2 Oct 2023 17:50:36 -0700 Subject: [PATCH 1/3] [diag] Silence `-Wfixed-enum-extension` in C23 The C23 standa

[clang] [diag] Silence `-Wfixed-enum-extension` in C23 (PR #68060)

2023-10-03 Thread Shoaib Meenai via cfe-commits
@@ -5019,7 +5019,7 @@ void Parser::ParseEnumSpecifier(SourceLocation StartLoc, DeclSpec &DS, else if (getLangOpts().MicrosoftExt) Diag(ColonLoc, diag::ext_ms_c_enum_fixed_underlying_type) << BaseRange; -else +else if (!getLangOpt

[clang] [diag] Silence `-Wfixed-enum-extension` in C23 (PR #68060)

2023-10-03 Thread Shoaib Meenai via cfe-commits
https://github.com/smeenai updated https://github.com/llvm/llvm-project/pull/68060 >From b931e047168d2312f05c0fbf2813915cc4e06ae8 Mon Sep 17 00:00:00 2001 From: Shoaib Meenai Date: Mon, 2 Oct 2023 17:50:36 -0700 Subject: [PATCH 1/2] [diag] Silence `-Wfixed-enum-extension` in C23 The C23 standa

[clang] [diag] Silence `-Wfixed-enum-extension` in C23 (PR #68060)

2023-10-02 Thread Shoaib Meenai via cfe-commits
https://github.com/smeenai created https://github.com/llvm/llvm-project/pull/68060 The C23 standard supports enums with fixed underlying types (N3030 [1]), so we shouldn't emit `-Wfixed-enum-extension` in C23 mode (since it's no longer a Clang extension at that point). [1] https://thephd.dev/_

[clang] [Sema] Use underlying type of scoped enum for -Wformat diagnostics (PR #67378)

2023-10-02 Thread Shoaib Meenai via cfe-commits
https://github.com/smeenai closed https://github.com/llvm/llvm-project/pull/67378 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [Sema] Use underlying type of scoped enum for -Wformat diagnostics (PR #67378)

2023-10-02 Thread Shoaib Meenai via cfe-commits
smeenai wrote: I have commit access. Thanks for the review! https://github.com/llvm/llvm-project/pull/67378 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [Sema] Use underlying type of scoped enum for -Wformat diagnostics (PR #67378)

2023-10-02 Thread Shoaib Meenai via cfe-commits
smeenai wrote: I updated the release notes. I was planning to ask for a pick into 17, but I'll just tweak the release notes for the pick and modify the Clang 18 release notes afterwards if it's accepted. https://github.com/llvm/llvm-project/pull/67378 __

[clang-tools-extra] [Sema] Use underlying type of scoped enum for -Wformat diagnostics (PR #67378)

2023-10-02 Thread Shoaib Meenai via cfe-commits
https://github.com/smeenai updated https://github.com/llvm/llvm-project/pull/67378 >From a1c307ddcc309b6b915feaad6d09f74ecc3f6e79 Mon Sep 17 00:00:00 2001 From: Shoaib Meenai Date: Mon, 25 Sep 2023 13:48:10 -0700 Subject: [PATCH 1/2] [Sema] Use underlying type of scoped enum for -Wformat diagn

[clang] [Sema] Use underlying type of scoped enum for -Wformat diagnostics (PR #67378)

2023-10-02 Thread Shoaib Meenai via cfe-commits
smeenai wrote: Ping. https://github.com/llvm/llvm-project/pull/67378 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Modify BoundsSan to improve debuggability (PR #65972)

2023-09-29 Thread Shoaib Meenai via cfe-commits
https://github.com/smeenai closed https://github.com/llvm/llvm-project/pull/65972 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Sema] Use underlying type of scoped enum for -Wformat diagnostics (PR #67378)

2023-09-25 Thread Shoaib Meenai via cfe-commits
https://github.com/smeenai created https://github.com/llvm/llvm-project/pull/67378 Right now, `-Wformat` for a scoped enum will suggest a cast based on the format specifier being used. This can lead to incorrect results, e.g. attempting to format a scoped enum with `%s` would suggest casting to

[clang] [Driver] Fix detection of libc++ with empty sysroot. (PR #66947)

2023-09-22 Thread Shoaib Meenai via cfe-commits
@@ -316,6 +318,52 @@ TEST(ToolChainTest, VFSSolarisMultiGCCInstallation) { } } +MATCHER_P(jobHasArgs, Substr, "") { + const driver::Command &C = arg; + std::string Args = ""; + llvm::ListSeparator Sep(" "); + for (const char *Arg : C.getArguments()) { +Args += Sep; +

[clang] [Driver] Fix detection of libc++ with empty sysroot. (PR #66947)

2023-09-22 Thread Shoaib Meenai via cfe-commits
https://github.com/smeenai resolved https://github.com/llvm/llvm-project/pull/66947 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Driver] Fix detection of libc++ with empty sysroot. (PR #66947)

2023-09-22 Thread Shoaib Meenai via cfe-commits
https://github.com/smeenai approved this pull request. https://github.com/llvm/llvm-project/pull/66947 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Driver] Fix detection of libc++ with empty sysroot. (PR #66947)

2023-09-22 Thread Shoaib Meenai via cfe-commits
smeenai wrote: LGTM, thanks! https://github.com/llvm/llvm-project/pull/66947 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Driver] Fix detection of libc++ with empty sysroot. (PR #66947)

2023-09-22 Thread Shoaib Meenai via cfe-commits
@@ -316,6 +318,52 @@ TEST(ToolChainTest, VFSSolarisMultiGCCInstallation) { } } +MATCHER_P(jobHasArgs, Substr, "") { + const driver::Command &C = arg; + std::string Args = ""; + llvm::ListSeparator Sep(" "); + for (const char *Arg : C.getArguments()) { +Args += Sep; +

[clang] [Sema] Fix fixit cast printing inside macros (PR #66853)

2023-09-20 Thread Shoaib Meenai via cfe-commits
https://github.com/smeenai closed https://github.com/llvm/llvm-project/pull/66853 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Sema] Fix fixit cast printing inside macros (PR #66853)

2023-09-20 Thread Shoaib Meenai via cfe-commits
https://github.com/smeenai updated https://github.com/llvm/llvm-project/pull/66853 >From 701b1d99515e40eec8dcbaba3a0b2dc436bf9652 Mon Sep 17 00:00:00 2001 From: Shoaib Meenai Date: Tue, 19 Sep 2023 19:46:56 -0700 Subject: [PATCH] [Sema] Fix fixit cast printing inside macros `Lexer::getLocForEn

[clang] [Driver] Fix detection of libc++ with empty sysroot. (PR #66947)

2023-09-20 Thread Shoaib Meenai via cfe-commits
smeenai wrote: > Thanks for the quick response! > > > The `sys::path::append` behavior here is surprising. I think it'd be better > > to change the computation of `SysRoot` in the function above (line 3102, > > which I can't comment because of GitHub, sigh) to default to > > `llvm::sys::path:

[clang] [Driver] Fix detection of libc++ with empty sysroot. (PR #66947)

2023-09-20 Thread Shoaib Meenai via cfe-commits
smeenai wrote: Sorry about the breakage. The `sys::path::append` behavior here is surprising. I think it'd be better to change the computation of `SysRoot` in the function above (line 3102, which I can't comment because of GitHub, sigh) to default to `llvm::sys::path::get_separator()` if it's

[clang] [Sema] Fix fixit cast printing inside macros (PR #66853)

2023-09-19 Thread Shoaib Meenai via cfe-commits
smeenai wrote: I updated the PR description with an example. https://github.com/llvm/llvm-project/pull/66853 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Sema] Fix fixit cast printing inside macros (PR #66853)

2023-09-19 Thread Shoaib Meenai via cfe-commits
https://github.com/smeenai edited https://github.com/llvm/llvm-project/pull/66853 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Sema] Fix fixit cast printing inside macros (PR #66853)

2023-09-19 Thread Shoaib Meenai via cfe-commits
https://github.com/smeenai created https://github.com/llvm/llvm-project/pull/66853 `Lexer::getLocForEndOfToken` is documented as returning an invalid source location when the end of the token is inside a macro expansion. We don't want that for this particular application, so just calculate the e

[clang] 915ebb0 - [driver] Address missed feedback from https://reviews.llvm.org/D158476

2023-09-18 Thread Shoaib Meenai via cfe-commits
Author: Shoaib Meenai Date: 2023-09-18T16:28:04-07:00 New Revision: 915ebb07dfc53486eccf0dc09b6411929a463e98 URL: https://github.com/llvm/llvm-project/commit/915ebb07dfc53486eccf0dc09b6411929a463e98 DIFF: https://github.com/llvm/llvm-project/commit/915ebb07dfc53486eccf0dc09b6411929a463e98.diff

[clang] 58288c6 - [driver] Search for compatible Android runtime directories

2023-09-18 Thread Shoaib Meenai via cfe-commits
Author: Shoaib Meenai Date: 2023-09-18T16:14:18-07:00 New Revision: 58288c6c1214f8a3a0e32e003406437652e098bd URL: https://github.com/llvm/llvm-project/commit/58288c6c1214f8a3a0e32e003406437652e098bd DIFF: https://github.com/llvm/llvm-project/commit/58288c6c1214f8a3a0e32e003406437652e098bd.diff

[clang] 1212d1b - [driver] Perform fallback target searches for stdlib

2023-09-18 Thread Shoaib Meenai via cfe-commits
Author: Shoaib Meenai Date: 2023-09-18T12:18:51-07:00 New Revision: 1212d1b511251de69939c8aa380f660373e26419 URL: https://github.com/llvm/llvm-project/commit/1212d1b511251de69939c8aa380f660373e26419 DIFF: https://github.com/llvm/llvm-project/commit/1212d1b511251de69939c8aa380f660373e26419.diff

[clang] b1e3cd1 - [driver] Conditionally include installed libc++ headers for Android

2023-09-18 Thread Shoaib Meenai via cfe-commits
Author: Shoaib Meenai Date: 2023-09-18T12:18:45-07:00 New Revision: b1e3cd1d79443603dc003441e07cdd8d30bb7f26 URL: https://github.com/llvm/llvm-project/commit/b1e3cd1d79443603dc003441e07cdd8d30bb7f26 DIFF: https://github.com/llvm/llvm-project/commit/b1e3cd1d79443603dc003441e07cdd8d30bb7f26.diff

[clang] Modify BoundsSan to improve debuggability (PR #65972)

2023-09-12 Thread Shoaib Meenai via cfe-commits
https://github.com/smeenai review_requested https://github.com/llvm/llvm-project/pull/65972 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Modify BoundsSan to improve debuggability (PR #65972)

2023-09-12 Thread Shoaib Meenai via cfe-commits
https://github.com/smeenai review_requested https://github.com/llvm/llvm-project/pull/65972 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Modify BoundsSan to improve debuggability (PR #65972)

2023-09-12 Thread Shoaib Meenai via cfe-commits
https://github.com/smeenai review_requested https://github.com/llvm/llvm-project/pull/65972 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] f41cd47 - [Driver] Enable stdlibxx-isystem test on Windows

2023-08-30 Thread Shoaib Meenai via cfe-commits
Author: Shoaib Meenai Date: 2023-08-30T14:39:00-07:00 New Revision: f41cd477361b1891ca2702b66a8a66915258f15b URL: https://github.com/llvm/llvm-project/commit/f41cd477361b1891ca2702b66a8a66915258f15b DIFF: https://github.com/llvm/llvm-project/commit/f41cd477361b1891ca2702b66a8a66915258f15b.diff

[clang] b6a1473 - [driver] Refactor getRuntimePaths. NFC

2023-08-28 Thread Shoaib Meenai via cfe-commits
Author: Shoaib Meenai Date: 2023-08-28T17:34:50-07:00 New Revision: b6a1473f97d38471b08331dee7ae7f6112c495c0 URL: https://github.com/llvm/llvm-project/commit/b6a1473f97d38471b08331dee7ae7f6112c495c0 DIFF: https://github.com/llvm/llvm-project/commit/b6a1473f97d38471b08331dee7ae7f6112c495c0.diff

[libunwind] 3da76c2 - [libunwind] Fix build with -Wunused-function

2023-07-27 Thread Shoaib Meenai via cfe-commits
Author: Shoaib Meenai Date: 2023-07-27T20:22:16-07:00 New Revision: 3da76c2116179fdb3fff8feb4551209e4218746e URL: https://github.com/llvm/llvm-project/commit/3da76c2116179fdb3fff8feb4551209e4218746e DIFF: https://github.com/llvm/llvm-project/commit/3da76c2116179fdb3fff8feb4551209e4218746e.diff

[clang] 1df10f1 - [Frontend] Remove ShowIncludesPretendHeader

2023-06-21 Thread Shoaib Meenai via cfe-commits
Author: Shoaib Meenai Date: 2023-06-21T15:48:28-07:00 New Revision: 1df10f15807f9b7deba3f714d27e21578a8b4748 URL: https://github.com/llvm/llvm-project/commit/1df10f15807f9b7deba3f714d27e21578a8b4748 DIFF: https://github.com/llvm/llvm-project/commit/1df10f15807f9b7deba3f714d27e21578a8b4748.diff

[clang] 67a1129 - [Frontend] Don't output skipped includes from predefines

2023-06-21 Thread Shoaib Meenai via cfe-commits
Author: Shoaib Meenai Date: 2023-06-21T15:48:27-07:00 New Revision: 67a11290df64fec44e671a1bdc3a225ed8a02962 URL: https://github.com/llvm/llvm-project/commit/67a11290df64fec44e671a1bdc3a225ed8a02962 DIFF: https://github.com/llvm/llvm-project/commit/67a11290df64fec44e671a1bdc3a225ed8a02962.diff

[clang] 8f7b51e - [CodeGen] Make __clang_call_terminate have an unwind table entry

2023-05-25 Thread Shoaib Meenai via cfe-commits
Author: Shoaib Meenai Date: 2023-05-25T10:56:23-07:00 New Revision: 8f7b51e4ec09f6f50ea6508a196ec607f0659179 URL: https://github.com/llvm/llvm-project/commit/8f7b51e4ec09f6f50ea6508a196ec607f0659179 DIFF: https://github.com/llvm/llvm-project/commit/8f7b51e4ec09f6f50ea6508a196ec607f0659179.diff

[clang] df43ec3 - [Driver] Add test for -stdlib++-isystem with -nostdinc

2022-11-30 Thread Shoaib Meenai via cfe-commits
Author: Shoaib Meenai Date: 2022-11-30T23:09:28-08:00 New Revision: df43ec30ab66f5af7bbf87e121e0fe26aad478b4 URL: https://github.com/llvm/llvm-project/commit/df43ec30ab66f5af7bbf87e121e0fe26aad478b4 DIFF: https://github.com/llvm/llvm-project/commit/df43ec30ab66f5af7bbf87e121e0fe26aad478b4.diff

[clang] 42b3a5f - [clang] Add missing header include

2022-07-14 Thread Shoaib Meenai via cfe-commits
Author: Shoaib Meenai Date: 2022-07-14T00:21:09-07:00 New Revision: 42b3a5fb463fd616d981888abaf0f48ab0065a8d URL: https://github.com/llvm/llvm-project/commit/42b3a5fb463fd616d981888abaf0f48ab0065a8d DIFF: https://github.com/llvm/llvm-project/commit/42b3a5fb463fd616d981888abaf0f48ab0065a8d.diff

[libunwind] 0be0a53 - [libunwind] Use process_vm_readv to avoid potential segfaults

2022-05-26 Thread Shoaib Meenai via cfe-commits
Author: Shoaib Meenai Date: 2022-05-26T09:12:51-07:00 New Revision: 0be0a53df65cb402359c257922d80ab93d86fb40 URL: https://github.com/llvm/llvm-project/commit/0be0a53df65cb402359c257922d80ab93d86fb40 DIFF: https://github.com/llvm/llvm-project/commit/0be0a53df65cb402359c257922d80ab93d86fb40.diff

[libunwind] 3d2b5b7 - [libunwind] Factor out sigreturn check condition. NFC

2022-05-26 Thread Shoaib Meenai via cfe-commits
Author: Shoaib Meenai Date: 2022-05-26T09:12:50-07:00 New Revision: 3d2b5b7b87857b0cc4c322cfc145c46c42fe2bbf URL: https://github.com/llvm/llvm-project/commit/3d2b5b7b87857b0cc4c322cfc145c46c42fe2bbf DIFF: https://github.com/llvm/llvm-project/commit/3d2b5b7b87857b0cc4c322cfc145c46c42fe2bbf.diff

[clang-tools-extra] 4baae16 - [pseudo] Fix pseudo-gen usage when cross-compiling

2022-05-25 Thread Shoaib Meenai via cfe-commits
Author: Shoaib Meenai Date: 2022-05-25T11:08:21-07:00 New Revision: 4baae166ce33ac763bfc1813cf56b8d26e07fb1f URL: https://github.com/llvm/llvm-project/commit/4baae166ce33ac763bfc1813cf56b8d26e07fb1f DIFF: https://github.com/llvm/llvm-project/commit/4baae166ce33ac763bfc1813cf56b8d26e07fb1f.diff

[clang] b4c1cbf - [hmaptool] Fix string decoding for Python 3

2022-03-03 Thread Shoaib Meenai via cfe-commits
Author: Shoaib Meenai Date: 2022-03-03T15:18:21-08:00 New Revision: b4c1cbff79d0631c35ca2efa97bd2a47929945b8 URL: https://github.com/llvm/llvm-project/commit/b4c1cbff79d0631c35ca2efa97bd2a47929945b8 DIFF: https://github.com/llvm/llvm-project/commit/b4c1cbff79d0631c35ca2efa97bd2a47929945b8.diff

[clang] 0c1d330 - [hmaptool] Fix dumping

2022-03-03 Thread Shoaib Meenai via cfe-commits
Author: Shoaib Meenai Date: 2022-03-03T15:18:09-08:00 New Revision: 0c1d330431f59011fd861e291d5048858a973c5a URL: https://github.com/llvm/llvm-project/commit/0c1d330431f59011fd861e291d5048858a973c5a DIFF: https://github.com/llvm/llvm-project/commit/0c1d330431f59011fd861e291d5048858a973c5a.diff

[clang] b846795 - [docs] [clang] Small documentation change for compilation databases

2022-01-22 Thread Shoaib Meenai via cfe-commits
Author: Dave Date: 2022-01-22T17:30:34-08:00 New Revision: b8467952404c3598c9c901332607eb1886e1721c URL: https://github.com/llvm/llvm-project/commit/b8467952404c3598c9c901332607eb1886e1721c DIFF: https://github.com/llvm/llvm-project/commit/b8467952404c3598c9c901332607eb1886e1721c.diff LOG: [do

[clang-tools-extra] ba94b8b - [clangd] Attempt to fix buildbots

2021-10-25 Thread Shoaib Meenai via cfe-commits
Author: Shoaib Meenai Date: 2021-10-25T20:16:59-07:00 New Revision: ba94b8bdffb4c65d5475746a6ba43d279683e5bd URL: https://github.com/llvm/llvm-project/commit/ba94b8bdffb4c65d5475746a6ba43d279683e5bd DIFF: https://github.com/llvm/llvm-project/commit/ba94b8bdffb4c65d5475746a6ba43d279683e5bd.diff

[libunwind] adf1561 - [libunwind] Inform ASan that resumption is noreturn

2021-05-26 Thread Shoaib Meenai via cfe-commits
Author: Shoaib Meenai Date: 2021-05-26T09:31:39-07:00 New Revision: adf1561d6ce8af057127c65af863b3f0e1c77e60 URL: https://github.com/llvm/llvm-project/commit/adf1561d6ce8af057127c65af863b3f0e1c77e60 DIFF: https://github.com/llvm/llvm-project/commit/adf1561d6ce8af057127c65af863b3f0e1c77e60.diff

[clang] 56f7e5a - [cmake] Add support for multiple distributions

2021-05-12 Thread Shoaib Meenai via cfe-commits
Author: Shoaib Meenai Date: 2021-05-12T11:13:18-07:00 New Revision: 56f7e5a822b43578e086c40d063af2a2c0d214ee URL: https://github.com/llvm/llvm-project/commit/56f7e5a822b43578e086c40d063af2a2c0d214ee DIFF: https://github.com/llvm/llvm-project/commit/56f7e5a822b43578e086c40d063af2a2c0d214ee.diff

[clang] 33930a0 - [clang] Pass option directly to command. NFC

2021-03-25 Thread Shoaib Meenai via cfe-commits
Author: Shoaib Meenai Date: 2021-03-25T11:36:06-07:00 New Revision: 33930a0787f6007ba7ebf36384115bebb412e08a URL: https://github.com/llvm/llvm-project/commit/33930a0787f6007ba7ebf36384115bebb412e08a DIFF: https://github.com/llvm/llvm-project/commit/33930a0787f6007ba7ebf36384115bebb412e08a.diff

[clang] 0135bc9 - [clang] Always execute multi-stage install steps

2021-03-25 Thread Shoaib Meenai via cfe-commits
Author: Shoaib Meenai Date: 2021-03-25T11:36:00-07:00 New Revision: 0135bc996d82ff68677820c421b4d666590e4f31 URL: https://github.com/llvm/llvm-project/commit/0135bc996d82ff68677820c421b4d666590e4f31 DIFF: https://github.com/llvm/llvm-project/commit/0135bc996d82ff68677820c421b4d666590e4f31.diff

[clang] 9a2a167 - [DirectoryWatcher] Increase timeout to make test less flaky

2021-03-05 Thread Shoaib Meenai via cfe-commits
Author: Shoaib Meenai Date: 2021-03-05T17:49:14-08:00 New Revision: 9a2a167b6ca7c35b60846592d7c11332c1f424e3 URL: https://github.com/llvm/llvm-project/commit/9a2a167b6ca7c35b60846592d7c11332c1f424e3 DIFF: https://github.com/llvm/llvm-project/commit/9a2a167b6ca7c35b60846592d7c11332c1f424e3.diff

[clang] 4dbb3f5 - [clang] Add llvm-strip to test dependencies

2021-01-09 Thread Shoaib Meenai via cfe-commits
Author: Shoaib Meenai Date: 2021-01-09T11:57:27-08:00 New Revision: 4dbb3f57c6fe581ef525dbe49a401f4bab834eff URL: https://github.com/llvm/llvm-project/commit/4dbb3f57c6fe581ef525dbe49a401f4bab834eff DIFF: https://github.com/llvm/llvm-project/commit/4dbb3f57c6fe581ef525dbe49a401f4bab834eff.diff

[clang-tools-extra] 6bd01b8 - [clangd] Account for vendor in version string

2020-11-02 Thread Shoaib Meenai via cfe-commits
Author: Shoaib Meenai Date: 2020-11-02T09:04:44-08:00 New Revision: 6bd01b8184de93979756331c71af69b422f71103 URL: https://github.com/llvm/llvm-project/commit/6bd01b8184de93979756331c71af69b422f71103 DIFF: https://github.com/llvm/llvm-project/commit/6bd01b8184de93979756331c71af69b422f71103.diff

[clang] 4e4ab8e - [clang] Limit scope of CLANG_VENDOR definition

2020-11-02 Thread Shoaib Meenai via cfe-commits
Author: Shoaib Meenai Date: 2020-11-02T09:04:43-08:00 New Revision: 4e4ab8e0152b42baef5e5a1e2484d865e1a57e90 URL: https://github.com/llvm/llvm-project/commit/4e4ab8e0152b42baef5e5a1e2484d865e1a57e90 DIFF: https://github.com/llvm/llvm-project/commit/4e4ab8e0152b42baef5e5a1e2484d865e1a57e90.diff

[clang] 0c9230d - Reland [libclang] Install both libclang.a and libclang.so when LIBCLANG_BUILD_STATIC=ON

2020-05-06 Thread Shoaib Meenai via cfe-commits
Author: Han Zhu Date: 2020-05-06T19:33:58-07:00 New Revision: 0c9230dad1692bc3d8f1ce2dddae413a115f2532 URL: https://github.com/llvm/llvm-project/commit/0c9230dad1692bc3d8f1ce2dddae413a115f2532 DIFF: https://github.com/llvm/llvm-project/commit/0c9230dad1692bc3d8f1ce2dddae413a115f2532.diff LOG:

[clang] f8990fe - [libclang] Install both libclang.a and libclang.so when LIBCLANG_BUILD_STATIC=ON

2020-04-27 Thread Shoaib Meenai via cfe-commits
Author: Han Zhu Date: 2020-04-27T13:37:07-07:00 New Revision: f8990feb125a0f8d3f2892a589bc6fad3c430858 URL: https://github.com/llvm/llvm-project/commit/f8990feb125a0f8d3f2892a589bc6fad3c430858 DIFF: https://github.com/llvm/llvm-project/commit/f8990feb125a0f8d3f2892a589bc6fad3c430858.diff LOG:

[clang] a299178 - [cmake] Fix -stripped for umbrella library install targets

2020-03-20 Thread Shoaib Meenai via cfe-commits
Author: Shoaib Meenai Date: 2020-03-20T18:46:48-07:00 New Revision: a299178ae77a9d0c7d66f50d17483b7d18898ef0 URL: https://github.com/llvm/llvm-project/commit/a299178ae77a9d0c7d66f50d17483b7d18898ef0 DIFF: https://github.com/llvm/llvm-project/commit/a299178ae77a9d0c7d66f50d17483b7d18898ef0.diff

  1   2   3   4   >