[PATCH] D128608: [NFC][ASTImporter] remove the unnecessary condition checks in ASTImporter.cpp

This revision was automatically updated to reflect the committed changes. Closed by commit rG98c6a3c0c220: [NFC][ASTImporter] remove the unnecessary condition checks in ASTImporter.cpp (authored by phyBrackets). Changed prior to commit: https://reviews.llvm.org/D128608?vs=440059&id=442167#toc

[PATCH] D128608: [NFC][AST] remove the unnecessary condition checks in ASTImporter.cpp

phyBrackets created this revision. Herald added a subscriber: martong. Herald added a reviewer: a.sidorin. Herald added a reviewer: shafik. Herald added a project: All. phyBrackets requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. I think tha

[PATCH] D125340: [clang][NFC][AST] rename the ImportError to ASTImportError

This revision was automatically updated to reflect the committed changes. Closed by commit rG9d637956b792: [clang][NFC][AST] rename the ImportError to ASTImportError (authored by phyBrackets). Changed prior to commit: https://reviews.llvm.org/D125340?vs=428508&id=436881#toc Repository: rG LL

[PATCH] D125340: [clang][NFC][AST] rename the ImportError to ASTImportError

phyBrackets added a comment. In D125340#3506210 , @balazske wrote: > I found one other place in **LibASTImporter.rst** where `ImportError` is > used. LLDB should be checked too. Yeah , I update the file **LibASTImporter.rst**, I'm not sure if there is n

[PATCH] D125340: [clang][NFC][AST] rename the ImportError to ASTImportError

phyBrackets added a comment. In D125340#3505723 , @martong wrote: > What are the benefits of this renaming? I mean is there a name clash? Do we > have another kind of "import" in Clang or in some of the dependent projects, > don't we? AS it suggested b

[PATCH] D125340: [clang][NFC][AST] rename the ImportError to ASTImportError

phyBrackets created this revision. Herald added a subscriber: martong. Herald added a reviewer: a.sidorin. Herald added a reviewer: shafik. Herald added a project: All. phyBrackets requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. this patch

[PATCH] D120489: [analyzer] Done some changes to detect Uninitialized read by the char array manipulation functions

phyBrackets added a comment. In D120489#3493313 , @martong wrote: > Maybe it is not too late to update the clang/docs/ReleaseNotes.rst? A new > checker is certainly important for the users. Many thanks! Yeah done! Thanks. Repository: rG LLVM Github

[PATCH] D124774: [clang][ASTImporter][NFC]: Move clang::ImportError into own header.

This revision was automatically updated to reflect the committed changes. Closed by commit rGdcb906757ada: [clang][ASTImporter][NFC]: Move clang::ImportError into own header. (authored by phyBrackets). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D12

[PATCH] D124774: [clang][ASTImporter][NFC]: Move clang::ImportError into own header.

phyBrackets added a comment. Thanks @martong @balazske for the Review . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124774/new/ https://reviews.llvm.org/D124774 ___ cfe-commits mailing list cfe-commits

[PATCH] D124774: [clang][ASTImporter][NFC]: Move clang::ImportError into own header.

phyBrackets updated this revision to Diff 427322. phyBrackets added a comment. Rebase several commits Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124774/new/ https://reviews.llvm.org/D124774 Files: clang/include/clang/AST/ASTImportError.h cl

[PATCH] D124774: [clang][ASTImporter][NFC]: Move clang::ImportError into own header.

phyBrackets added a comment. is there still any problem ? I'm not sure ? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124774/new/ https://reviews.llvm.org/D124774 ___ cfe-commits mailing list cfe-commit

[PATCH] D124774: [clang][ASTImporter][NFC]: Move clang::ImportError into own header.

phyBrackets updated this revision to Diff 427264. phyBrackets added a comment. address the buildbot failing issue Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124774/new/ https://reviews.llvm.org/D124774 Files: clang/include/clang/AST/ASTImport

[PATCH] D124774: [clang][ASTImporter][NFC]: Move clang::ImportError into own header.

phyBrackets updated this revision to Diff 427261. phyBrackets added a comment. Correct the number of character in line 1 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124774/new/ https://reviews.llvm.org/D124774 Files: clang/include/clang/AST/AS

[PATCH] D124774: [clang][ASTImporter][NFC]: Move clang::ImportError into own header.

phyBrackets added a comment. In D124774#3493382 , @phyBrackets wrote: > I'm having a problem , this patch expected to address the previous inline > comment but after making the specific change and committing it , when I'm > creating the patch using //

[PATCH] D124774: [clang][ASTImporter][NFC]: Move clang::ImportError into own header.

phyBrackets updated this revision to Diff 427259. phyBrackets added a comment. address inline comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124774/new/ https://reviews.llvm.org/D124774 Files: clang/include/clang/AST/ASTImportError.h In

[PATCH] D124774: [clang][ASTImporter][NFC]: Move clang::ImportError into own header.

phyBrackets added a comment. I'm having a problem , this patch expected to address the previous inline comment but after making the specific change and committing it , when I'm creating the patch using //arc diff --update // , the changes were suddenly gone and I thought that maybe the changes

[PATCH] D124774: [clang][ASTImporter][NFC]: Move clang::ImportError into own header.

phyBrackets updated this revision to Diff 427252. phyBrackets added a comment. address inline comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124774/new/ https://reviews.llvm.org/D124774 Files: clang/include/clang/AST/ASTImportError.h In

[PATCH] D124774: [clang][ASTImporter][NFC]: Move clang::ImportError into own header and rename it .

phyBrackets updated this revision to Diff 426992. phyBrackets added a comment. Address inline comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124774/new/ https://reviews.llvm.org/D124774 Files: clang/include/clang/AST/ASTImportError.h c

[PATCH] D124774: [clang][ASTImporter][NFC]: Move clang::ImportError into own header and rename it .

phyBrackets added inline comments. Comment at: clang/include/clang/AST/ASTImporterLookupTable.h:17 +#include "clang/AST/ASTImportError.h" #include "clang/AST/DeclBase.h" // lookup_result balazske wrote: > phyBrackets wrote: > > balazske wrote: > > > This inclu

[PATCH] D124774: [clang][ASTImporter][NFC]: Move clang::ImportError into own header and rename it .

phyBrackets added inline comments. Comment at: clang/include/clang/AST/ASTImportError.h:22 + +class ImportError : public llvm::ErrorInfo { +public: balazske wrote: > balazske wrote: > > Rename to `ASTImportError`. > The rename to `ASTImportError` is better in a s

[PATCH] D124774: [clang][ASTImporter][NFC]: Move clang::ImportError into own header and rename it .

phyBrackets added inline comments. Comment at: clang/include/clang/AST/ASTImporterLookupTable.h:17 +#include "clang/AST/ASTImportError.h" #include "clang/AST/DeclBase.h" // lookup_result balazske wrote: > This include is not needed here. Hey thanks for reviewi

[PATCH] D124774: [AST][FIXME]: trying to fixed a fixme in ASTImporterSharedState.h

phyBrackets created this revision. Herald added a subscriber: martong. Herald added a reviewer: a.sidorin. Herald added a project: All. phyBrackets requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https

[PATCH] D124768: update

phyBrackets created this revision. Herald added a project: All. phyBrackets requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D124768 Files: clang/include/clang/AST/ASTImportE

[PATCH] D121045: [analyzer][NFC] Merge similar conditional paths

phyBrackets added a comment. Thanks @steakhal ! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121045/new/ https://reviews.llvm.org/D121045 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://

[PATCH] D121045: [analyzer][NFC] Merge similar conditional paths

This revision was automatically updated to reflect the committed changes. Closed by commit rG90a6e3547863: [analyzer][NFC] Merge similar conditional paths (authored by phyBrackets). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121045/new/ https://r

[PATCH] D121045: [analyzer][NFC] Merge similar conditional paths

phyBrackets updated this revision to Diff 413402. phyBrackets added a comment. used the correct name for Opcodes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121045/new/ https://reviews.llvm.org/D121045 Files: clang/docs/DataFlowAnalysisIntro.m

[PATCH] D121045: [analyzer][NFC] Merge similar conditional paths

phyBrackets added a comment. Sorry but Idk why that DataFlowAnalysisIntro typo change also commited , I only add the deadstorechecker file. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121045/new/ https://reviews.llvm.org/D121045 ___

[PATCH] D121045: [analyzer][NFC] Merge similar conditional paths

phyBrackets updated this revision to Diff 413300. phyBrackets added a comment. query the opcode only once and reuse it Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121045/new/ https://reviews.llvm.org/D121045 Files: clang/docs/DataFlowAnalysisI

[PATCH] D121045: [analyzer][NFC] Merge similar conditional paths

phyBrackets added a comment. In D121045#3362373 , @steakhal wrote: > I would probably query the opcode only once and reuse it, but is also fine. > > Btw whats your intention making this change? Do you plan greater > refactorings/cleanups? Yeah, I think

[PATCH] D121045: [Analyzer][Refactor] Removed the duplicating of a if statement having same condition

phyBrackets created this revision. Herald added subscribers: manas, steakhal, ASDenysPetrov, martong, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, szepet, baloghadamsoftware, xazax.hun. Herald added a project: All. phyBrackets requested review of this revision. Herald added a projec

[PATCH] D120489: [analyzer] Done some changes to detect Uninitialized read by the char array manipulation functions

phyBrackets added a comment. https://github.com/llvm/llvm-project/commit/bd1917c88a32c0930864d04f4e71155dcc3fa592 , Hey @steakhal , I land it but why it is not showing the void emitUninitializedReadBug(CheckerContext &C, ProgramStateRef State, const Expr *E) co

[PATCH] D120489: [analyzer] Done some changes to detect Uninitialized read by the char array manipulation functions

This revision was automatically updated to reflect the committed changes. Closed by commit rGbd1917c88a32: [analyzer] Done some changes to detect Uninitialized read by the char array… (authored by Shivam <75530356+phybrack...@users.noreply.github.com>, committed by phyBrackets). Changed prior t

[PATCH] D120489: [analyzer] Done some changes to detect Uninitialized read by the char array manipulation functions

phyBrackets added a comment. @steakhal , if everything looks fine, can i land this ? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120489/new/ https://reviews.llvm.org/D120489 ___ cfe-commits mailing lis

[PATCH] D120489: [analyzer] Done some changes to detect Uninitialized read by the char array manipulation functions

phyBrackets added inline comments. Comment at: clang/test/Analysis/bstring_UninitRead.c:2 +// RUN: %clang_analyze_cc1 -verify %s \ +// RUN: -analyzer-checker=alpha.unix.cstring + steakhal wrote: > Yeah done! Thanks Repository: rG LLVM Github Monorepo CHANG

[PATCH] D120489: [analyzer] Done some changes to detect Uninitialized read by the char array manipulation functions

phyBrackets updated this revision to Diff 412464. phyBrackets added a comment. enabled the core checker Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120489/new/ https://reviews.llvm.org/D120489 Files: clang/docs/analyzer/checkers.rst clang/in

[PATCH] D120489: [analyzer] Done some changes to detect Uninitialized read by the char array manipulation functions

phyBrackets updated this revision to Diff 412452. phyBrackets added a comment. Remove unneccesary RUN and some macros definitions Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120489/new/ https://reviews.llvm.org/D120489 Files: clang/docs/analyz

[PATCH] D120489: [analyzer] Done some changes to detect Uninitialized read by the char array manipulation functions

phyBrackets added inline comments. Comment at: clang/test/Analysis/bstring_UninitRead.c:67-85 +//===--=== +// mempcpy() +//===--=== + +#ifdef VA

[PATCH] D120489: [analyzer] Done some changes to detect Uninitialized read by the char array manipulation functions

phyBrackets added inline comments. Comment at: clang/test/Analysis/bstring_UninitRead.c:67-85 +//===--=== +// mempcpy() +//===--=== + +#ifdef VA

[PATCH] D120489: [analyzer] Done some changes to detect Uninitialized read by the char array manipulation functions

phyBrackets added a comment. Hey @NoQ and @steakhal , will you just check , if everything looks fine or not! The test cases run successfully tho now! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120489/new/ https://reviews.llvm.org/D120489 _

[PATCH] D120489: [analyzer] Done some changes to detect Uninitialized read by the char array manipulation functions

phyBrackets updated this revision to Diff 412391. phyBrackets added a comment. Herald added a project: All. Created the separate test file for UninitializedRead checker Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120489/new/ https://reviews.llvm.

[PATCH] D120489: [analyzer] Done some changes to detect Uninitialized read by the char array manipulation functions

phyBrackets added a comment. Hey @NoQ and @steakhal , can i land this patch ? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120489/new/ https://reviews.llvm.org/D120489 ___ cfe-commits mailing list cfe-c

[PATCH] D120489: [analyzer] Done some changes to detect Uninitialized read by the char array manipulation functions

phyBrackets added inline comments. Comment at: clang/test/Analysis/bstring.c:310 - clang_analyzer_eval(p == &dst[4]); // expected-warning{{TRUE}} + clang_analyzer_eval(p == &dst[4]); // no-warning (above is fatal) } NoQ wrote: > Hmm, given that your change s

[PATCH] D120489: [analyzer] Done some changes to detect Uninitialized read by the char array manipulation functions

phyBrackets updated this revision to Diff 411652. phyBrackets added a comment. fix some alignment issue Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120489/new/ https://reviews.llvm.org/D120489 Files: clang/docs/analyzer/checkers.rst clang/in

[PATCH] D120489: [analyzer] Done some changes to detect Uninitialized read by the char array manipulation functions

phyBrackets updated this revision to Diff 411601. phyBrackets added a comment. aligned the indentation Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120489/new/ https://reviews.llvm.org/D120489 Files: clang/docs/analyzer/checkers.rst clang/inc

[PATCH] D120489: [analyzer] Done some changes to detect Uninitialized read by the char array manipulation functions

phyBrackets updated this revision to Diff 411447. phyBrackets added a comment. update the documentation for the uninitialized read checker Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120489/new/ https://reviews.llvm.org/D120489 Files: clang/do

[PATCH] D120489: [analyzer] Done some changes to detect Uninitialized read by the char array manipulation functions

phyBrackets updated this revision to Diff 411286. phyBrackets added a comment. Revised the changes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120489/new/ https://reviews.llvm.org/D120489 Files: clang/docs/analyzer/checkers.rst clang/include

[PATCH] D120489: [analyzer] Done some changes to detect Uninitialized read by the char array manipulation functions

phyBrackets added a comment. @steakhal would you just help, where in the file and what exactly write to in the documentation? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120489/new/ https://reviews.llvm.org/D120489 _

[PATCH] D120489: [analyzer][NFCi] Does some changes to detect Uninitialized read by the char array manipulation functions

phyBrackets created this revision. Herald added subscribers: ASDenysPetrov, martong, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, szepet, baloghadamsoftware, xazax.hun. phyBrackets requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commit

[PATCH] D119462: [analyzer][NFCi] Use the correct BugType in CStringChecker.

phyBrackets added a comment. In D119462#3319031 , @steakhal wrote: > I think yes, go ahead! Thanks ! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119462/new/ https://reviews.llvm.org/D119462 ___

[PATCH] D119462: [analyzer][NFCi] Use the correct BugType in CStringChecker.

This revision was automatically updated to reflect the committed changes. Closed by commit rG6745b6a0f185: [analyzer][NFCi] Use the correct BugType in CStringChecker. (authored by phyBrackets). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119462/new

[PATCH] D119462: [analyzer][NFCi] Use the correct BugType in CStringChecker.

phyBrackets added a comment. Hey @steakhal , any updates on this ? should I commit it ? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119462/new/ https://reviews.llvm.org/D119462 ___ cfe-commits mailing

[PATCH] D119364: Refactor nested if else with ternary operator in CGExprScalar.cpp

phyBrackets added a comment. Hey @rjmccall , would you tell me about this build fail https://green.lab.llvm.org/green/job/lldb-cmake/41339/ Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119364/new/ https://reviews.llvm.org/D119364 ___

[PATCH] D119364: Refactor nested if else with ternary operator in CGExprScalar.cpp

This revision was automatically updated to reflect the committed changes. Closed by commit rGde4e855204aa: Refactor nested if else with ternary operator in CGExprScalar.cpp (authored by phyBrackets). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D1193

[PATCH] D119462: [analyzer][NFCi] Use the correct BugType in CStringChecker.

phyBrackets added a comment. In D119462#3312482 , @steakhal wrote: > I would recommend not touching the unrelated lines, unless you have a clear > motive. Other than that I think its fair to say that this must have been a > bug. Ill check the report dif

[PATCH] D119364: Refactor nested if else with ternary operator in CGExprScalar.cpp

phyBrackets added a comment. In D119364#3310170 , @rjmccall wrote: > Sure, LGTM Hey Thanks, would you please help to land this patch . I don't have commit access . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm

[PATCH] D119364: Refactor nested if else with ternary operator in CGExprScalar.cpp

phyBrackets added a comment. In D119364#3310170 , @rjmccall wrote: > Sure, LGTM Yeah, will keep in mind. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119364/new/ https://reviews.llvm.org/D119364

[PATCH] D119462: resolve the bugtype typo inside emitAdditionOverflowbug function in CStringChecker.cpp.

phyBrackets updated this revision to Diff 407623. phyBrackets added a comment. Use the git blame Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119462/new/ https://reviews.llvm.org/D119462 Files: clang/lib/StaticAnalyzer/Checkers/CStringChecker.c

[PATCH] D119462: resolve the bugtype typo inside emitAdditionOverflowbug function

phyBrackets created this revision. Herald added a subscriber: martong. phyBrackets requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D119462 Files: clang/lib/StaticAnalyzer/Ch

[PATCH] D119364: Refactor nested if else with ternary operator

phyBrackets created this revision. phyBrackets requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D119364 Files: clang/lib/CodeGen/CGExprScalar.cpp Index: clang/lib/CodeGen/C

[PATCH] D119268: avoid the warning of assignment operation inside the if statement

phyBrackets created this revision. Herald added a subscriber: martong. phyBrackets requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D119268 Files: clang/lib/StaticAnalyzer/Ch

[PATCH] D117195: supdate

phyBrackets created this revision. phyBrackets requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D117195 Files: clang/docs/AddressSanitizer.rst Index: clang/docs/AddressSani