[clang] [llvm] [mlir] [clang][lldb][mlir] Fix some identical sub-expressions warnings (NFC) (PR #95715)

2025-02-10 Thread Shivam Gupta via cfe-commits
xgupta wrote: Probably need a fresh start. https://github.com/llvm/llvm-project/pull/95715 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [mlir] [clang][lldb][mlir] Fix some identical sub-expressions warnings (NFC) (PR #95715)

2025-02-10 Thread Shivam Gupta via cfe-commits
https://github.com/xgupta closed https://github.com/llvm/llvm-project/pull/95715 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy] Correct typo in ReleaseNotes.rst (PR #104674)

2024-08-17 Thread Shivam Gupta via cfe-commits
https://github.com/xgupta closed https://github.com/llvm/llvm-project/pull/104674 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy] Correct typo in ReleaseNotes.rst (PR #104674)

2024-08-17 Thread Shivam Gupta via cfe-commits
https://github.com/xgupta approved this pull request. Thanks! https://github.com/llvm/llvm-project/pull/104674 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Fixing Clang HIP inconsistent order for template functions (PR #101627)

2024-08-12 Thread Shivam Gupta via cfe-commits
xgupta wrote: First CI is failing with error - ``` clang: error: cannot find ROCm device library; provide its path via '--rocm-path' or '--rocm-device-lib-path', or pass '-nogpulib' to build without ROCm device library clang: error: cannot find HIP runtime; provide its path via '--rocm-path',

[clang] [llvm] [mlir] [clang][lldb][mlir] Fix some identical sub-expressions warnings (NFC) (PR #95715)

2024-07-26 Thread Shivam Gupta via cfe-commits
https://github.com/xgupta edited https://github.com/llvm/llvm-project/pull/95715 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [mlir] [clang][lldb][mlir] Fix some identical sub-expressions warnings (NFC) (PR #95715)

2024-07-26 Thread Shivam Gupta via cfe-commits
https://github.com/xgupta updated https://github.com/llvm/llvm-project/pull/95715 >From c30bfb621f413c7271bb5a02a7d699e68e053ba1 Mon Sep 17 00:00:00 2001 From: Shivam Gupta Date: Sun, 16 Jun 2024 23:39:47 +0530 Subject: [PATCH 1/4] [clang][lldb][mlir] Fix some identical sub-expressions warning

[clang] [clang-tools-extra] [llvm] [mlir] [clang][lldb][mlir] Fix some identical sub-expressions warnings (NFC) (PR #95715)

2024-07-26 Thread Shivam Gupta via cfe-commits
@@ -4368,7 +4368,7 @@ bool Sema::DiagRedefinedPlaceholderFieldDecl(SourceLocation Loc, Diag(Loc, diag::err_using_placeholder_variable) << Name; for (DeclContextLookupResult::iterator It = Found; It != Result.end(); It++) { const NamedDecl *ND = *It; -if (ND->getDe

[clang] [clang-tools-extra] [llvm] [mlir] [clang][lldb][mlir] Fix some identical sub-expressions warnings (NFC) (PR #95715)

2024-07-26 Thread Shivam Gupta via cfe-commits
@@ -96,7 +96,7 @@ bool areStatementsIdentical(const Stmt *FirstStmt, const Stmt *SecondStmt, if (FirstStmt == SecondStmt) return true; - if (FirstStmt->getStmtClass() != FirstStmt->getStmtClass()) + if (FirstStmt->getStmtClass() != SecondStmt->getStmtClass())

[clang] [Clang] Fix a variable shadowing in MapLattice (NFC) (PR #95697)

2024-07-25 Thread Shivam Gupta via cfe-commits
xgupta wrote: Thanks for the review @martinboehme! https://github.com/llvm/llvm-project/pull/95697 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Fix a variable shadowing in MapLattice (NFC) (PR #95697)

2024-07-25 Thread Shivam Gupta via cfe-commits
https://github.com/xgupta closed https://github.com/llvm/llvm-project/pull/95697 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Remove some dead code in getNumTeamsExprForTargetDirective (PR #95695)

2024-07-24 Thread Shivam Gupta via cfe-commits
https://github.com/xgupta closed https://github.com/llvm/llvm-project/pull/95695 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Remove some dead code in getNumTeamsExprForTargetDirective (PR #95695)

2024-07-24 Thread Shivam Gupta via cfe-commits
https://github.com/xgupta updated https://github.com/llvm/llvm-project/pull/95695 >From 16fde316ba9bd8a54545d71b46df968ae1bb86d3 Mon Sep 17 00:00:00 2001 From: Shivam Gupta Date: Sun, 16 Jun 2024 15:01:13 +0530 Subject: [PATCH 1/2] [Clang] Remove some dead code in getNumTeamsExprForTargetDirec

[clang] [clang-tools-extra] [llvm] [mlir] [clang][lldb][mlir] Fix some identical sub-expressions warnings (NFC) (PR #95715)

2024-06-17 Thread Shivam Gupta via cfe-commits
https://github.com/xgupta updated https://github.com/llvm/llvm-project/pull/95715 >From f80cc3b6ee218e954d68e867637c38211f344d83 Mon Sep 17 00:00:00 2001 From: Shivam Gupta Date: Sun, 16 Jun 2024 23:39:47 +0530 Subject: [PATCH 1/3] [clang][lldb][mlir] Fix some identical sub-expressions warning

[clang] [clang-tools-extra] [llvm] [mlir] [clang][lldb][mlir] Fix some identical sub-expressions warnings (NFC) (PR #95715)

2024-06-17 Thread Shivam Gupta via cfe-commits
https://github.com/xgupta updated https://github.com/llvm/llvm-project/pull/95715 >From f80cc3b6ee218e954d68e867637c38211f344d83 Mon Sep 17 00:00:00 2001 From: Shivam Gupta Date: Sun, 16 Jun 2024 23:39:47 +0530 Subject: [PATCH 1/2] [clang][lldb][mlir] Fix some identical sub-expressions warning

[clang] [Clang] Remove unreachable code in verilogGroupDecl (NFC) (PR #95666)

2024-06-16 Thread Shivam Gupta via cfe-commits
https://github.com/xgupta closed https://github.com/llvm/llvm-project/pull/95666 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Remove unreachable code in verilogGroupDecl (NFC) (PR #95666)

2024-06-16 Thread Shivam Gupta via cfe-commits
xgupta wrote: > I think @sstwcw fixes this in #95703 Oh nice then, I will close this PR. https://github.com/llvm/llvm-project/pull/95666 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commit

[clang] [clang-tools-extra] [llvm] [mlir] [clang][lldb][mlir] Fix some identical sub-expressions warnings (NFC) (PR #95715)

2024-06-16 Thread Shivam Gupta via cfe-commits
https://github.com/xgupta created https://github.com/llvm/llvm-project/pull/95715 This is reported in https://pvs-studio.com/en/blog/posts/cpp/1126/, fragment N4-8 V501 There are identical sub-expressions 'FirstStmt->getStmtClass()' to the left and to the right of the '!=' operator. ASTUtils.

[clang] [Clang] Remove unreachable code in verilogGroupDecl (NFC) (PR #95666)

2024-06-16 Thread Shivam Gupta via cfe-commits
https://github.com/xgupta edited https://github.com/llvm/llvm-project/pull/95666 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Fix logical error in 'if else' condition that lead to an unreachable code (PR #95666)

2024-06-16 Thread Shivam Gupta via cfe-commits
https://github.com/xgupta updated https://github.com/llvm/llvm-project/pull/95666 >From 0e88700adf7add65f3eb8a2d4d2c2de72703a0f0 Mon Sep 17 00:00:00 2001 From: Shivam Gupta Date: Sat, 15 Jun 2024 21:56:09 +0530 Subject: [PATCH 1/4] [Clang] Fix logical error in 'if else' condition that lead to

[clang] [Clang] Fix logical error in 'if else' condition that lead to an unreachable code (PR #95666)

2024-06-16 Thread Shivam Gupta via cfe-commits
https://github.com/xgupta updated https://github.com/llvm/llvm-project/pull/95666 >From 0e88700adf7add65f3eb8a2d4d2c2de72703a0f0 Mon Sep 17 00:00:00 2001 From: Shivam Gupta Date: Sat, 15 Jun 2024 21:56:09 +0530 Subject: [PATCH 1/3] [Clang] Fix logical error in 'if else' condition that lead to

[clang] [Clang] Fix logical error in 'if else' condition that lead to an unreachable code (PR #95666)

2024-06-16 Thread Shivam Gupta via cfe-commits
https://github.com/xgupta updated https://github.com/llvm/llvm-project/pull/95666 >From 0e88700adf7add65f3eb8a2d4d2c2de72703a0f0 Mon Sep 17 00:00:00 2001 From: Shivam Gupta Date: Sat, 15 Jun 2024 21:56:09 +0530 Subject: [PATCH 1/2] [Clang] Fix logical error in 'if else' condition that lead to

[clang] [Clang] Fix a variable shadowing in MapLattice (NFC) (PR #95697)

2024-06-16 Thread Shivam Gupta via cfe-commits
https://github.com/xgupta updated https://github.com/llvm/llvm-project/pull/95697 >From 60fdd988d16ea624d2fd732cf03ee0fc69a14abc Mon Sep 17 00:00:00 2001 From: Shivam Gupta Date: Sun, 16 Jun 2024 15:41:09 +0530 Subject: [PATCH 1/2] [Clang] Fix a variable shadowing in MapLattice (NFC) Reported

[clang] [Clang] Fix a variable shadowing in MapLattice (NFC) (PR #95697)

2024-06-16 Thread Shivam Gupta via cfe-commits
https://github.com/xgupta created https://github.com/llvm/llvm-project/pull/95697 Reported in https://pvs-studio.com/en/blog/posts/cpp/1126/, fragment N10. The PVS-Studio warning: V570 The 'C' variable is assigned to itself. MapLattice.h:52 >From 60fdd988d16ea624d2fd732cf03ee0fc69a14abc Mon Se

[clang] [Clang] Remove some dead code in getNumTeamsExprForTargetDirective (PR #95695)

2024-06-16 Thread Shivam Gupta via cfe-commits
https://github.com/xgupta created https://github.com/llvm/llvm-project/pull/95695 This was reported in https://pvs-studio.com/en/blog/posts/cpp/1126/, fragment N9. V523 The 'then' statement is equivalent to the subsequent code fragment. CGOpenMPRuntime.cpp:6040, 6036 >From 16fde316ba9bd8a545

[clang] [Clang] Fix logical error in 'if else' condition that lead to an unreachable code (PR #95666)

2024-06-15 Thread Shivam Gupta via cfe-commits
https://github.com/xgupta created https://github.com/llvm/llvm-project/pull/95666 This is described in https://pvs-studio.com/en/blog/posts/cpp/1126/ so caught by the PVS Studio analyzer. Warning message - The use of 'if (A) {...} else if (A) {...}' pattern was detected There were two same '

[clang] [clang] Skip tautological comparison if the comparison involves the 'size_t' type (PR #74427)

2024-05-19 Thread Shivam Gupta via cfe-commits
https://github.com/xgupta closed https://github.com/llvm/llvm-project/pull/74427 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Skip tautological comparison if the comparison involves the 'size_t' type (PR #74427)

2024-05-19 Thread Shivam Gupta via cfe-commits
xgupta wrote: Sorry, I do have motivation to continue this patch now, hence closing it. Thank to reviewers for reviewing it. https://github.com/llvm/llvm-project/pull/74427 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org

[clang] [Documentation][Blocks ABI] Fix typoed integer (PR #65688)

2024-05-12 Thread Shivam Gupta via cfe-commits
https://github.com/xgupta closed https://github.com/llvm/llvm-project/pull/65688 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Documentation][Blocks ABI] Fix typoed integer (PR #65688)

2024-05-12 Thread Shivam Gupta via cfe-commits
https://github.com/xgupta updated https://github.com/llvm/llvm-project/pull/65688 >From eede884bb0e374d6ce0db4811ab1a62fc21f4c2c Mon Sep 17 00:00:00 2001 From: Alcaro Date: Fri, 4 Jun 2021 09:25:40 +0200 Subject: [PATCH] Fix typoed integer --- clang/docs/Block-ABI-Apple.rst | 2 +- 1 file cha

[clang] [Clang][Sema] placement new initializes typedef array with correct size (PR #83124)

2024-02-27 Thread Shivam Gupta via cfe-commits
https://github.com/xgupta edited https://github.com/llvm/llvm-project/pull/83124 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[llvm] [polly] [clang] [polly][ScheduleOptimizer] Fix long compile time(hang) reported in polly (PR #75141)

2023-12-12 Thread Shivam Gupta via cfe-commits
@@ -0,0 +1,97 @@ +; RUN: opt -S -polly-optree -polly-delicm -polly-opt-isl -polly-schedule-computeout=10 -debug-only="polly-opt-isl" < %s 2>&1 | FileCheck %s +; Bailout if the computations of schedule compute exceeds the max scheduling quota. +; Max compute out is initiali

[clang] [clang] Skip tautological comparison if the comparison involves the 'size_t' type (PR #74427)

2023-12-11 Thread Shivam Gupta via cfe-commits
xgupta wrote: Ping @cor3ntin, do you have any more comments for this PR? https://github.com/llvm/llvm-project/pull/74427 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][InstrProf] Allow mix-up of absolute path with relative path on command line when using -fprofile-list= (PR #67519)

2023-12-11 Thread Shivam Gupta via cfe-commits
xgupta wrote: @ellishg, @gulfemsavrun shall we close this PR, or it is of any use? For me, it is not much now since it was my mistake to understand the use of -fprofile-list. https://github.com/llvm/llvm-project/pull/67519 ___ cfe-commits mailing li

[clang] [clang] Fix clang++ crash on assertions when compiling source (PR #70594)

2023-12-06 Thread Shivam Gupta via cfe-commits
xgupta wrote: > @cor3ntin Could you describe the format of the `release note` briefly so I > can `amend` my `commit` accordingly? Like this - https://github.com/llvm/llvm-project/pull/74553/files#diff-ec770381d76c859f5f572db789175fe44410a72608f58ad5dbb14335ba56eb97 You also need to clang-forma

[clang] [clang] Skip tautological comparison if the comparison involves the 'size_t' type (PR #74427)

2023-12-04 Thread Shivam Gupta via cfe-commits
https://github.com/xgupta created https://github.com/llvm/llvm-project/pull/74427 The issue with size_t comes when we are trying to add -Wtype-limits to -Wextra for GCC compatibility in review https://reviews.llvm.org/D142826. Example of issue (false positive) - $ cat clang/test/Sema/type-lim

[clang] [clang] Add missing LinkageSpec case to getCursorKindForDecl (PR #72401)

2023-11-24 Thread Shivam Gupta via cfe-commits
xgupta wrote: > By the way, I don't have permission to merge, so feel free to do it when you > think it's ready. Thanks for the contribution. https://github.com/llvm/llvm-project/pull/72401 ___ cfe-commits mailing list cfe-commits@lists.llvm.org htt

[clang] [clang] Add missing LinkageSpec case to getCursorKindForDecl (PR #72401)

2023-11-24 Thread Shivam Gupta via cfe-commits
https://github.com/xgupta closed https://github.com/llvm/llvm-project/pull/72401 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Add missing LinkageSpec case to getCursorKindForDecl (PR #72401)

2023-11-23 Thread Shivam Gupta via cfe-commits
https://github.com/xgupta approved this pull request. It looks good to me, maybe we need a release note change as a formal practice. https://github.com/llvm/llvm-project/pull/72401 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.l

[clang] [clang] Add missing LinkageSpec case to getCursorKindForDecl (PR #72401)

2023-11-22 Thread Shivam Gupta via cfe-commits
xgupta wrote: Does this fix https://github.com/llvm/llvm-project/issues/56687? https://github.com/llvm/llvm-project/pull/72401 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][Sema] Add -Wswitch-default warning option (PR #73077)

2023-11-21 Thread Shivam Gupta via cfe-commits
xgupta wrote: There is one clang-tidy check (bugprone-switch-missing-default-case) also for this feature. https://github.com/llvm/llvm-project/pull/73077 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/li

[clang] [Clang][InstrProf] Allow mix-up of absolute path with relative path on command line when using -fprofile-list= (PR #67519)

2023-11-18 Thread Shivam Gupta via cfe-commits
https://github.com/xgupta edited https://github.com/llvm/llvm-project/pull/67519 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][InstrProf] Allow mix-up of absolute path with relative path on command line when using -fprofile-list= (PR #67519)

2023-11-18 Thread Shivam Gupta via cfe-commits
https://github.com/xgupta edited https://github.com/llvm/llvm-project/pull/67519 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][InstrProf] Allow mix-up of absolute path with relative path on command line when using -fprofile-list= (PR #67519)

2023-11-18 Thread Shivam Gupta via cfe-commits
@@ -4,7 +4,8 @@ // RUN: %clang_cc1 -fprofile-instrument=clang -fcoverage-mapping -dump-coverage-mapping -fprofile-list=%t-func.list -emit-llvm %s -o - | FileCheck %s --check-prefix=FUNC // RUN: echo "src:%s" | sed -e 's/\\//g' > %t-file.list -// RUN: %clang_cc1 -fprofile

[clang] [Clang][InstrProf] Allow mix-up of absolute path with relative path on command line when using -fprofile-list= (PR #67519)

2023-11-18 Thread Shivam Gupta via cfe-commits
@@ -4,7 +4,8 @@ // RUN: %clang_cc1 -fprofile-instrument=clang -fcoverage-mapping -dump-coverage-mapping -fprofile-list=%t-func.list -emit-llvm %s -o - | FileCheck %s --check-prefix=FUNC // RUN: echo "src:%s" | sed -e 's/\\//g' > %t-file.list -// RUN: %clang_cc1 -fprofile

[clang] [Clang][InstrProf] Allow mix-up of absolute path with relative path on command line when using -fprofile-list= (PR #67519)

2023-11-18 Thread Shivam Gupta via cfe-commits
https://github.com/xgupta updated https://github.com/llvm/llvm-project/pull/67519 >From a7f4b08b54350ebbe4b115214a84669eb69aee3e Mon Sep 17 00:00:00 2001 From: Shivam Gupta Date: Thu, 19 Oct 2023 18:20:05 +0530 Subject: [PATCH] [Clang][InstrProf] Allow absolute path in fun.list of -fprofile-li

[clang] [Clang][InstrProf] Allow mix-up of absolute path with relative path on command line when using -fprofile-list= (PR #67519)

2023-11-08 Thread Shivam Gupta via cfe-commits
https://github.com/xgupta edited https://github.com/llvm/llvm-project/pull/67519 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][InstrProf] Allow mix-up of absolute path with relative path on command line when using -fprofile-list= (PR #67519)

2023-11-08 Thread Shivam Gupta via cfe-commits
https://github.com/xgupta edited https://github.com/llvm/llvm-project/pull/67519 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][InstrProf] Allow mix-up of absolute path with relative path on command line when using -fprofile-list= (PR #67519)

2023-11-08 Thread Shivam Gupta via cfe-commits
https://github.com/xgupta edited https://github.com/llvm/llvm-project/pull/67519 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][InstrProf] Allow mix-up of absolute path with relative path on command line when using -fprofile-list= (PR #67519)

2023-11-08 Thread Shivam Gupta via cfe-commits
https://github.com/xgupta edited https://github.com/llvm/llvm-project/pull/67519 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][InstrProf] Allow absolute path in fun.list of -fprofile-list= (PR #67519)

2023-11-08 Thread Shivam Gupta via cfe-commits
@@ -139,9 +139,23 @@ std::optional ProfileList::isFileExcluded(StringRef FileName, CodeGenOptions::ProfileInstrKind Kind) const { StringRef Section = getSectionName(Kind); - // Check for "source:=" + + // Convert the input file path to its canoni

[clang] [Clang][InstrProf] Allow absolute path in fun.list of -fprofile-list= (PR #67519)

2023-11-08 Thread Shivam Gupta via cfe-commits
https://github.com/xgupta updated https://github.com/llvm/llvm-project/pull/67519 >From 8fdc14ad3a3060407800fe2c570a3631d2a6e1cc Mon Sep 17 00:00:00 2001 From: Shivam Gupta Date: Thu, 19 Oct 2023 18:20:05 +0530 Subject: [PATCH 1/2] [Clang][InstrProf] Allow absolute path in fun.list of -fprofil

[clang] [Clang][InstrProf] Allow absolute path in fun.list of -fprofile-list= (PR #67519)

2023-11-08 Thread Shivam Gupta via cfe-commits
https://github.com/xgupta updated https://github.com/llvm/llvm-project/pull/67519 >From 400c889a4f0e867e3e2ceee43ae5c91f62f63c4d Mon Sep 17 00:00:00 2001 From: Shivam Gupta Date: Thu, 19 Oct 2023 18:20:05 +0530 Subject: [PATCH 1/2] [Clang][InstrProf] Allow absolute path in fun.list of -fprofil

[clang] [Docs][LTO] Updated HowToSubmitABug.rst for LTO crashes (PR #68389)

2023-10-26 Thread Shivam Gupta via cfe-commits
https://github.com/xgupta updated https://github.com/llvm/llvm-project/pull/68389 >From bdf991f4563e3aa840bec35b1678ad4fe8f9fbb6 Mon Sep 17 00:00:00 2001 From: Shivam Gupta Date: Fri, 6 Oct 2023 12:32:24 +0530 Subject: [PATCH 1/5] [Docs][LTO] Update HowToSubmitABug.rst for LTO crashes --- llv

[clang] [RecursiveASTVisitor] Fix RecursiveASTVisitor (RAV) fails to visit the initializer of a bitfield (PR #69557)

2023-10-26 Thread Shivam Gupta via cfe-commits
xgupta wrote: Thanks @cor3ntin for the review! https://github.com/llvm/llvm-project/pull/69557 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [RecursiveASTVisitor] Fix RecursiveASTVisitor (RAV) fails to visit the initializer of a bitfield (PR #69557)

2023-10-26 Thread Shivam Gupta via cfe-commits
https://github.com/xgupta closed https://github.com/llvm/llvm-project/pull/69557 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [RecursiveASTVisitor] Fix RecursiveASTVisitor (RAV) fails to visit the initializer of a bitfield (PR #69557)

2023-10-26 Thread Shivam Gupta via cfe-commits
https://github.com/xgupta updated https://github.com/llvm/llvm-project/pull/69557 >From 2e363be5e79e2aeeb219628db0c917e530e04d99 Mon Sep 17 00:00:00 2001 From: Shivam Gupta Date: Thu, 19 Oct 2023 09:06:43 +0530 Subject: [PATCH 1/4] [RecursiveASTVisitor] Fix RecursiveASTVisitor (RAV) fails to v

[clang] [RecursiveASTVisitor] Fix RecursiveASTVisitor (RAV) fails to visit the initializer of a bitfield (PR #69557)

2023-10-25 Thread Shivam Gupta via cfe-commits
https://github.com/xgupta updated https://github.com/llvm/llvm-project/pull/69557 >From 2e363be5e79e2aeeb219628db0c917e530e04d99 Mon Sep 17 00:00:00 2001 From: Shivam Gupta Date: Thu, 19 Oct 2023 09:06:43 +0530 Subject: [PATCH 1/3] [RecursiveASTVisitor] Fix RecursiveASTVisitor (RAV) fails to v

[clang] [AST] Use explicit type erasure in TypeSourceInfo constructor (PR #68435)

2023-10-20 Thread Shivam Gupta via cfe-commits
https://github.com/xgupta closed https://github.com/llvm/llvm-project/pull/68435 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Workaround for MSVC ARM64 build performance regression (PR #65215)

2023-10-20 Thread Shivam Gupta via cfe-commits
https://github.com/xgupta closed https://github.com/llvm/llvm-project/pull/65215 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Workaround for MSVC ARM64 build performance regression (PR #65215)

2023-10-20 Thread Shivam Gupta via cfe-commits
xgupta wrote: I have the access. https://github.com/llvm/llvm-project/pull/65215 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Workaround for MSVC ARM64 build performance regression (PR #65215)

2023-10-20 Thread Shivam Gupta via cfe-commits
xgupta wrote: @tru Is it fine to commit this? https://github.com/llvm/llvm-project/pull/65215 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] clang-linker-wrapper/LinkerWrapperOpts.td: "--sysroot" => "--sysroot=" (PR #65313)

2023-10-20 Thread Shivam Gupta via cfe-commits
https://github.com/xgupta closed https://github.com/llvm/llvm-project/pull/65313 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [Docs][LTO] Updated HowToSubmitABug.rst for LTO crashes (PR #68389)

2023-10-20 Thread Shivam Gupta via cfe-commits
https://github.com/xgupta edited https://github.com/llvm/llvm-project/pull/68389 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [Docs][LTO] Updated HowToSubmitABug.rst for LTO crashes (PR #68389)

2023-10-19 Thread Shivam Gupta via cfe-commits
@@ -153,6 +153,67 @@ Please run this, then file a bug with the instructions and reduced .bc file that bugpoint emits. If something goes wrong with bugpoint, please submit the "foo.bc" file and the option that llc crashes with. +LTO bugs +--- + +If you

[clang] [Clang][InstrProf] Allow absolute path in fun.list of -fprofile-list= (PR #67519)

2023-10-19 Thread Shivam Gupta via cfe-commits
@@ -139,9 +139,23 @@ std::optional ProfileList::isFileExcluded(StringRef FileName, CodeGenOptions::ProfileInstrKind Kind) const { StringRef Section = getSectionName(Kind); - // Check for "source:=" + + // Convert the input file path to its canoni

[clang] [Clang][InstrProf] Allow absolute path in fun.list of -fprofile-list= (PR #67519)

2023-10-19 Thread Shivam Gupta via cfe-commits
https://github.com/xgupta reopened https://github.com/llvm/llvm-project/pull/67519 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][InstrProf] Allow absolute path in fun.list of -fprofile-list= (PR #67519)

2023-10-19 Thread Shivam Gupta via cfe-commits
https://github.com/xgupta updated https://github.com/llvm/llvm-project/pull/67519 >From 400c889a4f0e867e3e2ceee43ae5c91f62f63c4d Mon Sep 17 00:00:00 2001 From: Shivam Gupta Date: Thu, 19 Oct 2023 18:20:05 +0530 Subject: [PATCH] [Clang][InstrProf] Allow absolute path in fun.list of -fprofile-li

[clang-tools-extra] [Docs][LTO] Updated HowToSubmitABug.rst for LTO crashes (PR #68389)

2023-10-19 Thread Shivam Gupta via cfe-commits
https://github.com/xgupta updated https://github.com/llvm/llvm-project/pull/68389 >From bdf991f4563e3aa840bec35b1678ad4fe8f9fbb6 Mon Sep 17 00:00:00 2001 From: Shivam Gupta Date: Fri, 6 Oct 2023 12:32:24 +0530 Subject: [PATCH 1/4] [Docs][LTO] Update HowToSubmitABug.rst for LTO crashes --- llv

[clang-tools-extra] [Docs][LTO] Updated HowToSubmitABug.rst for LTO crashes (PR #68389)

2023-10-19 Thread Shivam Gupta via cfe-commits
https://github.com/xgupta updated https://github.com/llvm/llvm-project/pull/68389 >From bdf991f4563e3aa840bec35b1678ad4fe8f9fbb6 Mon Sep 17 00:00:00 2001 From: Shivam Gupta Date: Fri, 6 Oct 2023 12:32:24 +0530 Subject: [PATCH 1/3] [Docs][LTO] Update HowToSubmitABug.rst for LTO crashes --- llv

[clang] [Docs][LTO] Updated HowToSubmitABug.rst for LTO crashes (PR #68389)

2023-10-19 Thread Shivam Gupta via cfe-commits
https://github.com/xgupta updated https://github.com/llvm/llvm-project/pull/68389 >From bdf991f4563e3aa840bec35b1678ad4fe8f9fbb6 Mon Sep 17 00:00:00 2001 From: Shivam Gupta Date: Fri, 6 Oct 2023 12:32:24 +0530 Subject: [PATCH 1/2] [Docs][LTO] Update HowToSubmitABug.rst for LTO crashes --- llv

[clang] [RecursiveASTVisitor] Fix RecursiveASTVisitor (RAV) fails to visit the initializer of a bitfield (PR #69557)

2023-10-18 Thread Shivam Gupta via cfe-commits
https://github.com/xgupta updated https://github.com/llvm/llvm-project/pull/69557 >From 96f6b90ed4a70430f94eab2d9ca317dd8367022a Mon Sep 17 00:00:00 2001 From: Shivam Gupta Date: Thu, 19 Oct 2023 09:06:43 +0530 Subject: [PATCH 1/2] [RecursiveASTVisitor] Fix RecursiveASTVisitor (RAV) fails to v

[clang] [RecursiveASTVisitor] Fix RecursiveASTVisitor (RAV) fails to visit the initializer of a bitfield (PR #69557)

2023-10-18 Thread Shivam Gupta via cfe-commits
https://github.com/xgupta edited https://github.com/llvm/llvm-project/pull/69557 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [RecursiveASTVisitor] Fix RecursiveASTVisitor (RAV) fails to visit the initializer of a bitfield (PR #69557)

2023-10-18 Thread Shivam Gupta via cfe-commits
https://github.com/xgupta created https://github.com/llvm/llvm-project/pull/69557 This fixes https://github.com/llvm/llvm-project/issues/64916. Patch by Scott McPeak >From 96f6b90ed4a70430f94eab2d9ca317dd8367022a Mon Sep 17 00:00:00 2001 From: Shivam Gupta Date: Thu, 19 Oct 2023 09:06:43 +053

[clang] [Clang][InstrProf] Allow absolute path in fun.list of -fprofile-list= (PR #67519)

2023-09-26 Thread Shivam Gupta via cfe-commits
https://github.com/xgupta edited https://github.com/llvm/llvm-project/pull/67519 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][InstrProf] Allow absolute path in fun.list of -fprofile-list= (PR #67519)

2023-09-26 Thread Shivam Gupta via cfe-commits
https://github.com/xgupta updated https://github.com/llvm/llvm-project/pull/67519 >From 9a38bc6f7322d641daec8d323b502cd09b721c53 Mon Sep 17 00:00:00 2001 From: Shivam Gupta Date: Wed, 27 Sep 2023 11:18:47 +0530 Subject: [PATCH 1/3] [Clang][InstrProf] Allow absolute path in fun.list of -fprofil

[clang] [Clang][InstrProf] Allow absolute path in fun.list of -fprofile-list= (PR #67519)

2023-09-26 Thread Shivam Gupta via cfe-commits
https://github.com/xgupta updated https://github.com/llvm/llvm-project/pull/67519 >From 9a38bc6f7322d641daec8d323b502cd09b721c53 Mon Sep 17 00:00:00 2001 From: Shivam Gupta Date: Wed, 27 Sep 2023 11:18:47 +0530 Subject: [PATCH 1/2] [Clang][InstrProf] Allow absolute path in fun.list of -fprofil

[clang] [Clang][InstrProf] Allow absolute path in fun.list of -fprofile-list= (PR #67519)

2023-09-26 Thread Shivam Gupta via cfe-commits
https://github.com/xgupta created https://github.com/llvm/llvm-project/pull/67519 None >From 9a38bc6f7322d641daec8d323b502cd09b721c53 Mon Sep 17 00:00:00 2001 From: Shivam Gupta Date: Wed, 27 Sep 2023 11:18:47 +0530 Subject: [PATCH] [Clang][InstrProf] Allow absolute path in fun.list of -fprof

[clang] a845252 - Revert "[Clang] Fix -Wconstant-logical-operand when LHS is a constant"

2023-08-07 Thread Shivam Gupta via cfe-commits
Author: Shivam Gupta Date: 2023-08-08T08:00:02+05:30 New Revision: a84525233776a716e2c6291993f0b33fd1c76f7c URL: https://github.com/llvm/llvm-project/commit/a84525233776a716e2c6291993f0b33fd1c76f7c DIFF: https://github.com/llvm/llvm-project/commit/a84525233776a716e2c6291993f0b33fd1c76f7c.diff

[clang-tools-extra] 1e51268 - [clang-tidy] performance-* checks: Also allow allow member expressions to be used in a const manner.

2023-07-23 Thread Shivam Gupta via cfe-commits
Author: Shivam Gupta Date: 2023-07-24T00:08:29+05:30 New Revision: 1e512688376c83d96f097e9b0ddb19132247a646 URL: https://github.com/llvm/llvm-project/commit/1e512688376c83d96f097e9b0ddb19132247a646 DIFF: https://github.com/llvm/llvm-project/commit/1e512688376c83d96f097e9b0ddb19132247a646.diff

[clang-tools-extra] 4754407 - [clang-tidy][clang-tidy-diff.py] Change shebang from python to python3

2023-07-23 Thread Shivam Gupta via cfe-commits
Author: Shivam Gupta Date: 2023-07-23T19:24:11+05:30 New Revision: 475440703238ca32adab6c3fe5e0039c3f96d1a5 URL: https://github.com/llvm/llvm-project/commit/475440703238ca32adab6c3fe5e0039c3f96d1a5 DIFF: https://github.com/llvm/llvm-project/commit/475440703238ca32adab6c3fe5e0039c3f96d1a5.diff

[clang] 061e855 - [clang][Docs] Added release note for D142609

2023-07-19 Thread Shivam Gupta via cfe-commits
Author: Shivam Gupta Date: 2023-07-19T15:00:24+05:30 New Revision: 061e855767dbe0821d81a8d47158f468dd00ae5f URL: https://github.com/llvm/llvm-project/commit/061e855767dbe0821d81a8d47158f468dd00ae5f DIFF: https://github.com/llvm/llvm-project/commit/061e855767dbe0821d81a8d47158f468dd00ae5f.diff

[clang] dfdfd30 - [Clang] Fix -Wconstant-logical-operand when LHS is a constant

2023-07-18 Thread Shivam Gupta via cfe-commits
Author: Shivam Gupta Date: 2023-07-19T12:12:11+05:30 New Revision: dfdfd306cfaf54fbc43e2d5eb36489dac3eb9976 URL: https://github.com/llvm/llvm-project/commit/dfdfd306cfaf54fbc43e2d5eb36489dac3eb9976 DIFF: https://github.com/llvm/llvm-project/commit/dfdfd306cfaf54fbc43e2d5eb36489dac3eb9976.diff

[clang-tools-extra] 42179bb - [clang-tidy] Add check for possibly incomplete switch statements

2023-07-16 Thread Shivam Gupta via cfe-commits
Author: Shivam Gupta Date: 2023-07-17T10:40:11+05:30 New Revision: 42179bbf6bcc9f90256b443c30f5e99f862bc2f6 URL: https://github.com/llvm/llvm-project/commit/42179bbf6bcc9f90256b443c30f5e99f862bc2f6 DIFF: https://github.com/llvm/llvm-project/commit/42179bbf6bcc9f90256b443c30f5e99f862bc2f6.diff

[clang] c1ab198 - [Clang][OpenMP]Solved the the always truth condition in Arm64

2023-05-06 Thread Shivam Gupta via cfe-commits
Author: Samuel Maina Date: 2023-05-06T22:00:00+05:30 New Revision: c1ab19850d5c42a6f76d9bd6049f9cba6e08fba1 URL: https://github.com/llvm/llvm-project/commit/c1ab19850d5c42a6f76d9bd6049f9cba6e08fba1 DIFF: https://github.com/llvm/llvm-project/commit/c1ab19850d5c42a6f76d9bd6049f9cba6e08fba1.diff

[clang] dd6a58b - [Sema] Avoid emitting warnings for constant destruction.

2023-05-06 Thread Shivam Gupta via cfe-commits
Author: Peter Kasting Date: 2023-05-06T20:54:22+05:30 New Revision: dd6a58babc853d180b9a7e5bd709ae12477da004 URL: https://github.com/llvm/llvm-project/commit/dd6a58babc853d180b9a7e5bd709ae12477da004 DIFF: https://github.com/llvm/llvm-project/commit/dd6a58babc853d180b9a7e5bd709ae12477da004.diff

[clang] 85ed0fb - Basic documentation of -mrecip=... option

2023-04-30 Thread Shivam Gupta via cfe-commits
Author: Tim Schmielau Date: 2023-05-01T07:43:00+05:30 New Revision: 85ed0fb5037b7b261b9e5dd8c35fc71830f46b55 URL: https://github.com/llvm/llvm-project/commit/85ed0fb5037b7b261b9e5dd8c35fc71830f46b55 DIFF: https://github.com/llvm/llvm-project/commit/85ed0fb5037b7b261b9e5dd8c35fc71830f46b55.diff

[clang] a704854 - [Clang][Doc] Added an open project for improving command line docs

2023-04-28 Thread Shivam Gupta via cfe-commits
Author: Shivam Gupta Date: 2023-04-28T23:32:37+05:30 New Revision: a70485493803d2e22cbc79184b78861b098ba416 URL: https://github.com/llvm/llvm-project/commit/a70485493803d2e22cbc79184b78861b098ba416 DIFF: https://github.com/llvm/llvm-project/commit/a70485493803d2e22cbc79184b78861b098ba416.diff

[clang] 62eec15 - [clang-rename] Exit gracefully when no input provided

2023-04-26 Thread Shivam Gupta via cfe-commits
Author: Shivam Gupta Date: 2023-04-26T20:23:14+05:30 New Revision: 62eec1584d2cd7634c31d4b82215fa8e260cf3b8 URL: https://github.com/llvm/llvm-project/commit/62eec1584d2cd7634c31d4b82215fa8e260cf3b8 DIFF: https://github.com/llvm/llvm-project/commit/62eec1584d2cd7634c31d4b82215fa8e260cf3b8.diff

[clang] 06387f9 - Revert "[clang-rename] Exit gracefully when no input provided"

2023-04-16 Thread Shivam Gupta via cfe-commits
Author: Shivam Gupta Date: 2023-04-17T10:31:40+05:30 New Revision: 06387f94cfdf6bbd37ac3b925a50410e11a1fc9d URL: https://github.com/llvm/llvm-project/commit/06387f94cfdf6bbd37ac3b925a50410e11a1fc9d DIFF: https://github.com/llvm/llvm-project/commit/06387f94cfdf6bbd37ac3b925a50410e11a1fc9d.diff

[clang] 7261991 - [clang-rename] Exit gracefully when no input provided

2023-04-16 Thread Shivam Gupta via cfe-commits
Author: Shivam Gupta Date: 2023-04-17T10:23:53+05:30 New Revision: 726199146a0bb53315ade042e759c65e6d96d556 URL: https://github.com/llvm/llvm-project/commit/726199146a0bb53315ade042e759c65e6d96d556 DIFF: https://github.com/llvm/llvm-project/commit/726199146a0bb53315ade042e759c65e6d96d556.diff

[clang] 64ae766 - [Docs] Update ClangFormatStyleOptions.rst's versionbadge's to have min-width

2023-04-14 Thread Shivam Gupta via cfe-commits
Author: Shivam Gupta Date: 2023-04-14T23:57:26+05:30 New Revision: 64ae7669a7cefa12ea1117680cf9bfb5c3f6084c URL: https://github.com/llvm/llvm-project/commit/64ae7669a7cefa12ea1117680cf9bfb5c3f6084c DIFF: https://github.com/llvm/llvm-project/commit/64ae7669a7cefa12ea1117680cf9bfb5c3f6084c.diff

[clang] 897e345 - Revert "[Clang] Add -Wtype-limits to -Wextra for GCC compatibility"

2023-02-01 Thread Shivam Gupta via cfe-commits
Author: Shivam Gupta Date: 2023-02-02T05:59:27+05:30 New Revision: 897e345042cdf2b3c1dffd234d1b593205f69a32 URL: https://github.com/llvm/llvm-project/commit/897e345042cdf2b3c1dffd234d1b593205f69a32 DIFF: https://github.com/llvm/llvm-project/commit/897e345042cdf2b3c1dffd234d1b593205f69a32.diff

[clang] 95668c0 - [Clang] Add -Wtype-limits to -Wextra for GCC compatibility

2023-02-01 Thread Shivam Gupta via cfe-commits
Author: Shivam Gupta Date: 2023-02-01T19:29:16+05:30 New Revision: 95668c0d97e6184729f3a3e9621a58d9edffb6b0 URL: https://github.com/llvm/llvm-project/commit/95668c0d97e6184729f3a3e9621a58d9edffb6b0 DIFF: https://github.com/llvm/llvm-project/commit/95668c0d97e6184729f3a3e9621a58d9edffb6b0.diff

[clang] 40003af - [Clang][NFC] Remove a redundancy check in Sema::adjustMemberFunctionCC

2023-01-23 Thread Shivam Gupta via cfe-commits
Author: Shivam Gupta Date: 2023-01-24T11:56:06+05:30 New Revision: 40003af98456607f9b6bd1910424c5243eeb5d01 URL: https://github.com/llvm/llvm-project/commit/40003af98456607f9b6bd1910424c5243eeb5d01 DIFF: https://github.com/llvm/llvm-project/commit/40003af98456607f9b6bd1910424c5243eeb5d01.diff

[clang] 94b9187 - [Clang] Fix a Wbitfield-enum-conversion warning in DirectoryLookup.h

2023-01-23 Thread Shivam Gupta via cfe-commits
Author: Shivam Gupta Date: 2023-01-23T23:48:48+05:30 New Revision: 94b9187a7d37e4269af35f8f7ec8e0f78fd6a06e URL: https://github.com/llvm/llvm-project/commit/94b9187a7d37e4269af35f8f7ec8e0f78fd6a06e DIFF: https://github.com/llvm/llvm-project/commit/94b9187a7d37e4269af35f8f7ec8e0f78fd6a06e.diff

[clang] 68b8908 - [Clang[NFC] Fix bitmask for NullabilityPayload in Types.h

2023-01-23 Thread Shivam Gupta via cfe-commits
Author: Shivam Gupta Date: 2023-01-23T20:18:08+05:30 New Revision: 68b890831615fc4350a47cf7ec404156128d03ac URL: https://github.com/llvm/llvm-project/commit/68b890831615fc4350a47cf7ec404156128d03ac DIFF: https://github.com/llvm/llvm-project/commit/68b890831615fc4350a47cf7ec404156128d03ac.diff

[clang] 4667821 - [NFC] Typo fix in ARCMTActions.h

2022-09-18 Thread Shivam Gupta via cfe-commits
Author: Shivam Gupta Date: 2022-09-18T12:34:24+05:30 New Revision: 46678211512238159199a5857e9f9d774016060c URL: https://github.com/llvm/llvm-project/commit/46678211512238159199a5857e9f9d774016060c DIFF: https://github.com/llvm/llvm-project/commit/46678211512238159199a5857e9f9d774016060c.diff

[clang] 48e1829 - [Diagnostics] Fix inconsistent shift-overflow warnings in C++20

2022-06-14 Thread Shivam Gupta via cfe-commits
Author: Shivam Gupta Date: 2022-06-14T20:19:46+05:30 New Revision: 48e1829874df15fd57e731d4824604f28e177585 URL: https://github.com/llvm/llvm-project/commit/48e1829874df15fd57e731d4824604f28e177585 DIFF: https://github.com/llvm/llvm-project/commit/48e1829874df15fd57e731d4824604f28e177585.diff

[clang] a01579a - [NFC] Suggest Release mode in clang GettingStarted.html

2022-06-10 Thread Shivam Gupta via cfe-commits
Author: Shivam Gupta Date: 2022-06-10T11:00:05+05:30 New Revision: a01579ad0a1bde4d90f4fb656f07586c3097428a URL: https://github.com/llvm/llvm-project/commit/a01579ad0a1bde4d90f4fb656f07586c3097428a DIFF: https://github.com/llvm/llvm-project/commit/a01579ad0a1bde4d90f4fb656f07586c3097428a.diff

  1   2   >