[PATCH] D144047: [CUDA][SPIRV] Match builtin types and __GCC_ATOMIC_XXX_LOCK_FREE macros on host/device

This revision was automatically updated to reflect the committed changes. Closed by commit rG8bd13ad6c537: [CUDA][SPIRV] Match builtin types and __GCC_ATOMIC_XXX_LOCK_FREE macros on… (authored by shangwuyao). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.

[PATCH] D144047: [CUDA][SPIRV] Match builtin types and __GCC_ATOMIC_XXX_LOCK_FREE macros on host/device

shangwuyao added a comment. Friendly ping :-) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144047/new/ https://reviews.llvm.org/D144047 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://li

[PATCH] D144047: [CUDA][SPIRV] Match builtin types and __GCC_ATOMIC_XXX_LOCK_FREE macros on host/device

shangwuyao updated this revision to Diff 498145. shangwuyao added a comment. Run clang-format. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144047/new/ https://reviews.llvm.org/D144047 Files: clang/lib/Basic/Targets/SPIR.h clang/test/CodeGenC

[PATCH] D144047: [CUDA][SPIRV] Match builtin types and __GCC_ATOMIC_XXX_LOCK_FREE macros on host/device

shangwuyao added a comment. In D144047#4129247 , @yaxunl wrote: > In D144047#4129182 , @shangwuyao > wrote: > >> In D144047#4129154 , @yaxunl wrote: >> >>> Making the bui

[PATCH] D144047: [CUDA][SPIRV] Match builtin types and __GCC_ATOMIC_XXX_LOCK_FREE macros on host/device

shangwuyao updated this revision to Diff 497700. shangwuyao added a comment. Amend with comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144047/new/ https://reviews.llvm.org/D144047 Files: clang/lib/Basic/Targets/SPIR.h clang/test/CodeGe

[PATCH] D144047: [CUDA][SPIRV] Match builtin types and __GCC_ATOMIC_XXX_LOCK_FREE macros on host/device

shangwuyao added a comment. In D144047#4129154 , @yaxunl wrote: > Making the builtin types consistent is necessary to keep struct layout > consistent across host and device, but why do we need to make > __GCC_ATOMIC_XXX_LOCK_FREE macros the same betwee

[PATCH] D144047: [CUDA][SPIRV] Match builtin types and __GCC_ATOMIC_XXX_LOCK_FREE macros on host/device

shangwuyao created this revision. shangwuyao added reviewers: jlebar, tra, yaxunl. Herald added subscribers: mattd, carlosgalvezp, ThomasRaoux. Herald added a project: All. shangwuyao requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This cha

[PATCH] D140226: [NVPTX] Introduce attribute to mark kernels without a language mode

shangwuyao added inline comments. Comment at: clang/include/clang/Basic/Attr.td:1198 -def CUDAGlobal : InheritableAttr { - let Spellings = [GNU<"global">, Declspec<"__global__">]; +def CUDAGlobal : InheritableAttr, TargetSpecificAttr { + let Spellings = [GNU<"global">, Declsp

[PATCH] D130387: [CUDA/SPIR-V] Force passing aggregate type byval

shangwuyao added a comment. In D130387#3672969 , @tra wrote: > In D130387#3672961 , @shangwuyao > wrote: > >> Accidentally submitted early... > > The landed revision seems to have my comments addressed. Was there

[PATCH] D130387: [CUDA/SPIR-V] Force passing aggregate type byval

shangwuyao added a comment. Accidentally submitted early... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130387/new/ https://reviews.llvm.org/D130387 ___ cfe-commits mailing list cfe-commits@lists.llvm.

[PATCH] D130387: [CUDA/SPIR-V] Force passing aggregate type byval

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG31d8dbd1e5b4: [CUDA/SPIR-V] Force passing aggregate type byval (authored by shangwuyao). Changed prior to commit: https://reviews.llvm.org/D130387

[PATCH] D130387: [CUDA/SPIR-V] Force passing aggregate type byval

shangwuyao created this revision. shangwuyao added reviewers: jlebar, mkuper, tra, yaxunl. Herald added subscribers: mattd, ThomasRaoux. Herald added a project: All. shangwuyao requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This patch forc

[PATCH] D123049: Emit OpenCL metadata when targeting SPIR-V

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rG15a1769631ff: Emit OpenCL metadata when targeting SPIR-V (authored by shangwuyao). Repository: rG LLVM Github Monorepo

[PATCH] D123049: Emit OpenCL metadata when targeting SPIR-V

shangwuyao added a comment. In D123049#3426849 , @yaxunl wrote: > Is this because your HIP threadIdx etc are implemented using OpenCL builtins > so that the emitted LLVM IR contains calls of OpenCL builtins? Yes, that's correct. Repository: rG LLVM

[PATCH] D123049: Emit OpenCL metadata when targeting SPIR-V

shangwuyao created this revision. shangwuyao added reviewers: jlebar, yaxunl, tra. Herald added subscribers: ldrumm, ThomasRaoux, Anastasia. Herald added a project: All. shangwuyao requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This is req

[PATCH] D120529: Disable broken hip test on Windows

shangwuyao abandoned this revision. shangwuyao added a comment. Closing this since the fix landed with https://reviews.llvm.org/D120563. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120529/new/ https://reviews.llvm.org/D120529 ___

[PATCH] D120563: [HIP] Fix test hip-link-bundled-archive.hip

shangwuyao accepted this revision. shangwuyao added a comment. This revision is now accepted and ready to land. LGTM, thanks for fixing this. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120563/new/ https://reviews.llvm.org/D120563 ___ cfe-c

[PATCH] D120529: Disable broken hip test on Windows

shangwuyao added a comment. Seems like C:\\Users\\ContainerAdministrator\\AppData\\Local\\Temp\\lit-tmp-4x8dbzx6\\libbc-hipBundled-amdgcn-gfx1030-4b53df.a somehow got interpreted by filecheck regex as: C:UsersContainerAdministratorAppDataLocalTemp\\

[PATCH] D120529: Disable broken hip test on Windows

shangwuyao added a comment. See the comments in https://reviews.llvm.org/D120366, an example test failure is in https://reviews.llvm.org/harbormaster/build/224364/. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120529/new/ https://reviews.llvm.org

[PATCH] D120529: Disable broken hip test on Windows

shangwuyao created this revision. shangwuyao added reviewers: tra, jlebar, yaxunl. shangwuyao requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Disable a hip test that's broken only for Windows at HEAD. Repository: rG LLVM Github Monorepo

[PATCH] D120366: [CUDA][SPIRV] Assign global address space to CUDA kernel arguments

shangwuyao added a comment. @yaxunl I saw that you added the test recently, could you provide some context? I think this test is broken at HEAD as I saw it is broken for other patches (see this build ) as well. Repository: rG LLVM Github M

[PATCH] D120366: [CUDA][SPIRV] Assign global address space to CUDA kernel arguments

shangwuyao updated this revision to Diff 411258. shangwuyao added a comment. Disabling the test failing at HEAD with a separate patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120366/new/ https://reviews.llvm.org/D120366 Files: clang/lib/Ba

[PATCH] D120366: [CUDA][SPIRV] Assign global address space to CUDA kernel arguments

shangwuyao added a comment. In D120366#3344221 , @jlebar wrote: > - What's different in this patch vs the previous one? Previous patch broke at two different post-commit build configurations. The generated SPIR-V are: define hidden spir_kernel void @

[PATCH] D120366: [CUDA][SPIRV] Assign global address space to CUDA kernel arguments

shangwuyao updated this revision to Diff 411241. shangwuyao added a comment. Disabled a hip test on Windows that's breaking on head. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120366/new/ https://reviews.llvm.org/D120366 Files: clang/lib/Basi

[PATCH] D120366: [CUDA][SPIRV] Assign global address space to CUDA kernel arguments

shangwuyao added a comment. Looking into the (new) build failure on Windows, since the change has already been reviewed, will try to commit after resolving the build failure. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120366/new/ https://review

[PATCH] D120366: [CUDA][SPIRV] Assign global address space to CUDA kernel arguments

shangwuyao created this revision. shangwuyao added reviewers: jlebar, tra, yaxunl. Herald added subscribers: carlosgalvezp, ThomasRaoux, Anastasia. shangwuyao requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This patch converts CUDA pointer

[PATCH] D119207: [CUDA][SPIRV] Assign global address space to CUDA kernel arguments

shangwuyao added a comment. In D119207#3330385 , @dyung wrote: > Hi, the test you added is failing on the PS4 Linux bot, can you take a look? > > https://lab.llvm.org/buildbot/#/builders/139/builds/17199 Looks like the compiled SPIR-V is slightly differe

[PATCH] D119207: [CUDA][SPIRV] Assign global address space to CUDA kernel arguments

shangwuyao added a comment. Thanks for the review, if it looks good, can we get this to land now? Otherwise more comments are welcome! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119207/new/ https://reviews.llvm.org/D119207

[PATCH] D119207: [CUDA][SPIRV] Assign global address space to CUDA kernel arguments

shangwuyao added inline comments. Comment at: clang/lib/CodeGen/TargetInfo.cpp:10322 ABIArgInfo SPIRVABIInfo::classifyKernelArgumentType(QualType Ty) const { - if (getContext().getLangOpts().HIP) { + if (getContext().getLangOpts().CUDAIsDevice) { // Coerce pointer argumen

[PATCH] D119207: [CUDA][SPIRV] Convert CUDA kernels to SPIR-V kernels

shangwuyao created this revision. Herald added subscribers: carlosgalvezp, ThomasRaoux, Anastasia, yaxunl. shangwuyao requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This patch converts CUDA pointer kernel arguments with default address spa