skatkov accepted this revision.
skatkov added a comment.
This revision is now accepted and ready to land.
with two nits.
Comment at: llvm/include/llvm/Passes/StandardInstrumentations.h:422
+ // Register all the standard instrumentation callbacks. If \p FAM is nullptr
+ // the
skatkov added a comment.
Consider landing tests update for "-verify-cfg-preserved=0" in a separate
commit. This will significantly reduce the size of review.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D91327/new/
https://reviews.llvm.org/D91327
__
skatkov added a comment.
First iteration: style comments.
Comment at: llvm/include/llvm/Passes/StandardInstrumentations.h:124
if (BBGuards)
for (auto &BB : *BBGuards) {
if (BB.second.isPoisoned())
redundant {}
consider using any_of
skatkov added inline comments.
Comment at: llvm/lib/Passes/StandardInstrumentations.cpp:769
+auto *F = any_cast(IR);
+if (auto *Result = FAM.getCachedResult(
+*const_cast(F)))
Result -> GraphBefore
Comment at: llvm/lib/Pass
