[PATCH] D155234: [SystemZ][z/OS] Forward headers to z/os system headers

2023-07-25 Thread Sean via Phabricator via cfe-commits
SeanP updated this revision to Diff 544067. SeanP added a comment. remove extra blank line CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155234/new/ https://reviews.llvm.org/D155234 Files: clang/lib/Headers/CMakeLists.txt clang/lib/Headers/builtins.h clang/lib/Headers/float.h c

[PATCH] D155234: [SystemZ][z/OS] Forward headers to z/os system headers

2023-07-24 Thread Sean via Phabricator via cfe-commits
SeanP updated this revision to Diff 543591. SeanP added a comment. fix up formatting CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155234/new/ https://reviews.llvm.org/D155234 Files: clang/lib/Headers/CMakeLists.txt clang/lib/Headers/builtins.h clang/lib/Headers/float.h clang/l

[PATCH] D155234: [SystemZ][z/OS] Forward headers to z/os system headers

2023-07-13 Thread Sean via Phabricator via cfe-commits
SeanP created this revision. SeanP added reviewers: abhina.sreeskantharajan, zibi, fanbo-meng. Herald added a project: All. SeanP requested review of this revision. Herald added a reviewer: jdoerfert. Herald added subscribers: cfe-commits, jplehr, sstefan1. Herald added a project: clang. For the h

[PATCH] D153582: [SystemZ][z/OS] Add required options/macro/etc for z/os compilation step

2023-06-29 Thread Sean via Phabricator via cfe-commits
SeanP updated this revision to Diff 535937. SeanP added a comment. fix merge conflicts CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153582/new/ https://reviews.llvm.org/D153582 Files: clang/include/clang/Driver/Options.td clang/lib/Basic/Targets/OSTargets.h clang/lib/Basic/Targe

[PATCH] D153582: [SystemZ][z/OS] Add required options/macro/etc for z/os compilation step

2023-06-28 Thread Sean via Phabricator via cfe-commits
SeanP updated this revision to Diff 535353. SeanP added a comment. Got old diff last time. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153582/new/ https://reviews.llvm.org/D153582 Files: clang/include/clang/Driver/Options.td clang/lib/Basic/Targets/OSTargets.h clang/lib/Basic/T

[PATCH] D153582: [SystemZ][z/OS] Add required options/macro/etc for z/os compilation step

2023-06-27 Thread Sean via Phabricator via cfe-commits
SeanP updated this revision to Diff 535214. SeanP added a comment. Generalize path names in test cases so \\ on windows match. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153582/new/ https://reviews.llvm.org/D153582 Files: clang/include/clang/Driver/Options.td clang/lib/Basic/Tar

[PATCH] D153580: [SystemZ][z/OS] Add support for z/OS link step (executable and shared libs)

2023-06-26 Thread Sean via Phabricator via cfe-commits
SeanP updated this revision to Diff 534816. SeanP added a comment. Apply comments from D153582 for similar changes. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153580/new/ https://reviews.llvm.org/D153580 Files: clang/include/clang/Driver/Options

[PATCH] D153582: [SystemZ][z/OS] Add required options/macro/etc for z/os compilation step

2023-06-26 Thread Sean via Phabricator via cfe-commits
SeanP marked 3 inline comments as done. SeanP added a comment. Thanks. made these changes. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153582/new/ https://reviews.llvm.org/D153582 ___ cfe-commits mailing list cfe-commits@lists.llvm.org htt

[PATCH] D153582: [SystemZ][z/OS] Add required options/macro/etc for z/os compilation step

2023-06-26 Thread Sean via Phabricator via cfe-commits
SeanP updated this revision to Diff 534729. SeanP added a comment. apply feedback CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153582/new/ https://reviews.llvm.org/D153582 Files: clang/include/clang/Driver/Options.td clang/lib/Basic/Targets/OSTargets.h clang/lib/Basic/Targets/Sy

[PATCH] D153582: [SystemZ][z/OS] Add required options/macro/etc for z/os compilation step

2023-06-26 Thread Sean via Phabricator via cfe-commits
SeanP updated this revision to Diff 534545. SeanP added a comment. minor clang-format updates CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153582/new/ https://reviews.llvm.org/D153582 Files: clang/include/clang/Driver/Options.td clang/lib/Basic/Targets/OSTargets.h clang/lib/Basi

[PATCH] D153582: [SystemZ][z/OS] Add required options/macro/etc for z/os compilation step

2023-06-24 Thread Sean via Phabricator via cfe-commits
SeanP updated this revision to Diff 534232. SeanP added a comment. Removed __ptr32 address space from data layout. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153582/new/ https://reviews.llvm.org/D153582 Files: clang/include/clang/Driver/Options.td clang/lib/Basic/Targets/OSTarge

[PATCH] D153582: [SystemZ][z/OS] Add required options/macro/etc for z/os compilation step

2023-06-22 Thread Sean via Phabricator via cfe-commits
SeanP created this revision. SeanP added reviewers: abhina.sreeskantharajan, Kai, fanbo-meng. Herald added a project: All. SeanP requested review of this revision. Herald added subscribers: cfe-commits, MaskRay. Herald added a project: clang. Add the required options and macros to the compilation

[PATCH] D153580: Add support for z/OS link step (executable and shared libs)

2023-06-22 Thread Sean via Phabricator via cfe-commits
SeanP created this revision. SeanP added reviewers: zibi, Kai, abhina.sreeskantharajan. Herald added a project: All. SeanP requested review of this revision. Herald added subscribers: cfe-commits, MaskRay. Herald added a project: clang. Add support for performing a link step on z/OS. This will su

[PATCH] D151828: [z/OS] Disable pr59765-modules-global-ctor-dtor.cppm on z/OS to make it unsupported.

2023-05-31 Thread Sean via Phabricator via cfe-commits
SeanP accepted this revision. SeanP added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151828/new/ https://reviews.llvm.org/D151828 ___ c

[PATCH] D137996: Add support for a backdoor driver option that enables emitting header usage information in JSON to a file

2023-01-05 Thread Sean via Phabricator via cfe-commits
SeanP added inline comments. Comment at: clang/tools/driver/driver.cpp:251 + std::string &OptFile) { + T OptVal = ::getenv(EnvOptSet); + if (OptVal) { This change is not POSIX compliant. If T is char *, the next call to getenv() on line 25

[PATCH] D137756: [z/OS][p][pg] Throw Error When Using -p or -pg on z/OS

2022-11-09 Thread Sean via Phabricator via cfe-commits
SeanP added inline comments. Comment at: clang/include/clang/Basic/DiagnosticDriverKinds.td:241 +def err_option_unsupported_zos: Error< + "the clang compiler does not support the '%0' option on z/OS.">; + Rather than saying "on z/OS" you should say "by the targe

[PATCH] D100197: Enable creation of large response file on z/OS

2021-04-09 Thread Sean via Phabricator via cfe-commits
SeanP created this revision. SeanP added reviewers: abhina.sree, hubert.reinterpretcast, muiez. SeanP requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Most text processing commands (eg. grep, awk) have a maximum line length limit on z/OS.

[PATCH] D98554: Save strings for CC_PRINT env vars

2021-03-23 Thread Sean via Phabricator via cfe-commits
SeanP marked 2 inline comments as done. SeanP added inline comments. Comment at: clang/include/clang/Driver/Driver.h:160 /// The file to log CC_PRINT_PROC_STAT_FILE output to, if enabled. - const char *CCPrintStatReportFilename; + std::string CCPrintStatReportFilename; ---

[PATCH] D98554: Save strings for CC_PRINT env vars

2021-03-23 Thread Sean via Phabricator via cfe-commits
SeanP updated this revision to Diff 332836. SeanP added a comment. Changed the code checking the env vars so it doesn't assign a null_ptr to the string. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98554/new/ https://reviews.llvm.org/D98554 Files: clang/include/clang/Driver/Driver

[PATCH] D98554: Save strings for CC_PRINT env vars

2021-03-12 Thread Sean via Phabricator via cfe-commits
SeanP created this revision. SeanP added reviewers: hubert.reinterpretcast, uweigand, Kai. SeanP requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The contents of the string returned by getenv() is not guaranteed across calls to getenv(). T

[PATCH] D89801: [SystemZ][z/OS] Set short-enums as the default for z/OS

2020-10-20 Thread Sean via Phabricator via cfe-commits
SeanP added inline comments. Comment at: clang/test/Driver/zos-driver-defaults.c:1 +// RUN: %clang -### --target=s390x-none-zos -fsyntax-only %s 2>&1 | FileCheck %s +// REQUIRES: clang-driver Can you add an additional test for -fno-short-enum to make sure that w