Can we revert this?
In our downstream project we were bitten by this:
https://github.com/google/mlir-npcomp/commit/cd7258dbd48bd9254c6741cab2d3f4e36cbd3c84
It seems that now by default anybody that depends on LLVM with CMake will
globally get a `-w` passed to their compiler. That doesn't seem lik
, even though users already know to pass the right flags and
expect to have to).
-- Sean Silva
>
> —
> Mehdi
>
>
>
> On Feb 28, 2017, at 11:22 PM, Sean Silva via cfe-commits <
> cfe-commits@lists.llvm.org> wrote:
>
> Nice!
>
> -- Sean Silva
>
> O
Nice!
-- Sean Silva
On Tue, Feb 28, 2017 at 5:01 PM, Paul Robinson via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: probinson
> Date: Tue Feb 28 19:01:10 2017
> New Revision: 296554
>
> URL: http://llvm.org/viewvc/llvm-project?rev=296554&view=rev
> Log:
> [PS4] Set our default dial
Nice!
On Tue, Feb 7, 2017 at 7:30 PM, Saleem Abdulrasool via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: compnerd
> Date: Tue Feb 7 21:30:13 2017
> New Revision: 294401
>
> URL: http://llvm.org/viewvc/llvm-project?rev=294401&view=rev
> Log:
> Sema: add warning for c++ member varia
Thanks!
On Wed, Jan 25, 2017 at 8:01 AM, Nico Weber via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: nico
> Date: Wed Jan 25 10:01:32 2017
> New Revision: 293065
>
> URL: http://llvm.org/viewvc/llvm-project?rev=293065&view=rev
> Log:
> Clarify how to forward-declare __llvm_profile s
On Sat, Jan 7, 2017 at 1:27 PM, Saleem Abdulrasool via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> I agree with Eric, I don't think that serializing the structure to
> std::cout is the right way to handle this.
>
> What were you thinking of mocking? Wouldn't you really end up mocking the
>
On Sat, Dec 31, 2016 at 1:41 PM, Richard Smith via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: rsmith
> Date: Sat Dec 31 15:41:23 2016
> New Revision: 290792
>
> URL: http://llvm.org/viewvc/llvm-project?rev=290792&view=rev
> Log:
> [c++17] Implement P0522R0 as written. This allows a
Thanks.
2016-12-06 16:28 GMT-08:00 Reid Kleckner :
> Comments in r288868. It implements GCC's %= inline asm feature, and we're
> just using it from MS-style inline asm to avoid duplicate labels clashing.
>
> 2016-12-01 0:37 GMT-08:00 Sean Silva :
>
>> what is this ${:uid} thing? Could the comment
what is this ${:uid} thing? Could the comment
in Sema::GetOrCreateMSAsmLabel explain it?
-- Sean Silva
On Mon, Nov 28, 2016 at 4:39 PM, Reid Kleckner via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: rnk
> Date: Mon Nov 28 18:39:37 2016
> New Revision: 288093
>
> URL: http://llvm.or
This is awesome Richard. Thanks!
-- Sean Silva
On Thu, Oct 27, 2016 at 1:55 PM, Richard Smith via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: rsmith
> Date: Thu Oct 27 15:55:56 2016
> New Revision: 285341
>
> URL: http://llvm.org/viewvc/llvm-project?rev=285341&view=rev
> Log:
> Ad
Nice to see this land!
One nit:
Currently, doesn't LLD/ELF ignore -plugin-opt? That will mean that if a
user uses the "gold syntax" then LLD will silently ignore it, which isn't
good. At the very least, can we issue an error if we see `-plugin-opt
jobs=N` and suggest the LLD spelling?
Or maybe ju
On Fri, Aug 19, 2016 at 4:33 PM, Joerg Sonnenberger via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> On Fri, Aug 19, 2016 at 03:30:42PM -0700, Richard Smith wrote:
> > It typically does; the default stack ulimit is likely tuned for "normal"
> > applications that are not expected (by an ISO s
You may also want to just try using the unicode character (not that it
really matters that much though).
On Mon, Aug 15, 2016 at 11:45 AM, Paul Robinson via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: probinson
> Date: Mon Aug 15 13:45:52 2016
> New Revision: 278710
>
> URL: http:/
On Tue, Aug 9, 2016 at 9:18 AM, Serge Pavlov wrote:
> Whether enable this warning or not should be determined by user feedback.
> The warning was implemented to help users in complicated cases that arise
> in module-enabled builds. It seems however that it makes troubles for other
> users. Based
silvas accepted this revision.
silvas added a comment.
This revision is now accepted and ready to land.
LGTM (also, another small suggestion).
Comment at: docs/UsersManual.rst:1502
@@ +1501,3 @@
+ multiple raw profiles dumped from different processes (running on the same
or
+
silvas added a comment.
LGTM with some small wording nits.
We may want to extend this to mention number modifier to `%m` (e.g. `%4m`).
Perhaps it is better to leave that to more advanced documentation -- your
experiments showed that even just 1 merge pool is quite scalable IIRC.
=
On Tue, Jul 19, 2016 at 5:01 PM, Xinliang David Li
wrote:
> The new behavior works really well. There is one follow up change I would
> like to discuss.
>
> The EQ form of the option -fprofile-generate= takes a directory name as
> the argument instead of the filename. Currently the compiler will
silvas updated this revision to Diff 64420.
silvas added a comment.
Rebase after r275507.
https://reviews.llvm.org/D21954
Files:
include/clang/Driver/CC1Options.td
include/clang/Frontend/CodeGenOptions.h
lib/CodeGen/BackendUtil.cpp
lib/CodeGen/CMakeLists.txt
lib/Frontend/CompilerInvoc
This revision was automatically updated to reflect the committed changes.
Closed by commit rL275668: [Driver] Add flags for enabling both types of PGO
Instrumentation (authored by silvas).
Changed prior to commit:
https://reviews.llvm.org/D21823?vs=64056&id=64222#toc
Repository:
rL LLVM
htt
Author: silvas
Date: Fri Jul 15 21:54:58 2016
New Revision: 275668
URL: http://llvm.org/viewvc/llvm-project?rev=275668&view=rev
Log:
[Driver] Add flags for enabling both types of PGO Instrumentation
The flags:
Enable IR-level instrumentation -fprofile-generate or -fprofile-generate=
When applying
silvas accepted this revision.
silvas added a comment.
This revision is now accepted and ready to land.
Once all of David's comments are addressed this LGTM.
Repository:
rL LLVM
https://reviews.llvm.org/D21823
___
cfe-commits mailing list
cfe-com
silvas added a comment.
Ping.
https://reviews.llvm.org/D21954
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: silvas
Date: Sat Jul 9 19:57:52 2016
New Revision: 275005
URL: http://llvm.org/viewvc/llvm-project?rev=275005&view=rev
Log:
Delete dead code.
We were just setting DisableUnitAtATime to its default value.
Modified:
cfe/trunk/include/clang/Frontend/CodeGenOptions.def
cfe/trunk/lib
silvas added a comment.
In http://reviews.llvm.org/D21823#479418, @davidxl wrote:
> I should have brought it up earlier, but I forgot.I think a better (and
> simpler) proposal is to make -fprofile-generate and -fprofile-use turn on IR
> based PGO.
>
> -fprofile-generate and -fprofile-use op
silvas added a subscriber: cfe-commits.
silvas added a comment.
Actually add cfe-commits. Oops.
Thanks to Chandler for pointing out I had added llvm-commits instead.
http://reviews.llvm.org/D21954
___
cfe-commits mailing list
cfe-commits@lists.llvm
On Fri, Jul 8, 2016 at 10:22 AM, Xinliang David Li
wrote:
>
>
> On Sun, Jul 3, 2016 at 1:50 PM, Sean Silva wrote:
>
>>
>>
>> On Sat, Jul 2, 2016 at 7:38 PM, Xinliang David Li
>> wrote:
>>
>>> Sanitizers are different IMO. Different santizers are rather
>>> independent, and there is no such thin
Btw we do have some advice for these situations in the programmer's manual:
http://llvm.org/docs/CodingStandards.html#don-t-use-default-labels-in-fully-covered-switches-over-enumerations
-- Sean Silva
On Thu, Jul 7, 2016 at 4:24 AM, Simon Pilgrim via cfe-commits <
cfe-commits@lists.llvm.org> wrot
On Sat, Jul 2, 2016 at 7:38 PM, Xinliang David Li
wrote:
> Sanitizers are different IMO. Different santizers are rather independent,
> and there is no such thing as -fsantize to mean -fsantize=all
>
> For PGO, in most of the cases, users do not need to care about the
> sub-options implied -- by d
On Sat, Jul 2, 2016 at 1:57 PM, Xinliang David Li
wrote:
>
>
> On Fri, Jul 1, 2016 at 4:32 PM, Sean Silva wrote:
>
>> silvas added inline comments.
>>
>>
>> Comment at: lib/Driver/Tools.cpp:3560
>> @@ +3559,3 @@
>> +if (PGOTrainArg->getOption().matches(options::OPT_fpgo_trai
silvas added inline comments.
Comment at: lib/Driver/Tools.cpp:3560
@@ +3559,3 @@
+if (PGOTrainArg->getOption().matches(options::OPT_fpgo_train_EQ)) {
+ if (StringRef(PGOTrainArg->getValue()) == "source-cfg")
+CmdArgs.push_back("-fprofile-instrument=clang");
-
gt; *Subject:* Re: r274084 - Revert "[PS4] Tighten up a test (noticed in
> passing)"
>
>
>
>
>
>
>
> On Thu, Jun 30, 2016 at 3:52 PM, Robinson, Paul
> wrote:
>
>
>
> > -Original Message-
> > From: cfe-commits [mailto:cfe-commits-bo
On Thu, Jun 30, 2016 at 3:52 PM, Robinson, Paul
wrote:
>
>
> > -Original Message-
> > From: cfe-commits [mailto:cfe-commits-boun...@lists.llvm.org] On Behalf
> Of
> > Sean Silva via cfe-commits
> > Sent: Tuesday, June 28, 2016 5:29 PM
> > To:
On Wed, Jun 29, 2016 at 1:34 PM, Sean Silva wrote:
>
>
> On Wed, Jun 29, 2016 at 12:51 PM, Richard Smith
> wrote:
>
>> On Wed, Jun 29, 2016 at 12:30 PM, Sean Silva
>> wrote:
>>
>>>
>>>
>>> On Wed, Jun 29, 2016 at 12:09 PM, Richard Smith via cfe-commits <
>>> cfe-commits@lists.llvm.org> wrote:
>
On Wed, Jun 29, 2016 at 12:51 PM, Richard Smith
wrote:
> On Wed, Jun 29, 2016 at 12:30 PM, Sean Silva
> wrote:
>
>>
>>
>> On Wed, Jun 29, 2016 at 12:09 PM, Richard Smith via cfe-commits <
>> cfe-commits@lists.llvm.org> wrote:
>>
>>> Hi all!
>>>
>>> I'd like to establish a policy for Clang's defa
On Wed, Jun 29, 2016 at 12:09 PM, Richard Smith via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Hi all!
>
> I'd like to establish a policy for Clang's default language standard (if
> none is specified with -std), as follows:
>
> Clang defaults to the most recent published standard for the
silvas added a comment.
Some basic comments.
Comment at: include/clang/Driver/Options.td:483
@@ +482,3 @@
+Group, Flags<[DriverOption]>, MetaVarName<"">,
+HelpText<"Generate instrumented code to collect execution counts into
(overridden by LLVM_PROFILE_FILE env var)">;
Author: silvas
Date: Tue Jun 28 19:29:23 2016
New Revision: 274084
URL: http://llvm.org/viewvc/llvm-project?rev=274084&view=rev
Log:
Revert "[PS4] Tighten up a test (noticed in passing)"
This reverts commit r269709.
r262285 changed this deliberately so that the test would not be
sensitive to whi
-def fpie : Flag<["-"], "fpie">, Group;
+def fpie : Flag<["-"], "fpie">, Group, Flags<[CC1Option]>;
I don't think this is the right solution as "-fpie" doesn't mean the same
thing to the driver and CC1 is sort of confusing (in CC1 it doesn't mean
anything by itself). Can you change the existing `
Thanks!
On Tue, Jun 14, 2016 at 10:30 AM, Vedant Kumar wrote:
> I think David got rid of that limitation.
>
> The related warning in compiler-rt does not reflect this:
>
> PROF_WARN("%%m specifier can only be specified once at the end of
> %s.\n", ...);
>
> Fixed the warning in r272685.
>
> th
Some of these tables are getting quite mangled somewhere along the line
(email client? mailing list handling? idk). Could you re-send with the
tables also attached or something else that avoids that problem?
-- Sean Silva
On Tue, Jun 14, 2016 at 4:23 PM, Galina Kistanova via cfe-commits <
cfe-co
On Mon, Jun 13, 2016 at 5:42 PM, Vedant Kumar via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: vedantk
> Date: Mon Jun 13 19:42:12 2016
> New Revision: 272604
>
> URL: http://llvm.org/viewvc/llvm-project?rev=272604&view=rev
> Log:
> [docs] Coverage: Document the profile merge pool sp
silvas accepted this revision.
silvas added a reviewer: silvas.
silvas added a comment.
This revision is now accepted and ready to land.
LGTM
http://reviews.llvm.org/D21186
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.or
silvas added a comment.
In http://reviews.llvm.org/D21186#454497, @silvas wrote:
> > It has no RTTI, so the test would always fail in a non-interesting way.
>
>
> It does. There is a call to dynamic_cast on lines 20 and 21 of this test. You
> can fix this by explicitly adding -frtti I believe.
silvas added a subscriber: silvas.
silvas added a comment.
> It has no RTTI, so the test would always fail in a non-interesting way.
It does. There is a call to dynamic_cast on lines 20 and 21 of this test. You
can fix this by explicitly adding -frtti I believe.
http://reviews.llvm.org/D21186
On Mon, Jun 6, 2016 at 11:23 AM, Rafael Espindola via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: rafael
> Date: Mon Jun 6 13:23:11 2016
> New Revision: 271918
>
> URL: http://llvm.org/viewvc/llvm-project?rev=271918&view=rev
> Log:
> Add a release note about the --build-id change.
silvas accepted this revision.
silvas added a comment.
This revision is now accepted and ready to land.
Overall this LGTM, but let Manuel or one of the other libTooling folks sign off.
Comment at: docs/LibASTMatchersTutorial.rst:46
@@ -45,3 +45,3 @@
cd ~/clang-llvm
On Thu, Jun 2, 2016 at 10:19 AM, Vedant Kumar via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: vedantk
> Date: Thu Jun 2 12:19:45 2016
> New Revision: 271544
>
> URL: http://llvm.org/viewvc/llvm-project?rev=271544&view=rev
> Log:
> [docs] Add a limitations section to SourceBasedCode
silvas added subscribers: MaggieYi, phillip.power.
silvas added a comment.
This is looking really good. So based on reading this, a rough sketch of how we
can expand this to PGO would be something like:
- there is a separate PGO page that has similar structure, but is more tuned
for the PGO use
What was the issue?
On Wed, May 25, 2016 at 12:17 PM, Galina Kistanova via llvm-commits <
llvm-comm...@lists.llvm.org> wrote:
> Hello,
>
> Builder
> http://lab.llvm.org:8011/builders/llvm-clang-lld-x86_64-scei-ps4-windows10pro-fast
> is back to normal.
> Sorry for the noise.
>
> Thanks
>
> Galina
On Thu, May 19, 2016 at 12:13 PM, Serge Pavlov wrote:
> In this case moving implementation of `Singleton::getInstance()` into a
> .cpp file would prevent compiler from instantiation of the method body when
> it sees `Singleton::getInstance()`. In this case
> `Singleton::getInstance()` must be ins
On Thu, Apr 21, 2016 at 12:44 AM, Serge Pavlov wrote:
> Let me demonstrate the problem using excerpt from v8 sources:
>
> -- lithium.h
> template
> struct LSubKindOperand {
> static int* Create(int index) { return &cache[index]; }
> st
silvas added a subscriber: silvas.
silvas added a comment.
I don't see an issue with putthing this as a helper in libBasic. We may need to
add a libOption dependency to it but that sounds fine.
http://reviews.llvm.org/D20404
___
cfe-commits mailing
Ah, just saw 270010
On Wed, May 18, 2016 at 6:49 PM, Sean Silva wrote:
>
>
> On Wed, May 18, 2016 at 6:39 PM, Richard Smith via cfe-commits <
> cfe-commits@lists.llvm.org> wrote:
>
>> Author: rsmith
>> Date: Wed May 18 20:39:10 2016
>> New Revision: 270009
>>
>> URL: http://llvm.org/viewvc/llvm-
On Wed, May 18, 2016 at 6:39 PM, Richard Smith via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: rsmith
> Date: Wed May 18 20:39:10 2016
> New Revision: 270009
>
> URL: http://llvm.org/viewvc/llvm-project?rev=270009&view=rev
> Log:
> Make Sema::getPrintingPolicy less ridiculously expe
On Wed, May 18, 2016 at 4:58 AM, Rafael Espindola via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: rafael
> Date: Wed May 18 06:58:56 2016
> New Revision: 269910
>
> URL: http://llvm.org/viewvc/llvm-project?rev=269910&view=rev
> Log:
> Update for llvm change.
>
> Modified:
> cfe/
On Tue, May 17, 2016 at 7:07 AM, Filipe Cabecinhas via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: filcab
> Date: Tue May 17 09:07:43 2016
> New Revision: 269765
>
> URL: http://llvm.org/viewvc/llvm-project?rev=269765&view=rev
> Log:
> Revert "[X86] Add immediate range checks for ma
On Fri, May 13, 2016 at 12:01 AM, Filipe Cabecinhas wrote:
>
> > On 13 May 2016, at 07:03, Sean Silva wrote:
> >
> >
> >
> > On Thu, May 12, 2016 at 9:51 AM, Filipe Cabecinhas via cfe-commits <
> cfe-commits@lists.llvm.org> wrote:
> > Author: filcab
> > Date: Thu May 12 11:51:36 2016
> > New Rev
On Thu, May 12, 2016 at 9:51 AM, Filipe Cabecinhas via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: filcab
> Date: Thu May 12 11:51:36 2016
> New Revision: 269309
>
> URL: http://llvm.org/viewvc/llvm-project?rev=269309&view=rev
> Log:
> [ubsan] Add -fsanitize-undefined-strip-path-com
On Wed, May 11, 2016 at 10:46 AM, Bruno Cardoso Lopes <
bruno.card...@gmail.com> wrote:
> > I'm glad to help, but it makes me uneasy to have somebody working on a
> > filesystem abstraction that does not have ready access to test and debug
> > their changes across the major host platforms that LLV
On Tue, May 10, 2016 at 11:14 PM, Bruno Cardoso Lopes <
bruno.card...@gmail.com> wrote:
> Hi Sean,
>
> > So sorry! It had gone quiet for a few hours and I wanted to avoid
> leaving it
> > red any longer.
>
> No problem, the priority is to get bot greens!
>
> > Does any platform define a guaranteed
On Tue, May 10, 2016 at 9:49 PM, Bruno Cardoso Lopes <
bruno.card...@gmail.com> wrote:
> Thanks Sean,
>
> I was about to ask for help and try a 4th attempt, as you noted after
> 3 attempts I was not yet able to make this work on windows though...
>
So sorry! It had gone quiet for a few hours and
Hi Bruno,
I had to revert this in r269100 because it was looking like the bot was
going to be left red overnight.
Changes to this VFS code seem to have a trend of breaking on windows. Any
idea why that is? I can understand things breaking on windows when writing
low-level parts of an FS abstracti
Author: silvas
Date: Tue May 10 23:04:59 2016
New Revision: 269160
URL: http://llvm.org/viewvc/llvm-project?rev=269160&view=rev
Log:
Hopefully bring llvm-clang-lld-x86_64-scei-ps4-windows10pro-fast back to life
Bruno made a couple valiant attempts but the bot is still red.
This reverts r269100 (
If this is something that GCC doesn't have, it would be nice if we put
something in our own docs about it (something like docs/UsersManual.rst).
On Thu, May 5, 2016 at 2:34 PM, Sriraman Tallam via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> On Thu, May 5, 2016 at 2:31 PM, Rafael Espíndola
Do we also handle ':'? The corresponding behavior in the linker is in:
http://llvm.org/klaus/lld/blob/master/ELF/DriverUtils.cpp#L-232
-- Sean Silva
On Fri, May 6, 2016 at 12:13 PM, Saleem Abdulrasool via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: compnerd
> Date: Fri May 6 14:1
On Mon, May 2, 2016 at 4:14 PM, Hal Finkel via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> hfinkel added a comment.
>
> In http://reviews.llvm.org/D19678#416127, @rcox2 wrote:
>
> > Actually, the Intel compiler distinguishes between an optimization
> report (-qopt-report) and an annotated l
This breaks the PS4 bots at least. They've been red for hours now.
http://lab.llvm.org:8011/builders/llvm-clang-lld-x86_64-scei-ps4-ubuntu-fast?numbuilds=100
On Fri, Apr 29, 2016 at 3:28 PM, Chris Bieneman via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: cbieneman
> Date: Fri Apr 29
Author: silvas
Date: Fri Apr 22 21:13:48 2016
New Revision: 267263
URL: http://llvm.org/viewvc/llvm-project?rev=267263&view=rev
Log:
[profile] Fix another use of the driver.
Follow-on to r267262.
Modified:
cfe/trunk/test/Profile/cxx-indirect-call.cpp
Modified: cfe/trunk/test/Profile/cxx-ind
Author: silvas
Date: Fri Apr 22 21:11:16 2016
New Revision: 267262
URL: http://llvm.org/viewvc/llvm-project?rev=267262&view=rev
Log:
[profile] Use cc1 in these tests instead of the driver.
I ran into this when seeing what tests would break if we make a
driver-level decision about whether FEPGO or
On Tue, Apr 19, 2016 at 7:28 AM, Nico Weber via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> (sorry, accidentally sent this mid-mail)
>
> ../../v8/src/crankshaft/lithium.h:322:45: error: instantiation of variable
> 'v8::internal::LSubKindOperand 128>::cache' required here, but no definition
On Tue, Apr 19, 2016 at 7:28 AM, Nico Weber via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> (sorry, accidentally sent this mid-mail)
>
> ../../v8/src/crankshaft/lithium.h:322:45: error: instantiation of variable
> 'v8::internal::LSubKindOperand 128>::cache' required here, but no definition
Thanks!
-- Sean Silva
On Wed, Apr 13, 2016 at 12:47 AM, Richard Smith via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: rsmith
> Date: Wed Apr 13 02:47:38 2016
> New Revision: 266178
>
> URL: http://llvm.org/viewvc/llvm-project?rev=266178&view=rev
> Log:
> constexpr -> const to appe
On Thu, Apr 7, 2016 at 5:09 PM, Richard Smith via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: rsmith
> Date: Thu Apr 7 19:09:53 2016
> New Revision: 265756
>
> URL: http://llvm.org/viewvc/llvm-project?rev=265756&view=rev
> Log:
> [modules] Don't write @import in -E output if the cu
Author: silvas
Date: Wed Apr 6 20:58:14 2016
New Revision: 265634
URL: http://llvm.org/viewvc/llvm-project?rev=265634&view=rev
Log:
Don't use PATH_MAX.
This is a SmallVector anyway, and so the exact size doesn't matter.
clang\lib\Frontend\ModuleDependencyCollector.cpp(83) : error C2065: 'PATH_M
On Wed, Apr 6, 2016 at 6:56 PM, Sean Silva wrote:
>
>
> On Wed, Apr 6, 2016 at 6:10 PM, Bruno Cardoso Lopes via cfe-commits <
> cfe-commits@lists.llvm.org> wrote:
>
>> Attempt to fix in r265630.
>>
>
> Did you ever fix PATH_MAX?
>
I've fixed it in r265634.
-- Sean Silva
>
>>
>> On Wed, Apr 6,
On Wed, Mar 16, 2016 at 7:20 PM, Bruno Cardoso Lopes via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: bruno
> Date: Wed Mar 16 21:20:43 2016
> New Revision: 263686
>
> URL: http://llvm.org/viewvc/llvm-project?rev=263686&view=rev
> Log:
> Reapply [2]: [VFS] Add support for handling pa
On Wed, Apr 6, 2016 at 6:10 PM, Bruno Cardoso Lopes via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Attempt to fix in r265630.
>
Did you ever fix PATH_MAX?
>
> On Wed, Apr 6, 2016 at 5:51 PM, Bruno Cardoso Lopes <
> bruno.card...@gmail.com> wrote:
>
>> Thanks Hans, taking a look!
>>
>> O
We also have toUppercase in include/clang/Basic/CharInfo.h
-- Sean Silva
On Wed, Apr 6, 2016 at 6:04 PM, Bruno Cardoso Lopes via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: bruno
> Date: Wed Apr 6 20:04:09 2016
> New Revision: 265630
>
> URL: http://llvm.org/viewvc/llvm-project?r
I've had to revert this in r265601 because it was breaking the PS4 bots.
In the future, please keep an eye on them! It's a total bummer leaving them
red for 2 days.
http://lab.llvm.org:8011/waterfall?builder=llvm-clang-lld-x86_64-scei-ps4-ubuntu-fast&builder=llvm-clang-lld-x86_64-scei-ps4-windows
Author: silvas
Date: Wed Apr 6 16:06:52 2016
New Revision: 265601
URL: http://llvm.org/viewvc/llvm-project?rev=265601&view=rev
Log:
Revert "Set the default C standard to C99 when targeting the PS4."
This reverts r265359.
It breaks
- llvm-clang-lld-x86_64-scei-ps4-ubuntu-fast
- llvm-clang-lld-x8
On Mon, Apr 4, 2016 at 11:33 AM, John McCall via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: rjmccall
> Date: Mon Apr 4 13:33:00 2016
> New Revision: 265323
>
> URL: http://llvm.org/viewvc/llvm-project?rev=265323&view=rev
> Log:
> Add a couple of convenience operations to CharUnits
Thanks!
On Tue, Mar 22, 2016 at 9:34 AM, Chris Bieneman wrote:
> Sean,
>
> All good feedback.
>
> Using print_function was done in r257936 with some other feedback from
> Bogner.
>
> The rest of your feedback I believe I have addressed in r264063.
>
> -Chris
>
> On Mar 21, 2016, at 9:21 PM, Sean
On Fri, Jan 15, 2016 at 1:21 PM, Chris Bieneman via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: cbieneman
> Date: Fri Jan 15 15:21:12 2016
> New Revision: 257934
>
> URL: http://llvm.org/viewvc/llvm-project?rev=257934&view=rev
> Log:
> [CMake] Support generation of linker order file
silvas added a comment.
Isn't there a `read` call or something that fails down the road? How can it be
silent?
http://reviews.llvm.org/D18011
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe
silvas added inline comments.
Comment at: cfe/trunk/lib/Driver/ToolChain.cpp:352
@@ +351,3 @@
+return UseLinker;
+} else {
+ // If we're passed -fuse-ld= with no argument, or with the argument ld,
Makes sense.
Repository:
rL LLVM
http://revie
silvas added a subscriber: silvas.
silvas added a comment.
Some nits but this looks fine to me. I've been wanting this for a while now.
Comment at: cfe/trunk/lib/Driver/ToolChain.cpp:347
@@ +346,3 @@
+
+if (UseLinker[0] == '/') {
+ // If we're passed -fuse-ld= with what
silvas added a comment.
I agree, David's suggestion has simplified things. This LGTM (with a couple
nits) but I'll let David give the final approval.
Comment at: lib/CodeGen/CodeGenModule.cpp:153
@@ +152,3 @@
+ if (CodeGenOpts.hasProfileClangUse()) {
+assert(!CodeGenOpts.P
silvas accepted this revision.
silvas added a comment.
This revision is now accepted and ready to land.
Nice cleanup. LGTM.
http://reviews.llvm.org/D17794
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/
silvas added a comment.
This makes sense. LGTM.
http://reviews.llvm.org/D17787
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
silvas added a comment.
makes sense. can you include a testcase? I assume we are forgetting some sort
of diagnostic without this patch.
Also, if learning about Clang's modules, I would start with `addHeaderInclude`
in lib/Frontend/FrontendActions.cpp. The module map stuff ultimately boils down
On Tue, Mar 1, 2016 at 1:00 PM, Warren Ristow <
warren_ris...@playstation.sony.com> wrote:
> wristow added a comment.
>
> In http://reviews.llvm.org/D17775#365611, @silvas wrote:
>
> > Random question:
> >
> > > We plan to enable dllimport/dllexport support for the PS4
> >
> >
> > How are you plan
silvas added a subscriber: silvas.
silvas added a comment.
Random question:
> We plan to enable dllimport/dllexport support for the PS4
How are you planning on codegenning them? The same way as we do in our private
branch?
http://reviews.llvm.org/D17775
___
On Tue, Mar 1, 2016 at 10:54 AM, Nico Weber via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> thakis added a comment.
>
> > I think we can do this separately. A "basename" macro is easier for
> programmers to use and no build system change needed.
>
>
> Hm, I would think that adding a flag to
silvas added a comment.
Some comments but otherwise feel free to commit.
Comment at: lib/CodeGen/CodeGenModule.cpp:154
@@ +153,3 @@
+assert(!CodeGenOpts.ProfileInstrumentUsePath.empty() &&
+ "Need to explicitly specify the profile name.");
+auto ReaderOrErr = l
All green on the two latest commits. Thanks!
http://lab.llvm.org:8011/builders/llvm-clang-lld-x86_64-scei-ps4-windows10pro-fast/builds/961
-- Sean Silva
On Mon, Feb 29, 2016 at 6:14 PM, John McCall wrote:
> On Feb 29, 2016, at 5:44 PM, Sean Silva wrote:
> This seems to be causing a substantial
silvas accepted this revision.
silvas added a comment.
This revision is now accepted and ready to land.
Thanks!
http://reviews.llvm.org/D17737
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe
This seems to be causing a substantial amount of warning spew from MSVC:
http://lab.llvm.org:8011/builders/llvm-clang-lld-x86_64-scei-ps4-windows10pro-fast/builds/955
I think our recommended "portable" method of using llvm_unreachable is
outside the switch, instead of in the default case:
http://l
Author: silvas
Date: Mon Feb 29 19:20:15 2016
New Revision: 262285
URL: http://llvm.org/viewvc/llvm-project?rev=262285&view=rev
Log:
Make test more robust.
Really all these tests are checking is that we find a file path. The
behavior when we don't find one will have `"ps4-ld"` in it. We just need
silvas added a comment.
Thanks, this is looking good. I have some naming suggestions and nits, but the
overall content of the patch LGTM.
Comment at: include/clang/Driver/CC1Options.td:286
@@ +285,3 @@
+def fprofile_instrument_usepath_EQ :
+Joined<["-"], "fprofile-instrumen
silvas accepted this revision.
silvas added a comment.
This revision is now accepted and ready to land.
Thanks. LGTM.
http://reviews.llvm.org/D17622
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listin
1 - 100 of 195 matches
Mail list logo
