[PATCH] D129009: [LTO] Fix LTO for aliased IFuncs

SchrodingerZhu added a comment. Hi, is there anything else I should do for this patch？ Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129009/new/ https://reviews.llvm.org/D129009 ___ cfe-commits mailing l

[PATCH] D129009: [LTO] Fix LTO for aliased IFuncs

SchrodingerZhu updated this revision to Diff 443536. SchrodingerZhu added a comment. This commit addresses issues mentioned in code reviews: - change applyAlongResolverPath to use reference since the pointer is supposed to be non-null. - update test format to align check rules under the same pre

[PATCH] D129009: [LTO] Fix LTO for aliased IFuncs

SchrodingerZhu updated this revision to Diff 443503. SchrodingerZhu marked 5 inline comments as done. SchrodingerZhu added a comment. This commit addresses problems mentioned in code reviews: - Fix format and wording for comments - Add more checks with llvm-dis - Adjust code styles for function r

[PATCH] D129009: [LTO] Fix LTO for aliased IFuncs

SchrodingerZhu added a comment. First of all, I am really sorry about the noise and the misbehavior here. I have to admit that some of the changes here are because I am still in the way of getting familiar with the patch system. I apologize for being careless in the progress. > I don't know ho

[PATCH] D129009: [LTO] Fix LTO for aliased IFuncs

SchrodingerZhu added a comment. @MaskRay PTAL Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129009/new/ https://reviews.llvm.org/D129009 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://li

[PATCH] D129009: [LTO] Fix LTO for aliased IFuncs

SchrodingerZhu updated this revision to Diff 441906. SchrodingerZhu added a comment. typo Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129009/new/ https://reviews.llvm.org/D129009 Files: llvm/include/llvm/IR/GlobalIFunc.h llvm/lib/Analysis/Mo

[PATCH] D129009: [LTO] Fix LTO for aliased IFuncs

SchrodingerZhu updated this revision to Diff 441905. SchrodingerZhu added a comment. more clean ups for ifunc logic Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129009/new/ https://reviews.llvm.org/D129009 Files: llvm/include/llvm/IR/GlobalIFun

[PATCH] D129009: [LTO] Fix LTO for aliased IFuncs

SchrodingerZhu marked an inline comment as done. SchrodingerZhu added a comment. ThinLTO with IFUNC is still Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129009/new/ https://reviews.llvm.org/D129009 ___

[PATCH] D129009: [LTO] Fix LTO for aliased IFuncs

SchrodingerZhu updated this revision to Diff 441899. SchrodingerZhu added a comment. fix test arg Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129009/new/ https://reviews.llvm.org/D129009 Files: llvm/lib/Analysis/ModuleSummaryAnalysis.cpp llv

[PATCH] D129009: [LTO] Fix LTO for aliased IFuncs

SchrodingerZhu updated this revision to Diff 441898. SchrodingerZhu added a comment. fix test arg Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129009/new/ https://reviews.llvm.org/D129009 Files: llvm/lib/Analysis/ModuleSummaryAnalysis.cpp llv

[PATCH] D129009: [LTO] Fix LTO for aliased IFuncs

SchrodingerZhu updated this revision to Diff 441897. SchrodingerZhu added a comment. enlarge test and fix accordingly Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129009/new/ https://reviews.llvm.org/D129009 Files: llvm/lib/Analysis/ModuleSumma

[PATCH] D129009: [LTO] Fix LTO for aliased IFuncs

SchrodingerZhu updated this revision to Diff 441895. SchrodingerZhu added a comment. fix typo Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129009/new/ https://reviews.llvm.org/D129009 Files: llvm/lib/Analysis/ModuleSummaryAnalysis.cpp llvm/li

[PATCH] D129009: [LTO] Fix LTO for aliased IFuncs

SchrodingerZhu updated this revision to Diff 441894. SchrodingerZhu added a comment. fix more Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129009/new/ https://reviews.llvm.org/D129009 Files: llvm/lib/Analysis/ModuleSummaryAnalysis.cpp llvm/li

[PATCH] D129009: [LTO] Fix LTO for aliased IFuncs

SchrodingerZhu updated this revision to Diff 441891. SchrodingerZhu added a comment. fix liveness of resolvers Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129009/new/ https://reviews.llvm.org/D129009 Files: llvm/lib/Analysis/ModuleSummaryAnaly

[PATCH] D129009: [LTO] Fix LTO for aliased IFuncs

SchrodingerZhu added a comment. The LTO problem is fixed but thinlto is not fully resolved: /home/schrodinger/Documents/llvm-project/llvm/cmake-build-debug/bin/clang test.c -o test -flto=thin -sha red -fuse-ld=lld IFunc resolver must be a definition ptr @f LLVM ERROR: Broken module fo

[PATCH] D129009: [LTO] Fix LTO for aliased IFuncs

SchrodingerZhu updated this revision to Diff 441887. SchrodingerZhu added a comment. - format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129009/new/ https://reviews.llvm.org/D129009 Files: llvm/lib/Analysis/ModuleSummaryAnalysis.cpp llvm/li

[PATCH] D129009: [LTO] Fix LTO for aliased IFuncs

SchrodingerZhu updated this revision to Diff 441886. SchrodingerZhu added a comment. - stage - stage - fix lto Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129009/new/ https://reviews.llvm.org/D129009 Files: llvm/lib/Analysis/ModuleSummaryAnaly

[PATCH] D129009: [LTO] Fix LTO for aliased IFuncs

SchrodingerZhu added a comment. @MaskRay unfortunately and fortunately, extending the test case to ; RUN: opt -module-summary -o %t.bc %s ; RUN: llvm-lto2 run %t.bc -r %t.bc,foo,pl -r %t.bc,bar,px -r %t.bc,baz,px -o %t2 ; RUN: llvm-nm %t2.1 | FileCheck %s ; CHECK: i foo ; CHECK: t foo_

[PATCH] D129009: [LTO] Fix LTO for aliased IFuncs

SchrodingerZhu updated this revision to Diff 441850. SchrodingerZhu added a comment. - adjust comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129009/new/ https://reviews.llvm.org/D129009 Files: llvm/lib/Analysis/ModuleSummaryAnalysis.cpp

[PATCH] D129009: [LTO] Fix LTO for aliased IFuncs

SchrodingerZhu updated this revision to Diff 441849. SchrodingerZhu added a comment. - move to proper place Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129009/new/ https://reviews.llvm.org/D129009 Files: llvm/lib/Analysis/ModuleSummaryAnalysis

[PATCH] D129009: [LTO] Fix LTO for aliased IFuncs

SchrodingerZhu updated this revision to Diff 441848. SchrodingerZhu added a comment. - address cr: use IR instead Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129009/new/ https://reviews.llvm.org/D129009 Files: llvm/lib/Analysis/ModuleSummaryAn

[PATCH] D129009: [LTO] Fix LTO for aliased IFuncs

SchrodingerZhu updated this revision to Diff 441846. SchrodingerZhu added a comment. - address cr: code brace Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129009/new/ https://reviews.llvm.org/D129009 Files: llvm/lib/Analysis/ModuleSummaryAnalys

[PATCH] D129009: [LTO] Fix LTO for aliased IFuncs

SchrodingerZhu updated this revision to Diff 441844. SchrodingerZhu added a comment. - specify target Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129009/new/ https://reviews.llvm.org/D129009 Files: llvm/lib/Analysis/ModuleSummaryAnalysis.cpp

[PATCH] D129009: [LTO] Fix LTO for aliased IFuncs

SchrodingerZhu added a comment. Sorry for the noise during the process. I am really new to LLVM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129009/new/ https://reviews.llvm.org/D129009 ___ cfe-commits

[PATCH] D129009: [LTO] Fix LTO for aliased IFuncs

SchrodingerZhu updated this revision to Diff 441830. SchrodingerZhu added a comment. - adjust run arg Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129009/new/ https://reviews.llvm.org/D129009 Files: llvm/lib/Analysis/ModuleSummaryAnalysis.cpp

[PATCH] D129009: [LTO] Fix LTO for aliased IFuncs

SchrodingerZhu updated this revision to Diff 441829. SchrodingerZhu added a comment. address CR Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129009/new/ https://reviews.llvm.org/D129009 Files: llvm/lib/Analysis/ModuleSummaryAnalysis.cpp llvm/

[PATCH] D129009: [LTO] Fix LTO for aliased IFuncs

SchrodingerZhu updated this revision to Diff 441828. SchrodingerZhu edited the summary of this revision. SchrodingerZhu added a comment. address CR Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129009/new/ https://reviews.llvm.org/D129009 Files:

[PATCH] D129009: [LTO] Fix LTO for aliased IFuncs

SchrodingerZhu updated this revision to Diff 441821. SchrodingerZhu added a comment. undo wrong patch Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129009/new/ https://reviews.llvm.org/D129009 Files: clang/test/Analysis/alias-indirect-function-l

[PATCH] D129009: [LTO] Fix LTO for aliased IFuncs

SchrodingerZhu updated this revision to Diff 441820. SchrodingerZhu added a comment. address CR Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129009/new/ https://reviews.llvm.org/D129009 Files: llvm/lib/Analysis/ModuleSummaryAnalysis.cpp llvm/

[PATCH] D129009: [LTO] Fix LTO for aliased IFuncs

SchrodingerZhu updated this revision to Diff 441819. SchrodingerZhu added a comment. address CR Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129009/new/ https://reviews.llvm.org/D129009 Files: llvm/lib/Analysis/ModuleSummaryAnalysis.cpp llvm/

[PATCH] D129009: [Analysis][LTO] Fix LTO for aliased IFuncs.

SchrodingerZhu updated this revision to Diff 441784. SchrodingerZhu added a comment. fix integration test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129009/new/ https://reviews.llvm.org/D129009 Files: clang/test/Analysis/alias-indirect-functi

[PATCH] D129009: [Analysis] Fix LTO for aliased IFuncs.

SchrodingerZhu updated this revision to Diff 441758. SchrodingerZhu retitled this revision from "[llvm.analysis] Fix LTO for aliased IFuncs. As https://github.com/llvm/llvm-project/issues/56290 indicates, when an ifunc is aliased in LTO, clang will attempt to create an alias summary; however, as

[PATCH] D129009: [llvm.analysis] Fix LTO for aliased IFuncs. As https://github.com/llvm/llvm-project/issues/56290 indicates, when an ifunc is aliased in LTO, clang will attempt to create an alias su

SchrodingerZhu updated this revision to Diff 441756. SchrodingerZhu retitled this revision from "[llvm.analysis] Fix LTO for aliased IFuncs." to "[llvm.analysis] Fix LTO for aliased IFuncs. As https://github.com/llvm/llvm-project/issues/56290 indicates, when an ifunc is aliased in LTO, clang wil

[PATCH] D129009: [llvm.analysis] Fix LTO for aliased IFuncs.

SchrodingerZhu created this revision. Herald added subscribers: steakhal, ormris, jeroen.dobbelaere, steven_wu, hiraditya, inglorion. Herald added a project: All. SchrodingerZhu requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commi