[clang] hurd: Fix build with -Werror,-Wswitch (PR #78520)

https://github.com/sthibaul closed https://github.com/llvm/llvm-project/pull/78520 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] hurd: Fix build with -Werror,-Wswitch (PR #78520)

sthibaul wrote: > Is there a reason you put this first? No particular reason. > Otherwise IMO it is slightly neater to put it last. Done so. https://github.com/llvm/llvm-project/pull/78520 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http

[clang] hurd: Fix build with -Werror,-Wswitch (PR #78520)

https://github.com/sthibaul updated https://github.com/llvm/llvm-project/pull/78520 >From 15e157e3f7a6beb0b8be36ad1a9dbe3d2079eecf Mon Sep 17 00:00:00 2001 From: Samuel Thibault Date: Thu, 18 Jan 2024 00:18:03 +0100 Subject: [PATCH] hurd: Fix build with -Werror,-Wswitch We do not handle all ar

[clang] hurd: Fix build with -Werror,-Wswitch (PR #78520)

sthibaul wrote: > Drive-by: is the `llvm_unreachable` actually unreachable? I.e. we never call > this function with this case? Hurd triplets are only defined for x86 and x86_64. https://github.com/llvm/llvm-project/pull/78520 ___ cfe-commits mailing

[clang] [llvm] Hurd: Add x86_64 support (PR #78065)

sthibaul wrote: See https://github.com/llvm/llvm-project/pull/78520 https://github.com/llvm/llvm-project/pull/78065 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] hurd: Fix build with -Werror,-Wswitch (PR #78520)

https://github.com/sthibaul created https://github.com/llvm/llvm-project/pull/78520 We do not handle all architectures, llvm_unreachable is called after the switch, so we can just break. Fixes https://lab.llvm.org/buildbot/#/builders/19/builds/23702 >From 682392edc899cdae19e73548feaf118e137e1

[llvm] [clang] Hurd: Add x86_64 support (PR #78065)

sthibaul wrote: > > > Could you add some descriptions? > > > > > > What kind of description, where? > > The commit message/first comment. Currently it's "No description provided." Ah, ok, done so. https://github.com/llvm/llvm-project/pull/78065 ___

[llvm] [clang] Hurd: Add x86_64 support (PR #78065)

https://github.com/sthibaul edited https://github.com/llvm/llvm-project/pull/78065 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[llvm] [clang] Hurd: Add x86_64 support (PR #78065)

https://github.com/sthibaul updated https://github.com/llvm/llvm-project/pull/78065 >From fefe6175fa21c668f58d69b0acc9abb89af981ab Mon Sep 17 00:00:00 2001 From: Samuel Thibault Date: Sun, 14 Jan 2024 19:01:52 +0100 Subject: [PATCH 1/3] hurd: Fix indent --- clang/test/Driver/hurd.cpp | 16 +++

[llvm] [clang] Hurd: Add x86_64 support (PR #78065)

@@ -78,3 +78,82 @@ // CHECK-CROSS: "{{.*}}/Inputs/basic_cross_hurd_tree/usr/lib/gcc/i686-gnu/10/../../../../i686-gnu/bin/ld" {{.*}} "-m" "elf_i386" // CHECK-CROSS: "{{.*}}/Inputs/basic_cross_hurd_tree/usr/lib/gcc/i686-gnu/10/crtbegin.o" // CHECK-CROSS: "-L{{.*}}/Inputs/basi

[clang] [llvm] Hurd: Add x86_64 support (PR #78065)

https://github.com/sthibaul updated https://github.com/llvm/llvm-project/pull/78065 >From fefe6175fa21c668f58d69b0acc9abb89af981ab Mon Sep 17 00:00:00 2001 From: Samuel Thibault Date: Sun, 14 Jan 2024 19:01:52 +0100 Subject: [PATCH 1/3] hurd: Fix indent --- clang/test/Driver/hurd.cpp | 16 +++

[clang] [llvm] Hurd: Add x86_64 support (PR #78065)

sthibaul wrote: > Could you add some descriptions? What kind of description, where? https://github.com/llvm/llvm-project/pull/78065 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] Hurd: Add x86_64 support (PR #78065)

@@ -2652,6 +2652,31 @@ void Generic_GCC::GCCInstallationDetector::AddDefaultGCCPrefixes( return; } + if (TargetTriple.isOSHurd()) { +static const char *const X86_64HurdTriples[] = {"x86_64-gnu"}; sthibaul wrote: But then also `BiarchTripleAliases.

[llvm] [clang] Hurd: Add x86_64 support (PR #78065)

https://github.com/sthibaul updated https://github.com/llvm/llvm-project/pull/78065 >From fefe6175fa21c668f58d69b0acc9abb89af981ab Mon Sep 17 00:00:00 2001 From: Samuel Thibault Date: Sun, 14 Jan 2024 19:01:52 +0100 Subject: [PATCH 1/3] hurd: Fix indent --- clang/test/Driver/hurd.cpp | 16 +++

[llvm] [clang] Hurd: Add x86_64 support (PR #78065)

@@ -2477,7 +2477,7 @@ void Generic_GCC::GCCInstallationDetector::AddDefaultGCCPrefixes( "x86_64-redhat-linux","x86_64-suse-linux", "x86_64-manbo-linux-gnu", "x86_64-linux-gnu", "x86_64-slackware-linux", "x86_64-unknown-linux", - "x86_64-amazon-linux"

[llvm] [clang] Hurd: Add x86_64 support (PR #78065)

@@ -78,3 +78,82 @@ // CHECK-CROSS: "{{.*}}/Inputs/basic_cross_hurd_tree/usr/lib/gcc/i686-gnu/10/../../../../i686-gnu/bin/ld" {{.*}} "-m" "elf_i386" // CHECK-CROSS: "{{.*}}/Inputs/basic_cross_hurd_tree/usr/lib/gcc/i686-gnu/10/crtbegin.o" // CHECK-CROSS: "-L{{.*}}/Inputs/basi

[llvm] [clang] Hurd: Add x86_64 support (PR #78065)

https://github.com/sthibaul updated https://github.com/llvm/llvm-project/pull/78065 >From fefe6175fa21c668f58d69b0acc9abb89af981ab Mon Sep 17 00:00:00 2001 From: Samuel Thibault Date: Sun, 14 Jan 2024 19:01:52 +0100 Subject: [PATCH 1/3] hurd: Fix indent --- clang/test/Driver/hurd.cpp | 16 +++

[clang] [llvm] Hurd: Add x86_64 support (PR #78065)

https://github.com/sthibaul created https://github.com/llvm/llvm-project/pull/78065 None >From 17619023092c35fb851866172094540f6d18718f Mon Sep 17 00:00:00 2001 From: Samuel Thibault Date: Sat, 13 Jan 2024 20:16:03 +0100 Subject: [PATCH] Hurd: Add x86_64 support --- clang/lib/Basic/Targets.c