[PATCH] D144638: [lit] Detect Inconsistent File Access Times

lenary planned changes to this revision. lenary added a comment. To be clear: I've not yet addressed @jhenderson's comments above, yet, which may require changes to the patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144638/new/ https://revie

[PATCH] D142410: [AArch64] ARMv8.5-A implies both FEAT_SB and FEAT_SSBS

lenary added a comment. @philipp.tomsich Reverse Ping. What are your plans for this change? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142410/new/ https://reviews.llvm.org/D142410 ___ cfe-commits mail

[PATCH] D146141: [ARM] Use FPUKind enum instead of unsigned

lenary accepted this revision. lenary added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146141/new/ https://reviews.llvm.org/D146141 __

[PATCH] D145563: [AArch64] Assembly Support for FEAT_GCS/FEAT_CHK

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. lenary marked an inline comment as done. Closed by commit rGcb7fb737858c: [AArch64] Assembly Support for FEAT_GCS/FEAT_CHK (authored by lenary). Changed prior to commi

[PATCH] D145563: [AArch64] Assembly Support for FEAT_GCS/FEAT_CHK

lenary marked an inline comment as done. lenary added inline comments. Comment at: llvm/lib/Target/AArch64/AArch64InstrInfo.td:1106 + +def : TokenAlias<"DSYNC", "dsync">; + john.brawn wrote: > It would make more sense to put this immediately after GCSB_DSYNC. Thi

[PATCH] D144638: [lit] Detect Inconsistent File Access Times

lenary marked an inline comment as done. lenary added a comment. @jhenderson @int3 I think I have addressed your feedback - are you happy for me to land this? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144638/new/ https://reviews.llvm.org/D1446

[PATCH] D145563: [AArch64] Assembly Support for FEAT_GCS/FEAT_CHK

lenary added a comment. The CHKFEAT instruction here is not exactly as described in https://developer.arm.com/downloads/-/exploration-tools today - but the next release of that description will be updated with the new syntax. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION h

[PATCH] D145563: [AArch64] Assembly Support for FEAT_GCS/FEAT_CHK

lenary created this revision. Herald added subscribers: hiraditya, kristof.beyls. Herald added a project: All. lenary requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. This implements support for two new 2022 A-profile exten

[PATCH] D144638: [lit] Detect Inconsistent File Access Times

lenary added inline comments. Comment at: llvm/utils/lit/lit/llvm/config.py:190 +return False +if "1995" not in touch_res_out: +return False michaelplatings wrote: > This could end up matching the wrong part of the stri

[PATCH] D144638: [lit] Detect Inconsistent File Access Times

lenary updated this revision to Diff 501838. lenary marked an inline comment as done. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144638/new/ https://reviews.llvm.org/D144638 Files: clang/test/Modules/prune.m lld/test/COFF/lto-cache.ll lld/t

[PATCH] D144638: [lit] Detect Inconsistent File Access Times

lenary added a comment. In D144638#4155217 , @michaelplatings wrote: > I see some of these tests previously had `UNSUPPORTED: system-netbsd` but not > `UNSUPPORTED: system-windows` - do you know why? I'm not entirely sure why, but I have some ideas: -

[PATCH] D144638: [lit] Detect Inconsistent File Access Times

lenary marked 2 inline comments as done. lenary added a comment. Hopefully this addresses the feedback so far. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144638/new/ https://reviews.llvm.org/D144638 _

[PATCH] D144638: [lit] Detect Inconsistent File Access Times

lenary retitled this revision from "[lit] Detect Consistent File Access Times" to "[lit] Detect Inconsistent File Access Times". lenary edited the summary of this revision. lenary updated this revision to Diff 500742. Herald added a subscriber: krytarowski. Repository: rG LLVM Github Monorepo

[PATCH] D144638: [lit] Detect Consistent File Access Times

lenary added inline comments. Comment at: llvm/utils/lit/lit/llvm/config.py:171 +# in the tests that do the same thing. +(_, try_touch_err) = self.get_process_output(["touch", "-a", "-t", "199505050555.55", f.name]) +if try_touch_err != "": --

[PATCH] D144638: [lit] Detect Consistent File Access Times

lenary added a comment. Updates incoming to add a specific check for netbsd and windows, which are currently excluding the affected tests anyway. Comment at: llvm/utils/lit/lit/llvm/config.py:165 +# +# This check hopefully detects both cases, and disables tests that re

[PATCH] D144638: [lit] Detect Consistent File Access Times

lenary added a comment. In D144638#4147133 , @jhenderson wrote: > This looks reasonable to me, with the caveat that I don't know a huge amount > about how the different OSes access time systems work. One question though: > if your antivirus was causing

[PATCH] D144638: [lit] Detect Consistent File Access Times

lenary added reviewers: simonwallis2, mgorny. lenary added a subscriber: mgorny. lenary added a comment. Adding more reviewers. @mgorny you disabled some tests on NetBSD in the past for the same reason (rG92dc7dce4a6f117a497ced1650bc48e5b658f0ea

[PATCH] D144638: [lit] Detect Consistent File Access Times

lenary created this revision. Herald added subscribers: pmatos, asb, ormris, steven_wu, delcypher, hiraditya, sbc100, emaste. Herald added a reviewer: alexander-shaposhnikov. Herald added a reviewer: jhenderson. Herald added projects: lld-macho, All. Herald added a reviewer: lld-macho. lenary requ

[PATCH] D140999: [NFC][TargetParser] Remove llvm/Support/AArch64TargetParser.h

This revision was automatically updated to reflect the committed changes. Closed by commit rG8c712296fb75: [NFC][TargetParser] Remove llvm/Support/AArch64TargetParser.h (authored by lenary). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140999/new/

[PATCH] D140999: [NFC][TargetParser] Remove llvm/Support/AArch64TargetParser.h

lenary added a comment. Most recent diff was to clang-format the patch, which has removed some duplicate includes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140999/new/ https://reviews.llvm.org/D140999

[PATCH] D140999: [NFC][TargetParser] Remove llvm/Support/AArch64TargetParser.h

lenary updated this revision to Diff 494600. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140999/new/ https://reviews.llvm.org/D140999 Files: clang/lib/Basic/Targets/AArch64.cpp clang/lib/Basic/Targets/AArch64.h clang/lib/CodeGen/CGBuiltin.cp

[PATCH] D140999: [NFC][TargetParser] Remove llvm/Support/AArch64TargetParser.h

lenary retitled this revision from "[NFC][TargetParser] Deprecate llvm/Support/AArch64TargetParser.h" to "[NFC][TargetParser] Remove llvm/Support/AArch64TargetParser.h". lenary edited the summary of this revision. lenary updated this revision to Diff 494596. Repository: rG LLVM Github Monorepo

[PATCH] D140999: [NFC][TargetParser] Deprecate llvm/Support/AArch64TargetParser.h

lenary added a comment. In D140999#4030131 , @MaskRay wrote: > I don't think it is necessary to deprecate the old header then delete it > after 16.0.0 is branched. > llvm/Support/AArch64TargetParser.h has very few open-source out-of-tree uses. > Perhaps

[PATCH] D139182: AArch64: add CodeGen support for FEAT_XS DSB instructions

lenary added a comment. I'm not sure I agree with "map naturally", when `CRm` is a 4-bit field, and both bit 7 and bit 5 are different in the `dsb ` vs `dsb nXS` instructions. Are you willing to put this through review for the ACLE ?

[PATCH] D142410: [AArch64] ARMv8.5-A implies both FEAT_SB and FEAT_SSBS

lenary added a comment. In D142410#4076389 , @philipp.tomsich wrote: > When looking at "ARM DDI 0487G.a", on page A2-68 under the heading > "Additional functionality added to Armv8.0 in later releases" in the > definition-list item "FEAT_SSBS, Speculat

[PATCH] D142410: [AArch64] ARMv8.5-A implies both FEAT_SB and FEAT_SSBS

lenary added a comment. SSBS is not mandatory from v8.5a onwards. More details/citation inline. NB: This will need a rebase, because @dmgreen changed how crypto is handled in these bitmaps yesterday. Comment at: llvm/include/llvm/TargetParser/AArch64TargetParser.h:311 inline

[PATCH] D140222: [AArch64] Check 128-bit Sysreg Builtins

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG03ef89f8d909: [AArch64] Check 128-bit Sysreg Builtins (authored by lenary). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https

[PATCH] D140222: [AArch64] Check 128-bit Sysreg Builtins

lenary added inline comments. Comment at: clang/lib/Sema/SemaChecking.cpp:8297 << Arg->getSourceRange(); } else if (IsAArch64Builtin && Fields.size() == 1) { +// If this is a write ... tmatheson wrote: > It might be more readable to outline t

[PATCH] D140959: RFC: Multilib prototype

lenary added a comment. Thanks for putting together this proposal. Broadly, I think it's good, and I think it solves a lot of rough edges that I recall running into with the GCC multilib configuration files in the past. I do worry about using `-cc1` args. On the one hand, it's the best place fo

[PATCH] D141411: [AArch64] Make -march and target("arch=..") attributes imply dependent features

lenary added a comment. Can we check this logic, especially around adding both AEK_SVE and AEK_SVE2 in the `AARCH64_ARCH` descriptions, this means that `-march=armv9-a+nosve2` still can generate sve instructions. I'm not entirely sure of the intended behaviour there, especially as sve2 should m

[PATCH] D140999: [NFC][TargetParser] Deprecate llvm/Support/AArch64TargetParser.h

lenary edited the summary of this revision. lenary updated this revision to Diff 486324. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140999/new/ https://reviews.llvm.org/D140999 Files: clang/lib/Basic/Targets/AArch64.cpp clang/lib/Basic/Target

[PATCH] D140999: [NFC][TargetParser] Deprecate llvm/Support/AArch64TargetParser.h

lenary added reviewers: tmatheson, pratlucas, MaskRay. lenary added a comment. Herald added subscribers: StephenFan, JDevlieghere. Adding some relevant reviewers. My plan is to land the other patches like this directly onto `main`, as they are NFC and a cleanup. I hope this is uncontroversial, b

[PATCH] D140999: [NFC][TargetParser] Deprecate llvm/Support/AArch64TargetParser.h

lenary created this revision. Herald added subscribers: hiraditya, kristof.beyls. Herald added a project: All. lenary requested review of this revision. Herald added subscribers: llvm-commits, lldb-commits, cfe-commits, MaskRay. Herald added projects: clang, LLDB, LLVM. This deprecates, but does n

[PATCH] D123609: [Clang] Remove support for legacy pass manager

lenary added a comment. Herald added a subscriber: pcwang-thead. In D123609#3451334 , @nikic wrote: > In D123609#3451320 , @HaohaiWen > wrote: > >> Hi @nikic, >> We recently noticed legacy PM was removed from man

[PATCH] D137838: [Support] Move TargetParsers to new component

lenary added a comment. In D137838#4018930 , @vitalybuka wrote: > This bot is broken after the patch > https://lab.llvm.org/buildbot/#/builders/236/builds/1480 Thanks for letting me know. I'm back in the office on the 3rd, and it looks like this will

[PATCH] D137838: [Support] Move TargetParsers to new component

lenary added a comment. In D137838#4010987 , @dblaikie wrote: > This has introduced a circular dependency due to the forwarding header > (forwarding header depends on new lib, new lib depends on support, where the > forwarding header is). Generally this

[PATCH] D137517: [TargetParser] Generate the defs for RISCV CPUs using llvm-tblgen.

lenary added inline comments. Comment at: llvm/lib/Target/AArch64/AsmParser/CMakeLists.txt:19 +target_include_directories(LLVMAArch64AsmParser PRIVATE ${LLVM_LIBRARY_DIR}/TargetParser/) fpetrogalli wrote: > lenary wrote: > > fpetrogalli wrote: > > > craig.topp

[PATCH] D137838: [Support] Move TargetParsers to new component

lenary added a comment. In D137838#4008605 , @lenary wrote: > I'm working on a follow-up, which should make the split a bit clearer, but > I'm also not a modulemap expert and the `-DLLVM_ENABLE_MODULES=On` > configuration is broken on my linux dev box.

[PATCH] D137517: [TargetParser] Generate the defs for RISCV CPUs using llvm-tblgen.

lenary added inline comments. Comment at: llvm/lib/Target/AArch64/AsmParser/CMakeLists.txt:19 +target_include_directories(LLVMAArch64AsmParser PRIVATE ${LLVM_LIBRARY_DIR}/TargetParser/) fpetrogalli wrote: > craig.topper wrote: > > fpetrogalli wrote: > > > lena

[PATCH] D137517: [TargetParser] Generate the defs for RISCV CPUs using llvm-tblgen.

lenary added a comment. One comment on the build changes, I don't have opinions on the RISC-V changes. Comment at: llvm/lib/Target/AArch64/AsmParser/CMakeLists.txt:19 +target_include_directories(LLVMAArch64AsmParser PRIVATE ${LLVM_LIBRARY_DIR}/TargetParser/)

[PATCH] D137838: [Support] Move TargetParsers to new component

lenary added a comment. I'm working on a follow-up, which should make the split a bit clearer, but I'm also not a modulemap expert and the `-DLLVM_ENABLE_MODULES=On` configuration is broken on my linux dev box. I'll post it for review if those two patches have at least made the build greener.

[PATCH] D137838: [Support] Move TargetParsers to new component

lenary added a comment. In D137838#4008443 , @aprantl wrote: > Can you please update `llvm/include/llvm/module.modulemap` for this change or > revert the patch? This is breaking all bots that build with > `-DLLVM_ENABLE_MODULES=On`. > > For example: >

[PATCH] D140222: [AArch64] Check 128-bit Sysreg Builtins

lenary marked 3 inline comments as done. lenary added a comment. Nits addressed. Will land in the new year, when I'm back at work. Right now it's time for a break! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140222/new/ https://reviews.llvm.org/

[PATCH] D140222: [AArch64] Check 128-bit Sysreg Builtins

lenary edited the summary of this revision. lenary updated this revision to Diff 484281. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140222/new/ https://reviews.llvm.org/D140222 Files: clang/include/clang/Basic/BuiltinsAArch64.def clang/lib/He

[PATCH] D137838: [Support] Move TargetParsers to new component

lenary added a comment. In D137838#4007920 , @thakis wrote: > Thanks for the heads-up. I updated the GN build in > 4ac51dd53d93b8dd18c58093766483c657fe3a08 > and > 2aa998d22fe09191cd

[PATCH] D137838: [Support] Move TargetParsers to new component

lenary added a comment. And a fixup for the compiler-rt symbolizer: https://reviews.llvm.org/rGecaab107e4d0 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137838/new/ https://reviews.llvm.org/D137838 ___

[PATCH] D137838: [Support] Move TargetParsers to new component

lenary marked an inline comment as done. lenary added a comment. Another fixup for the llvm examples was required, landed in https://reviews.llvm.org/rG16c4c4e04c14 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137838/new/ https://reviews.llvm.org

[PATCH] D137838: [Support] Move TargetParsers to new component

lenary marked an inline comment as done. lenary added inline comments. Comment at: llvm/include/llvm/ADT/Triple.h:11 +/// This header is deprecated in favour of +/// `llvm/TargetParser/AArch64TargetParser.h`. /// barannikov88 wrote: > Invalid comment. Fixed in h

[PATCH] D137838: [Support] Move TargetParsers to new component

lenary added a comment. This caused an issue in the libc benchmarks, fix here: 2a261a7b5764 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137838/new/ https://reviews.llvm.org/D1

[PATCH] D140222: [AArch64] Check 128-bit Sysreg Builtins

lenary created this revision. Herald added a subscriber: kristof.beyls. Herald added a project: All. lenary requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This patch contains several related changes: 1. We move to using TARGET_BUILTIN for

[PATCH] D139443: [AArch64] Support SLC in ACLE prefetch intrinsics

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. lenary marked 2 inline comments as done. Closed by commit rG82b51a142804: [AArch64] Support SLC in ACLE prefetch intrinsics (authored by lenary). Repository: rG LLVM

[PATCH] D137838: [Support] Move TargetParsers to new component

lenary added a comment. The most recent update is all the fixes needed after the builds @MaskRay asked me for. I think this is ready to land on Monday? @thakis there will be GN fallout from this change. I do not intend to update GN in this patchset, but wanted to give you a heads-up. Reposito

[PATCH] D139443: [AArch64] Support SLC in ACLE prefetch intrinsics

lenary added reviewers: paquette, aemerson. lenary added a comment. Adding Jessica and Amara as this affects GlobalISel for AArch64. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139443/new/ https://reviews.llvm.org/D139443 ___

[PATCH] D139443: [AArch64] Support SLC in ACLE prefetch intrinsics

lenary updated this revision to Diff 482489. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139443/new/ https://reviews.llvm.org/D139443 Files: clang/lib/CodeGen/CGBuiltin.cpp clang/lib/Sema/SemaChecking.cpp clang/test/CodeGen/arm_acle.c clan

[PATCH] D139443: [AArch64] Support SLC in ACLE prefetch intrinsics

lenary added inline comments. Comment at: llvm/test/CodeGen/AArch64/arm64-prefetch-new.ll:2 +; RUN: llc -mtriple=aarch64 -mattr=+v8.9a < %s | FileCheck %s +; RUN: llc -mtriple=aarch64 -mattr=+v8.9a -O0 --global-isel-abort=1 < %s | FileCheck %s + tschuett wrote:

[PATCH] D139443: [AArch64] Support SLC in ACLE prefetch intrinsics

lenary added a reviewer: sdesmalen. lenary added a subscriber: sdesmalen. lenary added a comment. @sdesmalen adding you as I've moved around the custom lowering of `INTRINSIC_VOID` to be its own function, and as we need to handle it for `@llvm.arm.prefetch` all the time, it's no longer condition

[PATCH] D139443: [AArch64] Support SLC in ACLE prefetch intrinsics

lenary created this revision. Herald added subscribers: hiraditya, kristof.beyls. Herald added a project: All. lenary requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. This change: - Modifies the ACLE code to allow the new

[PATCH] D139086: [AArch64] Implement __arm_rsr128/__arm_wsr128

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG83b3304dd2a3: [AArch64] Implement __arm_rsr128/__arm_wsr128 (authored by lenary). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D139086: [AArch64] Implement __arm_rsr128/__arm_wsr128

lenary created this revision. Herald added subscribers: hiraditya, kristof.beyls. Herald added a project: All. lenary requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. This only contains the SelectionDAG implementation. Glob

[PATCH] D137836: [Support] Move getHostNumPhysicalCores to Threading.h

lenary added a comment. In D137836#3959759 , @lenary wrote: > In D137836#3959693 , @DavidSpickett > wrote: > >> Looks like tests need updating for that new -1 return value: >> https://lab.llvm.org/buildbot/#/bui

[PATCH] D137836: [Support] Move getHostNumPhysicalCores to Threading.h

lenary added a comment. In D137836#3959693 , @DavidSpickett wrote: > Looks like tests need updating for that new -1 return value: > https://lab.llvm.org/buildbot/#/builders/178/builds/3419 > > That bot builds with threading disabled. Thanks for letting

[PATCH] D138920: [AArch64] Assembly support for VMSA

lenary added inline comments. Comment at: llvm/include/llvm/Support/AArch64TargetParser.h:82 + AEK_THE = 1ULL << 50, // FEAT_THE + AEK_D128 =1ULL << 51, // FEAT_LSE128 + AEK_LSE128 = 1ULL << 52, // FEAT_D128 Comments don't correspond to na

[PATCH] D138920: [AArch64] Assembly support for VMSA

lenary added a comment. Two nits. One below, the other: Please include everyone who contributed to this patch in the patch description. Comment at: llvm/lib/Target/AArch64/AArch64.td:519 +def FeatureTHE : SubtargetFeature<"the", "HasTHE", +"true", "Enable Translation Harde

[PATCH] D137836: [Support] Move getHostNumPhysicalCores to Threading.h

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. lenary marked an inline comment as done. Closed by commit rG3c97f6cab92f: [Support] Move getHostNumPhysicalCores to Threading.h (authored by lenary). Changed prior to

[PATCH] D137836: [Support] Move getHostNumPhysicalCores to Threading.h

lenary marked 3 inline comments as done. lenary added a comment. Going to attempt to land this again today. Comment at: llvm/lib/Support/Threading.cpp:59 if (MaxThreadCount <= 0) MaxThreadCount = 1; if (ThreadsRequested == 0) tmatheson wrote: > It lo

[PATCH] D137838: [RFC][Support] Move TargetParsers to new component

lenary added a comment. > As for the name TargetParser. @arsenm came up with the name > SubtargetRegistry. I am fine with either names. @fpetrogalli I'm going to stick with TargetParser, because I think this is less confusing, given that TargetRegistry is already a component. Repository: rG

[PATCH] D137838: [RFC][Support] Move TargetParsers to new component

lenary added inline comments. Comment at: clang/lib/Lex/CMakeLists.txt:3 -set(LLVM_LINK_COMPONENTS support) +set(LLVM_LINK_COMPONENTS + Support fpetrogalli wrote: > I wonder how `support` was not being detected as a linking error... Not sure, but I still think

[PATCH] D137836: [Support] Move getHostNumPhysicalCores to Threading.h

lenary added a subscriber: MaskRay. lenary added a comment. New version, which changes how the move works a bit. I've updated the description with the caveats, so this is now definitely not NFC. I'm looking for re-review, and maybe input from @MaskRay who has made some minor cleanups in this co

[PATCH] D137836: [Support] Move getHostNumPhysicalCores to Threading.h

lenary edited the summary of this revision. lenary updated this revision to Diff 477975. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137836/new/ https://reviews.llvm.org/D137836 Files: clang-tools-extra/clangd/test/Inputs/BenchmarkHeader.h llv

[PATCH] D137836: [Support] Move getHostNumPhysicalCores to Threading.h

lenary added a comment. In D137836#3950846 , @fhahn wrote: > (it looks like this job should have sent an email: > https://green.lab.llvm.org/green/job/clang-stage1-RA/32031/console) Yeah, sorry, no email. I'll check with colleagues to see if other peopl

[PATCH] D137836: [Support] Move getHostNumPhysicalCores to Threading.h

lenary added a comment. In D137836#3950815 , @fhahn wrote: > Unfortunately it looks like this commit breaks building on ARM64 macOS. I > reverted the change for now and added more details on the error in the revert > commit. Thanks for reverting. I had

[PATCH] D137836: [Support] Move getHostNumPhysicalCores to Threading.h

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG5577207d6d3e: [Support] Move getHostNumPhysicalCores to Threading.h (authored by lenary). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D137836: [Support] Move getHostNumPhysicalCores to Threading.h

lenary added inline comments. Comment at: llvm/unittests/Support/Host.cpp:33 -class HostTest : public testing::Test { - Triple Host; - -protected: - bool isSupportedArchAndOS() { -// Initially this is only testing detection of the number of -// physical cores, which i

[PATCH] D137836: [Support] Move getHostNumPhysicalCores to Threading.h

lenary added inline comments. Comment at: llvm/unittests/Support/Host.cpp:33 -class HostTest : public testing::Test { - Triple Host; - -protected: - bool isSupportedArchAndOS() { -// Initially this is only testing detection of the number of -// physical cores, which i

[PATCH] D137836: [Support] Move getHostNumPhysicalCores to Threading.h

lenary edited the summary of this revision. lenary updated this revision to Diff 477912. lenary marked 2 inline comments as done. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137836/new/ https://reviews.llvm.org/D137836 Files: clang-tools-extra/c

[PATCH] D137835: [ARM] Move ARM::parseBranchProtection into ARMTargetParserCommon

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG3e9b6adfc7ca: [ARM] Move ARM::parseBranchProtection into ARMTargetParserCommon (authored by lenary). Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D137835: [ARM] Move ARM::parseBranchProtection into ARMTargetParserCommon

lenary updated this revision to Diff 477904. lenary marked an inline comment as done. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137835/new/ https://reviews.llvm.org/D137835 Files: clang/lib/Basic/Targets/AArch64.cpp clang/lib/Basic/Targets/A

[PATCH] D138579: [AArch64] Assembly support for FEAT_LRCPC3

lenary added inline comments. Comment at: llvm/lib/Target/AArch64/AArch64InstrInfo.td:8572 + def STLR_x_64 : BaseLRCPC3IntegerLoadStore<0b11, 0b10, (outs GPR64sp:$Rn_wb) , (ins GPR64:$Rt, GPR64sp:$Rn), "stlr" , "\t$Rt, [$Rn, #-8]!", "$Rn = $Rn_wb">; /* PUSH register

[PATCH] D138579: [AArch64] Assembly support for FEAT_LRCPC3

lenary accepted this revision. lenary added a comment. This revision is now accepted and ready to land. Some comment nits that you can fixup on commit. Comment at: llvm/lib/Target/AArch64/AArch64InstrInfo.td:3913 +// are post-indexed, and the immediate values are not inside the

[PATCH] D138488: [AArch64][clang] implement 2022 General Data-Processing instructions

lenary added a comment. Oh, actually, I have a few nits. You can fix them on commit though. Comment at: llvm/lib/Target/AArch64/AArch64.td:497 +def FeatureCSSC : SubtargetFeature<"cssc", "HasCSSC", "true", + "Enable Common Short Sequence Compression (CSSC) instructions">; + --

[PATCH] D138488: [AArch64][clang] implement 2022 General Data-Processing instructions

lenary accepted this revision. lenary added a comment. This revision is now accepted and ready to land. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138488/new/ https://reviews.llvm.org/D138488 __

[PATCH] D137838: [RFC][Support] Move TargetParsers to new component

lenary added a comment. I've updated the patch to use forwarding headers (and to rebase past some changes that have happened in the interim). The patch is still huge because of the number of places using the TargetParsers, which need the component added to their CMakeLists.txt. I think after t

[PATCH] D137835: [ARM] Move ARM::parseBranchProtection into ARMTargetParserCommon

lenary marked an inline comment as done. lenary added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:47 #include "llvm/Option/ArgList.h" +#include "llvm/Support/ARMTargetParser.h" #include "llvm/Support/CodeGen.h" tmatheson wrote: > For cons

[PATCH] D137835: [ARM] Move ARM::parseBranchProtection into ARMTargetParserCommon

lenary retitled this revision from "[ARM] Move ARM::parseBranchProtection into ARMTargetParser" to "[ARM] Move ARM::parseBranchProtection into ARMTargetParserCommon". lenary edited the summary of this revision. lenary updated this revision to Diff 475860. Repository: rG LLVM Github Monorepo C

[PATCH] D137835: [ARM] Move ARM::parseBranchProtection into ARMTargetParser

lenary added a comment. I'm going to move this into the newly created `ARMTargetParserCommon` files which @tmatheson created in https://reviews.llvm.org/D137924 (which has landed). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137835/new/ https://

[PATCH] D137838: [RFC][Support] Move TargetParsers to new component

lenary added a comment. In D137838#3921828 , @thakis wrote: > This is a gigantic diff. I'd recommend keeping the .h files in the old place > for v0 and make them just forwarding headers that include the header at the > new location. That way, you don't

[PATCH] D137516: [TargetSupport] Move TargetParser API in a separate LLVM component.

lenary added a comment. In D137516#3912900 , @fpetrogalli wrote: > In D137516#3912842 , @lenary wrote: > >> In D137516#3912751 , @fpetrogalli >> wrote: >> >>> @arsenm @f

[PATCH] D137838: [RFC][Support] Move TargetParsers to new component

lenary added a comment. Herald added a subscriber: Michael137. Apologies to everyone who has automatically been marked as a reviewer for this change. There is more context for it here: https://discourse.llvm.org/t/targetparser-auto-generation-of-riscv-cpu-definitions/66419/4?u=lenary Repositor

[PATCH] D137836: [Support] Move getHostNumPhysicalCores to Threading.h

lenary created this revision. Herald added subscribers: kadircet, arphaman, hiraditya, krytarowski. Herald added a project: All. lenary requested review of this revision. Herald added projects: LLVM, clang-tools-extra. Herald added subscribers: cfe-commits, llvm-commits. This change is focussed on

[PATCH] D137835: [ARM] Move ARM::parseBranchProtection into ARMTargetParser

lenary created this revision. Herald added subscribers: hiraditya, kristof.beyls. Herald added a project: All. lenary requested review of this revision. Herald added subscribers: llvm-commits, cfe-commits, MaskRay. Herald added projects: clang, LLVM. This should live with the Arm targets, given th

[PATCH] D137659: [Driver] Refactor err_drv_unsupported_option_argument call sites to use llvm::opt::Arg::getSpelling

lenary accepted this revision. lenary added a comment. This revision is now accepted and ready to land. Thanks for doing this cleanup! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137659/new/ https://reviews.llvm.org/D137659 _

[PATCH] D137516: [TargetSupport] Move TargetParser API in a separate LLVM component.

lenary added a comment. In D137516#3912751 , @fpetrogalli wrote: > @arsenm @frasercrmck @lenary - thank you for the feedback > > 1. The library could host anything that needs to be auto-generated with > tablegen. If we add `MVT`s, the name `TargetSuppor

[PATCH] D137516: [TargetSupport] Move TargetParser API in a separate LLVM component.

lenary added a comment. I'm not convinced we should be leaving any of the other Target Parser information in Support, if we are doing this, though this creates layering issues which I've been trying to unpick. If you try to take `llvm/Support/*TargetParser*`, you find a few places where there

[PATCH] D123630: Remove connection between 'ffast-math' and 'ffp-contract'.

lenary added a comment. Oh, can you close this revision and link it to the landed commit please? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123630/new/ https://reviews.llvm.org/D123630 ___ cfe-commits

[PATCH] D123630: Remove connection between 'ffast-math' and 'ffp-contract'.

lenary added a comment. Reverse ping. This has been accepted, what is the status of landing this? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123630/new/ https://reviews.llvm.org/D123630 ___ cfe-commits mailing list cfe-commits@lists.llvm.o

[PATCH] D136145: [IR][RFC] Restrict read only when cache type of llvm.prefetch is instruction

lenary added a comment. The Arm changes (for tests) here are reasonable, and indeed both arm architectures do not allocate encoding space for instruction write. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136145/new/ https://reviews.llvm.org/D13

[PATCH] D128653: [PowerPC] Fix the check for scalar MASS conversion

lenary added a comment. You likely need `// REQUIRES: powerpc-registered-target` in the top of the test, as `-enable-ppc-gen-scalar-mass` is only present if the PowerPC target has been compiled into LLVM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.o

[PATCH] D128415: [ARM] Add Support for Cortex-M85

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG1666f09933ee: [ARM] Add Support for Cortex-M85 (authored by lenary). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://revi

[PATCH] D128415: [ARM] Add Support for Cortex-M85

lenary added a comment. @tschuett I've corrected the patch based on your feedback. If you're happy, I'm going to land this. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128415/new/ https://reviews.llvm.org/D128415 ___

[PATCH] D128415: [ARM] Add Support for Cortex-M85

lenary updated this revision to Diff 442109. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128415/new/ https://reviews.llvm.org/D128415 Files: clang/docs/ReleaseNotes.rst clang/test/CodeGen/arm-target-features.c clang/test/Driver/arm-cortex-cp

  1   2   3   >