[PATCH] D87629: Thread safety analysis: Improve documentation for ASSERT_CAPABILITY

ryanofsky marked 4 inline comments as done. ryanofsky added a comment. In D87629#2280475 , @ajtowns wrote: > AJ, maybe this discussion could moved to another issue? I find the details hard to follow, so having another issue would be helpful just to unde

[PATCH] D87629: Thread safety analysis: Improve documentation for ASSERT_CAPABILITY

ryanofsky marked 4 inline comments as done. ryanofsky added a comment. Agree with everything in D87629#2278073 . "Assumed" is the key word, and a wrong assumption doesn't imply UB or generating incorrect code

[PATCH] D87629: Thread safety analysis: Improve documentation for ASSERT_CAPABILITY

ryanofsky updated this revision to Diff 292576. ryanofsky added a comment. Removed bad information about exceptions, added sentence to clarify what it means for the analysis to "assume" something, tweaked description to only say asserts affect assumptions after calls instead of at or before call

[PATCH] D87629: Thread safety analysis: Improve documentation for ASSERT_CAPABILITY

ryanofsky added a comment. Great feedback! I need to absorb it all then I'll fix the changeset. The mistakes about exceptions came from me taking "(no return)" in the previous documentation too literally thinking it was referring to https://en.cppreference.com/w/cpp/language/attributes/noreturn

[PATCH] D87629: Thread safety analysis: Improve documentation for ASSERT_CAPABILITY

ryanofsky created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. ryanofsky requested review of this revision. Previous description didn't actually state the effect the attribute has on thread safety analysis (causing analysis to assume the capability is held)