[PATCH] D92797: APINotes: add initial stub of APINotesWriter

ronlieb added a comment. hi, this seems to be breaking out amdgpu opemp and hip buildbots https://lab.llvm.org/staging/#/builders/247/builds/4967 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92797/new/ https://reviews.llvm.org/D92797

[PATCH] D153226: OpenMP: Don't include stdbool.h in builtin headers

ronlieb accepted this revision. ronlieb added a comment. This revision is now accepted and ready to land. patch applied to local build resolves issues seen CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153226/new/ https://reviews.llvm.org/D153226 ___

[PATCH] D153226: OpenMP: Don't include stdbool.h in builtin headers

ronlieb added a subscriber: mhalk. ronlieb added a comment. @mhalk to review CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153226/new/ https://reviews.llvm.org/D153226 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llv

[PATCH] D151576: Fix runtime crash inside __kmpc_init_allocator

ronlieb added a comment. apologies, i just realized its a new test that you xfailed. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151576/new/ https://reviews.llvm.org/D151576 ___ cfe-commits mailing lis

[PATCH] D151576: Fix runtime crash inside __kmpc_init_allocator

ronlieb added a comment. i think the extra two failures are not related to you patch. so ignore comment about these libomptarget :: amdgcn-amd-amdhsa :: jit/empty_kernel_lvl1.c libomptarget :: amdgcn-amd-amdhsa :: jit/empty_kernel_lvl2.c Repository: rG LLVM Github Monorepo CHANGES SINCE LAS

[PATCH] D151576: Fix runtime crash inside __kmpc_init_allocator

ronlieb added a comment. observing failure in our amdgpu buildbot , 3 tests see: https://lab.llvm.org/staging/#/builders/247/builds/947 7: __tgt_target_table *__tgt_rtl_load_binary(int32_t, __tgt_device_image *): Assertion `Table != nullptr && "Invalid table"' failed. if you have a quick fix, p

[PATCH] D150646: [clang][X86] Add __cpuidex function to cpuid.h

ronlieb added a comment. seeing this issue in our downstream builders: [2023-05-24T11:46:07.333Z] /opt/rocm-5.6.0-12074/llvm/lib/clang/17.0.0/include/cpuid.h:333:22: error: static declaration of '__cpuidex' follows non-static declaration [2023-05-24T11:46:07.333Z] static __inline void __cpuide

[PATCH] D142569: [OpenMP] Introduce kernel environment

ronlieb added a comment. @tianshilei1992 this seems to have broken the amdgpu buildbot, could you please address quickly ? or revert and fix ? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142569/new/ https://reviews.llvm.org/D142569

[PATCH] D145093: [OpenMP] Add map info for dereference pointer.

ronlieb added a comment. had not heard back , so reverted it for now commit 8cf85a0cadb033fed3d96aa5283deb4bfbbaf2c8 (HEAD -> main, origin/main, origin/HEAD) Author: Ron Lieberman Date: Wed Mar 8 22:01:22 2023 -0600 Rev

[PATCH] D145093: [OpenMP] Add map info for dereference pointer.

ronlieb added a comment. seems to fail amdgpu buildbot https://lab.llvm.org/buildbot/#/builders/193/builds/27692 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145093/new/ https://reviews.llvm.org/D145093 __

[PATCH] D144634: [Clang][OpenMP] Support for Code Generation of loop bind clause

ronlieb added a comment. LIT Test ? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144634/new/ https://reviews.llvm.org/D144634 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.o

[PATCH] D141232: [OpenMP] Modernize the kernel launching interface and APIs

ronlieb added a comment. hi, breaks our amdgpu buildbot, please fix ASAP , or revert and fix. thx 3 patches: https://lab.llvm.org/buildbot/#/builders/193/builds/25299 i reverted locally and verified this patch as the cause. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION h

[PATCH] D133574: [C2x] reject type definitions in offsetof

ronlieb added a comment. our nekbone app is failing from this patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133574/new/ https://reviews.llvm.org/D133574 ___ cfe-commits mailing list cfe-commits@li

[PATCH] D112680: [OpenMP] Lower printf to __llvm_omp_vprintf

ronlieb added a comment. Herald added subscribers: kosarev, mattd. Herald added a project: All. @JonChesterfield i am seeing the testcase bug50022.cpp occasionally randomly failing in amdgpu bbot most recently: https://lab.llvm.org/buildbot/#/builders/193/builds/24230 the same bbot in Stagin

[PATCH] D139287: [OpenMP] Introduce basic JIT support to OpenMP target offloading

ronlieb added a comment. seems like this broke the amdgpu buildbot , plz resolve https://lab.llvm.org/buildbot/#/builders/193/builds/24122 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139287/new/ https://reviews.llvm.org/D139287 _

[PATCH] D137313: [NFC] Remove redundant loads when has_device_addr is used.

ronlieb added a comment. [AMD Official Use Only - General] Please look into AMDGPU bot fail https://lab.llvm.org/buildbot/#/builders/193/builds/21319 Get Outlook for iOShttps://aka.ms/o0ukef From: Jennifer Yu via Phabricator Sent: Friday, November 4, 2022 5:40

[PATCH] D135107: [clang][NFC] Use enum for -fstrict-flex-arrays

ronlieb added a comment. hi, seeing our amdgpu buildbot broken with this patch. please look into ? let me know if you any help on our end. https://lab.llvm.org/buildbot/#/builders/193/builds/19744 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135107

[PATCH] D134186: [Clang][OpenMP] Codegen generation for has_device_addr claues.

ronlieb added a comment. seeing a buildbot failure on amdgpu bot https://lab.llvm.org/buildbot/#/builders/193/builds/18788 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134186/new/ https://reviews.llvm.org/D134186 _

[PATCH] D133522: [clang] Fix Complex x Float x Int conversions so it handles type sugar

ronlieb added a comment. emailed a hopeful reproducer to you Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133522/new/ https://reviews.llvm.org/D133522 ___ cfe-commits mailing list cfe-commits@lists.llvm

[PATCH] D133522: [clang] Fix Complex x Float x Int conversions so it handles type sugar

ronlieb added a comment. hopefully will fix this ? invalid cast kind for complex value UNREACHABLE executed at /clang/lib/AST/ExprConstant.cpp:14263! PLEASE submit a bug report to https://github.com/llvm/llvm-project/issues/ and include the crash backtrace, preprocessed source, and as sociated ru

[PATCH] D111509: [clang] use getCommonSugar in an assortment of places

ronlieb added a comment. i am seeing similar issues in openmp buildbot failing with this patch Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111509/new/ https://reviews.llvm.org/D111509 ___ cfe-commits m

[PATCH] D131307: [Clang] Allow downgrading to a warning the diagnostic for setting a non fixed enum to a value outside the range of the enumeration values

ronlieb added a comment. thanks for the analysis , i agree its a coding error in our library. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131307/new/ https://reviews.llvm.org/D131307 ___ cfe-commits ma

[PATCH] D131307: [Clang] Allow downgrading to a warning the diagnostic for setting a non fixed enum to a value outside the range of the enumeration values

ronlieb added a comment. hi, latest commit seems to have broken buildbot for amdgpu https://lab.llvm.org/buildbot/#/builders/193/builds/16651 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131307/new/ https://reviews.llvm.org/D131307 _

[PATCH] D120662: [clang-offload-bundler] add -input/-output options

ronlieb added subscribers: saiislam, ronlieb. ronlieb added a comment. @saiislam for awareness Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120662/new/ https://reviews.llvm.org/D120662 ___ cfe-commits

[PATCH] D122781: Refactor sanitizer options handling for AMDGPU Toolchain

ronlieb added a comment. i pushed it in. will watch for build bot issues Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122781/new/ https://reviews.llvm.org/D122781 ___ cfe-commits mailing list cfe-commit

[PATCH] D122781: Refactor sanitizer options handling for AMDGPU Toolchain

This revision was automatically updated to reflect the committed changes. Closed by commit rGcc2139524f77: [AMDPU][Sanitizer] Refactor sanitizer options handling for AMDGPU Toolchain (authored by ronlieb). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org

[PATCH] D121837: [OpenMP][FIX] Allow device constructors for AMD GPU

ronlieb added a comment. i applied it locally and ran bot equiv, looks good to me Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121837/new/ https://reviews.llvm.org/D121837 ___ cfe-commits mailing list c

[PATCH] D121837: [OpenMP][FIX] Allow device constructors for AMD GPU

ronlieb added a comment. Hi Johannes, assert in two of the tests #7 0x5576b8d055e4 llvm::ConstantExpr::getAddrSpaceCast(llvm::Constant*, llvm::Type*, bool) (/work/omp-vega20-0/openmp-offload-amdgpu-runtime/llvm.build/bin/clang-15+0x1e4b5e4) https://lab.llvm.org/buildbot/#/builders/193/bui

[PATCH] D121233: [pseudo] Move pseudoparser from clang to clang-tools-extra

ronlieb added a comment. Hi Sam i think this breaks our amdgpu buildbot https://lab.llvm.org/buildbot/#/builders/193/builds/8513 any suggestions? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121233/new/ https://reviews.llvm.org/D121233 _

[PATCH] D120489: [analyzer] Done some changes to detect Uninitialized read by the char array manipulation functions

ronlieb added a comment. broke our hip buildbot as well. https://lab.llvm.org/buildbot/#/builders/165/builds/17076 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120489/new/ https://reviews.llvm.org/D120489

[PATCH] D119841: [OpenMP] Pass AMDGPU math libraries into the linker wrapper

ronlieb added a comment. Hi Joseph, seems to have broken amdgpu buildbit, please revert and fix ? https://lab.llvm.org/buildbot/#/builders/193/builds/6939 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119841/new/ https://reviews.llvm.org/D119841 _

[PATCH] D109885: [MLIR][[amdgpu-arch]][OpenMP] Remove direct dependency on /opt/rocm

ronlieb added a comment. Our conclusion is that the /opt/rocm weak default needs to stay in place. Thus this patch should be abandoned in my opinion. MarkS and I are requesting the folks that requestedt his change within AMD, revisit it. Repository: rG LLVM Github Monorepo CHANGES SINCE LA

[PATCH] D109885: [MLIR][[amdgpu-arch]][OpenMP] Remove direct dependency on /opt/rocm

ronlieb requested changes to this revision. ronlieb added a comment. This needs to be revisited. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109885/new/ https://reviews.llvm.org/D109885 ___ cfe-commits

[PATCH] D109885: [MLIR][[amdgpu-arch]][OpenMP] Remove direct dependency on /opt/rocm

ronlieb added subscribers: estewart08, ronlieb. ronlieb added a comment. Herald added a reviewer: bondhugula. Herald added a subscriber: sdasgup3. @estewart08 thoughts on a good CMAKE variable to allow users to define equivalent of /opt/rocm ? and not use environment variable inside the cmake

[PATCH] D115045: [Clang] Ignore CLANG_DEFAULT_LINKER for custom-linker toolchains

ronlieb added a comment. fyi: if i remove the now 'dead' use of the CMAKE variable from my cmake , then i am able to build. so i see you reverted, thx. i guess some coordination amongst buildbot maintainers who might use this option checking zorg: the last two are me: not sure who owns the 1

[PATCH] D115045: [Clang] Ignore CLANG_DEFAULT_LINKER for custom-linker toolchains

ronlieb added a comment. Hi Simon, i am seeing a failure in our amdgpu buildbot after this patch . https://lab.llvm.org/staging/#/builders/200/builds/1407 we do depend on the cmake flag you removed. we specify this -DCLANG_DEFAULT_LINKER=lld FAILED: openmp/libomptarget/libomptarget.rtl.x86_64.s

[PATCH] D114890: [OpenMP] Make the new device runtime the default

ronlieb added a comment. yes, thanks, sounds good Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114890/new/ https://reviews.llvm.org/D114890 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https:

[PATCH] D114890: [OpenMP] Make the new device runtime the default

ronlieb added a comment. thx for trying it out, please revert so we can look into it more on the AMDGPU target Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114890/new/ https://reviews.llvm.org/D114890

[PATCH] D114890: [OpenMP] Make the new device runtime the default

ronlieb added a comment. based on Shilei's last comment, do it in the morning ? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114890/new/ https://reviews.llvm.org/D114890 ___ cfe-commits mailing list cfe

[PATCH] D114890: [OpenMP] Make the new device runtime the default

ronlieb accepted this revision. ronlieb added a comment. works for me, i think Greg is ok with it too, we chatted internally an hour or so ago Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114890/new/ https://reviews.llvm.org/D114890

[PATCH] D114890: [OpenMP] Make the new device runtime the default

ronlieb added a comment. perhaps we can try this patch as is, and if it passes buildbot, let the new DeviceRTL be the default upstream for all targets. if it fails the AMDGPU buildbot, then perhaps apply the above suggested change of leaving old runtime default for now for AMD. or consider some

[PATCH] D102107: [OpenMP] Codegen aggregate for outlined function captures

ronlieb added a comment. i backed up to your reverted patch, and applied this one. I see some new errors libomptarget :: amdgcn-amd-amdhsa :: mapping/declare_mapper_target.cpp libomptarget :: amdgcn-amd-amdhsa :: mapping/declare_mapper_target_data.cpp libomptarget :: amdgcn-amd-amdhsa :: m

[PATCH] D110429: [OpenMP] Introduce a new worksharing RTL function for distribute

ronlieb added a comment. looks like subsequent builders passed. we might have an issue where the runtime was not fully built when the test ran. please disregard , your patch is fine. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110429/new/ https:

[PATCH] D110429: [OpenMP] Introduce a new worksharing RTL function for distribute

ronlieb added a comment. lld: error: undefined symbol: __kmpc_distribute_static_init_4 >>> referenced by /tmp/private_mapping-6f3f07-gfx906-d001f0.o:(__omp_outlined__) >>> referenced by /tmp/private_mapping-6f3f07-gfx906-d001f0.o:(__omp_outlined__) lld: error: undefined symbol: __kmpc_distribute

[PATCH] D110429: [OpenMP] Introduce a new worksharing RTL function for distribute

ronlieb added a comment. apologies, that pasted very poorly ... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110429/new/ https://reviews.llvm.org/D110429 ___ cfe-commits mailing list cfe-commits@lists.l

[PATCH] D110429: [OpenMP] Introduce a new worksharing RTL function for distribute

ronlieb added a comment. hi, we seem to have a link time error after this patch in our buildbot https://lab.llvm.org/staging/#/builders/182/builds/2023 - TEST 'libomptarget :: amdgcn-amd-amdhsa :: mapping/private_mapping.c' FAILED Script: --- : 'RUN: at line 1'; /w

[PATCH] D102107: [OpenMP] Codegen aggregate for outlined function captures

ronlieb added a subscriber: pdhaliwal. ronlieb added a comment. @pdhaliwal i will pass the problem over to Pushpinder Singh who should be waking up soon. George, thank you for reverting it. i can reproduce the issue on a local system. building latest (revert present) passes. Revert the revert an

[PATCH] D102107: [OpenMP] Codegen aggregate for outlined function captures

ronlieb added a comment. Please revert the patch so our buildbot can resume greeness, and we can look into it with urgency today (me or Jon) as it should be reproducible Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102107/new/ https://reviews.llv

[PATCH] D102107: [OpenMP] Codegen aggregate for outlined function captures

ronlieb added a comment. seeing buildbot failures after this patch landed https://lab.llvm.org/staging/#/builders/183/builds/1598 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102107/new/ https://reviews.llvm.org/D102107 _

[PATCH] D109943: [Clang] Fix long double availability check

ronlieb accepted this revision. ronlieb added a comment. This revision is now accepted and ready to land. thank you for the fix. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109943/new/ https://reviews.llvm.org/D109943 ___

[PATCH] D108708: [openmp][amdgpu] Initial gfx10 offloading implementation

ronlieb accepted this revision. ronlieb added a comment. This revision is now accepted and ready to land. since amdgpu buildbots are red, at Jon's request, i applied patch on latest trunk build. applies clean, builds fine, no additional regressions in bheck-openmp compiler now accepts -march=gfx

[PATCH] D108708: [openmp][amdgpu] Initial gfx10 offloading implementation

ronlieb added inline comments. Comment at: openmp/libomptarget/deviceRTLs/amdgcn/CMakeLists.txt:111 +set(mcpus gfx700 gfx701 gfx801 gfx803 gfx900 gfx902 gfx906 gfx908 gfx1010 gfx1031) if (DEFINED LIBOMPTARGET_AMDGCN_GFXLIST) set(mcpus ${LIBOMPTARGET_AMDGCN_GFXLIST})

[PATCH] D104904: [OpenMP][AMDGCN] Initial math headers support

ronlieb added subscribers: estewart08, ashi1. ronlieb added a comment. @estewart08 @ashi1 please review Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104904/new/ https://reviews.llvm.org/D104904 ___ cf

[PATCH] D96769: [OpenMP][AMDGPU] Skip backend and assemble phases for amdgcn

ronlieb accepted this revision. ronlieb added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96769/new/ https://reviews.llvm.org/D96769 ___ cfe-commits mailing list cfe-commits@lists.llvm.

[PATCH] D93356: [libomptarget][amdgpu] Call into deviceRTL instead of ockl

ronlieb accepted this revision. ronlieb added a comment. This revision is now accepted and ready to land. lgtm Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93356/new/ https://reviews.llvm.org/D93356 ___

[PATCH] D84470: [OpenMP 5.0] Fix user-defined mapper privatization in tasks

ronlieb accepted this revision. ronlieb added a comment. This revision is now accepted and ready to land. accepted. not sure if there were any outstanding comments from Johannes. your call Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84470/new/ h

[PATCH] D84470: [OpenMP 5.0] Fix user-defined mapper privatization in tasks

ronlieb added a comment. The latest patch applied cleanly to our downstream port. builds fine, tests very nicely as well. All the failing SOLLVE task wait depend tests now pass. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84470/new/ https://revi