Re: [PATCH] D17453: [Driver] Enable --rtlib option for MSVC target

2016-03-10 Thread Roman Shirokiy via cfe-commits
roman.shirokiy updated this revision to Diff 50260. roman.shirokiy added a comment. Updated diff with the test for "nostdlib" + "rtlib" case. http://reviews.llvm.org/D17453 Files: lib/Driver/Tools.cpp test/Driver/msvc-compiler-rt.c test/Driver/nostdlib.c Index: lib/Driver/Tools.cpp =

Re: [PATCH] D17453: [Driver] Enable --rtlib option for MSVC target

2016-03-10 Thread Roman Shirokiy via cfe-commits
roman.shirokiy added a comment. Hello! Thanks for the feedback! MSVC got its own runtime lib, so the function "AddRunTimeLibs" is not used anywhere in "visualstudio::Linker::Constructjob" i.e. "--rtlib" option is currently unused in MSVC environment (there is always a warning: argument unused

Re: [PATCH] D17453: [Driver] Enable --rtlib option for MSVC target

2016-03-09 Thread Roman Shirokiy via cfe-commits
roman.shirokiy added a comment. For now every native Windows installation of Clang contains small compiler-rt builtins lib (http://reviews.llvm.org/rL261432: [CMake] Add partial support for MSVC in compiler-rt builtins), but there is no specific interface to make use of this lib on Windows. Thi

[PATCH] D17453: [Driver] Enable --rtlib option for MSVC target

2016-02-19 Thread Roman Shirokiy via cfe-commits
roman.shirokiy created this revision. roman.shirokiy added reviewers: rnk, majnemer, beanz, pcc. roman.shirokiy added a subscriber: cfe-commits. This enables "--rtlib compiler-rt" option under MSVC environment. Related compiler-rt patch: http://reviews.llvm.org/D17452 http://reviews.llvm

[PATCH] D17452: [CMake] Add partial support for MSVC in compiler-rt builtins

2016-02-19 Thread Roman Shirokiy via cfe-commits
roman.shirokiy created this revision. roman.shirokiy added reviewers: rnk, majnemer, beanz, pcc. roman.shirokiy added a subscriber: cfe-commits. This enables MSVC build of complex number arithmetic compiler-rt builtins. Consider Clang which is built under native Windows environment. Compiling t