r263647 - Add attributes for preserve_mostcc/preserve_allcc calling conventions to the C/C++ front-end

Author: swiftix Date: Wed Mar 16 13:00:46 2016 New Revision: 263647 URL: http://llvm.org/viewvc/llvm-project?rev=263647&view=rev Log: Add attributes for preserve_mostcc/preserve_allcc calling conventions to the C/C++ front-end Till now, preserve_mostcc/preserve_allcc calling convention attribute

Re: [PATCH] D18025: Add attributes for preserve_mostcc/preserve_allcc calling conventions to the C/C++ front-end

This revision was automatically updated to reflect the committed changes. Closed by commit rL263647: Add attributes for preserve_mostcc/preserve_allcc calling conventions to the… (authored by swiftix). Changed prior to commit: http://reviews.llvm.org/D18025?vs=50508&id=50838#toc Repository:

Re: [PATCH] D18025: Add attributes for preserve_mostcc/preserve_allcc calling conventions to the C/C++ front-end

swiftix updated this revision to Diff 50508. swiftix added a comment. This patch revision addresses all issues mentioned by reviewers: - DocCatCallingConvs is used instead of DocCatVariable. - ObjectiveC is replaced by Objective-C in the docs. - Tests for preserve_most and preserve_all are combin

Re: [PATCH] D18025: Add attributes for preserve_mostcc/preserve_allcc calling conventions to the C/C++ front-end

swiftix added inline comments. Comment at: include/clang/Basic/Attr.td:1394 @@ -1393,1 +1393,3 @@ +def PreserveMost : InheritableAttr { + let Spellings = [GNU<"preserve_most">]; aaron.ballman wrote: > Do these attributes do anything on targets other than AArch6

Re: [PATCH] D18025: Add attributes for preserve_mostcc/preserve_allcc calling conventions to the C/C++ front-end

swiftix added a comment. Thanks for the hint about adding subscribers, because I was not aware it is possible in the Web-GUI. That was the reason why a new review was created. And thanks for the comments. I'll address your comments and upload the new patch for review. http://reviews.llvm.org/

Re: [PATCH] D18025: Add attributes for preserve_mostcc/preserve_allcc calling conventions to the C/C++ front-end

Hi Aaron, Hi Juergen, Could you review this simple patch? Is it OK to merge or are there any changes to be made? Thanks, Roman > On Mar 9, 2016, at 7:25 PM, Roman Levenstein wrote: > > swiftix created this revision. > swiftix added reviewers: ributzka, aaron.ballman. > swiftix added a subsc

Re: [PATCH] D17976: Add attributes for preserve_mostcc/preserve_allcc calling conventions to the C/C++ front-end

I resubmitted the patch as http://reviews.llvm.org/D18025 <http://reviews.llvm.org/D18025> and included the mailing list as a subscriber, so that the replies are not getting lost. Sorry for the inconvenience. -Roman > On Mar 8, 2016, at 5:44 PM, Roman Levenstein via cfe-commits

[PATCH] D18025: Add attributes for preserve_mostcc/preserve_allcc calling conventions to the C/C++ front-end

swiftix created this revision. swiftix added reviewers: ributzka, aaron.ballman. swiftix added a subscriber: cfe-commits. Herald added a subscriber: aemerson. Till now, preserve_mostcc/preserve_allcc calling convention attributes were only available at the LLVM IR level. This patch adds attribute

[PATCH] D17976: Add attributes for preserve_mostcc/preserve_allcc calling conventions to the C/C++ front-end

Forgot to add the mailing list when I created a patch.Begin forwarded message:From: Roman Levenstein Subject: [PATCH] D17976: Add attributes for preserve_mostcc/preserve_allcc calling conventions to the C/C++ front-endDate: March 8, 2016 at 5:17:02 PM PSTTo: rlevenst...@apple