This revision was automatically updated to reflect the committed changes.
Closed by commit rL26: Add WebKit brace style configuration option.
(authored by lifted).
Changed prior to commit:
http://reviews.llvm.org/D11837?vs=31660&id=31665#toc
Repository:
rL LLVM
http://reviews.llvm.org/D
Author: lifted
Date: Mon Aug 10 08:43:19 2015
New Revision: 26
URL: http://llvm.org/viewvc/llvm-project?rev=26&view=rev
Log:
Add WebKit brace style configuration option.
Summary:
Add brace style `BS_WebKit` as described on
https://www.webkit.org/coding/coding-style.html:
* Function defi
lifted added a comment.
I had commit access earlier, but I haven't tried it for long time. I'll ask for
help if there are any problems.
http://reviews.llvm.org/D11837
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi
lifted added a comment.
In http://reviews.llvm.org/D11837#220408, @klimek wrote:
> Can you also fix the current code in getWebKitStyle?
Yep, I've already done it.
http://reviews.llvm.org/D11837
___
cfe-commits mailing list
cfe-commits@lists.llvm.
lifted updated this revision to Diff 31660.
lifted added a comment.
Removed Qt brace style, add WebKit brace style.
Changed default brace style in the WebKit configuration to BS_WebKit.
http://reviews.llvm.org/D11837
Files:
docs/ClangFormatStyleOptions.rst
include/clang/Format/Format.h
l
lifted added a comment.
In http://reviews.llvm.org/D11837#220394, @klimek wrote:
> Webkit doesn't break for classes:
That's why we need to revert changes in UnwrappedLineParser.cpp.
The funny thing with WebKit style is that we don't need to add any logic to
deal with it, any style different fr
lifted added a comment.
Hooray, I've found the style I need - it's WebKit
https://www.webkit.org/coding/coding-style.html
So I believe there are other people waiting for the same style as me -
https://code.google.com/p/chromium/issues/detail?id=454958
How do you feel about renaming `BS_Qt` -> `
lifted added a comment.
> Hm, the referenced style guide doesn't say anything about namespaces.
You're right. Futhermore, it's hard to find any namespaces in qt repos at all -
Qt uses a macro for conditional compilation with namespaces.
> I also couldn't find anything in the qt source repo (ju
lifted created this revision.
lifted added a reviewer: djasper.
lifted added subscribers: cfe-commits, klimek.
Add Qt brace style as described on https://wiki.qt.io/Qt_Coding_Style :
* Use attached braces: the opening brace goes on the same line as the start of
the statement. If the closing br
