[lldb] [polly] [compiler-rt] [llvm] [libc] [libcxx] [clang-tools-extra] [openmp] [libcxxabi] [flang] [mlir] [clang] [mlir][vector] Fix invalid `LoadOp` indices being created (PR #76292)

2024-01-03 Thread Rik Huijzer via cfe-commits
rikhuijzer wrote: @joker-eph, thanks again for the review! https://github.com/llvm/llvm-project/pull/76292 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[lldb] [polly] [compiler-rt] [llvm] [libc] [libcxx] [clang-tools-extra] [openmp] [libcxxabi] [flang] [mlir] [clang] [mlir][vector] Fix invalid `LoadOp` indices being created (PR #76292)

2024-01-03 Thread Rik Huijzer via cfe-commits
https://github.com/rikhuijzer closed https://github.com/llvm/llvm-project/pull/76292 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [polly] [libc] [flang] [openmp] [compiler-rt] [clang] [libcxxabi] [llvm] [mlir] [libcxx] [lldb] [mlir][vector] Fix invalid `LoadOp` indices being created (PR #76292)

2024-01-02 Thread Rik Huijzer via cfe-commits
@@ -897,7 +921,8 @@ struct TransferOpConversion : public VectorToSCFPattern { } else { // It's safe to assume the mask buffer can be unpacked if the data // buffer was unpacked. -auto castedMaskType = *unpackOneDim(maskBufferType); +auto m

[clang-tools-extra] [polly] [libc] [flang] [openmp] [compiler-rt] [clang] [libcxxabi] [llvm] [mlir] [libcxx] [lldb] [mlir][vector] Fix invalid `LoadOp` indices being created (PR #76292)

2024-01-02 Thread Rik Huijzer via cfe-commits
https://github.com/rikhuijzer updated https://github.com/llvm/llvm-project/pull/76292 >From 0ff5a0ec09f7c26824bd90e6c7656222ee2448ae Mon Sep 17 00:00:00 2001 From: Rik Huijzer Date: Sat, 23 Dec 2023 16:32:27 +0100 Subject: [PATCH 1/3] [mlir][vector] Fix invalid `LoadOp` indices being created -

[openmp] [lldb] [flang] [clang-tools-extra] [compiler-rt] [mlir] [llvm] [polly] [libc] [libcxxabi] [libcxx] [clang] [mlir][vector] Fix invalid `LoadOp` indices being created (PR #76292)

2024-01-02 Thread Rik Huijzer via cfe-commits
https://github.com/rikhuijzer updated https://github.com/llvm/llvm-project/pull/76292 >From 0ff5a0ec09f7c26824bd90e6c7656222ee2448ae Mon Sep 17 00:00:00 2001 From: Rik Huijzer Date: Sat, 23 Dec 2023 16:32:27 +0100 Subject: [PATCH 1/2] [mlir][vector] Fix invalid `LoadOp` indices being created -

[compiler-rt] [flang] [mlir] [llvm] [clang-tools-extra] [clang] [mlir][vector] Fix invalid `LoadOp` indices being created (PR #76292)

2024-01-02 Thread Rik Huijzer via cfe-commits
@@ -897,7 +921,8 @@ struct TransferOpConversion : public VectorToSCFPattern { } else { // It's safe to assume the mask buffer can be unpacked if the data // buffer was unpacked. -auto castedMaskType = *unpackOneDim(maskBufferType); +auto m

[compiler-rt] [flang] [mlir] [llvm] [clang-tools-extra] [clang] [mlir][vector] Fix invalid `LoadOp` indices being created (PR #76292)

2024-01-02 Thread Rik Huijzer via cfe-commits
https://github.com/rikhuijzer updated https://github.com/llvm/llvm-project/pull/76292 >From 0ff5a0ec09f7c26824bd90e6c7656222ee2448ae Mon Sep 17 00:00:00 2001 From: Rik Huijzer Date: Sat, 23 Dec 2023 16:32:27 +0100 Subject: [PATCH 1/2] [mlir][vector] Fix invalid `LoadOp` indices being created -

[mlir] [flang] [clang] [compiler-rt] [llvm] [clang-tools-extra] [mlir][vector] Fix invalid `LoadOp` indices being created (PR #76292)

2024-01-01 Thread Rik Huijzer via cfe-commits
https://github.com/rikhuijzer edited https://github.com/llvm/llvm-project/pull/76292 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[mlir] [flang] [clang] [compiler-rt] [llvm] [clang-tools-extra] [mlir][vector] Fix invalid `LoadOp` indices being created (PR #76292)

2024-01-01 Thread Rik Huijzer via cfe-commits
https://github.com/rikhuijzer edited https://github.com/llvm/llvm-project/pull/76292 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[mlir] [flang] [clang] [compiler-rt] [llvm] [clang-tools-extra] [mlir][vector] Fix invalid `LoadOp` indices being created (PR #76292)

2024-01-01 Thread Rik Huijzer via cfe-commits
https://github.com/rikhuijzer edited https://github.com/llvm/llvm-project/pull/76292 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [mlir] [compiler-rt] [clang-tools-extra] [flang] [mlir][vector] Fix invalid `LoadOp` indices being created (PR #76292)

2024-01-01 Thread Rik Huijzer via cfe-commits
https://github.com/rikhuijzer updated https://github.com/llvm/llvm-project/pull/76292 >From 0ff5a0ec09f7c26824bd90e6c7656222ee2448ae Mon Sep 17 00:00:00 2001 From: Rik Huijzer Date: Sat, 23 Dec 2023 16:32:27 +0100 Subject: [PATCH] [mlir][vector] Fix invalid `LoadOp` indices being created ---

[mlir] [flang] [llvm] [compiler-rt] [libcxx] [clang-tools-extra] [clang] [mlir] Fix a zero stride canonicalizer crash (PR #74200)

2023-12-05 Thread Rik Huijzer via cfe-commits
https://github.com/rikhuijzer closed https://github.com/llvm/llvm-project/pull/74200 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[llvm] [libc] [mlir] [clang-tools-extra] [clang] [libcxx] [compiler-rt] [flang] [mlir][llvm] Fix verifier for const int and dense (PR #74340)

2023-12-05 Thread Rik Huijzer via cfe-commits
https://github.com/rikhuijzer closed https://github.com/llvm/llvm-project/pull/74340 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[compiler-rt] [libcxx] [clang-tools-extra] [flang] [libc] [mlir] [clang] [llvm] [mlir][llvm] Fix verifier for const int and dense (PR #74340)

2023-12-05 Thread Rik Huijzer via cfe-commits
https://github.com/rikhuijzer updated https://github.com/llvm/llvm-project/pull/74340 >From 47140903675a902a5803ef170bcd928783217a5f Mon Sep 17 00:00:00 2001 From: Rik Huijzer Date: Mon, 4 Dec 2023 16:57:08 +0100 Subject: [PATCH 1/4] [mlir][llvm] Fix verifier for const int --- mlir/lib/Dialec

[mlir] [llvm] [clang] [flang] [compiler-rt] [clang-tools-extra] [libcxx] [mlir] Fix a zero stride canonicalizer crash (PR #74200)

2023-12-05 Thread Rik Huijzer via cfe-commits
https://github.com/rikhuijzer edited https://github.com/llvm/llvm-project/pull/74200 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[mlir] [llvm] [clang] [flang] [compiler-rt] [clang-tools-extra] [libcxx] [mlir] Fix a zero stride canonicalizer crash (PR #74200)

2023-12-05 Thread Rik Huijzer via cfe-commits
https://github.com/rikhuijzer edited https://github.com/llvm/llvm-project/pull/74200 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[flang] [mlir] [compiler-rt] [clang-tools-extra] [clang] [libcxx] [llvm] [mlir] Fix a zero stride canonicalizer crash (PR #74200)

2023-12-05 Thread Rik Huijzer via cfe-commits
@@ -0,0 +1,14 @@ +// RUN: mlir-opt %s -inline -split-input-file | FileCheck %s + +// CHECK-LABEL: func @inline_negative_stride +func.func @inline_negative_stride(%arg0 : memref<10xf32>) -> memref<1xf32, strided<[?], offset: 1>> { + cf.br ^bb1(%arg0 : memref<10xf32>) +^bb1(%m: me

[flang] [mlir] [compiler-rt] [clang-tools-extra] [clang] [libcxx] [llvm] [mlir] Fix a zero stride canonicalizer crash (PR #74200)

2023-12-05 Thread Rik Huijzer via cfe-commits
https://github.com/rikhuijzer updated https://github.com/llvm/llvm-project/pull/74200 >From 22928e7e5da508d8d9dc8d4b7e54f84cccadef06 Mon Sep 17 00:00:00 2001 From: Rik Huijzer Date: Mon, 20 Nov 2023 09:02:41 +0100 Subject: [PATCH 1/6] [mlir][tensor] Fix canon via `hasNegativeDimension` --- ml

[libcxx] [clang] [llvm] [mlir] [compiler-rt] [flang] [clang-tools-extra] [mlir] Fix a zero stride canonicalizer crash (PR #74200)

2023-12-03 Thread Rik Huijzer via cfe-commits
rikhuijzer wrote: > Is it possible to add the test case (or minimal similar example) with > `--inline` option so that we can confirm the original issue is resolved. > > #73383 Thanks for the review and fixing the typos that I've made! I've added a test in a new `MemRef/inlining.mlir` file, wh

[libcxx] [clang] [llvm] [mlir] [compiler-rt] [flang] [clang-tools-extra] [mlir] Fix a zero stride canonicalizer crash (PR #74200)

2023-12-03 Thread Rik Huijzer via cfe-commits
https://github.com/rikhuijzer updated https://github.com/llvm/llvm-project/pull/74200 >From 22928e7e5da508d8d9dc8d4b7e54f84cccadef06 Mon Sep 17 00:00:00 2001 From: Rik Huijzer Date: Mon, 20 Nov 2023 09:02:41 +0100 Subject: [PATCH 1/7] [mlir][tensor] Fix canon via `hasNegativeDimension` --- ml

[clang-tools-extra] [mlir] [llvm] [clang] [mlir] Fix a zero stride canonicalizer crash (PR #74200)

2023-12-03 Thread Rik Huijzer via cfe-commits
https://github.com/rikhuijzer updated https://github.com/llvm/llvm-project/pull/74200 >From 22928e7e5da508d8d9dc8d4b7e54f84cccadef06 Mon Sep 17 00:00:00 2001 From: Rik Huijzer Date: Mon, 20 Nov 2023 09:02:41 +0100 Subject: [PATCH 1/6] [mlir][tensor] Fix canon via `hasNegativeDimension` --- ml

[clang] [clang-tools-extra] [llvm] [mlir] [mlir] Fix a zero stride canonicalizer crash (PR #74200)

2023-12-02 Thread Rik Huijzer via cfe-commits
https://github.com/rikhuijzer created https://github.com/llvm/llvm-project/pull/74200 This PR fixes https://github.com/llvm/llvm-project/issues/73383 and is another shot at the refactoring proposed in https://github.com/llvm/llvm-project/pull/72885. >From 22928e7e5da508d8d9dc8d4b7e54f84cccade

[mlir] [libc] [llvm] [openmp] [lldb] [libcxx] [clang] [lld] [flang] [clang-tools-extra] [compiler-rt] [mlir][async] Avoid crash when not using `func.func` (PR #72801)

2023-11-20 Thread Rik Huijzer via cfe-commits
https://github.com/rikhuijzer closed https://github.com/llvm/llvm-project/pull/72801 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[llvm] [clang-tools-extra] [openmp] [libc] [compiler-rt] [clang] [lld] [flang] [libcxx] [mlir] [lldb] [mlir][async] Avoid crash when not using `func.func` (PR #72801)

2023-11-20 Thread Rik Huijzer via cfe-commits
https://github.com/rikhuijzer updated https://github.com/llvm/llvm-project/pull/72801 >From 8abbf36f741c8363155e0f3cbf2450ff7f1f0801 Mon Sep 17 00:00:00 2001 From: Rik Huijzer Date: Sun, 19 Nov 2023 18:31:38 +0100 Subject: [PATCH 1/3] [mlir][async] Avoid crash when not using `func.func` --- .

[llvm] [lld] [lldb] [compiler-rt] [mlir] [clang] [flang] [libcxx] [mlir][async] Avoid crash when not using `func.func` (PR #72801)

2023-11-20 Thread Rik Huijzer via cfe-commits
@@ -1143,6 +1143,8 @@ void OpEmitter::genAttrNameGetters() { const char *const getAttrName = R"( assert(index < {0} && "invalid attribute index"); assert(name.getStringRef() == getOperationName() && "invalid operation name"); + assert(!name.getAttributeNames().empty

[llvm] [lld] [lldb] [compiler-rt] [mlir] [clang] [flang] [libcxx] [mlir][async] Avoid crash when not using `func.func` (PR #72801)

2023-11-20 Thread Rik Huijzer via cfe-commits
https://github.com/rikhuijzer updated https://github.com/llvm/llvm-project/pull/72801 >From 8abbf36f741c8363155e0f3cbf2450ff7f1f0801 Mon Sep 17 00:00:00 2001 From: Rik Huijzer Date: Sun, 19 Nov 2023 18:31:38 +0100 Subject: [PATCH 1/3] [mlir][async] Avoid crash when not using `func.func` --- .

[compiler-rt] [clang-tools-extra] [clang] [llvm] [mlir] [flang] [mlir] Verify non-negative `offset` and `size` (PR #72059)

2023-11-15 Thread Rik Huijzer via cfe-commits
https://github.com/rikhuijzer closed https://github.com/llvm/llvm-project/pull/72059 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[llvm] [flang] [clang] [mlir] [compiler-rt] [clang-tools-extra] [mlir] Verify non-negative `offset` and `size` (PR #72059)

2023-11-14 Thread Rik Huijzer via cfe-commits
https://github.com/rikhuijzer edited https://github.com/llvm/llvm-project/pull/72059 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[mlir] [llvm] [clang] [flang] [compiler-rt] [clang-tools-extra] [mlir] Verify non-negative `offset` and `size` (PR #72059)

2023-11-14 Thread Rik Huijzer via cfe-commits
rikhuijzer wrote: > Both options are correct, but they should be consistent. Not folding negative > dimension seems like a straightforward thing I think? After finding the right minimal reproducer, it was yes. Thanks. I've updated the first comment of this PR now that folding on negative dime

[mlir] [llvm] [clang] [flang] [compiler-rt] [clang-tools-extra] [mlir] Verify non-negative `offset` and `size` (PR #72059)

2023-11-14 Thread Rik Huijzer via cfe-commits
https://github.com/rikhuijzer edited https://github.com/llvm/llvm-project/pull/72059 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-tools-extra] [compiler-rt] [llvm] [flang] [mlir] [mlir] Verify non-negative `offset` and `size` (PR #72059)

2023-11-14 Thread Rik Huijzer via cfe-commits
https://github.com/rikhuijzer updated https://github.com/llvm/llvm-project/pull/72059 >From 8f90ae9113229faf5ab4b859e5c70f23853f4db8 Mon Sep 17 00:00:00 2001 From: Rik Huijzer Date: Sat, 11 Nov 2023 20:43:31 +0100 Subject: [PATCH 01/12] [mlir][memref] Verify subview offsets and sizes --- mlir

[compiler-rt] [clang-tools-extra] [clang] [llvm] [mlir] [mlir][tensor] Document `dest` operand (PR #71726)

2023-11-13 Thread Rik Huijzer via cfe-commits
https://github.com/rikhuijzer closed https://github.com/llvm/llvm-project/pull/71726 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[flang] [mlir] [clang] [compiler-rt] [llvm] [clang-tools-extra] [mlir] Verify non-negative `offset` and `size` (PR #72059)

2023-11-13 Thread Rik Huijzer via cfe-commits
https://github.com/rikhuijzer updated https://github.com/llvm/llvm-project/pull/72059 >From 8f90ae9113229faf5ab4b859e5c70f23853f4db8 Mon Sep 17 00:00:00 2001 From: Rik Huijzer Date: Sat, 11 Nov 2023 20:43:31 +0100 Subject: [PATCH 01/11] [mlir][memref] Verify subview offsets and sizes --- mlir

[flang] [mlir] [clang] [compiler-rt] [llvm] [clang-tools-extra] [mlir] Verify non-negative `offset` and `size` (PR #72059)

2023-11-13 Thread Rik Huijzer via cfe-commits
https://github.com/rikhuijzer updated https://github.com/llvm/llvm-project/pull/72059 >From 8f90ae9113229faf5ab4b859e5c70f23853f4db8 Mon Sep 17 00:00:00 2001 From: Rik Huijzer Date: Sat, 11 Nov 2023 20:43:31 +0100 Subject: [PATCH 01/10] [mlir][memref] Verify subview offsets and sizes --- mlir

[compiler-rt] [clang] [clang-tools-extra] [llvm] [mlir] [mlir][tensor] Document `dest` operand (PR #71726)

2023-11-13 Thread Rik Huijzer via cfe-commits
https://github.com/rikhuijzer updated https://github.com/llvm/llvm-project/pull/71726 >From 3f34a440abef46c5c6280fdcdf0c29e05dda4565 Mon Sep 17 00:00:00 2001 From: Rik Huijzer Date: Wed, 8 Nov 2023 20:10:41 +0100 Subject: [PATCH 1/5] [mlir][tensor] Document `dest` operand --- .../mlir/Dialect

[flang] [clang] [clang-tools-extra] [mlir] [compiler-rt] [llvm] [mlir] Verify non-negative `offset` and `size` (PR #72059)

2023-11-13 Thread Rik Huijzer via cfe-commits
https://github.com/rikhuijzer edited https://github.com/llvm/llvm-project/pull/72059 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[flang] [clang] [clang-tools-extra] [mlir] [compiler-rt] [llvm] [mlir] Verify non-negative `offset` or `size` (PR #72059)

2023-11-13 Thread Rik Huijzer via cfe-commits
https://github.com/rikhuijzer edited https://github.com/llvm/llvm-project/pull/72059 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[compiler-rt] [llvm] [mlir] [clang] [flang] [clang-tools-extra] [mlir] Verify non-negative `offset` or `size` (PR #72059)

2023-11-13 Thread Rik Huijzer via cfe-commits
https://github.com/rikhuijzer edited https://github.com/llvm/llvm-project/pull/72059 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[compiler-rt] [llvm] [mlir] [clang] [flang] [clang-tools-extra] [mlir][memref] Detect negative `offset` or `size` (PR #72059)

2023-11-13 Thread Rik Huijzer via cfe-commits
https://github.com/rikhuijzer edited https://github.com/llvm/llvm-project/pull/72059 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[compiler-rt] [llvm] [mlir] [clang] [flang] [clang-tools-extra] [mlir][memref] Detect negative `offset` or `size` for `subview` (PR #72059)

2023-11-13 Thread Rik Huijzer via cfe-commits
@@ -2842,8 +2851,18 @@ static LogicalResult produceSubViewErrorMsg(SliceVerificationResult result, llvm_unreachable("unexpected subview verification result"); } -/// Verifier for SubViewOp. LogicalResult SubViewOp::verify() { + for (int64_t offset : getStaticOffsets()) {

[flang] [clang] [clang-tools-extra] [mlir] [compiler-rt] [llvm] [mlir][memref] Detect negative `offset` or `size` for `subview` (PR #72059)

2023-11-13 Thread Rik Huijzer via cfe-commits
@@ -2621,6 +2621,15 @@ Type SubViewOp::inferResultType(MemRefType sourceMemRefType, dispatchIndexOpFoldResults(offsets, dynamicOffsets, staticOffsets); dispatchIndexOpFoldResults(sizes, dynamicSizes, staticSizes); dispatchIndexOpFoldResults(strides, dynamicStrides, stati

[flang] [clang] [clang-tools-extra] [mlir] [compiler-rt] [llvm] [mlir][memref] Detect negative `offset` or `size` for `subview` (PR #72059)

2023-11-13 Thread Rik Huijzer via cfe-commits
https://github.com/rikhuijzer updated https://github.com/llvm/llvm-project/pull/72059 >From 8f90ae9113229faf5ab4b859e5c70f23853f4db8 Mon Sep 17 00:00:00 2001 From: Rik Huijzer Date: Sat, 11 Nov 2023 20:43:31 +0100 Subject: [PATCH 1/9] [mlir][memref] Verify subview offsets and sizes --- mlir/l

[mlir] [llvm] [clang-tools-extra] [compiler-rt] [clang] [mlir][tensor] Document `dest` operand (PR #71726)

2023-11-13 Thread Rik Huijzer via cfe-commits
https://github.com/rikhuijzer updated https://github.com/llvm/llvm-project/pull/71726 >From 3f34a440abef46c5c6280fdcdf0c29e05dda4565 Mon Sep 17 00:00:00 2001 From: Rik Huijzer Date: Wed, 8 Nov 2023 20:10:41 +0100 Subject: [PATCH 1/4] [mlir][tensor] Document `dest` operand --- .../mlir/Dialect

[mlir] [llvm] [flang] [clang-tools-extra] [compiler-rt] [clang] [mlir][memref] Detect negative `offset` or `size` for `subview` (PR #72059)

2023-11-13 Thread Rik Huijzer via cfe-commits
https://github.com/rikhuijzer updated https://github.com/llvm/llvm-project/pull/72059 >From 8f90ae9113229faf5ab4b859e5c70f23853f4db8 Mon Sep 17 00:00:00 2001 From: Rik Huijzer Date: Sat, 11 Nov 2023 20:43:31 +0100 Subject: [PATCH 1/8] [mlir][memref] Verify subview offsets and sizes --- mlir/l

[clang] [mlir] Verify TestBuiltinAttributeInterfaces eltype (PR #69878)

2023-10-23 Thread Rik Huijzer via cfe-commits
https://github.com/rikhuijzer closed https://github.com/llvm/llvm-project/pull/69878 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [mlir] Verify TestBuiltinAttributeInterfaces eltype (PR #69878)

2023-10-23 Thread Rik Huijzer via cfe-commits
https://github.com/rikhuijzer closed https://github.com/llvm/llvm-project/pull/69878 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [mlir] Verify TestBuiltinAttributeInterfaces eltype (PR #69878)

2023-10-22 Thread Rik Huijzer via cfe-commits
https://github.com/rikhuijzer created https://github.com/llvm/llvm-project/pull/69878 Fixes https://github.com/llvm/llvm-project/issues/61871. This PR fixes two small things. First and foremost, it throws a clear error in the `-test-elements-attr-interface` when those tests are called on eleme

[clang] [mlir][arith] Fix canon pattern for large ints in chained arith (PR #68900)

2023-10-13 Thread Rik Huijzer via cfe-commits
@@ -39,26 +39,29 @@ using namespace mlir::arith; static IntegerAttr applyToIntegerAttrs(PatternRewriter &builder, Value res, Attribute lhs, Attribute rhs, -function_ref binFn) { - return builder.getIntegerAttr(res.getType(), -

[clang] [mlir][arith] Fix canon pattern for large ints in chained arith (PR #68900)

2023-10-13 Thread Rik Huijzer via cfe-commits
https://github.com/rikhuijzer updated https://github.com/llvm/llvm-project/pull/68900 >From ddbde18e483d12485ba25c715e8a94480b9d6dcf Mon Sep 17 00:00:00 2001 From: Rik Huijzer Date: Thu, 12 Oct 2023 16:55:22 +0200 Subject: [PATCH 1/4] [mlir][arith] Fix canon pattern for large ints in chained a

[clang] [mlir][arith] Fix canon pattern for large ints in chained arith (PR #68900)

2023-10-13 Thread Rik Huijzer via cfe-commits
https://github.com/rikhuijzer updated https://github.com/llvm/llvm-project/pull/68900 >From ddbde18e483d12485ba25c715e8a94480b9d6dcf Mon Sep 17 00:00:00 2001 From: Rik Huijzer Date: Thu, 12 Oct 2023 16:55:22 +0200 Subject: [PATCH 1/3] [mlir][arith] Fix canon pattern for large ints in chained a

[clang] [mlir][llvm] Fix elem type passing into `getelementptr` (PR #68136)

2023-10-05 Thread Rik Huijzer via cfe-commits
rikhuijzer wrote: Thanks both for the review and clarifications. I'm learning a lot. https://github.com/llvm/llvm-project/pull/68136 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [mlir][llvm] Fix elem type passing into `getelementptr` (PR #68136)

2023-10-05 Thread Rik Huijzer via cfe-commits
https://github.com/rikhuijzer closed https://github.com/llvm/llvm-project/pull/68136 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [mlir][llvm] Fix elem type passing into `getelementptr` (PR #68136)

2023-10-04 Thread Rik Huijzer via cfe-commits
rikhuijzer wrote: > [...] I am a bit afraid of the burden of having to maintain what is > essentially a third GEP representation. Thanks for the explanation @zero9178. I am affraid I do not fully understand your reasoning (most likely due to a lack of knowledge on my side). However, it sounds

[clang] [mlir][llvm] Fix elem type passing into `getelementptr` (PR #68136)

2023-10-04 Thread Rik Huijzer via cfe-commits
rikhuijzer wrote: > What are the use cases for allowing either of these two syntaxes? > The LLVM Dialect tries to closely mirror LLVM proper as much as possible and > this would deviate from LLVMs behaviour. While the transition is currently > stalled, in the future typed pointers will be remov

[clang] [mlir][llvm] Fix elem type passing into `getelementptr` (PR #68136)

2023-10-03 Thread Rik Huijzer via cfe-commits
https://github.com/rikhuijzer updated https://github.com/llvm/llvm-project/pull/68136 >From 57ec61b03b4c54164f40be996b1d57420f2d4a2c Mon Sep 17 00:00:00 2001 From: Rik Huijzer Date: Tue, 3 Oct 2023 19:31:03 +0200 Subject: [PATCH] [mlir][llvm] Fix elem type passing into `getelementptr` --- mli