https://github.com/rnk approved this pull request.
Yep, feel free to reland this.
https://github.com/llvm/llvm-project/pull/140910
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/rnk approved this pull request.
Wow. Thanks for debugging it! I assumed this had more to do with intrin0.h than
the namespaces in the libc++ string header.
https://github.com/llvm/llvm-project/pull/142019
___
cfe-commits mailing lis
rnk wrote:
(This is mostly written wearing my "Googler" hat, not the clang area team lead
hat)
There's been a lot of discussion of what the exact use case is. I think it's
helpful to share the context that Google essentially uses Clang header modules
to wrap generated proto headers, and this
https://github.com/rnk approved this pull request.
Thanks!
https://github.com/llvm/llvm-project/pull/138562
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -6009,6 +6009,8 @@ def note_not_found_by_two_phase_lookup : Note<"%0 should
be declared prior to th
def err_undeclared_use : Error<"use of undeclared %0">;
def warn_deprecated : Warning<"%0 is deprecated">,
InGroup;
+def warn_deprecated_switch_case : Warning<"%0 is depr
rnk wrote:
> I think silencing the warning is better than suggesting a default case, which
> may not be considered good practice.
I'm not sure, I think our perspectives as compiler people might be a bit off
base. We're always forming closed algebraic sum types, like variants, AST
nodes, that
https://github.com/rnk edited https://github.com/llvm/llvm-project/pull/138562
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/rnk commented:
I'm OK with this, but I feel like this is creating scope creep. Now we have a
special Wdeprecated-declarations carveouts for switches, but if you unpack the
switch into if / else chain comparisons, you get deprecation warnings. Should
we disable deprecation wa
@@ -6767,6 +6767,9 @@ class Sema final : public SemaBase {
};
std::optional DelayedDefaultInitializationContext;
+/// Whether evaluating an expression for a switch case label.
rnk wrote:
supernit: pack it with the contextual bools above, for both
https://github.com/rnk approved this pull request.
Nice, looks good, thanks for implementing this!
https://github.com/llvm/llvm-project/pull/138205
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/
@@ -1825,6 +1825,11 @@ class Sema final : public SemaBase {
/// Set of no-builtin functions listed by \#pragma function.
llvm::SmallSetVector MSFunctionNoBuiltins;
+ /// Map of BuiltinIDs to source locations that have #pragma intrinsic calls
+ /// that refer to them.
+
https://github.com/rnk commented:
Thanks!
https://github.com/llvm/llvm-project/pull/138205
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/rnk edited https://github.com/llvm/llvm-project/pull/138205
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
rnk wrote:
Sorry to hear about the issue. I think the way this is supposed to work is that
the clang frontend target ABIInfo is supposed to carefully construct struct
types that cause the backend to pass the C struct type correctly in registers
and memory. See for example clang/lib/CodeGen/Tar
https://github.com/rnk approved this pull request.
This looks good, but I'd give it another day to give other reviewers an
opportunity to comment.
https://github.com/llvm/llvm-project/pull/139614
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
rnk wrote:
> Or we think no one else does this anchor business, and in that case... why
> are we doing it?
Anchoring debug information out of a header and into a .cpp file can be a
powerful optimization. I added a key method to Sema in
586f65d31f32ca6bc8cfdb8a4f61bee5057bf6c8 and it resulted
@@ -710,4 +710,17 @@ void AnnotateIgnoreWritesEnd(const char *file, int line);
#define LLVM_PREFERRED_TYPE(T)
#endif
+/// \macro LLVM_VIRTUAL_ANCHOR_FUNCTION
+/// This macro is used to adhere to LLVM's policy that each class with a vtable
+/// must have at least one out-of-lin
https://github.com/rnk commented:
I thought we'd have more anchors, honestly. Maybe these are just the overriding
ones.
https://github.com/llvm/llvm-project/pull/139614
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi
https://github.com/rnk edited https://github.com/llvm/llvm-project/pull/139614
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -304,7 +304,7 @@ getCodeModel(const CodeGenOptions &CodeGenOpts) {
.Case("kernel", llvm::CodeModel::Kernel)
.Case("medium", llvm::CodeModel::Medium)
.Case("large", llvm::CodeModel::Large)
-
@@ -138,6 +138,12 @@ let Attributes = [Const, NoThrow,
RequiredVectorWidth<256>], Features = "avx" in
}
}
+// PRFCHW
+let Features = "prfchw", Header = "intrin.h", Attributes = [NoThrow, Const] in
{
rnk wrote:
Looks like I actually had a pending change to
https://github.com/rnk updated https://github.com/llvm/llvm-project/pull/138360
Rate limit · GitHub
body {
background-color: #f6f8fa;
color: #24292e;
font-family: -apple-system,BlinkMacSystemFont,Segoe
UI,Helvetica,Arial,sans-serif,
https://github.com/rnk updated https://github.com/llvm/llvm-project/pull/138360
Rate limit · GitHub
body {
background-color: #f6f8fa;
color: #24292e;
font-family: -apple-system,BlinkMacSystemFont,Segoe
UI,Helvetica,Arial,sans-serif,
https://github.com/rnk closed https://github.com/llvm/llvm-project/pull/138613
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
rnk wrote:
I hacked together a workaround here:
https://github.com/llvm/llvm-project/pull/138613
I'm mostly just guessing remotely, since I don't have a reliable repro, that
the final PerformPending... event is rounding into the previous event group
that just ended. If the JSON encodes this n
00:00:00 2001
From: Reid Kleckner
Date: Mon, 5 May 2025 23:18:24 +
Subject: [PATCH] [clang] Deflake the TimeProfile support tests
These tests have been flaky since they were merged into the
AllClangUnitTests binary, but the flakiness is inherent to the nature of
timer-based tests.
---
cl
https://github.com/rnk commented:
Thanks! I think this is sufficiently niche that we don't need a flag flip to
manage the diagnostic change fallout.
https://github.com/llvm/llvm-project/pull/138562
___
cfe-commits mailing list
cfe-commits@lists.llvm.o
@@ -15,7 +15,7 @@ enum SwitchTwo {
};
void testSwitchTwo(enum SwitchTwo st) {
- switch (st) {} // expected-warning{{enumeration values 'Vim' and 'Emacs' not
handled in switch}}
+ switch (st) {} // expected-warning{{enumeration values 'Ed', 'Vim' and
'Emacs' not handled in
https://github.com/rnk edited https://github.com/llvm/llvm-project/pull/138562
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Markus =?utf-8?q?Gschoßmann?= ,
Markus =?utf-8?q?Gschoßmann?= ,
Markus =?utf-8?q?Gschoßmann?= ,
Markus =?utf-8?q?Gschoßmann?=
Message-ID:
In-Reply-To:
rnk wrote:
I attempted to reapply this patch, but the BPF test which I added fails with
this test for reasons I don't understand. @mgschossman
https://github.com/rnk approved this pull request.
https://github.com/llvm/llvm-project/pull/138251
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
rnk wrote:
> follow what we did for _m_prefetchw, but it seems the same idea was tried
> there but that was also reverted for what seems to be the same exact problem.
> See https://github.com/llvm/llvm-project/pull/115099 and revert
> [here](https://github.com/llvm/llvm-project/commit/83ff9d4a
@@ -138,6 +142,12 @@ let Attributes = [Const, NoThrow,
RequiredVectorWidth<256>], Features = "avx" in
}
}
+// PRFCHW
+let Features = "prfchw", Header = "x86intrin.h", Attributes = [NoThrow, Const]
in {
+ def _m_prefetch : X86LibBuiltin<"void(void *)">;
rn
https://github.com/rnk created https://github.com/llvm/llvm-project/pull/138360
This reverts commit 83ff9d4a34b1e579dd809759d13b70b8837f0cde.
Don't change the builtin signature of _mm_prefetch this time.
>From 7da648bdd03a2fce7ab214f0425efb3a1ec1f4fe Mon Sep 17 00:00:00 2001
Fr
rnk wrote:
> FWIW, I'm seeing the test failure on Windows x64 with a debug build of
> Clang's unit tests as of a fresh fetch of main this morning.
Sorry about that! I leaned on the Windows premerge tests to find Windows issues
(they did, that was useful), but I'm pretty sure it uses release, n
rnk wrote:
Are the `CodeGenTest.TestNonAlterTest` failures still an issue? I don't see
that failure on any bots. I haven't gotten any reports.
https://github.com/llvm/llvm-project/pull/134196
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
htt
https://github.com/rnk closed https://github.com/llvm/llvm-project/pull/138021
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/rnk approved this pull request.
https://github.com/llvm/llvm-project/pull/136046
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
rnk wrote:
> `BasicTests` and `FormatTests` had fairly few deps (they didn't need Sema
> etc) and compiled much fewer files than they presumably now do. Does it make
> sense to keep those as distinct binaries?
FormatTests has many clang dependencies, but after rebuilding, it looks like
it's s
rnk wrote:
I disabled the failing test in 743c32eb8195c248c699c61ffbac141947b8e6ab.
https://github.com/llvm/llvm-project/pull/134196
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: Reid Kleckner
Date: 2025-04-29T11:27:58-07:00
New Revision: 743c32eb8195c248c699c61ffbac141947b8e6ab
URL:
https://github.com/llvm/llvm-project/commit/743c32eb8195c248c699c61ffbac141947b8e6ab
DIFF:
https://github.com/llvm/llvm-project/commit/743c32eb8195c248c699c61ffbac141947b8e6ab.diff
rnk wrote:
I attempted to repro on my macbook, but it doesn't reproduce. This test doesn't
seem high value, and I thin kthe right next step is to disable it to green the
bots before debugging it.
https://github.com/llvm/llvm-project/pull/134196
___
c
https://github.com/rnk closed https://github.com/llvm/llvm-project/pull/134196
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
rnk wrote:
If anyone is looking for stories about the value of premerge testing, I was all
set to push this tonight, but I saw the linux premerge test failure. I debugged
it, and it turns out to be a subtle interaction where if you run Clang codegen
with registered targets but no registered Ta
https://github.com/rnk updated https://github.com/llvm/llvm-project/pull/134196
>From 528be44ebae8ea5cd7f23c51ad11c314a73f152b Mon Sep 17 00:00:00 2001
From: Reid Kleckner
Date: Fri, 28 Mar 2025 22:11:05 -0700
Subject: [PATCH 1/9] [clang] Merge gtest binaries into AllClangUnitTests
T
https://github.com/rnk updated https://github.com/llvm/llvm-project/pull/134196
>From 528be44ebae8ea5cd7f23c51ad11c314a73f152b Mon Sep 17 00:00:00 2001
From: Reid Kleckner
Date: Fri, 28 Mar 2025 22:11:05 -0700
Subject: [PATCH 1/8] [clang] Merge gtest binaries into AllClangUnitTests
T
Author: Reid Kleckner
Date: 2025-04-26T09:17:56-07:00
New Revision: ccdd55c518277d749eff878ffcb5ca3de55c2a60
URL:
https://github.com/llvm/llvm-project/commit/ccdd55c518277d749eff878ffcb5ca3de55c2a60
DIFF:
https://github.com/llvm/llvm-project/commit/ccdd55c518277d749eff878ffcb5ca3de55c2a60.diff
https://github.com/rnk closed https://github.com/llvm/llvm-project/pull/134930
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
rnk wrote:
> I wonder if we can do this check statically instead.
I'm not sure I follow, what do you mean by "statically" in this context?
https://github.com/llvm/llvm-project/pull/137411
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https:/
https://github.com/rnk closed https://github.com/llvm/llvm-project/pull/137411
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
.
Disable these tests if shared libraries are involved. Another way to
make these tests work would be to update the loader search path
environment variables, but it is difficult to do that portably.
>From c2c8d11f82c384c35f422427f64173eef5332776 Mon Sep 17 00:00:00 2001
From: Reid Kleckner
Date: Fri,
https://github.com/rnk updated https://github.com/llvm/llvm-project/pull/134196
>From 528be44ebae8ea5cd7f23c51ad11c314a73f152b Mon Sep 17 00:00:00 2001
From: Reid Kleckner
Date: Fri, 28 Mar 2025 22:11:05 -0700
Subject: [PATCH 1/8] [clang] Merge gtest binaries into AllClangUnitTests
T
@@ -304,7 +304,7 @@ getCodeModel(const CodeGenOptions &CodeGenOpts) {
.Case("kernel", llvm::CodeModel::Kernel)
.Case("medium", llvm::CodeModel::Medium)
.Case("large", llvm::CodeModel::Large)
-
rnk wrote:
Ping, WDYT?
https://github.com/llvm/llvm-project/pull/134196
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/rnk closed https://github.com/llvm/llvm-project/pull/137079
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
rnk wrote:
Sure, but winnt.h declares and uses tons of x86 intrinsics already, and we have
a way to make this work. Let me go look at what we did for `_m_prefetchw` and
see if we can apply that here.
We want to do something similar to a default-error-warning, where system
headers like winnt.h
Markus =?utf-8?q?Gschoßmann?= ,
Markus =?utf-8?q?Gschoßmann?= ,
Markus =?utf-8?q?Gschoßmann?= ,
Markus =?utf-8?q?Gschoßmann?=
Message-ID:
In-Reply-To:
rnk wrote:
> the issue still repros for me with this change reverted.
This was actually user error on my side, after messing around a bit I wa
https://github.com/rnk edited https://github.com/llvm/llvm-project/pull/136046
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -0,0 +1,127 @@
+//===--- RunOnNewStack.cpp - Crash Recovery
---===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
https://github.com/rnk approved this pull request.
If we ever generalize this, it would make sense to have a standalone .s /.asm
file in the build.
https://github.com/llvm/llvm-project/pull/136046
___
cfe-commits mailing list
cfe-commits@lists.llvm.or
https://github.com/rnk updated https://github.com/llvm/llvm-project/pull/137079
>From e78b8012376798746b5cf4d664e656e22591acdb Mon Sep 17 00:00:00 2001
From: Reid Kleckner
Date: Wed, 23 Apr 2025 22:29:22 +
Subject: [PATCH 1/3] [BPF] Fix issues with external declarations of C++
struc
Markus =?utf-8?q?Gscho=C3=9Fmann?= ,
Markus =?utf-8?q?Gscho=C3=9Fmann?= ,
Markus =?utf-8?q?Gscho=C3=9Fmann?= ,
Markus =?utf-8?q?Gscho=C3=9Fmann?=
Message-ID:
In-Reply-To:
rnk wrote:
We should be able to reland after #137079 lands
https://github.com/llvm/llvm-project/pull/130674
__
declarations.
This fixes issues reported on #130674 by @lexi-nadia .
>From e78b8012376798746b5cf4d664e656e22591acdb Mon Sep 17 00:00:00 2001
From: Reid Kleckner
Date: Wed, 23 Apr 2025 22:29:22 +
Subject: [PATCH 1/2] [BPF] Fix issues with external declarations of C++
structor decls
Use GetAddrOfGlo
Author: Reid Kleckner
Date: 2025-04-23T22:30:44Z
New Revision: 0e0a1665fa340b9f1934d12aff818064aaf289ef
URL:
https://github.com/llvm/llvm-project/commit/0e0a1665fa340b9f1934d12aff818064aaf289ef
DIFF:
https://github.com/llvm/llvm-project/commit/0e0a1665fa340b9f1934d12aff818064aaf289ef.diff
LOG
Markus =?utf-8?q?Gschoßmann?= ,
Markus =?utf-8?q?Gschoßmann?= ,
Markus =?utf-8?q?Gschoßmann?= ,
Markus =?utf-8?q?Gschoßmann?=
Message-ID:
In-Reply-To:
rnk wrote:
The actual underlying issue appears to come from ae0d224 / #91310 , which
added `CodeGenModule::EmitExternalFunctionDeclaration`,
Author: Reid Kleckner
Date: 2025-04-23T22:09:02Z
New Revision: cd826d6e840ed33ad88458c862da5f9fcc6e908c
URL:
https://github.com/llvm/llvm-project/commit/cd826d6e840ed33ad88458c862da5f9fcc6e908c
DIFF:
https://github.com/llvm/llvm-project/commit/cd826d6e840ed33ad88458c862da5f9fcc6e908c.diff
LOG
Markus =?utf-8?q?Gschoßmann?= ,
Markus =?utf-8?q?Gschoßmann?= ,
Markus =?utf-8?q?Gschoßmann?= ,
Markus =?utf-8?q?Gschoßmann?=
Message-ID:
In-Reply-To:
rnk wrote:
Hm, reverting this change doesn't fix the verifier error, the issue still
repros for me with this change reverted. Are we sure this
Markus =?utf-8?q?Gschoßmann?= ,
Markus =?utf-8?q?Gschoßmann?= ,
Markus =?utf-8?q?Gschoßmann?= ,
Markus =?utf-8?q?Gschoßmann?=
Message-ID:
In-Reply-To:
rnk wrote:
Thanks!
It looks like the new IR after this change doesn't pass verification, and
presumably this causes the crash later:
```
$ cl
https://github.com/rnk approved this pull request.
Thanks, I think this is a good direction.
https://github.com/llvm/llvm-project/pull/128222
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-co
https://github.com/rnk approved this pull request.
Thanks, looks good to me!
I wanted to add llvm-cxxfilt to the test to confirm these all demnagle to
something readable, but I see it doesn't work on Microsoft symbols today, which
is unfortunate. The code I want is on github in @nico's
https:
https://github.com/rnk approved this pull request.
https://github.com/llvm/llvm-project/pull/136154
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/rnk approved this pull request.
Is this ready to go? I can't recall if we ultimately accepted the RFC.
https://github.com/llvm/llvm-project/pull/118026
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cg
Markus =?utf-8?q?Gscho=C3=9Fmann?= ,
Markus =?utf-8?q?Gscho=C3=9Fmann?= ,
Markus =?utf-8?q?Gscho=C3=9Fmann?= ,
Markus =?utf-8?q?Gscho=C3=9Fmann?=
Message-ID:
In-Reply-To:
https://github.com/rnk closed https://github.com/llvm/llvm-project/pull/130674
_
@@ -0,0 +1,33 @@
+// RUN: %clang_cc1 %s -triple x86_64-windows -fsyntax-only
-Wcast-function-type -Wno-cast-function-type-strict -verify=windows
+// RUN: %clang_cc1 %s -triple x86_64-windows -fsyntax-only
-Wcast-function-type -Wno-cast-function-type-strict -x c++ -verify=windows
rnk wrote:
We do a similar mangling for our extended vector types, so I would start by
copying the clang/test/CodeGenCXX/mangle-ms-vector-types.cpp file to
mangle-ms-matrix.cpp, and add a second RUN line that pipes the result to
`llvm-cxxfilt` and uses a second FileCheck invocation to validate
Markus =?utf-8?q?Gscho=C3=9Fmann?= ,
Markus =?utf-8?q?Gscho=C3=9Fmann?= ,
Markus =?utf-8?q?Gscho=C3=9Fmann?= ,
Markus =?utf-8?q?Gscho=C3=9Fmann?=
Message-ID:
In-Reply-To:
https://github.com/rnk approved this pull request.
Thanks for the comment!
https://github.com/llvm/llvm-project/pull/13067
https://github.com/rnk edited https://github.com/llvm/llvm-project/pull/135660
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/rnk approved this pull request.
I agree this is the practical thing to do.
https://github.com/llvm/llvm-project/pull/135660
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-c
https://github.com/rnk commented:
I haven't actually directly implemented one of these, but this approach looks
like the others. Please add tests. Also, I see that we use llvm-cxxfilt to
validate that the mangling comes back the way we expect. Please add some tests
with that utility to check t
https://github.com/rnk approved this pull request.
Thanks, looks good.
https://github.com/llvm/llvm-project/pull/133173
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -0,0 +1,115 @@
+//===--- RunOnNewStack.cpp - Crash Recovery
---===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
@@ -0,0 +1,180 @@
+
+// RUN: %clang_cc1 -fsyntax-only -Wms-bitfield-compatibility -verify -triple
armv8 -std=c++23 %s
+// RUN: %clang_cc1 -fsyntax-only -DMS_BITFIELDS -mms-bitfields
-verify=msbitfields -triple armv8-apple-macos10.15 -std=c++23 %s
+
+// msbitfields-no-diagnostics
@@ -27,6 +27,8 @@
extern "C" {
#endif
+#if !defined(__CUDA_ARCH__)
+
rnk wrote:
> If we have to define them on non-windows targets anyways, perhaps a better
> fix is to let clang define them everywhere, and avoid this special case in
> the headers.
Yes, we
https://github.com/rnk closed https://github.com/llvm/llvm-project/pull/135430
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
rnk wrote:
I just happened to look into the implementation of AutoConvert.h, and I see the
entire interface is defined away when not targeting zOS. This means that all
call sites need to be conditional on `ifdef __MVS__`, which means we have ugly
ifdef droppings all over the codebase, which ha
@@ -13,10 +15,41 @@ struct Bar {
struct Baz {
virtual ~Baz() {}
- static void operator delete[](void* ptr) = delete; // expected-note
{{explicitly marked deleted here}}
+ static void operator delete[](void* ptr) = delete; // expected-note
{{explicitly marked deleted here
https://github.com/rnk edited https://github.com/llvm/llvm-project/pull/135041
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/rnk updated https://github.com/llvm/llvm-project/pull/134196
>From 528be44ebae8ea5cd7f23c51ad11c314a73f152b Mon Sep 17 00:00:00 2001
From: Reid Kleckner
Date: Fri, 28 Mar 2025 22:11:05 -0700
Subject: [PATCH 1/8] [clang] Merge gtest binaries into AllClangUnitTests
T
https://github.com/rnk ready_for_review
https://github.com/llvm/llvm-project/pull/134196
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/rnk updated https://github.com/llvm/llvm-project/pull/134196
>From 528be44ebae8ea5cd7f23c51ad11c314a73f152b Mon Sep 17 00:00:00 2001
From: Reid Kleckner
Date: Fri, 28 Mar 2025 22:11:05 -0700
Subject: [PATCH 1/7] [clang] Merge gtest binaries into AllClangUnitTests
T
https://github.com/rnk updated https://github.com/llvm/llvm-project/pull/134196
>From 528be44ebae8ea5cd7f23c51ad11c314a73f152b Mon Sep 17 00:00:00 2001
From: Reid Kleckner
Date: Fri, 28 Mar 2025 22:11:05 -0700
Subject: [PATCH 1/6] [clang] Merge gtest binaries into AllClangUnitTests
T
https://github.com/rnk updated https://github.com/llvm/llvm-project/pull/134196
>From 528be44ebae8ea5cd7f23c51ad11c314a73f152b Mon Sep 17 00:00:00 2001
From: Reid Kleckner
Date: Fri, 28 Mar 2025 22:11:05 -0700
Subject: [PATCH 1/5] [clang] Merge gtest binaries into AllClangUnitTests
T
https://github.com/rnk updated https://github.com/llvm/llvm-project/pull/134196
>From 528be44ebae8ea5cd7f23c51ad11c314a73f152b Mon Sep 17 00:00:00 2001
From: Reid Kleckner
Date: Fri, 28 Mar 2025 22:11:05 -0700
Subject: [PATCH 1/4] [clang] Merge gtest binaries into AllClangUnitTests
T
https://github.com/rnk updated https://github.com/llvm/llvm-project/pull/134196
>From 528be44ebae8ea5cd7f23c51ad11c314a73f152b Mon Sep 17 00:00:00 2001
From: Reid Kleckner
Date: Fri, 28 Mar 2025 22:11:05 -0700
Subject: [PATCH 1/3] [clang] Merge gtest binaries into AllClangUnitTests
T
@@ -11045,15 +11045,18 @@ bool Sema::CheckDestructor(CXXDestructorDecl
*Destructor) {
DiagnoseUseOfDecl(OperatorDelete, Loc);
MarkFunctionReferenced(Loc, OperatorDelete);
Destructor->setOperatorDelete(OperatorDelete, ThisArg);
- // Lookup delete[] too in
https://github.com/rnk approved this pull request.
I have some minor suggestions, but please go ahead and land this without
additional review since it is a forward-fix.
https://github.com/llvm/llvm-project/pull/135041
___
cfe-commits mailing list
cfe-
@@ -11045,15 +11045,18 @@ bool Sema::CheckDestructor(CXXDestructorDecl
*Destructor) {
DiagnoseUseOfDecl(OperatorDelete, Loc);
MarkFunctionReferenced(Loc, OperatorDelete);
Destructor->setOperatorDelete(OperatorDelete, ThisArg);
- // Lookup delete[] too in
https://github.com/rnk commented:
The premerge tests failed on a modules crash recovery test case on other
platforms, and those seem like true positives that need to be fixed.
Overall, I think the main risk with this approach is that it will break
in-process, FP-based stack unwinders that vali
https://github.com/rnk updated https://github.com/llvm/llvm-project/pull/134196
>From 528be44ebae8ea5cd7f23c51ad11c314a73f152b Mon Sep 17 00:00:00 2001
From: Reid Kleckner
Date: Fri, 28 Mar 2025 22:11:05 -0700
Subject: [PATCH 1/2] [clang] Merge gtest binaries into AllClangUnitTests
T
https://github.com/rnk closed https://github.com/llvm/llvm-project/pull/134195
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
1 - 100 of 1735 matches
Mail list logo
