[PATCH] D87187: [Driver] Perform Linux distribution detection just once

rnk added inline comments. Comment at: clang/lib/Driver/Distro.cpp:205 +const llvm::Triple &TargetOrHost) { + static Distro::DistroType Type = Distro::UninitializedDistro; + rnk wrote: > aganea wrote: > > I'm not sure if this

[PATCH] D87187: [Driver] Perform Linux distribution detection just once

rnk added inline comments. Comment at: clang/lib/Driver/Distro.cpp:205 +const llvm::Triple &TargetOrHost) { + static Distro::DistroType Type = Distro::UninitializedDistro; + aganea wrote: > I'm not sure if this is safe. @rnk D

[PATCH] D83154: clang: Add -fcoverage-prefix-map

rnk added a comment. Yeah, my goal is for the build system to be able to avoid having to embed PWD into the compiler flags. For example, I believe it is a goal of the LLVM gn build system for the build tree to be relocatable. If the compiler command lines need to contain absolute paths to make

[PATCH] D87701: Do not apply calling conventions to MSVC entry points

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. lgtm, thanks. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87701/new/ https://reviews.llvm.org/D87701 ___ cfe-commits mailing list cfe-commits@

[PATCH] D80409: [MS ABI] Add mangled type for auto template parameter whose argument kind is Integeral

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. lgtm, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80409/new/ https://reviews.llvm.org/D80409 __

[PATCH] D80409: [MS ABI] Add mangled type for auto template parameter whose argument kind is Integeral

rnk added a comment. Looks good, but we should test both sides of the MSVC behavior. Comment at: clang/test/CodeGenCXX/mangle-ms-auto-templates.cpp:17 + AutoParmTemplate<0> auto_int; + // CHECK: call {{.*}} @"??0?$AutoParmTemplate@$H0A@@@QAE@XZ" + AutoParmTemplate auto_bool;

[PATCH] D80409: [MS ABI] Add mangled type for auto template parameter whose argument kind is Integeral

rnk added inline comments. Comment at: clang/lib/AST/MicrosoftMangle.cpp:383 +const NonTypeTemplateParmDecl *PD = nullptr, +QualType *TemplateArgType = nullptr); + void mangleExpression(const Expr *E, const NonTypeTemplateP

[PATCH] D83154: clang: Add -fcoverage-prefix-map

rnk added inline comments. Comment at: clang/lib/CodeGen/CoverageMappingGen.cpp:1334 + llvm::SmallString<256> Path(Filename); + llvm::sys::fs::make_absolute(Path); + llvm::sys::path::remove_dots(Path, /*remove_dot_dot=*/true); keith wrote: > rnk wrote: > > Ple

[PATCH] D83154: clang: Add -fcoverage-prefix-map

rnk added inline comments. Comment at: clang/include/clang/Driver/Options.td:1980 HelpText<"remap file source paths in debug info">; +def fprofile_prefix_map_QA + : Joined<["-"], "fprofile-prefix-map=">, Group, Any reason for the _QA suffix instead of _EQ?

[PATCH] D80966: [codeview] Put !heapallocsite on calls to operator new

This revision was automatically updated to reflect the committed changes. Closed by commit rG672ed5386024: [codeview] Put !heapallocsite on calls to operator new (authored by rnk). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80966/new/ https://rev

[PATCH] D80966: [codeview] Put !heapallocsite on calls to operator new

rnk updated this revision to Diff 267767. rnk added a comment. - revert lld change Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80966/new/ https://reviews.llvm.org/D80966 Files: clang/lib/CodeGen/CGCall.cpp clang/lib/CodeGen/CGDebugInfo.cpp

[PATCH] D80966: [codeview] Put !heapallocsite on calls to operator new

rnk created this revision. rnk added a reviewer: akhuang. Herald added a reviewer: MaskRay. Herald added a project: clang. rnk updated this revision to Diff 267767. rnk added a comment. - revert lld change Clang marks calls to operator new as heap allocation sites, but the operator declared at g

[PATCH] D80876: [clang] Default to windows response files when running on windows

rnk added a comment. This seems wrong for mingw, so check with @mstorsjo. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80876/new/ https://reviews.llvm.org/D80876 ___ cfe-commits mailing list cfe-commi

[PATCH] D69585: Add option to instantiate templates already in the PCH

rnk added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:5610 + if (Args.hasFlag(options::OPT_fpch_instantiate_templates, + options::OPT_fno_pch_instantiate_templates, false)) +CmdArgs.push_back("-fpch-instantiate-templates"); --

[PATCH] D69585: Add option to instantiate templates already in the PCH

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. lgtm IMO there is a pretty clear performance use case for this mode of operation, and it seems to me that you have addressed @rsmith's feedback. Please wait a few days to see if he has more to add,

[PATCH] D80153: [AST] Mangle LambdaContextDecl for top level decl

rnk added a comment. After looking at the code more, I'm more convinced that your fix is in the right place. Comment at: clang/lib/AST/MicrosoftMangle.cpp:954 if ((isa(LambdaContextDecl) || - isa(LambdaContextDecl)) && -LambdaContex

[PATCH] D66324: clang-misexpect: Profile Guided Validation of Performance Annotations in LLVM

rnk added inline comments. Comment at: cfe/trunk/lib/Frontend/CompilerInvocation.cpp:3457 + if (Diags.isIgnored(diag::warn_profile_data_misexpect, SourceLocation())) +Res.FrontendOpts.LLVMArgs.push_back("-pgo-warn-misexpect"); + Clang generally tries to avoi

[PATCH] D80225: [Driver] Recognize -fuse-ld={bfd, gold, lld} but don't prepend "ld." or "ld64." for other values

rnk added a comment. Personally, I support this. I never liked the magic `ld.` prefixing. If we want a way to select a proprietary linker, it seems reasonable to ask the user to name the complete binary basename (`ld.lld`, `lld`, `ld64`, `myld`, etc). The driver shouldn't force the linker to us