[PATCH] D89765: [LibTooling][Clang-cast] A Clang LibTool to convert C-style casts to C++ style casts and more.

oneraynyday updated this revision to Diff 299470. oneraynyday added a comment. - Address clang-tidy - Address using C++17 left-fold expression in C++14 - Address minor style issues Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89765/new/ https://re

[PATCH] D89765: [LibTooling][Clang-cast] A Clang LibTool to convert C-style casts to C++ style casts and more.

oneraynyday added a comment. In D89765#2342624 , @awarzynski wrote: > > - Have you considered sending an RFC to cfe-dev regarding this tool? I think > that it would be a great way of attracting peoples attention. More > importantly, should we add an

[PATCH] D89770: Don't use C++17 features

oneraynyday updated this revision to Diff 299282. oneraynyday added a comment. C++17 features cause buildkite to fail. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89770/new/ https://reviews.llvm.org/D89770 Files: clang-tools-extra/clang-cast/M

[PATCH] D89770: Don't use C++17 features

oneraynyday created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. oneraynyday requested review of this revision. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D89770 Files: clang-tools-extra/clang-cast/Matcher.h Index: clang-tools-extr

[PATCH] D89765: [LibTooling][Clang-cast] A Clang LibTool to convert C-style casts to C++ style casts and more.

oneraynyday added a comment. Hi there, Thank you for taking a look! Sorry about the mess with diff's - this is my first time working with Arcanist. I thought `arc diff --update ` in Arcanist meant a push to the branch. Moving forward, should I use `arc diff` to add extra changes onto the code

[PATCH] D89765: [LibTooling][Clang-cast] A Clang LibTool to convert C-style casts to C++ style casts and more.

oneraynyday updated this revision to Diff 299274. oneraynyday added a comment. Don't use C++17 features as clang currently uses C++14. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89765/new/ https://reviews.llvm.org/D89765 Files: clang-tools-ex