Rajveer100 wrote:
Thanks for merging, it would be nice if the members could help me with this:
https://github.com/llvm/llvm-project/issues/139365
https://github.com/llvm/llvm-project/pull/139859
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://github.com/Rajveer100 updated
https://github.com/llvm/llvm-project/pull/139859
>From a385808a47e3a7b585a225b9fbf10c55ba01ef5b Mon Sep 17 00:00:00 2001
From: Rajveer
Date: Wed, 14 May 2025 13:44:31 +0530
Subject: [PATCH] [clang][Sema] Diagnose exceptions only in non-dependent
context in
Rajveer100 wrote:
Done.
https://github.com/llvm/llvm-project/pull/139859
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/Rajveer100 updated
https://github.com/llvm/llvm-project/pull/139859
>From 2fc6e7ccab49888b60bbb43e0e6350555c5eb9f1 Mon Sep 17 00:00:00 2001
From: Rajveer
Date: Wed, 14 May 2025 13:44:31 +0530
Subject: [PATCH] [clang][Sema] Diagnose exceptions only in non-dependent
context in
https://github.com/Rajveer100 updated
https://github.com/llvm/llvm-project/pull/139859
>From 136f1c030db440054a2052a69c5c4dd27f50823e Mon Sep 17 00:00:00 2001
From: Rajveer
Date: Wed, 14 May 2025 13:44:31 +0530
Subject: [PATCH] [clang][Sema] Diagnose exceptions only in non-dependent
context in
https://github.com/Rajveer100 updated
https://github.com/llvm/llvm-project/pull/139859
>From f3201c1089203963f8cb73c58ea498a84848dd88 Mon Sep 17 00:00:00 2001
From: Rajveer
Date: Wed, 14 May 2025 13:44:31 +0530
Subject: [PATCH] [clang][Sema] Diagnose exceptions only in non-dependent
context in
Rajveer100 wrote:
I have made the changes, let me know if this is fair enough.
https://github.com/llvm/llvm-project/pull/139859
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/Rajveer100 updated
https://github.com/llvm/llvm-project/pull/139859
>From 214aa7fa765c82121cbf3e8f6cf41a0ed2e06376 Mon Sep 17 00:00:00 2001
From: Rajveer
Date: Wed, 14 May 2025 13:44:31 +0530
Subject: [PATCH] [clang][Sema] Diagnose exceptions only in non-dependent
context in
Rajveer100 wrote:
I am actually facing an issue all of a sudden after rebasing and deletion of
build folder:
```shell
rajveersingh@MacBook-Pro llvm-project % build/bin/clang++ -std=c++20
-fno-exceptions debug-clang-138939.cpp -v
Rajveer100 wrote:
I feel like this issue is a little too niche to be adding such complexity,
maybe just covering those specific uses cases before codegen might be the way
to go?
https://github.com/llvm/llvm-project/pull/139859
___
cfe-commits mailing
Rajveer100 wrote:
Moving the checks does work for these limited cases, but now that we don't have
them there, one of the old tests now doesn't show up the diagnosis:
```c++
void f() {
throw;
}
void g() {
try {
f();
} catch (...) {
}
}
```
Since there is a separate call:
```c++
re
https://github.com/Rajveer100 updated
https://github.com/llvm/llvm-project/pull/139859
>From 46a9b0193bb5bdb9a082582f19e7a32ac2a3973d Mon Sep 17 00:00:00 2001
From: Rajveer
Date: Wed, 14 May 2025 13:44:31 +0530
Subject: [PATCH] [clang][Sema] Diagnose exceptions only in non-dependent
context in
Rajveer100 wrote:
> @Rajveer100 I think instead of looking at the context, we should check if the
> expression (`Ex`) is instantiation dependent
Checking the expression causes a crash:
Details
```shell
PLEASE submit a bug report to https://github.com/llvm/llvm-project/issues/ and
include th
Rajveer100 wrote:
@erichkeane
As expected the following case is being accepted, which shouldn't happen, let
me know what you recommend to diagnose this:
```c++
template void foo() {
try {
} catch (...) {
}
throw 1;
}
void bar2() { foo(); }
```
https://github.com/llvm/llvm-project/pul
https://github.com/Rajveer100 created
https://github.com/llvm/llvm-project/pull/139859
Resolves #138939
When enabling `--fno-exceptions` flag, discarded statements containing
`try/catch/throw` in an independent context can be avoided from being rejected.
>From 552e394608f8c8d70ddef70a32dd9bd4
Rajveer100 wrote:
@Sirraide
https://github.com/llvm/llvm-project/pull/96301
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/Rajveer100 updated
https://github.com/llvm/llvm-project/pull/96301
>From cbd6e832fbbc905d52926e268d7ba8568df80df1 Mon Sep 17 00:00:00 2001
From: Rajveer
Date: Fri, 21 Jun 2024 18:26:36 +0530
Subject: [PATCH] [clang] Allow class with anonymous union member to be
const-default
https://github.com/Rajveer100 updated
https://github.com/llvm/llvm-project/pull/96301
>From c12be47eaa24981080b9eeb3aaa4770b03ad6a9e Mon Sep 17 00:00:00 2001
From: Rajveer
Date: Fri, 21 Jun 2024 18:26:36 +0530
Subject: [PATCH] [clang] Allow class with anonymous union member to be
const-default
Rajveer100 wrote:
Thanks for the approval @cor3ntin, could you land this for me?!
https://github.com/llvm/llvm-project/pull/96301
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -0,0 +1,43 @@
+// RUN: %clang_cc1 -std=c++23 -fsyntax-only -verify %s
+
+struct A {
Rajveer100 wrote:
Added.
https://github.com/llvm/llvm-project/pull/96301
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
ht
https://github.com/Rajveer100 updated
https://github.com/llvm/llvm-project/pull/96301
>From f42cea250e79efc6ae51139d51ac72adc4fe7bfd Mon Sep 17 00:00:00 2001
From: Rajveer
Date: Fri, 21 Jun 2024 18:26:36 +0530
Subject: [PATCH] [clang] Allow class with anonymous union member to be
const-default
Rajveer100 wrote:
@cor3ntin
CI looks good.
https://github.com/llvm/llvm-project/pull/96301
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/Rajveer100 updated
https://github.com/llvm/llvm-project/pull/96301
>From dfc44453e9168048d60071ba6e28e7b01be22114 Mon Sep 17 00:00:00 2001
From: Rajveer
Date: Fri, 21 Jun 2024 18:26:36 +0530
Subject: [PATCH] [clang] Allow class with anonymous union member to be
const-default
https://github.com/Rajveer100 updated
https://github.com/llvm/llvm-project/pull/96301
>From 387e83880994ddd71898680e421bc4590a3dbd63 Mon Sep 17 00:00:00 2001
From: Rajveer
Date: Fri, 21 Jun 2024 18:26:36 +0530
Subject: [PATCH] [clang] Allow class with anonymous union member to be
const-default
Rajveer100 wrote:
Only windows failed.
https://github.com/llvm/llvm-project/pull/96301
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/Rajveer100 updated
https://github.com/llvm/llvm-project/pull/96301
>From 8796f60f0255ab8810d6019b4c470d64a44a6ce2 Mon Sep 17 00:00:00 2001
From: Rajveer
Date: Fri, 21 Jun 2024 18:26:36 +0530
Subject: [PATCH] [clang] Allow class with anonymous union member to be
const-default
Rajveer100 wrote:
@Sirraide The tests pass, not sure about the failure though.
https://github.com/llvm/llvm-project/pull/96301
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/Rajveer100 updated
https://github.com/llvm/llvm-project/pull/96301
>From 3ccb1c969621894a9a6dabb2f9adfc213d50e886 Mon Sep 17 00:00:00 2001
From: Rajveer
Date: Fri, 21 Jun 2024 18:26:36 +0530
Subject: [PATCH] [clang] Allow class with anonymous union member to be
const-default
https://github.com/Rajveer100 updated
https://github.com/llvm/llvm-project/pull/96301
>From 49e6fb5481ab0589f653345f1c3cdbe161aefb34 Mon Sep 17 00:00:00 2001
From: Rajveer
Date: Fri, 21 Jun 2024 18:26:36 +0530
Subject: [PATCH] [clang] Allow class with anonymous union member to be
const-default
https://github.com/Rajveer100 updated
https://github.com/llvm/llvm-project/pull/96301
>From 975a91bd8cb8c9e04f1dcfc455f83f7115d1cf71 Mon Sep 17 00:00:00 2001
From: Rajveer
Date: Fri, 21 Jun 2024 18:26:36 +0530
Subject: [PATCH] [clang] Allow class with anonymous union member to be
const-default
https://github.com/Rajveer100 updated
https://github.com/llvm/llvm-project/pull/96301
>From 13648d1c897f73b04ada715fe7d1f9338c2e3591 Mon Sep 17 00:00:00 2001
From: Rajveer
Date: Fri, 21 Jun 2024 18:26:36 +0530
Subject: [PATCH] [clang] Allow class with anonymous union member to be
const-default
https://github.com/Rajveer100 updated
https://github.com/llvm/llvm-project/pull/96301
>From 950586bd017175a1039952f7cf090c85d7bfc6e0 Mon Sep 17 00:00:00 2001
From: Rajveer
Date: Fri, 21 Jun 2024 18:26:36 +0530
Subject: [PATCH] [clang] Allow class with anonymous union member to be
const-default
https://github.com/Rajveer100 updated
https://github.com/llvm/llvm-project/pull/96301
>From b46a96d5fb7abe08877fcf6b16996f4105c6559e Mon Sep 17 00:00:00 2001
From: Rajveer
Date: Fri, 21 Jun 2024 18:26:36 +0530
Subject: [PATCH] [clang] Allow class with anonymous union member to be
const-default
https://github.com/Rajveer100 updated
https://github.com/llvm/llvm-project/pull/96301
>From f31e4ec4f7374723afb0dc91409b95a8d2855573 Mon Sep 17 00:00:00 2001
From: Rajveer
Date: Fri, 21 Jun 2024 18:26:36 +0530
Subject: [PATCH] [clang] Allow class with anonymous union member to be
const-default
https://github.com/Rajveer100 updated
https://github.com/llvm/llvm-project/pull/96301
>From 326e0f5bdb8d543ddd42345e6a9ffb8a7fb2b823 Mon Sep 17 00:00:00 2001
From: Rajveer
Date: Fri, 21 Jun 2024 18:26:36 +0530
Subject: [PATCH] [clang] Allow class with anonymous union member to be
const-default
https://github.com/Rajveer100 updated
https://github.com/llvm/llvm-project/pull/96301
>From 7e0b2c0a08c63a01309991980d30c64bcea325fe Mon Sep 17 00:00:00 2001
From: Rajveer
Date: Fri, 21 Jun 2024 18:26:36 +0530
Subject: [PATCH] [clang] Allow class with anonymous union member to be
const-default
https://github.com/Rajveer100 updated
https://github.com/llvm/llvm-project/pull/96301
>From 03c02eaafdccb3f049e6909af7255fcf7d4d1784 Mon Sep 17 00:00:00 2001
From: Rajveer
Date: Fri, 21 Jun 2024 18:26:36 +0530
Subject: [PATCH] [clang] Allow class with anonymous union member to be
const-default
Rajveer100 wrote:
@zygoloid
Could you review this?
https://github.com/llvm/llvm-project/pull/96301
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/Rajveer100 updated
https://github.com/llvm/llvm-project/pull/96301
>From 7efe2bd186cb0a97b8f8b66b9c69da92c79fc60a Mon Sep 17 00:00:00 2001
From: Rajveer
Date: Fri, 21 Jun 2024 18:26:36 +0530
Subject: [PATCH] [clang] Allow class with anonymous union member to be
const-default
https://github.com/Rajveer100 updated
https://github.com/llvm/llvm-project/pull/96301
>From 1a25f021b797e5591f1ae324c8a8b5244047d5f4 Mon Sep 17 00:00:00 2001
From: Rajveer
Date: Fri, 21 Jun 2024 18:26:36 +0530
Subject: [PATCH] [clang] Allow class with anonymous union member to be
const-default
Rajveer100 wrote:
> Sure. Do I need to do anything?
I don't have the access rights to merge yet.
https://github.com/llvm/llvm-project/pull/98129
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cf
Rajveer100 wrote:
@nickhuang99
Could you land this for me?
https://github.com/llvm/llvm-project/pull/98129
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/Rajveer100 created
https://github.com/llvm/llvm-project/pull/98129
Resolves #97983
>From e20e592845a1de4282e7492bec2e2b34ac3b96cf Mon Sep 17 00:00:00 2001
From: Rajveer
Date: Tue, 9 Jul 2024 13:58:20 +0530
Subject: [PATCH] [clang][doc] Improve error handling for `LibTooling`
Rajveer100 wrote:
@zygoloid
Let me know if the new changes work well.
https://github.com/llvm/llvm-project/pull/96301
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/Rajveer100 updated
https://github.com/llvm/llvm-project/pull/96301
>From 751e630dbf54ef6f3a1209a5d09f99093ad84cae Mon Sep 17 00:00:00 2001
From: Rajveer
Date: Fri, 21 Jun 2024 18:26:36 +0530
Subject: [PATCH] [clang] Allow class with anonymous union member to be
const-default
https://github.com/Rajveer100 updated
https://github.com/llvm/llvm-project/pull/96301
>From 3fb29e52b7227c2778942b3ca941112596ce89c1 Mon Sep 17 00:00:00 2001
From: Rajveer
Date: Fri, 21 Jun 2024 18:26:36 +0530
Subject: [PATCH] [clang] Allow class with anonymous union member to be
const-default
https://github.com/Rajveer100 edited
https://github.com/llvm/llvm-project/pull/96301
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -1392,7 +1392,8 @@ class CXXRecordDecl : public RecordDecl {
bool allowConstDefaultInit() const {
return !data().HasUninitializedFields ||
!(data().HasDefaultedDefaultConstructor ||
- needsImplicitDefaultConstructor());
+ needsImplici
https://github.com/Rajveer100 updated
https://github.com/llvm/llvm-project/pull/96301
>From b964923b9610c9cd53e4d1de8f5d51d8fcebc78c Mon Sep 17 00:00:00 2001
From: Rajveer
Date: Fri, 21 Jun 2024 18:26:36 +0530
Subject: [PATCH] [clang] Allow class with anonymous union member to be
const-default
@@ -1392,7 +1392,8 @@ class CXXRecordDecl : public RecordDecl {
bool allowConstDefaultInit() const {
return !data().HasUninitializedFields ||
!(data().HasDefaultedDefaultConstructor ||
- needsImplicitDefaultConstructor());
+ needsImplici
@@ -0,0 +1,11 @@
+// RUN: %clang_cc1 -std=c++23 -fsyntax-only -verify %s
Rajveer100 wrote:
Indeed.
https://github.com/llvm/llvm-project/pull/96301
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.l
@@ -1392,7 +1392,8 @@ class CXXRecordDecl : public RecordDecl {
bool allowConstDefaultInit() const {
return !data().HasUninitializedFields ||
!(data().HasDefaultedDefaultConstructor ||
- needsImplicitDefaultConstructor());
+ needsImplici
Rajveer100 wrote:
@zygoloid
https://github.com/llvm/llvm-project/pull/96301
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/Rajveer100 created
https://github.com/llvm/llvm-project/pull/96301
Resolves #95854
-- As per https://eel.is/c++draft/dcl.init#general-8.3
>From c8f2496e91d58c8704911665e1bf1dd7dfbb1d2e Mon Sep 17 00:00:00 2001
From: Rajveer
Date: Fri, 21 Jun 2024 18:26:36 +0530
Subject: [PA
Rajveer100 wrote:
@Sirraide @zygoloid
Can I be of any help to improve this?
https://github.com/llvm/llvm-project/pull/94159
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Rajveer100 wrote:
@Sirraide
Can you land this for me?
https://github.com/llvm/llvm-project/pull/94159
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Rajveer100 wrote:
I have done the last few changes as well.
Regarding the force-push, I will try to do single commits and later squash them!
https://github.com/llvm/llvm-project/pull/94159
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https:
https://github.com/Rajveer100 updated
https://github.com/llvm/llvm-project/pull/94159
>From bf114654e02d4723457730de0d067c7a00abf42d Mon Sep 17 00:00:00 2001
From: Rajveer
Date: Sun, 2 Jun 2024 18:33:37 +0530
Subject: [PATCH] [clang] Fix-it hint for `++this` -> `++*this` when deref is
modifiab
@@ -0,0 +1,49 @@
+// RUN: %clang_cc1 -std=c++23 -fsyntax-only -verify %s
+
+struct S {
+ void f() {
+++this; // expected-error {{expression is not assignable}}
+// expected-note@-1 {{add '*' to dereference it}}
+ }
+
+ void g() const {
+++this; // expected-error {{e
@@ -13273,6 +13273,22 @@ enum {
ConstUnknown, // Keep as last element
};
+static void MaybeSuggestDerefFixIt(Sema &S, const Expr *E, SourceLocation Loc)
{
+ ExprResult Deref;
+ Expr *TE = const_cast(E);
+ {
+Sema::TentativeAnalysisScope Trap(S);
+Deref = S.ActOn
https://github.com/Rajveer100 updated
https://github.com/llvm/llvm-project/pull/94159
>From 765176a735a922c404502c927338d90853335923 Mon Sep 17 00:00:00 2001
From: Rajveer
Date: Sun, 2 Jun 2024 18:33:37 +0530
Subject: [PATCH] [clang] Fix-it hint for `++this` -> `++*this` when deref is
modifiab
https://github.com/Rajveer100 updated
https://github.com/llvm/llvm-project/pull/94159
>From 3b25887966d1846a7c3d8f0c95fa1be73282b267 Mon Sep 17 00:00:00 2001
From: Rajveer
Date: Sun, 2 Jun 2024 18:33:37 +0530
Subject: [PATCH] [clang] Fix-it hint for `++this` -> `++*this` when deref is
modifiab
@@ -8777,6 +8777,9 @@ def err_typecheck_incomplete_type_not_modifiable_lvalue :
Error<
def err_typecheck_lvalue_casts_not_supported : Error<
"assignment to cast is illegal, lvalue casts are not supported">;
+def note_typecheck_expression_not_modifiable_lvalue : Note<
--
Rajveer100 wrote:
I have added a `FIXME` for now regarding the Obj-C part.
The function change is also done.
https://github.com/llvm/llvm-project/pull/94159
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman
https://github.com/Rajveer100 updated
https://github.com/llvm/llvm-project/pull/94159
>From 1a9ef88a6fec33521ecdfe9d7e6d5ebc8d0805a5 Mon Sep 17 00:00:00 2001
From: Rajveer
Date: Sun, 2 Jun 2024 18:33:37 +0530
Subject: [PATCH] [clang] Fix-it hint for `++this` -> `++*this` when deref is
modifiab
Rajveer100 wrote:
I think this can be merged considering the approved changes?
https://github.com/llvm/llvm-project/pull/94592
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -10,6 +10,7 @@ void h() {
SEL* ps = &s;
@selector(dealloc) = s; // expected-error {{expression is not assignable}}
+ // expected-note@-1 {{add '*' to dereference it}}
Rajveer100 wrote:
I see a way to handle this:
`E->getType()->isSpecificBuiltinType
@@ -13367,6 +13367,21 @@ static void DiagnoseConstAssignment(Sema &S, const
Expr *E,
if (!DiagnosticEmitted) {
S.Diag(Loc, diag::err_typecheck_assign_const)
<< ExprRange << ConstVariable << VD << VD->getType();
+ ExprResult Deref;
+
@@ -13367,6 +13367,20 @@ static void DiagnoseConstAssignment(Sema &S, const
Expr *E,
if (!DiagnosticEmitted) {
S.Diag(Loc, diag::err_typecheck_assign_const)
<< ExprRange << ConstVariable << VD << VD->getType();
+ ExprResult Deref;
+
@@ -10,6 +10,7 @@ void h() {
SEL* ps = &s;
@selector(dealloc) = s; // expected-error {{expression is not assignable}}
+ // expected-note@-1 {{add '*' to dereference it}}
Rajveer100 wrote:
Actually, it isn't valid in case of `@selector`, that's why I was
@@ -10,6 +10,7 @@ void h() {
SEL* ps = &s;
@selector(dealloc) = s; // expected-error {{expression is not assignable}}
+ // expected-note@-1 {{add '*' to dereference it}}
Rajveer100 wrote:
One way I can think of is to do a AST visit and check for `ObjCSe
https://github.com/Rajveer100 updated
https://github.com/llvm/llvm-project/pull/94159
>From e38b38773bcade3407dde112994de5a6c5f0d7e0 Mon Sep 17 00:00:00 2001
From: Rajveer
Date: Sun, 2 Jun 2024 18:33:37 +0530
Subject: [PATCH] [clang] Fix-it hint for `++this` -> `++*this` when deref is
modifiab
https://github.com/Rajveer100 edited
https://github.com/llvm/llvm-project/pull/94159
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -10,6 +10,7 @@ void h() {
SEL* ps = &s;
@selector(dealloc) = s; // expected-error {{expression is not assignable}}
+ // expected-note@-1 {{add '*' to dereference it}}
Rajveer100 wrote:
I made a check for `isObjCObjectPointerType`, maybe there's a sep
https://github.com/Rajveer100 edited
https://github.com/llvm/llvm-project/pull/94159
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -10,6 +10,7 @@ void h() {
SEL* ps = &s;
@selector(dealloc) = s; // expected-error {{expression is not assignable}}
+ // expected-note@-1 {{add '*' to dereference it}}
Rajveer100 wrote:
>From my knowledge, this would assign the value of s to the SEL o
@@ -13367,6 +13367,21 @@ static void DiagnoseConstAssignment(Sema &S, const
Expr *E,
if (!DiagnosticEmitted) {
S.Diag(Loc, diag::err_typecheck_assign_const)
<< ExprRange << ConstVariable << VD << VD->getType();
+ ExprResult Deref;
+
@@ -13587,10 +13602,47 @@ static bool CheckForModifiableLvalue(Expr *E,
SourceLocation Loc, Sema &S) {
SourceRange Assign;
if (Loc != OrigLoc)
Assign = SourceRange(OrigLoc, OrigLoc);
- if (NeedType)
+ if (NeedType) {
S.Diag(Loc, DiagID) << E->getType() << E->get
https://github.com/Rajveer100 edited
https://github.com/llvm/llvm-project/pull/94159
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -13367,6 +13367,21 @@ static void DiagnoseConstAssignment(Sema &S, const
Expr *E,
if (!DiagnosticEmitted) {
S.Diag(Loc, diag::err_typecheck_assign_const)
<< ExprRange << ConstVariable << VD << VD->getType();
+ ExprResult Deref;
+
Rajveer100 wrote:
@Sirraide
Let me know if any further changes are needed. All tests should pass once CI
finishes.
https://github.com/llvm/llvm-project/pull/94159
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/
https://github.com/Rajveer100 updated
https://github.com/llvm/llvm-project/pull/94159
>From 5092ffd04d1eeefcd0e9708415d40886e112bc31 Mon Sep 17 00:00:00 2001
From: Rajveer
Date: Sun, 2 Jun 2024 18:33:37 +0530
Subject: [PATCH] [clang] Fix-it hint for `++this` -> `++*this` when deref is
modifiab
@@ -13367,6 +13367,8 @@ static void DiagnoseConstAssignment(Sema &S, const Expr
*E,
if (!DiagnosticEmitted) {
S.Diag(Loc, diag::err_typecheck_assign_const)
<< ExprRange << ConstVariable << VD << VD->getType();
+ S.Diag(Loc, diag::note_t
@@ -13367,6 +13367,8 @@ static void DiagnoseConstAssignment(Sema &S, const Expr
*E,
if (!DiagnosticEmitted) {
S.Diag(Loc, diag::err_typecheck_assign_const)
<< ExprRange << ConstVariable << VD << VD->getType();
+ S.Diag(Loc, diag::note_t
https://github.com/Rajveer100 updated
https://github.com/llvm/llvm-project/pull/94159
>From 6dec67c1fe9b64881a7b4f97f2341b2fdf7db48b Mon Sep 17 00:00:00 2001
From: Rajveer
Date: Sun, 2 Jun 2024 18:33:37 +0530
Subject: [PATCH] [clang] Fix-it hint for `++this` -> `++*this` when deref is
modifiab
https://github.com/Rajveer100 edited
https://github.com/llvm/llvm-project/pull/94159
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -0,0 +1,14 @@
+// RUN: %clang_cc1 -std=c++23 -fsyntax-only -verify %s
+
Rajveer100 wrote:
Sure, I'll add more.
https://github.com/llvm/llvm-project/pull/94159
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
Rajveer100 wrote:
Tests which fail currently:
Clang :: Sema/exprs.c
Clang :: Sema/va_arg_x86_32.c
Clang :: SemaObjCXX/sel-address.mm
Also, what do you think about the fix-it hint wording for errors such as
`assignment to cast is illegal, lvalue casts are not supported`?
https://github.com/llv
https://github.com/Rajveer100 updated
https://github.com/llvm/llvm-project/pull/94159
>From 95ce40b0336cda8c5a352d8abb824906b1d643d9 Mon Sep 17 00:00:00 2001
From: Rajveer
Date: Sun, 2 Jun 2024 18:33:37 +0530
Subject: [PATCH] [clang] Fix-it hint for `++this` -> `++*this` when deref is
modifiab
https://github.com/Rajveer100 updated
https://github.com/llvm/llvm-project/pull/94159
>From e637dc83ec205f7e4dde356b8f5d06ce3abc899e Mon Sep 17 00:00:00 2001
From: Rajveer
Date: Sun, 2 Jun 2024 18:33:37 +0530
Subject: [PATCH] [clang] Fix-it hint for `++this` -> `++*this` when deref is
modifiab
Rajveer100 wrote:
cc @Sirraide
https://github.com/llvm/llvm-project/pull/94159
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/Rajveer100 created
https://github.com/llvm/llvm-project/pull/94159
Resolves #93066
>From 9c90d4a83a913566d782774700a06dd640722dfd Mon Sep 17 00:00:00 2001
From: Rajveer
Date: Sun, 2 Jun 2024 18:33:37 +0530
Subject: [PATCH] [clang] Fix-it hint for `++this` -> `++*this` when d
Rajveer100 wrote:
Thanks for the approval, could you land this for me?
https://github.com/llvm/llvm-project/pull/91119
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Rajveer100 wrote:
I am not sure what causes the build failure here.
https://github.com/llvm/llvm-project/pull/91119
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/Rajveer100 updated
https://github.com/llvm/llvm-project/pull/91119
>From 78a2afab67eef9a8a05ced89df0aadb56a2ec2b8 Mon Sep 17 00:00:00 2001
From: Rajveer
Date: Sun, 5 May 2024 18:05:00 +0530
Subject: [PATCH] [clang][analyzer] Check for label location bindings in
`DereferenceC
https://github.com/Rajveer100 updated
https://github.com/llvm/llvm-project/pull/91119
>From 5c7712d1841664a9424b98abdd22d7967d00913f Mon Sep 17 00:00:00 2001
From: Rajveer
Date: Sun, 5 May 2024 18:05:00 +0530
Subject: [PATCH] [clang][analyzer] Check for label location bindings in
`DereferenceC
Rajveer100 wrote:
Should we introduce a new Kind in `DerefKind`?
https://github.com/llvm/llvm-project/pull/91119
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Rajveer100 wrote:
@steakhal
https://github.com/llvm/llvm-project/pull/91119
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/Rajveer100 updated
https://github.com/llvm/llvm-project/pull/91119
>From dcc23f7751ba2ceb281a9b027907dbf849ba65c6 Mon Sep 17 00:00:00 2001
From: Rajveer
Date: Sun, 5 May 2024 18:05:00 +0530
Subject: [PATCH] [clang][analyzer] Check for label location bindings in
`DereferenceC
https://github.com/Rajveer100 updated
https://github.com/llvm/llvm-project/pull/91119
>From c1d62262d2545e4999f08f2ba28a12c71789926f Mon Sep 17 00:00:00 2001
From: Rajveer
Date: Sun, 5 May 2024 18:05:00 +0530
Subject: [PATCH] [clang][analyzer] Check for label location bindings in
`DereferenceC
1 - 100 of 132 matches
Mail list logo
