[PATCH] D81045: [LLVM] Change isa<> to a variadic function template

jurahul added a comment. Yes, I'd appreciate if someone can land this change. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81045/new/ https://reviews.llvm.org/D81045 ___ cfe-commits mailing list cfe-c

[PATCH] D81045: [LLVM] Change isa<> to a variadic function template

jurahul updated this revision to Diff 270015. jurahul edited the summary of this revision. jurahul added a comment. Address review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81045/new/ https://reviews.llvm.org/D81045 Files: clang/inc

[PATCH] D81045: [LLVM] Change isa<> to a variadic function template

jurahul updated this revision to Diff 269870. jurahul added a comment. Split isa<> changes into its own change Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81045/new/ https://reviews.llvm.org/D81045 Files: clang/include/clang/AST/DeclBase.h l

[PATCH] D81045: [MLIR] Modify HasParent trait to allow one of several op's as a parent

jurahul added inline comments. Comment at: llvm/include/llvm/Support/Casting.h:147 +template +LLVM_NODISCARD inline typename std::enable_if::type +isa(const Y &Val) { jpienaar wrote: > I'm worried that folks may not notice this change based on the change > desc

[PATCH] D81045: [MLIR] Modify HasParent trait to allow one of several op's as a parent

jurahul added a comment. This is ready for review. The 2 Clang hip related failure are not caused by this change, and the offending change has been reverted now (http://lists.llvm.org/pipermail/cfe-commits/Week-of-Mon-20200601/323475.html) Repository: rG LLVM Github Monorepo CHANGES SINCE L

[PATCH] D81045: [MLIR] Modify HasParent trait to allow one of several op's as a parent

jurahul updated this revision to Diff 268929. jurahul added a comment. Remove {} in ScalarEvolution.cpp to match existing style Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81045/new/ https://reviews.llvm.org/D81045 Files: clang/include/clang/A

[PATCH] D81045: [MLIR] Modify HasParent trait to allow one of several op's as a parent

jurahul updated this revision to Diff 268905. jurahul added a comment. fix MLIR test failure due to change in error message. Reinstate the old message for a single parent case Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81045/new/ https://review

[PATCH] D81045: [MLIR] Modify HasParent trait to allow one of several op's as a parent

jurahul updated this revision to Diff 268903. jurahul added a comment. Fix Clang build failure Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81045/new/ https://reviews.llvm.org/D81045 Files: clang/include/clang/AST/DeclBase.h llvm/include/llvm

[PATCH] D81045: [MLIR] Modify HasParent trait to allow one of several op's as a parent

jurahul updated this revision to Diff 268618. jurahul added a comment. Herald added subscribers: cfe-commits, msifontes. Herald added a project: clang. Fix Clang build failure Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81045/new/ https://reviews