r313675 - [OpenMP] fix seg-faults printing diagnostics with invalid ordered(n) values

2017-09-19 Thread Rachel Craik via cfe-commits
Author: rcraik Date: Tue Sep 19 14:04:23 2017 New Revision: 313675 URL: http://llvm.org/viewvc/llvm-project?rev=313675&view=rev Log: [OpenMP] fix seg-faults printing diagnostics with invalid ordered(n) values When the value specified for n in ordered(n) is larger than the number of loops a segme

[libcxx] r308932 - Remove addtional parameters in function std::next() and std::prev()

2017-07-24 Thread Rachel Craik via cfe-commits
Author: rcraik Date: Mon Jul 24 15:17:05 2017 New Revision: 308932 URL: http://llvm.org/viewvc/llvm-project?rev=308932&view=rev Log: Remove addtional parameters in function std::next() and std::prev() Creating a function pointer with proper parameters pointing to std::next() or std::prev() shoul

Re: r247618 - C11 _Bool bitfield diagnostic

2015-09-14 Thread Rachel Craik via cfe-commits
elds for MS bitfield layout, rather than just warning on them? (Does record layout fail somehow?) On Mon, Sep 14, 2015 at 2:27 PM, Rachel Craik via cfe-commits < cfe-commits@lists.llvm.org> wrote: Author: rcraik Date: Mon Sep 14 16:27:36 2015 New Revision: 247618

r247618 - C11 _Bool bitfield diagnostic

2015-09-14 Thread Rachel Craik via cfe-commits
Author: rcraik Date: Mon Sep 14 16:27:36 2015 New Revision: 247618 URL: http://llvm.org/viewvc/llvm-project?rev=247618&view=rev Log: C11 _Bool bitfield diagnostic Summary: Implement DR262 (for C). This patch will mainly affect bitfields of type _Bool Reviewers: fraggamuffin, rsmith Subscribers

r247560 - Test commit

2015-09-14 Thread Rachel Craik via cfe-commits
Author: rcraik Date: Mon Sep 14 09:08:18 2015 New Revision: 247560 URL: http://llvm.org/viewvc/llvm-project?rev=247560&view=rev Log: Test commit Remove some trailing whitespace Modified: cfe/trunk/lib/Basic/Builtins.cpp Modified: cfe/trunk/lib/Basic/Builtins.cpp URL: http://llvm.org/viewvc

Re: [PATCH] D10018: C11 _Bool bitfield diagnostic

2015-09-11 Thread Rachel Craik via cfe-commits
rcraik marked 3 inline comments as done. rcraik added a comment. http://reviews.llvm.org/D10018 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D10018: C11 _Bool bitfield diagnostic

2015-09-11 Thread Rachel Craik via cfe-commits
rcraik updated the summary for this revision. rcraik updated this revision to Diff 34571. rcraik added a comment. switched to using getIntWidth instead of getTypeSize and updated the error and warning messages accordingly, as have the necessary test cases. The separate check for _Bool bitfields

Re: [PATCH] D10018: C11 _Bool bitfield diagnostic

2015-09-10 Thread Rachel Craik via cfe-commits
rcraik added inline comments. Comment at: lib/Sema/SemaDecl.cpp:12586 @@ -12585,3 +12585,3 @@ if (!FieldTy->isDependentType()) { uint64_t TypeSize = Context.getTypeSize(FieldTy); if (Value.getZExtValue() > TypeSize) { hubert.reinterpretcast wrote: > r

Re: [PATCH] D10018: C11 _Bool bitfield diagnostic

2015-09-09 Thread Rachel Craik via cfe-commits
rcraik updated this revision to Diff 34339. rcraik added a comment. I've updated the message to make it a bit clearer that this is a portability concern. Are there any further concerns with this patch? http://reviews.llvm.org/D10018 Files: include/clang/Basic/DiagnosticGroups.td include/cl

Re: [PATCH] D11582: Fix assertion failure in TransformOpaqueValueExpr

2015-08-31 Thread Rachel Craik via cfe-commits
rcraik added a comment. Ping 3! http://reviews.llvm.org/D11582 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D11582: Fix assertion failure in TransformOpaqueValueExpr

2015-08-12 Thread Rachel Craik via cfe-commits
rcraik added a comment. ping 2! http://reviews.llvm.org/D11582 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D10018: C11 _Bool bitfield diagnostic

2015-08-06 Thread Rachel Craik via cfe-commits
rcraik marked 2 inline comments as done. rcraik added a comment. http://reviews.llvm.org/D10018 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits