[PATCH] D156858: Add Documentation for Execution Results Handling in Clang-REPL

QuillPusher accepted this revision. QuillPusher added a comment. This revision is now accepted and ready to land. Thanks @Krishna-13-cyber for the prompt efforts @v.g.vassilev it is ready to commit as far as I can see Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://rev

[PATCH] D156858: Add Documentation for Execution Results Handling in Clang-REPL

QuillPusher added a comment. @Krishna-13-cyber added Graphviz code snippets to replace all .png images Comment at: clang/docs/ClangRepl.rst:248-250 +.. image:: valuesynth.png + :align: center + :alt: valuesynth design v.g.vassilev wrote: > Can we replace t

[PATCH] D156858: Add Documentation for Execution Results Handling in Clang-REPL

QuillPusher added inline comments. Comment at: clang/docs/ClangRepl.rst:393-396 + +.. image:: autoprint.png + :align: center + :alt: autoprint design Please replace the image reference with the following Graphviz code (do not delete the image .png for now, w

[PATCH] D156858: Add Documentation for Execution Results Handling in Clang-REPL

QuillPusher requested changes to this revision. QuillPusher added a comment. This revision now requires changes to proceed. Added minor changes requested by Vassil Comment at: clang/docs/ClangRepl.rst:296 + +For example, the CPPYY code makes use of this feature to enable runnin

[PATCH] D156858: Add Documentation for Execution Results Handling in Clang-REPL

QuillPusher accepted this revision. QuillPusher added a comment. This revision is now accepted and ready to land. accepting current revision, one minor change is still required, adding that separately Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D1

[PATCH] D156858: Add Documentation for Execution Results Handling in Clang-REPL

QuillPusher requested changes to this revision. QuillPusher added a comment. This revision now requires changes to proceed. added minor changes based on Vassil's review during docs meeting Comment at: clang/docs/ClangRepl.rst:220-230 + +:doc:`ExecutionResultsHandling` helps ext

[PATCH] D156858: Add Documentation for Execution Results Handling in Clang-REPL

QuillPusher accepted this revision. QuillPusher added a comment. This revision is now accepted and ready to land. Thanks @Krishna-13-cyber for the prompt changes. @v.g.vassilev If no further changes are required by @junaire , then this should be ready to merge Repository: rG LLVM Github Mono

[PATCH] D156858: Add Documentation for Execution Results Handling in Clang-REPL

QuillPusher requested changes to this revision. QuillPusher added a comment. This revision now requires changes to proceed. Thanks @junaire for the clarification, following is the updated document structure: 1. Capture Execution Results - How the Feature works - more details - Implementati

[PATCH] D156858: Add Documentation for Execution Results Handling in Clang-REPL

QuillPusher accepted this revision. QuillPusher added a comment. This revision is now accepted and ready to land. Thanks for the updates, look OK to me Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156858/new/ https://reviews.llvm.org/D156858

[PATCH] D156858: Add Documentation for Execution Results Handling in Clang-REPL

QuillPusher requested changes to this revision. QuillPusher added a comment. This revision now requires changes to proceed. added some comments for minor changes. Two sections to be removed since they are not yet merged to upstream code: - Complex Data Types - Users can create their own types