[PATCH] D108045: [clangd] Fix clangd crash when including a header

qdelacru added a comment. Yes please land this. Thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108045/new/ https://reviews.llvm.org/D108045 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/

[PATCH] D108045: [clangd] Fix clangd crash when including a header

qdelacru updated this revision to Diff 372005. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108045/new/ https://reviews.llvm.org/D108045 Files: clang-tools-extra/clangd/CodeComplete.cpp clang-tools-extra/clangd/ParsedAST.cpp clang-tools-extra/clangd/Preamble.cpp clang-tools-extr

[PATCH] D108045: [clangd] Fix clangd crash when including a header

qdelacru updated this revision to Diff 369581. qdelacru added a comment. Create macro directive only preamble patch for code completion CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108045/new/ https://reviews.llvm.org/D108045 Files: clang-tools-extra/clangd/CodeComplete.cpp clang-

[PATCH] D108045: [clangd] Fix clangd crash when including a header

qdelacru updated this revision to Diff 366358. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108045/new/ https://reviews.llvm.org/D108045 Files: clang-tools-extra/clangd/CodeComplete.cpp clang-tools-extra/clangd/Preamble.cpp clang-tools-extra/clangd/unittests/CodeCompleteTests.cpp

[PATCH] D108045: [clangd] Fix clangd crash when including a header

qdelacru created this revision. qdelacru added a reviewer: kadircet. Herald added subscribers: usaxena95, arphaman. qdelacru requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. Fixes https://github.com/clangd/

[PATCH] D105451: [clang] Fix crash when there is an invalid declaration with flag -Wcast-align

qdelacru added a comment. Please use Queen Dela Cruz, qdela...@cisco.com. Thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105451/new/ https://reviews.llvm.org/D105451 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists

[PATCH] D105451: [clang] Fix crash when there is an invalid declaration with flag -Wcast-align

qdelacru updated this revision to Diff 356836. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105451/new/ https://reviews.llvm.org/D105451 Files: clang/lib/Sema/SemaChecking.cpp clang/test/Sema/warn-cast-align.c Index: clang/test/Sema/warn-cast-align.c ==

[PATCH] D105451: [clang] Fix crash when there is an invalid declaration with flag -Wcast-align

qdelacru updated this revision to Diff 356591. qdelacru added a comment. Fix format CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105451/new/ https://reviews.llvm.org/D105451 Files: clang/lib/Sema/SemaChecking.cpp clang/test/Sema/warn-cast-align.c Index: clang/test/Sema/warn-cast

[PATCH] D105451: [clang] Fix crash when there is an invalid declaration with flag -Wcast-align

qdelacru created this revision. qdelacru added a reviewer: aaron.ballman. qdelacru requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. When there is unknown type in a struct in code compiled with -Wcast-align, the compiler crashes due to clang

[PATCH] D101870: [clangd] Check if macro is already in the IdentifierTable before loading it

qdelacru added a comment. Yes I need help landing this, please use qdela...@cisco.com. Thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101870/new/ https://reviews.llvm.org/D101870 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D101870: [clangd] Check if macro is already in the IdentifierTable before loading it

qdelacru updated this revision to Diff 343141. qdelacru added a comment. Added suggested new test case CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101870/new/ https://reviews.llvm.org/D101870 Files: clang-tools-extra/clangd/CodeComplete.cpp clang-tools-extra/clangd/unittests/Code

[PATCH] D101870: [clangd] Check if macro is already in the IdentifierTable before loading it

qdelacru created this revision. qdelacru added a reviewer: sammccall. Herald added subscribers: usaxena95, kadircet, arphaman. qdelacru requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. Having nested macros