https://github.com/Priyanshu3820 edited
https://github.com/llvm/llvm-project/pull/172299
___
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/Priyanshu3820 created
https://github.com/llvm/llvm-project/pull/172299
None
>From 2fc787b56e25b558e4740f88f9406d806705087f Mon Sep 17 00:00:00 2001
From: Priyanshu3820 <[email protected]>
Date: Mon, 15 Dec 2025 19:27:20 +0530
Subject: [PATCH] Emit CIR op for select/sele
Priyanshu3820 wrote:
> Most people just drop their PR and reopen a new one, which doesn't spam a lot
> of people. ;) I got auto subscribed because of the clang-format label.
Will surely keep that in mind for future PRs. Apologies for the inconvenience
caused.
https://github.com/llvm/llvm-proj
https://github.com/Priyanshu3820 updated
https://github.com/llvm/llvm-project/pull/171615
>From 286dba2d5a5ca74c84c4e221192bf51cc6a731a3 Mon Sep 17 00:00:00 2001
From: Priyanshu Kumar <[email protected]>
Date: Fri, 12 Dec 2025 10:57:40 +
Subject: [PATCH 1/2] Resolve conflict
---
clan
https://github.com/Priyanshu3820 updated
https://github.com/llvm/llvm-project/pull/171615
>From 286dba2d5a5ca74c84c4e221192bf51cc6a731a3 Mon Sep 17 00:00:00 2001
From: Priyanshu Kumar <[email protected]>
Date: Fri, 12 Dec 2025 10:57:40 +
Subject: [PATCH 1/2] Resolve conflict
---
clan
Priyanshu3820 wrote:
thanks @badumbatish
https://github.com/llvm/llvm-project/pull/171615
___
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/Priyanshu3820 updated
https://github.com/llvm/llvm-project/pull/171615
>From 286dba2d5a5ca74c84c4e221192bf51cc6a731a3 Mon Sep 17 00:00:00 2001
From: Priyanshu Kumar <[email protected]>
Date: Fri, 12 Dec 2025 10:57:40 +
Subject: [PATCH 1/3] Resolve conflict
---
clan
@@ -1662,12 +1662,43 @@ CIRGenFunction::emitX86BuiltinExpr(unsigned builtinID,
const CallExpr *expr) {
case X86::BI__builtin_ia32_cmpnltsd:
case X86::BI__builtin_ia32_cmpnlesd:
case X86::BI__builtin_ia32_cmpordsd:
+cgm.errorNYI(expr->getSourceRange(),
+
https://github.com/Priyanshu3820 updated
https://github.com/llvm/llvm-project/pull/171615
>From 286dba2d5a5ca74c84c4e221192bf51cc6a731a3 Mon Sep 17 00:00:00 2001
From: Priyanshu Kumar <[email protected]>
Date: Fri, 12 Dec 2025 10:57:40 +
Subject: [PATCH 1/2] Resolve conflict
---
clan
@@ -1662,12 +1662,43 @@ CIRGenFunction::emitX86BuiltinExpr(unsigned builtinID,
const CallExpr *expr) {
case X86::BI__builtin_ia32_cmpnltsd:
case X86::BI__builtin_ia32_cmpnlesd:
case X86::BI__builtin_ia32_cmpordsd:
+cgm.errorNYI(expr->getSourceRange(),
+
Priyanshu3820 wrote:
hi @andykaylor, I encountered lots of conflicts during a rebase(affected dozens
of files) which triggered the llvmbot to add all these unrelated labels. Now I
have cleaned the branch and run a clean rebase but the labels are still there.
https://github.com/llvm/llvm-projec
https://github.com/Priyanshu3820 updated
https://github.com/llvm/llvm-project/pull/171615
>From 286dba2d5a5ca74c84c4e221192bf51cc6a731a3 Mon Sep 17 00:00:00 2001
From: Priyanshu Kumar <[email protected]>
Date: Fri, 12 Dec 2025 10:57:40 +
Subject: [PATCH] Resolve conflict
---
clang/li
Priyanshu3820 wrote:
@llvmbot, you've added too many labels. Just keep `Clang` and `ClangIR` and
remove the rest
https://github.com/llvm/llvm-project/pull/171615
___
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/ma
https://github.com/Priyanshu3820 updated
https://github.com/llvm/llvm-project/pull/171615
>From 27136522eec0e27493145a7c5cac2b8cf8bcfe42 Mon Sep 17 00:00:00 2001
From: Priyanshu Kumar <[email protected]>
Date: Fri, 12 Dec 2025 10:57:40 +
Subject: [PATCH] Resolve conflict
---
clang/li
https://github.com/Priyanshu3820 updated
https://github.com/llvm/llvm-project/pull/171615
error: too big or took too long to generate
___
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -1662,12 +1662,43 @@ CIRGenFunction::emitX86BuiltinExpr(unsigned builtinID,
const CallExpr *expr) {
case X86::BI__builtin_ia32_cmpnltsd:
case X86::BI__builtin_ia32_cmpnlesd:
case X86::BI__builtin_ia32_cmpordsd:
+cgm.errorNYI(expr->getSourceRange(),
+
@@ -1602,12 +1514,40 @@ mlir::Value CIRGenFunction::emitX86BuiltinExpr(unsigned
builtinID,
case X86::BI__builtin_ia32_cmpnltsd:
case X86::BI__builtin_ia32_cmpnlesd:
case X86::BI__builtin_ia32_cmpordsd:
- case X86::BI__builtin_ia32_vcvtph2ps_mask:
- case X86::BI__builti
https://github.com/Priyanshu3820 updated
https://github.com/llvm/llvm-project/pull/171615
>From ea26e94f1ab429798860705ddd65d4e8f58c4103 Mon Sep 17 00:00:00 2001
From: Priyanshu3820 <[email protected]>
Date: Wed, 10 Dec 2025 18:34:52 +0530
Subject: [PATCH 01/12] Implement convert_half buil
@@ -1602,12 +1514,40 @@ mlir::Value CIRGenFunction::emitX86BuiltinExpr(unsigned
builtinID,
case X86::BI__builtin_ia32_cmpnltsd:
case X86::BI__builtin_ia32_cmpnlesd:
case X86::BI__builtin_ia32_cmpordsd:
- case X86::BI__builtin_ia32_vcvtph2ps_mask:
- case X86::BI__builti
@@ -0,0 +1,67 @@
+// RUN: %clang_cc1 -triple x86_64-unknown-linux-gnu -target-feature
+avx512fp16 -target-feature +avx512bf16 -fclangir -emit-cir %s -o - | FileCheck
%s --check-prefix=CIR
+// RUN: %clang_cc1 -triple x86_64-unknown-linux-gnu -target-feature
+avx512fp16 -target-f
https://github.com/Priyanshu3820 updated
https://github.com/llvm/llvm-project/pull/171615
>From ea26e94f1ab429798860705ddd65d4e8f58c4103 Mon Sep 17 00:00:00 2001
From: Priyanshu3820 <[email protected]>
Date: Wed, 10 Dec 2025 18:34:52 +0530
Subject: [PATCH 01/11] Implement convert_half buil
https://github.com/Priyanshu3820 updated
https://github.com/llvm/llvm-project/pull/171615
>From ea26e94f1ab429798860705ddd65d4e8f58c4103 Mon Sep 17 00:00:00 2001
From: Priyanshu3820 <[email protected]>
Date: Wed, 10 Dec 2025 18:34:52 +0530
Subject: [PATCH 01/10] Implement convert_half buil
Priyanshu3820 wrote:
> > @andykaylor, the CI checks are failing and the build log is saying this-
> > `/home/gha/actions-runner/_work/llvm-project/llvm-project/clang/lib/CIR/CodeGen/CIRGenStmt.cpp:117:11:
> > error: enumeration value 'DeferStmtClass' not handled in switch
> > [-Werror,-Wswitch]
https://github.com/Priyanshu3820 updated
https://github.com/llvm/llvm-project/pull/171615
>From ea26e94f1ab429798860705ddd65d4e8f58c4103 Mon Sep 17 00:00:00 2001
From: Priyanshu3820 <[email protected]>
Date: Wed, 10 Dec 2025 18:34:52 +0530
Subject: [PATCH 01/10] Implement convert_half buil
https://github.com/Priyanshu3820 updated
https://github.com/llvm/llvm-project/pull/171615
>From ea26e94f1ab429798860705ddd65d4e8f58c4103 Mon Sep 17 00:00:00 2001
From: Priyanshu3820 <[email protected]>
Date: Wed, 10 Dec 2025 18:34:52 +0530
Subject: [PATCH 1/9] Implement convert_half builti
https://github.com/Priyanshu3820 updated
https://github.com/llvm/llvm-project/pull/171615
Unicorn! · GitHub
body {
background-color: #f1f1f1;
margin: 0;
font-family: "Helvetica Neue", Helvetica, Arial, sans-serif;
}
.container { margin: 5
Priyanshu3820 wrote:
@andykaylor, the CI checks are failing and the build log is saying this-
`/home/gha/actions-runner/_work/llvm-project/llvm-project/clang/lib/CIR/CodeGen/CIRGenStmt.cpp:117:11:
error: enumeration value 'DeferStmtClass' not handled in switch
[-Werror,-Wswitch]
117 | swit
https://github.com/Priyanshu3820 updated
https://github.com/llvm/llvm-project/pull/171615
>From 8ca7bbb9da45b696760d1071341717cf4ccafe2c Mon Sep 17 00:00:00 2001
From: Priyanshu3820 <[email protected]>
Date: Wed, 10 Dec 2025 18:34:52 +0530
Subject: [PATCH 1/8] Implement convert_half builti
https://github.com/Priyanshu3820 updated
https://github.com/llvm/llvm-project/pull/171615
>From 8ca7bbb9da45b696760d1071341717cf4ccafe2c Mon Sep 17 00:00:00 2001
From: Priyanshu3820 <[email protected]>
Date: Wed, 10 Dec 2025 18:34:52 +0530
Subject: [PATCH 1/7] Implement convert_half builti
https://github.com/Priyanshu3820 updated
https://github.com/llvm/llvm-project/pull/171615
>From 8ca7bbb9da45b696760d1071341717cf4ccafe2c Mon Sep 17 00:00:00 2001
From: Priyanshu3820 <[email protected]>
Date: Wed, 10 Dec 2025 18:34:52 +0530
Subject: [PATCH 1/4] Implement convert_half builti
https://github.com/Priyanshu3820 updated
https://github.com/llvm/llvm-project/pull/171615
>From 8ca7bbb9da45b696760d1071341717cf4ccafe2c Mon Sep 17 00:00:00 2001
From: Priyanshu3820 <[email protected]>
Date: Wed, 10 Dec 2025 18:34:52 +0530
Subject: [PATCH 1/3] Implement convert_half builti
https://github.com/Priyanshu3820 updated
https://github.com/llvm/llvm-project/pull/171615
>From 8ca7bbb9da45b696760d1071341717cf4ccafe2c Mon Sep 17 00:00:00 2001
From: Priyanshu3820 <[email protected]>
Date: Wed, 10 Dec 2025 18:34:52 +0530
Subject: [PATCH 1/2] Implement convert_half builti
https://github.com/Priyanshu3820 updated
https://github.com/llvm/llvm-project/pull/171615
>From 8ca7bbb9da45b696760d1071341717cf4ccafe2c Mon Sep 17 00:00:00 2001
From: Priyanshu3820 <[email protected]>
Date: Wed, 10 Dec 2025 18:34:52 +0530
Subject: [PATCH] Implement convert_half builtin
-
https://github.com/Priyanshu3820 updated
https://github.com/llvm/llvm-project/pull/171615
>From 2faec1394b8af173e845399c212f1ad4a28efd70 Mon Sep 17 00:00:00 2001
From: Priyanshu3820 <[email protected]>
Date: Wed, 10 Dec 2025 18:34:52 +0530
Subject: [PATCH 1/6] Implement convert_half builti
@@ -1602,12 +1514,40 @@ mlir::Value CIRGenFunction::emitX86BuiltinExpr(unsigned
builtinID,
case X86::BI__builtin_ia32_cmpnltsd:
case X86::BI__builtin_ia32_cmpnlesd:
case X86::BI__builtin_ia32_cmpordsd:
- case X86::BI__builtin_ia32_vcvtph2ps_mask:
- case X86::BI__builti
https://github.com/Priyanshu3820 updated
https://github.com/llvm/llvm-project/pull/171615
>From 2faec1394b8af173e845399c212f1ad4a28efd70 Mon Sep 17 00:00:00 2001
From: Priyanshu3820 <[email protected]>
Date: Wed, 10 Dec 2025 18:34:52 +0530
Subject: [PATCH 1/5] Implement convert_half builti
Priyanshu3820 wrote:
> you can use `clang/tools/clang-format/git-clang-format --binary
> ./build/bin/clang-format HEAD~1` to format your changes so it doesn't trigger
> the CI warning.
done
https://github.com/llvm/llvm-project/pull/171615
___
cfe-c
https://github.com/Priyanshu3820 deleted
https://github.com/llvm/llvm-project/pull/171615
___
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -1602,12 +1514,40 @@ mlir::Value CIRGenFunction::emitX86BuiltinExpr(unsigned
builtinID,
case X86::BI__builtin_ia32_cmpnltsd:
case X86::BI__builtin_ia32_cmpnlesd:
case X86::BI__builtin_ia32_cmpordsd:
- case X86::BI__builtin_ia32_vcvtph2ps_mask:
- case X86::BI__builti
https://github.com/Priyanshu3820 updated
https://github.com/llvm/llvm-project/pull/171615
>From 2faec1394b8af173e845399c212f1ad4a28efd70 Mon Sep 17 00:00:00 2001
From: Priyanshu3820 <[email protected]>
Date: Wed, 10 Dec 2025 18:34:52 +0530
Subject: [PATCH 1/4] Implement convert_half builti
https://github.com/Priyanshu3820 updated
https://github.com/llvm/llvm-project/pull/171615
Unicorn! · GitHub
body {
background-color: #f1f1f1;
margin: 0;
font-family: "Helvetica Neue", Helvetica, Arial, sans-serif;
}
.container { margin: 5
https://github.com/Priyanshu3820 updated
https://github.com/llvm/llvm-project/pull/171615
>From 2faec1394b8af173e845399c212f1ad4a28efd70 Mon Sep 17 00:00:00 2001
From: Priyanshu3820 <[email protected]>
Date: Wed, 10 Dec 2025 18:34:52 +0530
Subject: [PATCH 1/2] Implement convert_half builti
https://github.com/Priyanshu3820 edited
https://github.com/llvm/llvm-project/pull/171615
___
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/Priyanshu3820 created
https://github.com/llvm/llvm-project/pull/171615
related to #167765
Calls the LLVM intrinsic for the following builtins-
`BI__builtin_ia32_vcvtph2ps_mask`
`BI__builtin_ia32_vcvtph2ps256_mask`
`BI__builtin_ia32_vcvtph2ps512_mask`
`BI__builtin_ia32_cvtne
Priyanshu3820 wrote:
Thanks @andykaylor for the review and guidance! This was a great learning
experience.
https://github.com/llvm/llvm-project/pull/169310
___
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/
Priyanshu3820 wrote:
hey @andykaylor, I have run the tests locally and they were successful. I have
also pasted the last few lines of the output log in the PR description. Please
have a look.
https://github.com/llvm/llvm-project/pull/169310
___
cfe-c
https://github.com/Priyanshu3820 edited
https://github.com/llvm/llvm-project/pull/169310
___
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/Priyanshu3820 updated
https://github.com/llvm/llvm-project/pull/169310
>From 627bcb3bde64a780ed2b99267d97c9679f9c Mon Sep 17 00:00:00 2001
From: Priyanshu3820 <[email protected]>
Date: Wed, 26 Nov 2025 17:45:00 +0530
Subject: [PATCH 01/28] Add CIR sqrt builtin suppor
https://github.com/Priyanshu3820 updated
https://github.com/llvm/llvm-project/pull/169310
>From 627bcb3bde64a780ed2b99267d97c9679f9c Mon Sep 17 00:00:00 2001
From: Priyanshu3820 <[email protected]>
Date: Wed, 26 Nov 2025 17:45:00 +0530
Subject: [PATCH 01/27] Add CIR sqrt builtin suppor
Priyanshu3820 wrote:
> This looks good except for the BOM issue.
removed now
https://github.com/llvm/llvm-project/pull/169310
___
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/Priyanshu3820 updated
https://github.com/llvm/llvm-project/pull/169310
>From 627bcb3bde64a780ed2b99267d97c9679f9c Mon Sep 17 00:00:00 2001
From: Priyanshu3820 <[email protected]>
Date: Wed, 26 Nov 2025 17:45:00 +0530
Subject: [PATCH 01/27] Add CIR sqrt builtin suppor
https://github.com/Priyanshu3820 updated
https://github.com/llvm/llvm-project/pull/169310
>From 627bcb3bde64a780ed2b99267d97c9679f9c Mon Sep 17 00:00:00 2001
From: Priyanshu3820 <[email protected]>
Date: Wed, 26 Nov 2025 17:45:00 +0530
Subject: [PATCH 01/26] Add CIR sqrt builtin suppor
@@ -45,6 +46,14 @@
using namespace cir;
using namespace llvm;
+// Actual lowering
Priyanshu3820 wrote:
I must have somehow removed the beginning during some commits. It is now
rectified, moved to where other floating point ops are located and #include
"clan
@@ -781,9 +781,21 @@ mlir::Value CIRGenFunction::emitX86BuiltinExpr(unsigned
builtinID,
case X86::BI__builtin_ia32_sqrtsh_round_mask:
case X86::BI__builtin_ia32_sqrtsd_round_mask:
case X86::BI__builtin_ia32_sqrtss_round_mask:
+ case X86::BI__builtin_ia32_sqrtpd256:
+ c
https://github.com/Priyanshu3820 updated
https://github.com/llvm/llvm-project/pull/169310
>From 627bcb3bde64a780ed2b99267d97c9679f9c Mon Sep 17 00:00:00 2001
From: Priyanshu3820 <[email protected]>
Date: Wed, 26 Nov 2025 17:45:00 +0530
Subject: [PATCH 01/17] Add CIR sqrt builtin suppor
https://github.com/Priyanshu3820 updated
https://github.com/llvm/llvm-project/pull/169310
>From 627bcb3bde64a780ed2b99267d97c9679f9c Mon Sep 17 00:00:00 2001
From: Priyanshu3820 <[email protected]>
Date: Wed, 26 Nov 2025 17:45:00 +0530
Subject: [PATCH 01/14] Add CIR sqrt builtin suppor
https://github.com/Priyanshu3820 updated
https://github.com/llvm/llvm-project/pull/169310
>From 627bcb3bde64a780ed2b99267d97c9679f9c Mon Sep 17 00:00:00 2001
From: Priyanshu3820 <[email protected]>
Date: Wed, 26 Nov 2025 17:45:00 +0530
Subject: [PATCH 01/13] Add CIR sqrt builtin suppor
https://github.com/Priyanshu3820 updated
https://github.com/llvm/llvm-project/pull/169310
>From 627bcb3bde64a780ed2b99267d97c9679f9c Mon Sep 17 00:00:00 2001
From: Priyanshu3820 <[email protected]>
Date: Wed, 26 Nov 2025 17:45:00 +0530
Subject: [PATCH 1/4] Add CIR sqrt builtin support
https://github.com/Priyanshu3820 updated
https://github.com/llvm/llvm-project/pull/169310
>From 627bcb3bde64a780ed2b99267d97c9679f9c Mon Sep 17 00:00:00 2001
From: Priyanshu3820 <[email protected]>
Date: Wed, 26 Nov 2025 17:45:00 +0530
Subject: [PATCH 1/3] Add CIR sqrt builtin support
https://github.com/Priyanshu3820 updated
https://github.com/llvm/llvm-project/pull/169310
>From 627bcb3bde64a780ed2b99267d97c9679f9c Mon Sep 17 00:00:00 2001
From: Priyanshu3820 <[email protected]>
Date: Wed, 26 Nov 2025 17:45:00 +0530
Subject: [PATCH 1/2] Add CIR sqrt builtin support
https://github.com/Priyanshu3820 edited
https://github.com/llvm/llvm-project/pull/169310
___
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/Priyanshu3820 edited
https://github.com/llvm/llvm-project/pull/169310
___
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/Priyanshu3820 edited
https://github.com/llvm/llvm-project/pull/169310
___
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Priyanshu3820 wrote:
just saw PR #165682 has been merged, which removes these x86 sqrt builtins from
clang. I'm waiting for guidance on whether CIR should still implement these or
follow upstream's direction with __builtin_elementwise_sqrt.
https://github.com/llvm/llvm-project/pull/169310
https://github.com/Priyanshu3820 updated
https://github.com/llvm/llvm-project/pull/169310
>From 627bcb3bde64a780ed2b99267d97c9679f9c Mon Sep 17 00:00:00 2001
From: Priyanshu3820 <[email protected]>
Date: Wed, 26 Nov 2025 17:45:00 +0530
Subject: [PATCH] Add CIR sqrt builtin support for
Priyanshu3820 wrote:
> Yes, exactly. AFAICT you're implementing functionality which will be removed.
> More generally, you might want to check whether any builtins generate
> platform-specific IR instructions. If no, there is (or should) probably be a
> generic version, which the x86 builtins
Priyanshu3820 wrote:
hi @andykaylor, @philnik777's PR #165682 is removing the x86 sqrt builtins from
Clang and replacing them with generic __builtin_elementwise_sqrt versions. I
just wanted to clarify whether removing these builtins from clang also mean
that we will be going to remove them fro
Priyanshu3820 wrote:
> I think #165682 is removing all the builtins implemented here.
Thanks for letting me know. Just to clarify, my PR is implementing CIR lowering
for these builtins, not modifying Clang's builtin definitions themselves. But
you raised a good point that if #165682 removes th
https://github.com/Priyanshu3820 updated
https://github.com/llvm/llvm-project/pull/169310
>From 627bcb3bde64a780ed2b99267d97c9679f9c Mon Sep 17 00:00:00 2001
From: Priyanshu3820 <[email protected]>
Date: Wed, 26 Nov 2025 17:45:00 +0530
Subject: [PATCH] Add CIR sqrt builtin support for
https://github.com/Priyanshu3820 updated
https://github.com/llvm/llvm-project/pull/169310
>From 627bcb3bde64a780ed2b99267d97c9679f9c Mon Sep 17 00:00:00 2001
From: Priyanshu3820 <[email protected]>
Date: Wed, 26 Nov 2025 17:45:00 +0530
Subject: [PATCH] Add CIR sqrt builtin support for
@@ -0,0 +1,27 @@
+//===- CIROps.h - CIR dialect operations *- C++
-*-===//
Priyanshu3820 wrote:
Done
https://github.com/llvm/llvm-project/pull/169310
___
cfe-commits mailing list
cfe-commits@li
https://github.com/Priyanshu3820 updated
https://github.com/llvm/llvm-project/pull/169310
>From 627bcb3bde64a780ed2b99267d97c9679f9c Mon Sep 17 00:00:00 2001
From: Priyanshu3820 <[email protected]>
Date: Wed, 26 Nov 2025 17:45:00 +0530
Subject: [PATCH] Add CIR sqrt builtin support for
Priyanshu3820 wrote:
@andykaylor Apologies for the noise - I had some git issues that accidentally
included unrelated LLVM changes, which triggered auto-assignment of many
reviewers. The PR is now cleaned up with only the `sqrt` builtin
implementation. Could you help remove the extra reviewers
https://github.com/Priyanshu3820 reopened
https://github.com/llvm/llvm-project/pull/169310
___
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/Priyanshu3820 updated
https://github.com/llvm/llvm-project/pull/169310
>From 627bcb3bde64a780ed2b99267d97c9679f9c Mon Sep 17 00:00:00 2001
From: Priyanshu3820 <[email protected]>
Date: Wed, 26 Nov 2025 17:45:00 +0530
Subject: [PATCH] Add CIR sqrt builtin support for
https://github.com/Priyanshu3820 updated
https://github.com/llvm/llvm-project/pull/169310
>From 31d3e0baa4079d83c9913a6790739d4e0e05859f Mon Sep 17 00:00:00 2001
From: Priyanshu3820 <[email protected]>
Date: Wed, 19 Nov 2025 11:10:41 +0530
Subject: [PATCH 01/13] LowerToLLVM: clean up cir.s
https://github.com/Priyanshu3820 updated
https://github.com/llvm/llvm-project/pull/169310
>From 31d3e0baa4079d83c9913a6790739d4e0e05859f Mon Sep 17 00:00:00 2001
From: Priyanshu3820 <[email protected]>
Date: Wed, 19 Nov 2025 11:10:41 +0530
Subject: [PATCH 01/12] LowerToLLVM: clean up cir.s
@@ -18,6 +18,7 @@
#include "mlir/Conversion/LLVMCommon/TypeConverter.h"
#include "mlir/Dialect/DLTI/DLTI.h"
#include "mlir/Dialect/Func/IR/FuncOps.h"
+#include "mlir/Dialect/LLVMIR/IR/LLVMOps.h"
Priyanshu3820 wrote:
Yes, you're right. I removed it now.
https
https://github.com/Priyanshu3820 updated
https://github.com/llvm/llvm-project/pull/169310
>From 31d3e0baa4079d83c9913a6790739d4e0e05859f Mon Sep 17 00:00:00 2001
From: Priyanshu3820 <[email protected]>
Date: Wed, 19 Nov 2025 11:10:41 +0530
Subject: [PATCH 01/11] LowerToLLVM: clean up cir.s
@@ -914,6 +914,28 @@ static mlir::LogicalResult
checkReturnAndFunction(cir::ReturnOp op,
return mlir::success();
}
+mlir::LogicalResult cir::SqrtOp::verify() {
Priyanshu3820 wrote:
added
https://github.com/llvm/llvm-project/pull/169310
__
https://github.com/Priyanshu3820 updated
https://github.com/llvm/llvm-project/pull/169310
>From 31d3e0baa4079d83c9913a6790739d4e0e05859f Mon Sep 17 00:00:00 2001
From: Priyanshu3820 <[email protected]>
Date: Wed, 19 Nov 2025 11:10:41 +0530
Subject: [PATCH 01/10] LowerToLLVM: clean up cir.s
Priyanshu3820 wrote:
Understood!
https://github.com/llvm/llvm-project/pull/169310
___
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Priyanshu3820 wrote:
May I just move the `sqrt` implementation to the top? That way, the builtins
that are currently above them will just fall through to the NYI error at the
end.
https://github.com/llvm/llvm-project/pull/169310
_
https://github.com/Priyanshu3820 edited
https://github.com/llvm/llvm-project/pull/169310
___
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -44,6 +46,96 @@
using namespace cir;
using namespace llvm;
+using namespace mlir;
+
+static std::string getLLVMIntrinsicNameForType(Type llvmTy) {
Priyanshu3820 wrote:
I had initially planned to use this helper function but then used
`getIntrinsicSuffix()
@@ -44,6 +46,96 @@
using namespace cir;
using namespace llvm;
+using namespace mlir;
Priyanshu3820 wrote:
I had used explicit `mlir::` prefixes throughout but added `using namespace
mlir;` just to prevent any discrepancies. I have removed it now.
https://gi
@@ -18,6 +18,7 @@
#include "mlir/Conversion/LLVMCommon/TypeConverter.h"
#include "mlir/Dialect/DLTI/DLTI.h"
#include "mlir/Dialect/Func/IR/FuncOps.h"
+#include "mlir/Dialect/LLVMIR/IR/LLVMOps.h"
Priyanshu3820 wrote:
This include is needed for `LLVM::LLVMFuncOp
@@ -30,6 +31,7 @@
#include "mlir/Target/LLVMIR/Dialect/LLVMIR/LLVMToLLVMIRTranslation.h"
#include "mlir/Target/LLVMIR/Export.h"
#include "mlir/Transforms/DialectConversion.h"
+#include "clang/Basic/LLVM.h"
Priyanshu3820 wrote:
This is not needed. Thanks for po
https://github.com/Priyanshu3820 deleted
https://github.com/llvm/llvm-project/pull/169310
___
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -1,4 +1,4 @@
-//- LowerToLLVM.cpp - Lowering from CIR to LLVMIR
-===//
+//- LowerToLLVM.cpp - Lowering from CIR to LLVMIR
-===//
Priyanshu3820 wrote:
seems like a phantom diff caused due to line ending differe
@@ -30,6 +31,7 @@
#include "mlir/Target/LLVMIR/Dialect/LLVMIR/LLVMToLLVMIRTranslation.h"
#include "mlir/Target/LLVMIR/Export.h"
#include "mlir/Transforms/DialectConversion.h"
+#include "clang/Basic/LLVM.h"
Priyanshu3820 wrote:
You're right. The file only uses
https://github.com/Priyanshu3820 updated
https://github.com/llvm/llvm-project/pull/169310
>From 31d3e0baa4079d83c9913a6790739d4e0e05859f Mon Sep 17 00:00:00 2001
From: Priyanshu3820 <[email protected]>
Date: Wed, 19 Nov 2025 11:10:41 +0530
Subject: [PATCH 1/9] LowerToLLVM: clean up cir.sqr
@@ -914,6 +914,28 @@ static mlir::LogicalResult
checkReturnAndFunction(cir::ReturnOp op,
return mlir::success();
}
+mlir::LogicalResult cir::SqrtOp::verify() {
Priyanshu3820 wrote:
Removed!
https://github.com/llvm/llvm-project/pull/169310
@@ -716,7 +716,19 @@ mlir::Value CIRGenFunction::emitX86BuiltinExpr(unsigned
builtinID,
case X86::BI__builtin_ia32_sqrtpd256:
case X86::BI__builtin_ia32_sqrtpd:
case X86::BI__builtin_ia32_sqrtps256:
- case X86::BI__builtin_ia32_sqrtps:
+ case X86::BI__builtin_ia32_sqrt
@@ -0,0 +1,27 @@
+//===- CIROps.h - CIR dialect operations *- C++
-*-===//
Priyanshu3820 wrote:
Actually I had added `CIROps.h` because I was getting a compilation error so I
thought a wrapper header would come in handy to access the Tab
https://github.com/Priyanshu3820 updated
https://github.com/llvm/llvm-project/pull/169310
>From 31d3e0baa4079d83c9913a6790739d4e0e05859f Mon Sep 17 00:00:00 2001
From: Priyanshu3820 <[email protected]>
Date: Wed, 19 Nov 2025 11:10:41 +0530
Subject: [PATCH 1/8] LowerToLLVM: clean up cir.sqr
https://github.com/Priyanshu3820 updated
https://github.com/llvm/llvm-project/pull/169310
>From 31d3e0baa4079d83c9913a6790739d4e0e05859f Mon Sep 17 00:00:00 2001
From: Priyanshu3820 <[email protected]>
Date: Wed, 19 Nov 2025 11:10:41 +0530
Subject: [PATCH 1/7] LowerToLLVM: clean up cir.sqr
https://github.com/Priyanshu3820 updated
https://github.com/llvm/llvm-project/pull/169310
>From 31d3e0baa4079d83c9913a6790739d4e0e05859f Mon Sep 17 00:00:00 2001
From: Priyanshu3820 <[email protected]>
Date: Wed, 19 Nov 2025 11:10:41 +0530
Subject: [PATCH 1/6] LowerToLLVM: clean up cir.sqr
https://github.com/Priyanshu3820 updated
https://github.com/llvm/llvm-project/pull/169310
>From 31d3e0baa4079d83c9913a6790739d4e0e05859f Mon Sep 17 00:00:00 2001
From: Priyanshu3820 <[email protected]>
Date: Wed, 19 Nov 2025 11:10:41 +0530
Subject: [PATCH 1/6] LowerToLLVM: clean up cir.sqr
https://github.com/Priyanshu3820 edited
https://github.com/llvm/llvm-project/pull/169310
___
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
1 - 100 of 109 matches
Mail list logo
