[PATCH] D122965: Corrected A Command

2022-04-04 Thread Priyansh Singh via Phabricator via cfe-commits
ps-19 marked an inline comment as done. ps-19 added a comment. Priyansh Singh priyansh.singh...@gmail.com Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122965/new/ https://reviews.llvm.org/D122965 ___ cf

[PATCH] D122965: Corrected A Command

2022-04-04 Thread Priyansh Singh via Phabricator via cfe-commits
ps-19 marked 2 inline comments as done. ps-19 added a comment. Can anyone please review the patch? Comment at: clang/test/CodeGen/c-unicode.c:5 int \uaccess = 0; // ALLOWED: "곎ss": // ALLOWED-NOT: "\uaccess": smeenai wrote: > ps-19 wrote: > > Comment Line No

[PATCH] D122965: Corrected A Command

2022-04-03 Thread Priyansh Singh via Phabricator via cfe-commits
ps-19 updated this revision to Diff 420104. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122965/new/ https://reviews.llvm.org/D122965 Files: clang/test/CodeGen/c-unicode.c Index: clang/test/CodeGen/c-unicode.c ==

[PATCH] D122965: Corrected A Command

2022-04-02 Thread Priyansh Singh via Phabricator via cfe-commits
ps-19 added a comment. In D122965#3424348 , @ps-19 wrote: > I seriously can not understand why x64_Debian build if failing for every > patch. I have ran clang-format command for every patch even multiple times. Repository: rG LLVM Github Monorepo C

[PATCH] D122965: Corrected A Command

2022-04-02 Thread Priyansh Singh via Phabricator via cfe-commits
ps-19 added a comment. I seriously can not understand why x64_Debian build if failing for every patch. Comment at: clang/test/CodeGen/c-unicode.c:5 int \uaccess = 0; // ALLOWED: "곎ss": // ALLOWED-NOT: "\uaccess": Comment Line No: 5 is // ALLOWED: "곎ss": i th

[PATCH] D122965: Correct Command

2022-04-01 Thread Priyansh Singh via Phabricator via cfe-commits
ps-19 created this revision. ps-19 added reviewers: aaron.ballman, ktkachov, beanz, phosek, ldionne, smeenai, compnerd. Herald added a subscriber: pengfei. Herald added a project: All. ps-19 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits.

[PATCH] D122871: Clang-Formatting

2022-04-01 Thread Priyansh Singh via Phabricator via cfe-commits
ps-19 abandoned this revision. ps-19 added a comment. Closed as: 1. Formating test file causes build to fail. 2. Formatting of whole page is not accpeted in LLVM as it created problem future with commands like `git blame` . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION htt

[PATCH] D122871: Clang-Formatting

2022-04-01 Thread Priyansh Singh via Phabricator via cfe-commits
ps-19 added a comment. Pardon, it was my mistake i didn't see that the file i was amending was actually a test file i just search "switch" statement in my script. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122871/new/ https://reviews.llvm.org/D

[PATCH] D122871: Clang-Formatting

2022-04-01 Thread Priyansh Singh via Phabricator via cfe-commits
ps-19 added a comment. okay now i understand the issue completely. If i just mentioned that i am formatting a test file it would be correct then according to my patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122871/new/ https://reviews.llvm.

[PATCH] D122871: Clang-Formatting

2022-03-31 Thread Priyansh Singh via Phabricator via cfe-commits
ps-19 added a comment. I think inbuilt clang formatter in llvm ate up my work. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122871/new/ https://reviews.llvm.org/D122871 ___ cfe-commits mailing list cfe-

[PATCH] D122871: Clang-Formatting

2022-03-31 Thread Priyansh Singh via Phabricator via cfe-commits
ps-19 created this revision. ps-19 added reviewers: aaron.ballman, ktkachov, xbolva00, jyknight, jy7.yang, jyasskin, jyh, jyimusuuhilik, Dan, DaAnIV, danalbert, Danbab, danbeam. Herald added a project: All. ps-19 requested review of this revision. Herald added a project: clang-tools-extra. Herald