[PATCH] D105909: [clang][CallGraphSection] Add type id metadata to indirect call and targets

2023-11-22 Thread Prabhu Karthikeyan Rajasekaran via Phabricator via cfe-commits
Prabhuk updated this revision to Diff 558152. Prabhuk added a comment. Rebased the patchset and addressed the compilation and test failures Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105909/new/ https://reviews.llvm.org/D105909 Files: llvm/in

[PATCH] D105907: [CallGraphSection] Add call graph section options and documentation

2023-11-22 Thread Prabhu Karthikeyan Rajasekaran via Phabricator via cfe-commits
Prabhuk updated this revision to Diff 558151. Prabhuk added a comment. Rebased the patchset and addressed the compilation failures Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105907/new/ https://reviews.llvm.org/D105907 Files: llvm/include/llv

[PATCH] D105907: [CallGraphSection] Add call graph section options and documentation

2023-11-22 Thread Prabhu Karthikeyan Rajasekaran via Phabricator via cfe-commits
Prabhuk commandeered this revision. Prabhuk added a reviewer: necipfazil. Prabhuk added a comment. Herald added a project: All. https://discourse.llvm.org/t/rfc-computing-storing-and-restoring-conservative-call-graphs-with-llvm/58446/3?u=prabhuk Repository: rG LLVM Github Monorepo CHANGES SIN

[PATCH] D105909: [clang][CallGraphSection] Add type id metadata to indirect call and targets

2023-11-22 Thread Prabhu Karthikeyan Rajasekaran via Phabricator via cfe-commits
Prabhuk commandeered this revision. Prabhuk added a reviewer: necipfazil. Prabhuk added a comment. Herald added a project: All. https://discourse.llvm.org/t/rfc-computing-storing-and-restoring-conservative-call-graphs-with-llvm/58446/3?u=prabhuk Repository: rG LLVM Github Monorepo CHANGES SIN

[PATCH] D152206: [Basic] Support 64-bit x86 target for UEFI

2023-09-28 Thread Prabhu Karthikeyan Rajasekaran via Phabricator via cfe-commits
Prabhuk added a comment. Relanding the change as the build dependency issue related to the original patch is fixed by this commit: c43aa466b8980e620fd27404ca2ba60210b76111 Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D152206: [Basic] Support 64-bit x86 target for UEFI

2023-09-28 Thread Prabhu Karthikeyan Rajasekaran via Phabricator via cfe-commits
Prabhuk updated this revision to Diff 557456. Prabhuk added a comment. Relanding the change. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152206/new/ https://reviews.llvm.org/D152206 Files: llvm/lib/IR/DataLayout.cpp llvm/lib/TargetParser/Tri

[PATCH] D152206: [Basic] Support 64-bit x86 target for UEFI

2023-09-28 Thread Prabhu Karthikeyan Rajasekaran via Phabricator via cfe-commits
Prabhuk added inline comments. Comment at: llvm/unittests/IR/DataLayoutTest.cpp:109 +TEST(DataLayoutTest, UEFI) { + Triple TT = Triple("x86_64-unknown-uefi"); + mbrkusanin wrote: > Prabhuk wrote: > > mbrkusanin wrote: > > > This is giving me a linker error: > >

[PATCH] D152206: [Basic] Support 64-bit x86 target for UEFI

2023-09-28 Thread Prabhu Karthikeyan Rajasekaran via Phabricator via cfe-commits
Prabhuk added inline comments. Comment at: llvm/unittests/IR/DataLayoutTest.cpp:109 +TEST(DataLayoutTest, UEFI) { + Triple TT = Triple("x86_64-unknown-uefi"); + mbrkusanin wrote: > This is giving me a linker error: > > $ ninja unittests/IR/IRTests > > /us

[PATCH] D159541: [UEFI] X86_64 UEFI Clang Driver

2023-09-26 Thread Prabhu Karthikeyan Rajasekaran via Phabricator via cfe-commits
Prabhuk updated this revision to Diff 557372. Prabhuk added a comment. Removed IsIntegratedAssemblerDefault. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159541/new/ https://reviews.llvm.org/D159541 Files: clang/lib/Basic/Targets.cpp clang/li

[PATCH] D152206: [Basic] Support 64-bit x86 target for UEFI

2023-09-22 Thread Prabhu Karthikeyan Rajasekaran via Phabricator via cfe-commits
Prabhuk updated this revision to Diff 557263. Prabhuk added a comment. Updated the test name and added comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152206/new/ https://reviews.llvm.org/D152206 Files: llvm/lib/IR/DataLayout.cpp llvm/l

[PATCH] D152206: [Basic] Support 64-bit x86 target for UEFI

2023-09-22 Thread Prabhu Karthikeyan Rajasekaran via Phabricator via cfe-commits
Prabhuk updated this revision to Diff 557261. Prabhuk added a comment. Add DataLayoutTest for UEFI target. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152206/new/ https://reviews.llvm.org/D152206 Files: llvm/lib/IR/DataLayout.cpp llvm/lib/Ta

[PATCH] D159541: [UEFI] X86_64 UEFI Clang Driver

2023-09-22 Thread Prabhu Karthikeyan Rajasekaran via Phabricator via cfe-commits
Prabhuk updated this revision to Diff 557227. Prabhuk added a comment. Addressed review comments about the inline comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159541/new/ https://reviews.llvm.org/D159541 Files: clang/lib/Basic/Targets

[PATCH] D152206: [Basic] Support 64-bit x86 target for UEFI

2023-09-22 Thread Prabhu Karthikeyan Rajasekaran via Phabricator via cfe-commits
Prabhuk added a comment. @phosek -- Regarding the abandoning commit. I had messed up the commit splitting process earlier. Uploaded the correct set of files for this change now. Please take a look. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152

[PATCH] D152206: [Basic] Support 64-bit x86 target for UEFI

2023-09-22 Thread Prabhu Karthikeyan Rajasekaran via Phabricator via cfe-commits
Prabhuk updated this revision to Diff 557223. Prabhuk added a comment. Update patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152206/new/ https://reviews.llvm.org/D152206 Files: llvm/lib/IR/DataLayout.cpp llvm/lib/TargetParser/Triple.cpp

[PATCH] D152206: [Basic] Support 64-bit x86 target for UEFI

2023-09-22 Thread Prabhu Karthikeyan Rajasekaran via Phabricator via cfe-commits
Prabhuk updated this revision to Diff 557221. Prabhuk added a comment. Datalayout update. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152206/new/ https://reviews.llvm.org/D152206 Files: llvm/lib/Target/X86/MCTargetDesc/X86MCTargetDesc.cpp ll

[PATCH] D159540: [Basic] X86 backend changes for UEFI

2023-09-21 Thread Prabhu Karthikeyan Rajasekaran via Phabricator via cfe-commits
Prabhuk updated this revision to Diff 557214. Prabhuk added a comment. Handle UEFI64 in X86RegisterInfo for all Win64 equivalent cases except for Swift and OCL. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159540/new/ https://reviews.llvm.org/D15

[PATCH] D159540: [Basic] X86 backend changes for UEFI

2023-09-21 Thread Prabhu Karthikeyan Rajasekaran via Phabricator via cfe-commits
Prabhuk updated this revision to Diff 557203. Prabhuk added a comment. Uploading the backend changes correctly. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159540/new/ https://reviews.llvm.org/D159540 Files: llvm/lib/Target/X86/MCTargetDesc/X8

[PATCH] D152206: [Basic] Support 64-bit x86 target for UEFI

2023-09-21 Thread Prabhu Karthikeyan Rajasekaran via Phabricator via cfe-commits
Prabhuk marked an inline comment as done. Prabhuk added a comment. Clang Driver Changes - https://reviews.llvm.org/D159541 Current - https://reviews.llvm.org/D152206 X86 Backend changes - https://reviews.llvm.org/D159540 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https:/

[PATCH] D152206: [Basic] Support 64-bit x86 target for UEFI

2023-09-21 Thread Prabhu Karthikeyan Rajasekaran via Phabricator via cfe-commits
Prabhuk updated this revision to Diff 557202. Prabhuk added a comment. Splitting commit into 3 commits. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152206/new/ https://reviews.llvm.org/D152206 Files: llvm/lib/Target/X86/MCTargetDesc/X86MCTarge

[PATCH] D159541: [UEFI] X86_64 UEFI Clang Driver

2023-09-21 Thread Prabhu Karthikeyan Rajasekaran via Phabricator via cfe-commits
Prabhuk created this revision. Prabhuk added a reviewer: phosek. Herald added a subscriber: pengfei. Herald added a project: All. Prabhuk requested review of this revision. Herald added subscribers: cfe-commits, MaskRay. Herald added a project: clang. Introduce changes necessary for UEFI X86_64 ta

[PATCH] D159540: [Basic] X86 backend changes for UEFI

2023-09-21 Thread Prabhu Karthikeyan Rajasekaran via Phabricator via cfe-commits
Prabhuk updated this revision to Diff 557199. Prabhuk added a comment. Herald added subscribers: cfe-commits, MaskRay. Herald added a project: clang. Clang Driver changes for UEFI X86_64 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159540/new/ htt

[PATCH] D152206: [Basic] Support 64-bit x86 target for UEFI

2023-09-20 Thread Prabhu Karthikeyan Rajasekaran via Phabricator via cfe-commits
Prabhuk updated this revision to Diff 557154. Prabhuk added a comment. Minor cleanup. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152206/new/ https://reviews.llvm.org/D152206 Files: clang/lib/Basic/Targets.cpp clang/lib/Basic/Targets/OSTarge

[PATCH] D152206: [Basic] Support 64-bit x86 target for UEFI

2023-09-20 Thread Prabhu Karthikeyan Rajasekaran via Phabricator via cfe-commits
Prabhuk updated this revision to Diff 557153. Prabhuk added a comment. Update X86 backend to use Microsoft ABI for UEFI target. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152206/new/ https://reviews.llvm.org/D152206 Files: clang/lib/Basic/Tar

[PATCH] D152206: [Basic] Support 64-bit x86 target for UEFI

2023-09-14 Thread Prabhu Karthikeyan Rajasekaran via Phabricator via cfe-commits
Prabhuk updated this revision to Diff 556813. Prabhuk marked 2 inline comments as done. Prabhuk added a comment. Addressed review comments. Added "-dll" and "-tsaware:no" linker flags for UEFI. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152206/ne

[PATCH] D152206: [Basic] Support 64-bit x86 target for UEFI

2023-07-13 Thread Prabhu Karthikeyan Rajasekaran via Phabricator via cfe-commits
Prabhuk updated this revision to Diff 540091. Prabhuk marked 5 inline comments as done. Prabhuk added a comment. Minor formatting changes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152206/new/ https://reviews.llvm.org/D152206 Files: clang/li

[PATCH] D152206: [Basic] Support 64-bit x86 target for UEFI

2023-07-13 Thread Prabhu Karthikeyan Rajasekaran via Phabricator via cfe-commits
Prabhuk updated this revision to Diff 540085. Prabhuk marked 6 inline comments as done. Prabhuk added a comment. Added subsystem and entry args. Improved driver test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152206/new/ https://reviews.llvm.or

[PATCH] D152206: [Basic] Support 64-bit x86 target for UEFI

2023-06-22 Thread Prabhu Karthikeyan Rajasekaran via Phabricator via cfe-commits
Prabhuk updated this revision to Diff 533809. Prabhuk added a comment. Clean up lit test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152206/new/ https://reviews.llvm.org/D152206 Files: clang/lib/Basic/Targets.cpp clang/lib/Basic/Targets/OST

[PATCH] D152206: [Basic] Support 64-bit x86 target for UEFI

2023-06-22 Thread Prabhu Karthikeyan Rajasekaran via Phabricator via cfe-commits
Prabhuk updated this revision to Diff 533795. Prabhuk added a comment. Improve lit test for uefi. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152206/new/ https://reviews.llvm.org/D152206 Files: clang/lib/Basic/Targets.cpp clang/lib/Basic/Tar

[PATCH] D152206: [Basic] Support 64-bit x86 target for UEFI

2023-06-22 Thread Prabhu Karthikeyan Rajasekaran via Phabricator via cfe-commits
Prabhuk updated this revision to Diff 533782. Prabhuk added a comment. Herald added subscribers: llvm-commits, hiraditya. Herald added a project: LLVM. Set the Objectformat in the appropriate place to fix the triple string for UEFI. Simplify the lit test for UEFI toolchain to C. Repository: rG

[PATCH] D152206: [Basic] Support 64-bit x86 target for UEFI

2023-06-13 Thread Prabhu Karthikeyan Rajasekaran via Phabricator via cfe-commits
Prabhuk updated this revision to Diff 530917. Prabhuk added a comment. Adding a simple lit test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152206/new/ https://reviews.llvm.org/D152206 Files: clang/lib/Basic/Targets.cpp clang/lib/Basic/Targ

[PATCH] D152206: [Basic] Support 64-bit x86 target for UEFI

2023-06-12 Thread Prabhu Karthikeyan Rajasekaran via Phabricator via cfe-commits
Prabhuk updated this revision to Diff 530609. Prabhuk added a comment. Addressed comments from last reviews except for adding lit tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152206/new/ https://reviews.llvm.org/D152206 Files: clang/lib/

[PATCH] D131594: Add Clang UEFI target to support "x86_64-unknown-uefi" triple

2023-06-05 Thread Prabhu Karthikeyan Rajasekaran via Phabricator via cfe-commits
Prabhuk updated this revision to Diff 528610. Prabhuk added a comment. Updated commit message. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131594/new/ https://reviews.llvm.org/D131594 Files: llvm/include/llvm/MC/TargetRegistry.h llvm/include

[PATCH] D152206: [Basic] Support 64-bit x86 target for UEFI

2023-06-05 Thread Prabhu Karthikeyan Rajasekaran via Phabricator via cfe-commits
Prabhuk updated this revision to Diff 528609. Prabhuk added a comment. Update commit message. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152206/new/ https://reviews.llvm.org/D152206 Files: clang/lib/Basic/Targets.cpp clang/lib/Basic/Targets

[PATCH] D152206: [Basic] Support 64-bit x86 target for UEFI

2023-06-05 Thread Prabhu Karthikeyan Rajasekaran via Phabricator via cfe-commits
Prabhuk created this revision. Prabhuk added a reviewer: phosek. Herald added a subscriber: pengfei. Herald added a project: All. Prabhuk requested review of this revision. Herald added subscribers: cfe-commits, MaskRay. Herald added a project: clang. Adding support for X86_64 UEFI target to begin

[PATCH] D131594: Add Clang UEFI target to support "x86_64-unknown-uefi" triple

2023-06-05 Thread Prabhu Karthikeyan Rajasekaran via Phabricator via cfe-commits
Prabhuk updated this revision to Diff 528603. Prabhuk added a comment. Update the test. Remove unnecessary items in UEFI toolchain. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131594/new/ https://reviews.llvm.org/D131594 Files: clang/lib/Basic

[PATCH] D131594: WORK IN PROGRESS Add Clang UEFI target to support "x86_64-unknown-uefi" triple

2023-06-02 Thread Prabhu Karthikeyan Rajasekaran via Phabricator via cfe-commits
Prabhuk updated this revision to Diff 528064. Prabhuk added a comment. Simplifying the patch to include just the scaffolding for X86_64 platform. Removing the predefines to be added as a separate patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D

[PATCH] D131594: WORK IN PROGRESS Add Clang UEFI target to support "x86_64-unknown-uefi" triple

2023-05-16 Thread Prabhu Karthikeyan Rajasekaran via Phabricator via cfe-commits
Prabhuk updated this revision to Diff 522714. Prabhuk added a comment. Addressing Petr's comments. Adding buildLinker initial draft for UEFI. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131594/new/ https://reviews.llvm.org/D131594 Files: clang

[PATCH] D131594: WORK IN PROGRESS Add Clang UEFI target to support "x86_64-unknown-uefi" triple

2023-05-16 Thread Prabhu Karthikeyan Rajasekaran via Phabricator via cfe-commits
Prabhuk updated this revision to Diff 522680. Prabhuk added a comment. Use make_unique instead of new for UEFI TargetInfo. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131594/new/ https://reviews.llvm.org/D131594 Files: clang/lib/Basic/Targets.

[PATCH] D131594: WORK IN PROGRESS Add Clang UEFI target to support "x86_64-unknown-uefi" triple

2023-05-16 Thread Prabhu Karthikeyan Rajasekaran via Phabricator via cfe-commits
Prabhuk updated this revision to Diff 522657. Prabhuk added a comment. Not ready for review yet. Updating build files and tests. Fixed a compile time error. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131594/new/ https://reviews.llvm.org/D131594

[PATCH] D131594: WORK IN PROGRESS Add Clang UEFI target to support "x86_64-unknown-uefi" triple

2023-05-16 Thread Prabhu Karthikeyan Rajasekaran via Phabricator via cfe-commits
Prabhuk updated this revision to Diff 522644. Prabhuk added a comment. Herald added a reviewer: jdoerfert. Herald added a reviewer: sscalpone. Herald added subscribers: jplehr, sstefan1. Added UEFI toolchain. Constructing linker and started a WIP UEFI toolchain to break away from MSVC toolchain.

[PATCH] D131594: WORK IN PROGRESS Add Clang UEFI target to support "x86_64-unknown-uefi" triple

2022-11-23 Thread Prabhu Karthikeyan Rajasekaran via Phabricator via cfe-commits
Prabhuk updated this revision to Diff 477634. Prabhuk marked an inline comment as done. Prabhuk added a comment. Herald added a subscriber: wenlei. Added tests to the new UEFI target. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131594/new/ https:

[PATCH] D131594: WORK IN PROGRESS Add Clang UEFI target to support "x86_64-unknown-uefi" triple

2022-11-23 Thread Prabhu Karthikeyan Rajasekaran via Phabricator via cfe-commits
Prabhuk updated this revision to Diff 477622. Prabhuk marked an inline comment as done. Prabhuk added a comment. Herald added a subscriber: pengfei. Introducing a new toolchain for UEFI COFF. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131594/new/

[PATCH] D131594: WORK IN PROGRESS Add Clang UEFI target to support "x86_64-unknown-uefi" triple

2022-10-18 Thread Prabhu Karthikeyan Rajasekaran via Phabricator via cfe-commits
Prabhuk updated this revision to Diff 468600. Prabhuk added a comment. Add __UEFI__ macro. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131594/new/ https://reviews.llvm.org/D131594 Files: clang/lib/Basic/Targets.cpp clang/lib/Basic/Targets/OS

[PATCH] D131594: WORK IN PROGRESS Add Clang UEFI target to support "x86_64-unknown-uefi" triple

2022-10-18 Thread Prabhu Karthikeyan Rajasekaran via Phabricator via cfe-commits
Prabhuk updated this revision to Diff 468595. Prabhuk added a comment. Introducing UEFIX86_64TargetInfo. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131594/new/ https://reviews.llvm.org/D131594 Files: clang/lib/Basic/Targets.cpp clang/lib/Ba

[PATCH] D131594: WORK IN PROGRESS Add Clang UEFI target to support "x86_64-unknown-uefi" triple

2022-10-17 Thread Prabhu Karthikeyan Rajasekaran via Phabricator via cfe-commits
Prabhuk updated this revision to Diff 468370. Prabhuk added a comment. Herald added a subscriber: MaskRay. Added changes to the Driver.cpp. This version uses underlying MSVC toolchain to compile UEFI target introduced here. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION http

[PATCH] D131594: WORK IN PROGRESS Add Clang UEFI target to support "x86_64-unknown-uefi" triple

2022-08-10 Thread Prabhu Karthikeyan Rajasekaran via Phabricator via cfe-commits
Prabhuk created this revision. Herald added a subscriber: hiraditya. Herald added a project: All. Prabhuk requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D131