[PATCH] D131526: [OMPIRBuilder] Add support for safelen clause

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGbce94ea551ae: [OMPIRBuilder] Add support for safelen clause (authored by psoni2628). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTIO

[PATCH] D131526: [OMPIRBuilder] Add support for safelen clause

psoni2628 updated this revision to Diff 453745. psoni2628 added a comment. - Simplify expression based on reviewer comments - Rebase CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131526/new/ https://reviews.llvm.org/D131526 Files: clang/lib/CodeGen/CGStmtOpenMP.cpp clang/test/OpenM

[PATCH] D131526: [OMPIRBuilder] Add support for safelen clause

psoni2628 added inline comments. Comment at: llvm/include/llvm/Frontend/OpenMP/OMPIRBuilder.h:625 + void applySimd(CanonicalLoopInfo *Loop, Value *IfCond, ConstantInt *Simdlen, + ConstantInt *Safelen); shraiysh wrote: > [nit] Please set the def

[PATCH] D131526: [OMPIRBuilder] Add support for safelen clause

psoni2628 updated this revision to Diff 451500. psoni2628 added a comment. - Add LoopMDList CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131526/new/ https://reviews.llvm.org/D131526 Files: clang/lib/CodeGen/CGStmtOpenMP.cpp clang/test/OpenMP/irbuilder_safelen.cpp clang/test/Open

[PATCH] D131526: [OMPIRBuilder] Add support for safelen clause

psoni2628 updated this revision to Diff 451449. psoni2628 added a comment. - Add comments based on reviewer's feedback - Rebase CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131526/new/ https://reviews.llvm.org/D131526 Files: clang/lib/CodeGen/CGStmtOpenMP.cpp clang/test/OpenMP/irb

[PATCH] D131526: [OMPIRBuilder] Add support for safelen clause

psoni2628 added inline comments. Comment at: llvm/lib/Frontend/OpenMP/OMPIRBuilder.cpp:3045 + if (!(Simdlen == nullptr && Safelen == nullptr)) { +ConstantInt *VectorizeWidth = Simdlen == nullptr ? Safelen : Simdlen; addLoopMetadata( domada wrote: > Coul

[PATCH] D129149: [OMPIRBuilder] Add support for simdlen clause

psoni2628 updated this revision to Diff 443622. psoni2628 added a comment. - Rebase, ensuring that build bot failures are gone CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129149/new/ https://reviews.llvm.org/D129149 Files: clang/lib/CodeGen/CGStmtOpenMP.cpp clang/test/OpenMP/irbu

[PATCH] D129149: [OMPIRBuilder] Add support for simdlen clause

psoni2628 updated this revision to Diff 442715. psoni2628 marked 4 inline comments as done. psoni2628 added a comment. Herald added subscribers: bzcheeseman, awarzynski, sdasgup3, wenzhicui, wrengr, dcaballe, cota, teijeong, rdzhabarov, tatianashp, msifontes, jurahul, Kayjukh, grosul1, Joonsoo, s

[PATCH] D129149: [OMPIRBuilder] Add support for simdlen clause

psoni2628 marked 8 inline comments as done. psoni2628 added inline comments. Comment at: clang/test/OpenMP/irbuilder_simdlen.cpp:1 +// RUN: %clang_cc1 -no-opaque-pointers -fopenmp-enable-irbuilder -verify -fopenmp -fopenmp-version=45 -x c++ -triple x86_64-unknown-unknown -emit-l

[PATCH] D129149: [OMPIRBuilder] Add support for simdlen clause

psoni2628 updated this revision to Diff 442637. psoni2628 added a comment. - Autogenerate check lines for test case - Use isa instead of dyncast - Remove unused DebugLoc - Remove `llvm::` from `llvm::ConstantInt` CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129149/new/ https://reviews.

[PATCH] D129149: [OMPIRBuilder] Add support for simdlen clause

psoni2628 added inline comments. Comment at: llvm/include/llvm/Frontend/OpenMP/OMPIRBuilder.h:608 + /// + /// \param DL Debug location for instructions added by unrolling. + /// \param LoopThe simd loop. jdoerfert wrote: > psoni2628 wrote: > > jdoerfe

[PATCH] D129149: [OMPIRBuilder] Add support for simdlen clause

psoni2628 added inline comments. Comment at: llvm/include/llvm/Frontend/OpenMP/OMPIRBuilder.h:608 + /// + /// \param DL Debug location for instructions added by unrolling. + /// \param LoopThe simd loop. jdoerfert wrote: > No debug location needed. Yo

[PATCH] D129149: [OMPIRBuilder] Add support for simdlen clause

psoni2628 added inline comments. Comment at: llvm/lib/Frontend/OpenMP/OMPIRBuilder.cpp:2885 +void OpenMPIRBuilder::applySimdlen(DebugLoc, CanonicalLoopInfo *CanonicalLoop, + llvm::ConstantInt *Simdlen) { + LLVMContext &Ctx = Builder.getContext()

[PATCH] D129149: [OMPIRBuilder] Add support for simdlen clause

psoni2628 updated this revision to Diff 442595. psoni2628 added a comment. - Remove discouraged else after return CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129149/new/ https://reviews.llvm.org/D129149 Files: clang/lib/CodeGen/CGStmtOpenMP.cpp clang/test/OpenMP/irbuilder_simd.cp

[PATCH] D129149: [OMPIRBuilder] Add support for simdlen clause

psoni2628 added a comment. In D129149#3632813 , @kiranchandramohan wrote: > Nit: Also add to the summary that this patch uses the simdlen support in > OpenMPIRBuilder when it is enabled in Clang. I just wanted to clarify that below is what you mean?

[PATCH] D129149: [OMPIRBuilder] Add support for simdlen clause

psoni2628 added inline comments. Comment at: clang/lib/CodeGen/CGStmtOpenMP.cpp:2596 // Check for unsupported clauses - if (!S.clauses().empty()) { -// Currently no clause is supported -return false; + for (OMPClause *C : S.clauses()) { +// Currently only simdlen

[PATCH] D129149: [OMPIRBuilder] Add support for simdlen clause

psoni2628 updated this revision to Diff 442555. psoni2628 marked 3 inline comments as done. psoni2628 added a comment. - Create new tests instead of modifying existing ones - Specialize `isSupportedByOpenMPIRBuilder` for `OMPSimdDirective` CHANGES SINCE LAST ACTION https://reviews.llvm.org/D12

[PATCH] D129149: [OMPIRBuilder] Add support for simdlen clause

psoni2628 added inline comments. Comment at: clang/lib/CodeGen/CGStmtOpenMP.cpp:2596 // Check for unsupported clauses - if (!S.clauses().empty()) { -// Currently no clause is supported -return false; + for (OMPClause *C : S.clauses()) { +// Currently only simdlen

[PATCH] D129149: [OMPIRBuilder] Add support for simdlen clause

psoni2628 marked an inline comment as not done. psoni2628 added inline comments. Comment at: clang/lib/CodeGen/CGStmtOpenMP.cpp:2596 // Check for unsupported clauses - if (!S.clauses().empty()) { -// Currently no clause is supported -return false; + for (OMPClause *C

[PATCH] D129149: [OMPIRBuilder] Add support for simdlen clause

psoni2628 added inline comments. Comment at: clang/lib/CodeGen/CGStmtOpenMP.cpp:2596 // Check for unsupported clauses - if (!S.clauses().empty()) { -// Currently no clause is supported -return false; + for (OMPClause *C : S.clauses()) { +// Currently only simdlen