blastrock added a comment.
Thanks for the reviews! I do not have commit access, so please merge this
whenever you can.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D73701/new/
https://reviews.llvm.org/D73701
blastrock updated this revision to Diff 241713.
blastrock edited the summary of this revision.
blastrock added a reverted change: D1783: Allow nested lambdas in NSDMIs (i.e
default initializers).
blastrock added a comment.
Thank you for the answers.
I have removed all the outermost lambda code a
blastrock created this revision.
blastrock added reviewers: rjmccall, hliao.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
This is an attempt to fix https://bugs.llvm.org/show_bug.cgi?id=44368
I don't know why the comment said that we should take the linkage of the
outer
blastrock abandoned this revision.
blastrock added a comment.
Indeed, I'm closing this then, I haven't tested your patch yet but the fix
seems to be the exact same. You seem to have a better idea of what you are
doing and your patch reflects that ^^
Thanks for the fix!
Repository:
rG LLVM G
blastrock created this revision.
blastrock added reviewers: GorNishanov, EricWF, lewissbaker, tks2103,
modocache, rsmith.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
blastrock edited the summary of this revision.
This started with bug https://bugs.llvm.org/show_bug.cgi?
blastrock abandoned this revision.
blastrock added a comment.
No, https://reviews.llvm.org/D23765 seems to fix this issue.
https://reviews.llvm.org/D27116
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/
