[PATCH] D82733: [clang][docs] Add note about using `-flto` with `-g` on macOS

2020-06-30 Thread Philippe Blain via Phabricator via cfe-commits
phil-blain added a comment. Great, thanks ! Note that I don't have commit access. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82733/new/ https://reviews.llvm.org/D82733 ___ cfe-commits mailing list c

[PATCH] D82733: [clang][docs] Add note about using `-flto` with `-g` on macOS

2020-06-29 Thread Philippe Blain via Phabricator via cfe-commits
phil-blain added a comment. I tested the sphinx build for the `man` and `html` targets. Any other targets I should check ? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82733/new/ https://reviews.llvm.org/D82733

[PATCH] D82733: [clang][docs] Add note about using `-flto` with `-g` on macOS

2020-06-29 Thread Philippe Blain via Phabricator via cfe-commits
phil-blain updated this revision to Diff 274286. phil-blain added a comment. Use `note::` Sphinx directive Also: - Fix Sphinx formatting for preformatted text - Correctly pass the linker argument (initial '-' was missing) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https

[PATCH] D82733: [clang][docs] Add note about using `-flto` with `-g` on macOS

2020-06-29 Thread Philippe Blain via Phabricator via cfe-commits
phil-blain added inline comments. Comment at: clang/docs/CommandGuide/clang.rst:477 + Note: on Darwin, when using :option:`-flto` along with :option:`-g` and + compiling and linking in separate steps, you also need to pass JDevlieghere wrote: > Any reason not

[PATCH] D82733: [clang][docs] Add note about using `-flto` with `-g` on macOS

2020-06-29 Thread Philippe Blain via Phabricator via cfe-commits
phil-blain created this revision. phil-blain added reviewers: echristo, dblaikie. Herald added subscribers: dexonsmith, inglorion. Herald added a reviewer: JDevlieghere. Herald added a project: clang. If `-Wl,object_path_lto,.o` is not passed at link time when compiling and linking in separate ste