[PATCH] D142939: Fix handling of -> calls for modernize-use-emplace

BigPeet added a comment. Thank you very much. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142939/new/ https://reviews.llvm.org/D142939 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://li

[PATCH] D142939: Fix handling of -> calls for modernize-use-emplace

BigPeet added a comment. Ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142939/new/ https://reviews.llvm.org/D142939 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cg

[PATCH] D142939: Fix handling of -> calls for modernize-use-emplace

BigPeet added a comment. > Generally we use prefer `llvm::ArrayRef` over `const std::vector &` I will keep this in mind. Or should this be fixed in this revision? Anyway, if this gets merged, my username/mail are GitHub username: BigPeet GitHub email: pwolf2...@gmail.com Thanks for the fast re

[PATCH] D142939: Fix handling of -> calls for modernize-use-emplace

BigPeet updated this revision to Diff 493756. BigPeet added a comment. - fix passing vector by value instead of by ref-to-const Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142939/new/ https://reviews.llvm.org/D142939 Files: clang-tools-extra/c

[PATCH] D142939: Fix handling of -> calls for modernize-use-emplace

BigPeet added a comment. Refactored the code a little bit to get rid of some repetitions. Should effectively match the same code as the accepted revision. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142939/new/ https://reviews.llvm.org/D142939

[PATCH] D142939: Fix handling of -> calls for modernize-use-emplace

BigPeet updated this revision to Diff 493753. BigPeet added a comment. - additional deduplication of code Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142939/new/ https://reviews.llvm.org/D142939 Files: clang-tools-extra/clang-tidy/modernize/Us

[PATCH] D142939: Fix handling of -> calls for modernize-use-emplace

BigPeet updated this revision to Diff 493745. BigPeet added a comment. - reducing code repitition + further tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142939/new/ https://reviews.llvm.org/D142939 Files: clang-tools-extra/clang-tidy/mode

[PATCH] D142939: Fix handling of -> calls for modernize-use-emplace

BigPeet created this revision. Herald added a subscriber: carlosgalvezp. Herald added a reviewer: njames93. Herald added a project: All. BigPeet requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. Fixes #55869 Repository: rG LLV

[PATCH] D135405: fix handling of braced-init temporaries for modernize-use-emplace

BigPeet added a comment. Ping? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135405/new/ https://reviews.llvm.org/D135405 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cg

[PATCH] D135405: fix handling of braced-init temporaries for modernize-use-emplace

BigPeet added a comment. GitHub username: BigPeet GitHub email: pwolf2...@gmail.com Thanks for your quick response. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135405/new/ https://reviews.llvm.org/D135405 ___

[PATCH] D135405: fix handling of braced-init temporaries for modernize-use-emplace

BigPeet added a comment. Ping. (Sorry, it's my first time contributing to LLVM and I simply don't know what happens next. Do I need to do anything? Or is it just waiting to get merged at some point?) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D

[PATCH] D135405: fix handling of braced-init temporaries for modernize-use-emplace

BigPeet added a comment. Thanks for the review. Do I have to do anything or how will this be handled from here? Comment at: clang-tools-extra/test/clang-tidy/checkers/modernize/use-emplace.cpp:1268 + + v2.emplace_back(NonTrivialWithVector()); + // CHECK-MESSAGES: :[[@LINE-1

[PATCH] D135405: fix handling of braced-init temporaries for modernize-use-emplace

BigPeet added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135405/new/ https://reviews.llvm.org/D135405 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi

[PATCH] D135405: fix handling of braced-init temporaries for modernize-use-emplace

BigPeet added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135405/new/ https://reviews.llvm.org/D135405 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi

[PATCH] D135405: fix handling of braced-init temporaries for modernize-use-emplace

BigPeet added a comment. Just a reminder. Do I have to do anything? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135405/new/ https://reviews.llvm.org/D135405 ___ cfe-commits mailing list cfe-commits@lis

[PATCH] D135405: fix handling of braced-init temporaries for modernize-use-emplace

BigPeet updated this revision to Diff 466198. BigPeet added a comment. fixed wrong arc diff handling :-/ Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135405/new/ https://reviews.llvm.org/D135405 Files: clang-tools-extra/clang-tidy/modernize/Use

[PATCH] D135405: fix handling of braced-init temporaries for modernize-use-emplace

BigPeet updated this revision to Diff 466197. BigPeet added a comment. applying clang-format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135405/new/ https://reviews.llvm.org/D135405 Files: clang-tools-extra/clang-tidy/modernize/UseEmplaceCheck

[PATCH] D135405: fix handling of braced-init temporaries for modernize-use-emplace

BigPeet updated this revision to Diff 465888. BigPeet added a comment. - update comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135405/new/ https://reviews.llvm.org/D135405 Files: clang-tools-extra/clang-tidy/modernize/UseEmplaceCheck.cpp

[PATCH] D135405: fix handling of braced-init temporaries for modernize-use-emplace

BigPeet created this revision. Herald added a subscriber: carlosgalvezp. Herald added a project: All. BigPeet requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. Addresses https://github.com/llvm/llvm-project/issues/55870 Reposito