[PATCH] D149713: [Sema] Avoid emitting warnings for constant destruction.

pkasting added a comment. Thanks @rsmith; I don't have commit access, so can you land the updated patch for me? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149713/new/ https://reviews.llvm.org/D149713 ___

[PATCH] D149713: [Sema] Avoid emitting warnings for constant destruction.

pkasting updated this revision to Diff 519188. pkasting added a comment. Update test per review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149713/new/ https://reviews.llvm.org/D149713 Files: clang/lib/Sema/SemaDeclCXX.cpp clang/te

[PATCH] D149713: [Sema] Avoid emitting warnings for constant destruction.

pkasting created this revision. pkasting added a reviewer: rsmith. Herald added a project: All. pkasting requested review of this revision. Herald added a project: clang. Fixes https://github.com/llvm/llvm-project/issues/62436. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D149

[PATCH] D118070: Make lld-link work in a non-MSVC shell

pkasting updated this revision to Diff 409046. pkasting added a comment. Fix test failure. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118070/new/ https://reviews.llvm.org/D118070 Files: clang/docs/tools/clang-formatted-files.txt clang/lib/D

[PATCH] D118070: Make lld-link work in a non-MSVC shell

pkasting added a comment. MaskRay: Friendly ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118070/new/ https://reviews.llvm.org/D118070 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https:

[PATCH] D118070: Make lld-link work in a non-MSVC shell

pkasting updated this revision to Diff 406570. pkasting marked 2 inline comments as done. pkasting added a comment. Review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118070/new/ https://reviews.llvm.org/D118070 Files: clang/docs/too

[PATCH] D118070: Make lld-link work in a non-MSVC shell

pkasting updated this revision to Diff 406526. pkasting added a comment. This fixes a failing test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118070/new/ https://reviews.llvm.org/D118070 Files: clang/docs/tools/clang-formatted-files.txt cl

[PATCH] D118070: Make lld-link work in a non-MSVC shell

pkasting updated this revision to Diff 406101. Herald added a reviewer: MaskRay. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118070/new/ https://reviews.llvm.org/D118070 Files: clang/docs/tools/clang-formatted-files.txt clang/lib/Driver/ToolCh

[PATCH] D118070: Make lld-link work in a non-MSVC shell

pkasting added a comment. In D118070#3297956 , @thakis wrote: > I think the setup matches what we have in clang, right? Yes, I think so. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118070/new/ https://r

[PATCH] D118070: Make lld-link work in a non-MSVC shell

pkasting marked an inline comment as done. pkasting added a comment. In D118070#3289222 , @ychen wrote: > Thanks for doing this! Update the release note? Done. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/

[PATCH] D118070: Make lld-link work in a non-MSVC shell

pkasting updated this revision to Diff 404994. pkasting marked 5 inline comments as done. pkasting retitled this revision from "Add /winsysroot support to lld" to "Make lld-link work in a non-MSVC shell". pkasting edited the summary of this revision. Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D118070: Add /winsysroot support to lld

pkasting marked 9 inline comments as done. pkasting added a comment. In D118070#3278123 , @thakis wrote: > Things that can still improve: > > 1. This now does way more than just /winsysroot:. It also makes it so that > lld-link works in a non-msvc shell

[PATCH] D118070: Add /winsysroot support to lld

pkasting updated this revision to Diff 403679. pkasting added a comment. Herald added subscribers: hiraditya, mgorny. Refactored to share code with clang-cl. Still no tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118070/new/ https://reviews

[PATCH] D118070: Add /winsysroot support to lld

pkasting updated this revision to Diff 403316. pkasting edited the summary of this revision. pkasting added a comment. Functional, but not yet refactored to share code with clang-cl. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118070/new/ https:/

[PATCH] D118070: Add /winsysroot support to lld

pkasting updated this revision to Diff 403265. pkasting added a comment. Herald added subscribers: cfe-commits, dexonsmith, mstorsjo. Herald added a project: clang. Adds autodetection and full support for other clang-cl switches, but doesn't work: config->machine is not set this early, so it's al