[PATCH] D108021: [dllexport] Instantiate default ctor default args

peterjc123 added a comment. Sure, please do that. Comment at: clang/lib/Sema/SemaDeclCXX.cpp:6012 +auto *CD = dyn_cast(MD); +if (CD && CD->isDefaultConstructor() && TSK == TSK_Undeclared) { + S.InstantiateDefaultCtorDefaultArgs(CD); rnk

[PATCH] D108021: [dllexport] Instantiate default ctor default args

peterjc123 updated this revision to Diff 366423. peterjc123 added a comment. clang-tidy CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108021/new/ https://reviews.llvm.org/D108021 Files: clang/lib/Sema/SemaDeclCXX.cpp clang/test/CodeGenCXX/dllexport-ctor-closure-nested.cpp Index:

[PATCH] D108068: [dllexport] Instantiate default ctor default args

peterjc123 created this revision. peterjc123 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D108068 Files: clang/lib/Sema/SemaDeclCXX.cpp clang/test/CodeGenCXX/dllexport-

[PATCH] D108067: [dllexport] Instantiate default ctor default args

peterjc123 created this revision. peterjc123 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D108067 Files: clang/lib/Sema/SemaDeclCXX.cpp clang/test/CodeGenCXX/dllexport-

[PATCH] D108021: [dllexport] Instantiate default ctor default args

peterjc123 updated this revision to Diff 366416. peterjc123 added a comment. clang-format CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108021/new/ https://reviews.llvm.org/D108021 Files: clang/lib/Sema/SemaDeclCXX.cpp clang/test/CodeGenCXX/dllexport-ctor-closure-nested.cpp Index

[PATCH] D108021: [dllexport] Instantiate default ctor default args

peterjc123 updated this revision to Diff 366413. peterjc123 added a comment. Skip in template classes CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108021/new/ https://reviews.llvm.org/D108021 Files: clang/lib/Sema/SemaDeclCXX.cpp clang/test/CodeGenCXX/dllexport-ctor-closure-nested

[PATCH] D108021: [dllexport] Instantiate default ctor default args

peterjc123 updated this revision to Diff 366411. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108021/new/ https://reviews.llvm.org/D108021 Files: clang/lib/Sema/SemaDeclCXX.cpp clang/test/CodeGenCXX/dllexport-ctor-closure-nested.cpp Index: clang/test/CodeGenCXX/dllexport-ctor-clos

[PATCH] D108021: [dllexport] Instantiate default ctor default args

peterjc123 updated this revision to Diff 366410. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108021/new/ https://reviews.llvm.org/D108021 Files: clang/lib/Sema/SemaDeclCXX.cpp clang/test/CodeGenCXX/dllexport-ctor-closure-nested.cpp Index: clang/test/CodeGenCXX/dllexport-ctor-clos

[PATCH] D108021: [dllexport] Instantiate default ctor default args

peterjc123 updated this revision to Diff 366407. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108021/new/ https://reviews.llvm.org/D108021 Files: clang/lib/Sema/SemaDeclCXX.cpp clang/test/CodeGenCXX/dllexport-ctor-closure-nested.cpp Index: cl

[PATCH] D108021: [dllexport] Instantiate default ctor default args

peterjc123 updated this revision to Diff 366405. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108021/new/ https://reviews.llvm.org/D108021 Files: clang/lib/Sema/SemaDeclCXX.cpp clang/test/CodeGenCXX/dllexport-ctor-closure-nested.cpp Index: cl

[PATCH] D108021: [dllexport] Instantiate default ctor default args

peterjc123 added a comment. @rnk @hans Test added. Please take some time to review the changes. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108021/new/ https://reviews.llvm.org/D108021 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D108021: [dllexport] Instantiate default ctor default args

peterjc123 updated this revision to Diff 366399. peterjc123 added a comment. Add test CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108021/new/ https://reviews.llvm.org/D108021 Files: clang/lib/Sema/SemaDeclCXX.cpp clang/test/CodeGenCXX/dllexport-ctor-closure-nested.cpp Index

[PATCH] D108021: [dllexport] Instantiate default ctor default args

peterjc123 updated this revision to Diff 366394. peterjc123 added a comment. Add test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108021/new/ https://reviews.llvm.org/D108021 Files: clang/test/CodeGenCXX/dllexport-ctor-closure-nested.cpp Ind

[PATCH] D108021: [dllexport] Instantiate default ctor default args

peterjc123 updated this revision to Diff 366393. peterjc123 added a comment. Add test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108021/new/ https://reviews.llvm.org/D108021 Files: clang/test/CodeGenCXX/dllexport-ctor-closure-nested.cpp Ind

[PATCH] D108021: [dllexport] Instantiate default ctor default args

peterjc123 added a comment. In D108021#2943842 , @rnk wrote: > I think it looks good, but it needs a test. > > I worry that we might have the same bug for copy closures, but the fix will > be different, since those are used in exception handling. Thanks

[PATCH] D108021: [dllexport] Instantiate default ctor default args

peterjc123 created this revision. peterjc123 added a reviewer: rnk. peterjc123 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Fixes https://bugs.llvm.org/show_bug.cgi?id=51414. Repository: rG LLVM Github Monorepo https://reviews.llvm.