[PATCH] D25439: Fixed column shift when formatting line containing bit shift operators

idlecode added a comment. No, not yet - I was about to ask someone to commit this for me :) https://reviews.llvm.org/D25439 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D26125: [clang-tidy] Fixed readability-else-after-return for cascade statements

idlecode retitled this revision from "[clang-tidy] Fixed else-after-return warning in cascade if statement" to "[clang-tidy] Fixed readability-else-after-return for cascade statements". idlecode updated the summary for this revision. idlecode updated this revision to Diff 76604. idlecode added a

[PATCH] D26125: [clang-tidy] Fixed else-after-return warning in cascade if statement

idlecode added a comment. @mgehre: Yes it does - in your case AST looks like `ifStmt(b) - CompoundStmt - ifStmt(c)`, so ifStmt's don't have direct parent-child relations. But there is another problem: while(a) if (b) return 1; else doSomething(2); In such case, generated f

[PATCH] D26125: [clang-tidy] Fixed else-after-return warning in cascade if statement

idlecode planned changes to this revision. idlecode added inline comments. Comment at: clang-tidy/readability/ElseAfterReturnCheck.cpp:28 stmt(forEach( - ifStmt(hasThen(stmt( + ifStmt(unless(hasParent(ifStmt())), + hasThen(stmt( --

[PATCH] D26125: [clang-tidy] Fixed else-after-return warning in cascade if statement

idlecode marked an inline comment as done. idlecode added inline comments. Comment at: clang-tidy/readability/ElseAfterReturnCheck.cpp:28 stmt(forEach( - ifStmt(hasThen(stmt( + ifStmt(unless(hasParent(ifStmt())), + hasThen(stmt( --

[PATCH] D26125: [clang-tidy] Fixed else-after-return warning in cascade if statement

idlecode marked an inline comment as done. idlecode added inline comments. Comment at: clang-tidy/readability/ElseAfterReturnCheck.cpp:28 stmt(forEach( - ifStmt(hasThen(stmt( + ifStmt(unless(hasParent(ifStmt())), + hasThen(stmt( --

[PATCH] D26125: [clang-tidy] Fixed else-after-return warning in cascade if statement

idlecode created this revision. idlecode added reviewers: djasper, malcolm.parsons, omtcyfz. idlecode added a subscriber: cfe-commits. Fix applied to else in a cascade if statements changed program semantics in cases when not all previous branches resulted in flow change. Fixes PR30652 https://

[PATCH] D25439: Fixed column shift when formatting line containing bit shift operators

idlecode updated this revision to Diff 75635. https://reviews.llvm.org/D25439 Files: lib/Format/FormatTokenLexer.cpp unittests/Format/FormatTest.cpp Index: unittests/Format/FormatTest.cpp === --- unittests/Format/FormatTest.cpp

[PATCH] D25439: Fixed column shift when formatting line containing bit shift operators

idlecode added a comment. Thanks for pointing it out, just a minute ago I found a proper document mentioning it (I have no idea how I could miss it). I hope to be more use in future :) Comment at: unittests/Format/FormatTest.cpp:11365 +

[PATCH] D25439: Fixed column shift when formatting line containing bit shift operators

idlecode updated this revision to Diff 74412. https://reviews.llvm.org/D25439 Files: lib/Format/FormatTokenLexer.cpp unittests/Format/FormatTest.cpp Index: unittests/Format/FormatTest.cpp === --- unittests/Format/FormatTest.cpp

[PATCH] D25439: Fixed column shift when formatting line containing bit shift operators

idlecode marked an inline comment as done. idlecode added a comment. Sure, I will upload diff as soon as I test it https://reviews.llvm.org/D25439 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo

[PATCH] D25439: Fixed column shift when formatting line containing bit shift operators

idlecode created this revision. idlecode added a subscriber: cfe-commits. Herald added a subscriber: klimek. During clang-format source lexing >> and << operators are split and treated as two less/greater operators but column position of following tokens was not adjusted accordingly. https://rev