pastey added a comment.
Guys, sorry for a dumb question – so the fix can be pushed now? If yes, then
there's one issue – I don't think I have write access to push the fix – may I
ask one of you to push it?
ERROR: Permission to llvm/llvm-project.git denied to pastey12.
Repository:
rC Clang
pastey marked an inline comment as done.
pastey added a comment.
@MyDeveloperDay, thanks for looking into this. Added a comment
Repository:
rC Clang
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D71939/new/
https://reviews.llvm.org/D71939
___
pastey updated this revision to Diff 235621.
Repository:
rC Clang
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D71939/new/
https://reviews.llvm.org/D71939
Files:
clang/lib/Format/UnwrappedLineFormatter.cpp
clang/unittests/Format/FormatTest.cpp
Index: clang/unittests/Format/Forma
pastey added a comment.
Thanks for your feedback. Let's see what other reviewers say.
Repository:
rC Clang
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D71939/new/
https://reviews.llvm.org/D71939
___
cfe-commits mailing list
cfe-commits@
pastey updated this revision to Diff 235466.
pastey added a comment.
Bouska, thank you! Don't know how I missed that failing test. Never commit on
friday :)
However, seeing this test result in a browser window gave me that "a-ha". I
understood that I had wrong perception of what MultiLine featu
pastey created this revision.
pastey added a reviewer: MyDeveloperDay.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
Hi,
Found a bug introduced with BraceWrappingFlags AfterControlStatement MultiLine.
This feature conflicts with the existing BeforeCatch and BeforeElse fl