[clang] [Clang][Sema] Add a test for move ctor calling for a base class. NFC (PR #97164)

2024-07-28 Thread Pavel Samolysov via cfe-commits
https://github.com/samolisov closed https://github.com/llvm/llvm-project/pull/97164 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][Sema] Add a test for move ctor calling for a base class. NFC (PR #97164)

2024-07-19 Thread Pavel Samolysov via cfe-commits
samolisov wrote: Gentle ping. I've addressed all the comments (thank you, @vitalybuka). https://github.com/llvm/llvm-project/pull/97164 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][Sema] Add a test for move ctor calling for a base class. NFC (PR #97164)

2024-07-07 Thread Pavel Samolysov via cfe-commits
@@ -0,0 +1,43 @@ +// RUN: %clang_cc1 -ast-dump -fblocks %s | FileCheck -strict-whitespace %s samolisov wrote: @vitalybuka Thank you for the suggestion. I've regenerated the test using the tool and cut the dump to make it a bit shorter. https://github.com/llvm/l

[clang] [Clang][Sema] Add a test for move ctor calling for a base class. NFC (PR #97164)

2024-07-07 Thread Pavel Samolysov via cfe-commits
https://github.com/samolisov updated https://github.com/llvm/llvm-project/pull/97164 >From edf0d10b41099068ef49a2d2fe0ce60356d2f2fd Mon Sep 17 00:00:00 2001 From: Pavel Samolysov Date: Sat, 29 Jun 2024 15:18:11 +0300 Subject: [PATCH 1/2] [Clang][Sema] Add a test for move ctor calling for a base

[clang] [Clang][Sema] Add a test for move ctor calling for a base class. NFC (PR #97164)

2024-07-01 Thread Pavel Samolysov via cfe-commits
@@ -0,0 +1,43 @@ +// RUN: %clang_cc1 -ast-dump -fblocks %s | FileCheck -strict-whitespace %s samolisov wrote: Unfortunately, I have no idea how to generate tests for clang. This test has been manually written. https://github.com/llvm/llvm-project/pull/97164 ___

[clang] [Clang][Sema] Add a test for move ctor calling for a base class. NFC (PR #97164)

2024-06-29 Thread Pavel Samolysov via cfe-commits
samolisov wrote: This is a pre-fix test (but, actually, I have no fix for now) to demonstrate the difference in compilation between some looking very similar pieces of the code. I sure the root cause (if this is an issue at all) lies in `SemaInit.cpp`, this is why I've added the developers who

[clang] [Clang][Sema] Add a test for move ctor calling for a base class. NFC (PR #97164)

2024-06-29 Thread Pavel Samolysov via cfe-commits
https://github.com/samolisov updated https://github.com/llvm/llvm-project/pull/97164 >From edf0d10b41099068ef49a2d2fe0ce60356d2f2fd Mon Sep 17 00:00:00 2001 From: Pavel Samolysov Date: Sat, 29 Jun 2024 15:18:11 +0300 Subject: [PATCH] [Clang][Sema] Add a test for move ctor calling for a base cl

[clang] [Clang][Sema] Add a test for move ctor calling for a base class. NFC (PR #97164)

2024-06-29 Thread Pavel Samolysov via cfe-commits
https://github.com/samolisov updated https://github.com/llvm/llvm-project/pull/97164 >From 0d9db6b69674dc3e33ab6b411c062b0126486d4c Mon Sep 17 00:00:00 2001 From: Pavel Samolysov Date: Sat, 29 Jun 2024 15:18:11 +0300 Subject: [PATCH] [Clang][Sema] Add a test for move ctor calling for a base cl

[clang] [Clang][Sema] Add a test for move ctor calling for a base class. NFC (PR #97164)

2024-06-29 Thread Pavel Samolysov via cfe-commits
https://github.com/samolisov created https://github.com/llvm/llvm-project/pull/97164 When clang compiles the following expression: ```c++ return A{B{"Move Ctor"}}; ``` (where `B` is a base class for `A`), it adds a call to the move constructor of `B`. When the code is changed to... ```c++

[clang] [clang] Remove a redundant check in Mangle. NFC (PR #95071)

2024-06-11 Thread Pavel Samolysov via cfe-commits
https://github.com/samolisov closed https://github.com/llvm/llvm-project/pull/95071 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Remove a redundant check in Mangle. NFC (PR #95071)

2024-06-10 Thread Pavel Samolysov via cfe-commits
https://github.com/samolisov created https://github.com/llvm/llvm-project/pull/95071 This addresses a review comment for PR #94987 Because that PR is a big automatic change, this change was moved in a separate one. >From c0e810f0a8d17ce222ad0775874539e09a90eb33 Mon Sep 17 00:00:00 2001 From: P

[clang] [clang] Replace X && isa(X) with isa_and_nonnull(X). NFC (PR #94987)

2024-06-10 Thread Pavel Samolysov via cfe-commits
https://github.com/samolisov closed https://github.com/llvm/llvm-project/pull/94987 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Replace X && isa(X) with isa_and_nonnull(X). NFC (PR #94987)

2024-06-10 Thread Pavel Samolysov via cfe-commits
https://github.com/samolisov updated https://github.com/llvm/llvm-project/pull/94987 >From 691223b4e873257a74b295bfb77839406adc742a Mon Sep 17 00:00:00 2001 From: Pavel Samolysov Date: Mon, 10 Jun 2024 17:35:14 +0300 Subject: [PATCH 1/2] [clang] Replace X && isa(X) with isa_and_nonnull(X). NFC

[clang] [clang] Replace X && isa(X) with isa_and_nonnull(X). NFC (PR #94987)

2024-06-10 Thread Pavel Samolysov via cfe-commits
@@ -8510,7 +8510,8 @@ class MappableExprsHandler { assert(VDecl == VD && "We got information for the wrong declaration??"); assert(!Components.empty() && "Not expecting declaration with no component lists."); -if (VD && E && VD->getType()

[clang] [clang] Replace X && isa(X) with isa_and_nonnull(X). NFC (PR #94987)

2024-06-10 Thread Pavel Samolysov via cfe-commits
@@ -2772,7 +2772,7 @@ fixVariable(const VarDecl *VD, FixitStrategy::Kind K, // also covers call-operator of lamdas isa(FD) || // skip when the function body is a try-block -(FD->hasBody() && isa(FD->getBody())) || +isa_and_nonnull(FD->get

[clang] [clang] Replace X && isa(X) with isa_and_nonnull(X). NFC (PR #94987)

2024-06-10 Thread Pavel Samolysov via cfe-commits
@@ -302,7 +302,7 @@ void MangleContext::mangleBlock(const DeclContext *DC, const BlockDecl *BD, assert((isa(DC) || isa(DC)) && "expected a NamedDecl or BlockDecl"); if (isa(DC)) - for (; DC && isa(DC); DC = DC->getParent()) + for (; isa_and_nonnull

[clang] [clang] Replace X && isa(X) with isa_and_nonnull(X). NFC (PR #94987)

2024-06-10 Thread Pavel Samolysov via cfe-commits
https://github.com/samolisov updated https://github.com/llvm/llvm-project/pull/94987 >From 691223b4e873257a74b295bfb77839406adc742a Mon Sep 17 00:00:00 2001 From: Pavel Samolysov Date: Mon, 10 Jun 2024 17:35:14 +0300 Subject: [PATCH] [clang] Replace X && isa(X) with isa_and_nonnull(X). NFC Th

[clang] [clang] Replace X && isa(X) with isa_and_nonnull(X). NFC (PR #94987)

2024-06-10 Thread Pavel Samolysov via cfe-commits
https://github.com/samolisov created https://github.com/llvm/llvm-project/pull/94987 This addresses a clang-tidy suggestion. >From 34352ddc7cb351c74ff3758c3990a480adc4c2c2 Mon Sep 17 00:00:00 2001 From: Pavel Samolysov Date: Mon, 10 Jun 2024 17:35:14 +0300 Subject: [PATCH] [clang] Replace X &&

[clang] [clang] Fix-it hint for `++this` -> `++*this` when deref is modifiable (PR #94159)

2024-06-10 Thread Pavel Samolysov via cfe-commits
@@ -8777,6 +8777,9 @@ def err_typecheck_incomplete_type_not_modifiable_lvalue : Error< def err_typecheck_lvalue_casts_not_supported : Error< "assignment to cast is illegal, lvalue casts are not supported">; +def note_typecheck_expression_not_modifiable_lvalue : Note< --

[clang] [clang] Fix a typo: ExplicitObje[C]tArgument. NFC (PR #94094)

2024-05-31 Thread Pavel Samolysov via cfe-commits
https://github.com/samolisov closed https://github.com/llvm/llvm-project/pull/94094 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Fix a typo: ExplicitObje[C]tArgument. NFC (PR #94094)

2024-05-31 Thread Pavel Samolysov via cfe-commits
https://github.com/samolisov created https://github.com/llvm/llvm-project/pull/94094 None >From 3ad23f75eff822360f349f5101d832fb769fe11d Mon Sep 17 00:00:00 2001 From: Pavel Samolysov Date: Sat, 1 Jun 2024 07:56:23 +0300 Subject: [PATCH] [clang] Fix a typo: ExplicitObje[C]tArgument. NFC ---

[clang] b10a341 - [Pipelines] Introduce DAE after ArgumentPromotion

2022-08-28 Thread Pavel Samolysov via cfe-commits
Author: Pavel Samolysov Date: 2022-08-28T10:47:03+03:00 New Revision: b10a341aa5b0b93b9175a8f11efc9a0955ab361e URL: https://github.com/llvm/llvm-project/commit/b10a341aa5b0b93b9175a8f11efc9a0955ab361e DIFF: https://github.com/llvm/llvm-project/commit/b10a341aa5b0b93b9175a8f11efc9a0955ab361e.dif

[clang] f964417 - Revert "[Pipelines] Introduce DAE after ArgumentPromotion"

2022-08-26 Thread Pavel Samolysov via cfe-commits
Author: Pavel Samolysov Date: 2022-08-26T13:43:09+03:00 New Revision: f964417c32d05a88c80db315e97ada639d97eda1 URL: https://github.com/llvm/llvm-project/commit/f964417c32d05a88c80db315e97ada639d97eda1 DIFF: https://github.com/llvm/llvm-project/commit/f964417c32d05a88c80db315e97ada639d97eda1.dif

[clang] 879f511 - [Pipelines] Introduce DAE after ArgumentPromotion

2022-08-25 Thread Pavel Samolysov via cfe-commits
Author: Pavel Samolysov Date: 2022-08-25T10:55:47+03:00 New Revision: 879f5118fc74657e4a5c4eff6810098e1eed75ac URL: https://github.com/llvm/llvm-project/commit/879f5118fc74657e4a5c4eff6810098e1eed75ac DIFF: https://github.com/llvm/llvm-project/commit/879f5118fc74657e4a5c4eff6810098e1eed75ac.dif

[clang] 6703ad1 - Revert "[Pipelines] Introduce DAE after ArgumentPromotion"

2022-08-24 Thread Pavel Samolysov via cfe-commits
Author: Pavel Samolysov Date: 2022-08-24T12:44:13+03:00 New Revision: 6703ad1e0c2a30153c75139764672d2ad16069c8 URL: https://github.com/llvm/llvm-project/commit/6703ad1e0c2a30153c75139764672d2ad16069c8 DIFF: https://github.com/llvm/llvm-project/commit/6703ad1e0c2a30153c75139764672d2ad16069c8.dif

[clang] 3f20dcb - [Pipelines] Introduce DAE after ArgumentPromotion

2022-08-24 Thread Pavel Samolysov via cfe-commits
Author: Pavel Samolysov Date: 2022-08-24T10:36:12+03:00 New Revision: 3f20dcbf708cb23f79c4866d8285a8ae7bd885de URL: https://github.com/llvm/llvm-project/commit/3f20dcbf708cb23f79c4866d8285a8ae7bd885de DIFF: https://github.com/llvm/llvm-project/commit/3f20dcbf708cb23f79c4866d8285a8ae7bd885de.dif

[libunwind] e251fb4 - [libunwind][CMake] Fix name of LIBUNWIND_SUPPORTS_NODEFAULTLIBS_FLAG

2022-05-26 Thread Pavel Samolysov via cfe-commits
Author: Pavel Samolysov Date: 2022-05-27T09:20:57+03:00 New Revision: e251fb4cdeb723eff5507be1efeb3fc69f7a2ce7 URL: https://github.com/llvm/llvm-project/commit/e251fb4cdeb723eff5507be1efeb3fc69f7a2ce7 DIFF: https://github.com/llvm/llvm-project/commit/e251fb4cdeb723eff5507be1efeb3fc69f7a2ce7.dif