[PATCH] D108525: Fix documentation and snippets for the handle attributes.

2021-08-23 Thread Paul Herman via Phabricator via cfe-commits
paulherman added a comment. In D108525#2960877 , @aaron.ballman wrote: > In D108525#2960765 , @paulherman > wrote: > >> Thanks for the very prompt review! I'm afraid I no longer have permissions >> to submit --

[PATCH] D108525: Fix documentation and snippets for the handle attributes.

2021-08-23 Thread Paul Herman via Phabricator via cfe-commits
paulherman added a comment. Thanks for the very prompt review! I'm afraid I no longer have permissions to submit --my last commit was in 2015 and I recall that I had SVN access, but many things have changed. Would it be possible to submit this on my behalf? Repository: rG LLVM Github Monorep

[PATCH] D108525: Fix documentation and snippets for the handle attributes.

2021-08-23 Thread Paul Herman via Phabricator via cfe-commits
paulherman updated this revision to Diff 368127. paulherman added a comment. Explaining the tag argument. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108525/new/ https://reviews.llvm.org/D108525 Files: clang/include/clang/Basic/AttrDocs.td I

[PATCH] D108525: Fix documentation and snippets for the handle attributes.

2021-08-22 Thread Paul Herman via Phabricator via cfe-commits
paulherman created this revision. Herald added a reviewer: aaron.ballman. paulherman requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D108525 Files: clang/include/clang/Basic

[PATCH] D70469: [attributes] [analyzer] Add handle related attributes

2021-08-22 Thread Paul Herman via Phabricator via cfe-commits
paulherman added inline comments. Herald added subscribers: manas, steakhal, jdoerfert, ASDenysPetrov, phosek. Comment at: clang/include/clang/Basic/AttrDocs.td:4724 + zx_status_t zx_socket_create(uint32_t options, + zx_handle_t __attribute__((acqui