RE: [PATCH] D20979: [OpenCL] Use function metadata to represent kernel attributes

2016-08-01 Thread Pan Xiuli via cfe-commits
Hi, What I mean is the spec of spir 1.2/2.0 has very clear example about how the metadata should organized. But now with this patch, the result of spir is changed and not like it before. So what I want to know is why we change the old spir example style code, but not add something alongside. No

RE: [PATCH] D20979: [OpenCL] Use function metadata to represent kernel attributes

2016-07-31 Thread Pan Xiuli via cfe-commits
Hi Sam, I am now using llvm39 to enable our opencl driver, but I found this patch broke the spir target as well. The opencl.kernels metadata is required by spir spec. I think we should keep the old code for spir target. Thanks Xiuli -Original Message- From: Yaxun Liu [mailto:yaxun@