[clang] [clang] Do not emit template parameter objects as COMDATs when they have internal linkage. (PR #125448)

https://github.com/resistor closed https://github.com/llvm/llvm-project/pull/125448 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Do not emit template parameter objects as COMDATs when they have internal linkage. (PR #125448)

https://github.com/resistor updated https://github.com/llvm/llvm-project/pull/125448 >From 8d2ed55358510e45c03934aaaffccbf12d0bffce Mon Sep 17 00:00:00 2001 From: Owen Anderson Date: Mon, 3 Feb 2025 15:41:20 +1300 Subject: [PATCH] [clang] Do not emit template parameter objects as COMDATs when

[clang] [clang] Do not emit template parameter objects as COMDATs when they have internal linkage. (PR #125448)

https://github.com/resistor updated https://github.com/llvm/llvm-project/pull/125448 >From b3078fa4389f6be3f0b8c463ab9e79f1b4a9d23b Mon Sep 17 00:00:00 2001 From: Owen Anderson Date: Mon, 3 Feb 2025 15:41:20 +1300 Subject: [PATCH] [clang] Do not emit template parameter objects as COMDATs when

[clang] [clang] Do not emit template parameter objects as COMDATs when they have internal linkage. (PR #125448)

@@ -0,0 +1,38 @@ +// RUN: %clang_cc1 -emit-llvm -std=c++20 -triple x86_64-unknown-linux-gnu %s -o - | FileCheck %s + +// COMDAT groups in ELF objects are not permitted to contain local symbols. While template parameter +// objects are normally emitted in COMDATs, we shouldn't do

[clang] [clang] Do not emit template parameter objects as COMDATs when they have internal linkage. (PR #125448)

@@ -0,0 +1,38 @@ +// RUN: %clang_cc1 -emit-llvm -std=c++20 -triple x86_64-unknown-linux-gnu %s -o - | FileCheck %s resistor wrote: Done https://github.com/llvm/llvm-project/pull/125448 ___ cfe-commits mailing list cfe

[clang] [clang] Do not emit template parameter objects as COMDATs when they have internal linkage. (PR #125448)

https://github.com/resistor updated https://github.com/llvm/llvm-project/pull/125448 >From fabd1f091d018e76d59777ce29a9d16ef6abb48f Mon Sep 17 00:00:00 2001 From: Owen Anderson Date: Mon, 3 Feb 2025 15:41:20 +1300 Subject: [PATCH] [clang] Do not emit template parameter objects as COMDATs when

[clang] [clang] Do not emit template parameter objects as COMDATs when they have internal linkage. (PR #125448)

@@ -3765,7 +3765,7 @@ ConstantAddress CodeGenModule::GetAddrOfTemplateParamObject( auto *GV = new llvm::GlobalVariable(getModule(), Init->getType(), /*isConstant=*/true, Linkage, Init, Name); setGVProperties(GV, TPO); - if (supportsC

[clang] [clang] Do not emit template parameter objects as COMDATs when they have internal linkage. (PR #125448)

https://github.com/resistor created https://github.com/llvm/llvm-project/pull/125448 Per the ELF spec, section groups may only contain local symbols if those symbols are only referenced from within the section group. [1] In the case of template parameter objects, they can be referenced from ou

[clang-tools-extra] e4e0f93 - Remove the ThreadLocal template from LLVM.

Author: Owen Anderson Date: 2023-01-10T21:07:52-07:00 New Revision: e4e0f933079859c12983f955e7ee66ba4fb39932 URL: https://github.com/llvm/llvm-project/commit/e4e0f933079859c12983f955e7ee66ba4fb39932 DIFF: https://github.com/llvm/llvm-project/commit/e4e0f933079859c12983f955e7ee66ba4fb39932.diff

[clang-tools-extra] ef9aa34 - Revert "Remove the ThreadLocal template from LLVM."

Author: Owen Anderson Date: 2023-01-09T21:21:38-07:00 New Revision: ef9aa34f0274cdbfa82c47f8ab99f02679fd0d13 URL: https://github.com/llvm/llvm-project/commit/ef9aa34f0274cdbfa82c47f8ab99f02679fd0d13 DIFF: https://github.com/llvm/llvm-project/commit/ef9aa34f0274cdbfa82c47f8ab99f02679fd0d13.diff

[clang-tools-extra] 54d78b6 - Remove the ThreadLocal template from LLVM.

Author: Owen Anderson Date: 2023-01-09T21:12:27-07:00 New Revision: 54d78b639b9c18b42abd4fac5c6e76105f06b3ef URL: https://github.com/llvm/llvm-project/commit/54d78b639b9c18b42abd4fac5c6e76105f06b3ef DIFF: https://github.com/llvm/llvm-project/commit/54d78b639b9c18b42abd4fac5c6e76105f06b3ef.diff

Re: [PATCH] D16041: Change vfs::FileSystem to be managed with std::shared_ptr

> On Jan 11, 2016, at 2:13 PM, Benjamin Kramer wrote: > > On Mon, Jan 11, 2016 at 8:08 PM, Owen Anderson <mailto:resis...@mac.com>> wrote: >> >>> On Jan 11, 2016, at 8:25 AM, David Blaikie wrote: >>> >>> >>> >>> On Sun

Re: [PATCH] D16041: Change vfs::FileSystem to be managed with std::shared_ptr

> On Jan 11, 2016, at 8:25 AM, David Blaikie wrote: > > > > On Sun, Jan 10, 2016 at 11:42 PM, Owen Anderson via cfe-commits > wrote: > resistor created this revision. > resistor added reviewers: chandlerc, bkramer, klimek. > resistor added a subscriber: cfe-

[PATCH] D16041: Change vfs::FileSystem to be managed with std::shared_ptr

resistor created this revision. resistor added reviewers: chandlerc, bkramer, klimek. resistor added a subscriber: cfe-commits. resistor set the repository for this revision to rL LLVM. Herald added a subscriber: klimek. Managing it with IntrusiveRefCntPtr caused the virtual destructor not to be