[PATCH] D158008: [AArch64] Add patterns for FMADD, FMSUB

2023-08-30 Thread OverMighty via Phabricator via cfe-commits
overmighty added a comment. Ping. If you would like the current patch with `extractelt` to be committed, please commit it as "OverMighty ". Thank you. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158008/new/ https://reviews.llvm.org/D158008 __

[PATCH] D158008: [AArch64] Add patterns for FMADD, FMSUB

2023-08-19 Thread OverMighty via Phabricator via cfe-commits
overmighty added inline comments. Comment at: llvm/lib/Target/AArch64/AArch64InstrFormats.td:5393 + (EXTRACT_SUBREG V128:$Rn, hsub), FPR16:$Rm, FPR16:$Ra)>; + } + dzhidzhoev wrote: > BTW, these lines add some patterns for fnmadd. Could you add some

[PATCH] D158008: [AArch64] Add patterns for FMADD, FMSUB

2023-08-19 Thread OverMighty via Phabricator via cfe-commits
overmighty updated this revision to Diff 551754. overmighty added a reviewer: dzhidzhoev. overmighty added a comment. - Rebase new upstream commits. - Replace usage of deprecated `vector_extract` with `extractelt` in new patterns. - Add `f16` operators before `EXTRACT_SUBREG`s in new `*Hrrr` inst

[PATCH] D158008: [AArch64] Add patterns for FMADD, FMSUB

2023-08-17 Thread OverMighty via Phabricator via cfe-commits
overmighty added a comment. The crashes in complex-deinterleaving-f16-mul.ll and fp16_intrinsic_lane.ll seem to be caused by D156831 . CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158008/new/ https://reviews.llvm.org/D158008 _

[PATCH] D158008: [AArch64] Add patterns for FMADD, FMSUB

2023-08-17 Thread OverMighty via Phabricator via cfe-commits
overmighty added a comment. If this still looks good to you, please commit it as "OverMighty ". Thank you. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158008/new/ https://reviews.llvm.org/D158008 ___ cfe-commits mailing list cfe-commits@li

[PATCH] D158008: [AArch64] Add patterns for FMADD, FMSUB

2023-08-17 Thread OverMighty via Phabricator via cfe-commits
overmighty updated this revision to Diff 551193. overmighty added a comment. Add tests for A[0]*B+C patterns. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158008/new/ https://reviews.llvm.org/D158008 Files: clang/test/CodeGen/aarch64-neon-scalar-x-indexed-elem-constrained.c llvm/l

[PATCH] D158008: [AArch64] Add patterns for FMADD, FMSUB

2023-08-15 Thread OverMighty via Phabricator via cfe-commits
overmighty created this revision. overmighty added reviewers: dmgreen, john.brawn, SjoerdMeijer. Herald added subscribers: arphaman, hiraditya, kristof.beyls. Herald added a project: All. overmighty requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llv