[clang] 351f15b - Reapply "[KeyIntsr][Clang] Builtins atoms (#134651)"

Author: Orlando Cazalet-Hyams Date: 2025-05-29T10:40:34+01:00 New Revision: 351f15ba82f861cd7441f613db8317c353ca79c2 URL: https://github.com/llvm/llvm-project/commit/351f15ba82f861cd7441f613db8317c353ca79c2 DIFF: https://github.com/llvm/llvm-project/commit/351f15ba82f861cd7441f613db8317c353ca79

[clang] 894a0dd - Revert "[KeyIntsr][Clang] Builtins atoms (#134651)"

Author: Orlando Cazalet-Hyams Date: 2025-05-28T18:31:08+01:00 New Revision: 894a0dd57f81211f9e431d9e84f2856d34f46993 URL: https://github.com/llvm/llvm-project/commit/894a0dd57f81211f9e431d9e84f2856d34f46993 DIFF: https://github.com/llvm/llvm-project/commit/894a0dd57f81211f9e431d9e84f2856d34f469

[clang] [KeyIntsr][Clang] Builtins alloca auto-init atom (PR #134651)

OCHyams wrote: Reverted due to downstream failure, will fix tomorrow! https://github.com/llvm/llvm-project/pull/134651 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [KeyInstr][Clang] Ret atom (PR #134652)

https://github.com/OCHyams edited https://github.com/llvm/llvm-project/pull/134652 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [KeyIntsr][Clang] Builtins alloca auto-init atom (PR #134651)

https://github.com/OCHyams closed https://github.com/llvm/llvm-project/pull/134651 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [KeyInstr][Clang] For stmt atom (PR #134646)

https://github.com/OCHyams updated https://github.com/llvm/llvm-project/pull/134646 >From 0c7a83007e218dd7338b92f1d50319b0f35cf55f Mon Sep 17 00:00:00 2001 From: Orlando Cazalet-Hyams Date: Thu, 3 Apr 2025 19:12:47 +0100 Subject: [PATCH 1/7] [KeyInstr][Clang] For stmt atom This patch is part o

[clang] [KeyInstr][Clang] Reset atomGroup number for each function (PR #141607)

https://github.com/OCHyams closed https://github.com/llvm/llvm-project/pull/141607 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [KeyIntsr][Clang] Builtins alloca auto-init atom (PR #134651)

@@ -4466,7 +4473,8 @@ RValue CodeGenFunction::EmitBuiltinExpr(const GlobalDecl GD, unsigned BuiltinID, Value *SizeVal = EmitScalarExpr(E->getArg(2)); EmitNonNullArgCheck(Dest, E->getArg(0)->getType(), E->getArg(0)->getExprLoc(), FD, 0); -Bui

[clang] [KeyIntsr][Clang] Builtins alloca auto-init atom (PR #134651)

https://github.com/OCHyams updated https://github.com/llvm/llvm-project/pull/134651 >From bf3a37df3a82797227e476485f6cf4c0c9a7c912 Mon Sep 17 00:00:00 2001 From: Orlando Cazalet-Hyams Date: Fri, 4 Apr 2025 14:36:43 +0100 Subject: [PATCH 1/5] [KeyInstr][Clang] Store-like builtin atoms --- clan

[clang] [llvm] [not for merge][RFC] Key Instructions front end demo (PR #130943)

https://github.com/OCHyams closed https://github.com/llvm/llvm-project/pull/130943 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [KeyInstr][Clang] Atomic ops atoms (PR #141624)

https://github.com/OCHyams created https://github.com/llvm/llvm-project/pull/141624 This patch is part of a stack that teaches Clang to generate Key Instructions metadata for C and C++. The feature is only functional in LLVM if LLVM is built with CMake flag LLVM_EXPERIMENTAL_KEY_INSTRUCTIONs.

[clang] [KeyInstr][Clang] Bitfield atom (PR #134648)

https://github.com/OCHyams updated https://github.com/llvm/llvm-project/pull/134648 >From 76d8a4306760fba28fc22c936b46d98263c37971 Mon Sep 17 00:00:00 2001 From: Orlando Cazalet-Hyams Date: Thu, 3 Apr 2025 19:57:39 +0100 Subject: [PATCH 1/3] [KeyInstr][Clang] Bitfield atom This patch is part o

[clang] [KeyInstr][Clang] For stmt atom (PR #134646)

OCHyams wrote: You were right about any ctrl-flow breaking the br-to-cond atom group. Fixed, improved testing, and follow up with additional work for continue/break in https://github.com/llvm/llvm-project/pull/141618 n.b. this is now based on top of https://github.com/llvm/llvm-project/pull/1

[clang] [KeyInstr][Clang] Catch variable init atom (PR #134641)

https://github.com/OCHyams closed https://github.com/llvm/llvm-project/pull/134641 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [KeyInstr][Clang] For stmt atom (PR #134646)

https://github.com/OCHyams updated https://github.com/llvm/llvm-project/pull/134646 >From 510cb679b679f7265107127cc3d57a76b576e42d Mon Sep 17 00:00:00 2001 From: Orlando Cazalet-Hyams Date: Tue, 27 May 2025 14:57:12 +0100 Subject: [PATCH 1/8] [KeyInstr][Clang] Reset atomGroup number for each f

[clang] [KeyInstr][Clang] For stmt atom (PR #134646)

https://github.com/OCHyams updated https://github.com/llvm/llvm-project/pull/134646 >From 510cb679b679f7265107127cc3d57a76b576e42d Mon Sep 17 00:00:00 2001 From: Orlando Cazalet-Hyams Date: Tue, 27 May 2025 14:57:12 +0100 Subject: [PATCH 1/7] [KeyInstr][Clang] Reset atomGroup number for each f

[clang] [KeyInstr][Clang] Reset atomGroup number for each function (PR #141607)

https://github.com/OCHyams created https://github.com/llvm/llvm-project/pull/141607 CGDebugInfo::completeFunction was added previously but mistakenly not called (dropped through the cracks while putting together the patch stack). Moved out of #134652 and #134654. >From 510cb679b679f7265107127

[clang] [KeyIntsr][Clang] Builtins alloca auto-init atom (PR #134651)

@@ -0,0 +1,77 @@ + +// RUN: %clang_cc1 -gkey-instructions -x c++ %s -debug-info-kind=line-tables-only -gno-column-info -emit-llvm -o - -ftrivial-auto-var-init=zero -fenable-matrix -disable-llvm-passes \ +// RUN: | FileCheck %s --implicit-check-not atomGroup --implicit-check-not

[clang] [KeyInstr][Clang] Assign vector element atom (PR #134649)

https://github.com/OCHyams updated https://github.com/llvm/llvm-project/pull/134649 >From d5bf606509f4f4fcb30e0cb1ea2fe0b51e5a5b5c Mon Sep 17 00:00:00 2001 From: Orlando Cazalet-Hyams Date: Thu, 3 Apr 2025 21:56:37 +0100 Subject: [PATCH] [KeyInstr][Clang] Assign vector element atom This patch

[clang] [KeyInstr][Clang] Assign matrix element atom (PR #134650)

https://github.com/OCHyams edited https://github.com/llvm/llvm-project/pull/134650 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [KeyInstr][Clang] Assign matrix element atom (PR #134650)

https://github.com/OCHyams closed https://github.com/llvm/llvm-project/pull/134650 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [KeyInstr][Clang] Assign matrix element atom (PR #134650)

https://github.com/OCHyams updated https://github.com/llvm/llvm-project/pull/134650 >From 1a7848740a2b708724d057cd881a3e4db42e96e3 Mon Sep 17 00:00:00 2001 From: Orlando Cazalet-Hyams Date: Thu, 3 Apr 2025 22:05:32 +0100 Subject: [PATCH 1/2] [KeyInstr][Clang] Assign matrix element atom This pa

[clang] [KeyInstr][Clang] Assign vector element atom (PR #134649)

https://github.com/OCHyams closed https://github.com/llvm/llvm-project/pull/134649 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [KeyInstr][Clang] Bitfield atom (PR #134648)

https://github.com/OCHyams closed https://github.com/llvm/llvm-project/pull/134648 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [KeyInstr][Clang] Switch stmt atom (PR #134643)

https://github.com/OCHyams closed https://github.com/llvm/llvm-project/pull/134643 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [KeyInstr][Clang] Switch stmt atom (PR #134643)

https://github.com/OCHyams updated https://github.com/llvm/llvm-project/pull/134643 >From 71a5f65a7ecbd0b1ba3b5e45f0b03fa34484f85a Mon Sep 17 00:00:00 2001 From: Orlando Cazalet-Hyams Date: Thu, 3 Apr 2025 18:43:56 +0100 Subject: [PATCH 1/3] [KeyInstr][Clang] Switch stmt atom This patch is par

[clang] [KeyInstr] Complex assignment atoms (PR #134638)

https://github.com/OCHyams closed https://github.com/llvm/llvm-project/pull/134638 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [KeyInstr][Clang] Catch variable init atom (PR #134641)

https://github.com/OCHyams updated https://github.com/llvm/llvm-project/pull/134641 >From 7c86cc1b0b0bfaba4c304a31b5b0f2a1f391ad63 Mon Sep 17 00:00:00 2001 From: Orlando Cazalet-Hyams Date: Thu, 3 Apr 2025 17:31:32 +0100 Subject: [PATCH 1/3] [KeyInstr][Clang] Catch variable init atom This patc

[clang] [KeyInstr] Complex assignment atoms (PR #134638)

https://github.com/OCHyams updated https://github.com/llvm/llvm-project/pull/134638 >From fa1c06148d4f79e9464d92ab5c26d9a22c5bf41d Mon Sep 17 00:00:00 2001 From: Orlando Cazalet-Hyams Date: Thu, 3 Apr 2025 13:36:59 +0100 Subject: [PATCH 01/10] [KeyInstr] Complex assignment atoms This patch is

[clang] [KeyInstr] Complex assignment atoms (PR #134638)

https://github.com/OCHyams updated https://github.com/llvm/llvm-project/pull/134638 >From fa1c06148d4f79e9464d92ab5c26d9a22c5bf41d Mon Sep 17 00:00:00 2001 From: Orlando Cazalet-Hyams Date: Thu, 3 Apr 2025 13:36:59 +0100 Subject: [PATCH 1/9] [KeyInstr] Complex assignment atoms This patch is pa

[clang] 94929b7 - [KeyInstr] Add triple to Clang tests

Author: Orlando Cazalet-Hyams Date: 2025-05-27T10:54:44+01:00 New Revision: 94929b725f415a8ab8de35194f3c2eec5192990f URL: https://github.com/llvm/llvm-project/commit/94929b725f415a8ab8de35194f3c2eec5192990f DIFF: https://github.com/llvm/llvm-project/commit/94929b725f415a8ab8de35194f3c2eec519299

[clang] [KeyInstr] Complex assignment atoms (PR #134638)

OCHyams wrote: Sorry I misunderstood what you were saying. Fixed, this should now have symmetry with prior patches. Expanded the test coverage. There's 4 binop assign calls that are instrumented individually which reflects the previous patch's macro usage. The expanded test coverage identified

[clang] [KeyInstr] Complex assignment atoms (PR #134638)

https://github.com/OCHyams updated https://github.com/llvm/llvm-project/pull/134638 >From fa1c06148d4f79e9464d92ab5c26d9a22c5bf41d Mon Sep 17 00:00:00 2001 From: Orlando Cazalet-Hyams Date: Thu, 3 Apr 2025 13:36:59 +0100 Subject: [PATCH 1/8] [KeyInstr] Complex assignment atoms This patch is pa

[clang] [KeyIntsr][Clang] Builtins alloca auto-init atom (PR #134651)

https://github.com/OCHyams updated https://github.com/llvm/llvm-project/pull/134651 >From bf3a37df3a82797227e476485f6cf4c0c9a7c912 Mon Sep 17 00:00:00 2001 From: Orlando Cazalet-Hyams Date: Fri, 4 Apr 2025 14:36:43 +0100 Subject: [PATCH 1/2] [KeyInstr][Clang] Store-like builtin atoms --- clan

[clang] [KeyIntsr][Clang] Builtins alloca auto-init atom (PR #134651)

https://github.com/OCHyams ready_for_review https://github.com/llvm/llvm-project/pull/134651 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [KeyIntsr][Clang] Builtins alloca auto-init atom (PR #134651)

https://github.com/OCHyams edited https://github.com/llvm/llvm-project/pull/134651 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [KeyInstr][Clang] Assign vector element atom (PR #134649)

https://github.com/OCHyams ready_for_review https://github.com/llvm/llvm-project/pull/134649 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [KeyInstr][Clang] Assign vector element atom (PR #134649)

https://github.com/OCHyams edited https://github.com/llvm/llvm-project/pull/134649 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [KeyInstr][Clang] Bitfield atom (PR #134648)

https://github.com/OCHyams ready_for_review https://github.com/llvm/llvm-project/pull/134648 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [KeyInstr][Clang] Bitfield atom (PR #134648)

https://github.com/OCHyams edited https://github.com/llvm/llvm-project/pull/134648 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [KeyInstr][Clang] For range stmt atoms (PR #134647)

https://github.com/OCHyams ready_for_review https://github.com/llvm/llvm-project/pull/134647 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [KeyInstr][Clang] For range stmt atoms (PR #134647)

https://github.com/OCHyams edited https://github.com/llvm/llvm-project/pull/134647 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [KeyInstr][Clang] For stmt atom (PR #134646)

https://github.com/OCHyams updated https://github.com/llvm/llvm-project/pull/134646 >From 8be98dcf4e19f1971a03ad072336f0e0e9c67a55 Mon Sep 17 00:00:00 2001 From: Orlando Cazalet-Hyams Date: Thu, 3 Apr 2025 19:12:47 +0100 Subject: [PATCH 1/2] [KeyInstr][Clang] For stmt atom This patch is part o

[clang] [KeyInstr][Clang] For stmt atom (PR #134646)

https://github.com/OCHyams ready_for_review https://github.com/llvm/llvm-project/pull/134646 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [KeyInstr][Clang] For stmt atom (PR #134646)

https://github.com/OCHyams converted_to_draft https://github.com/llvm/llvm-project/pull/134646 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [KeyInstr][Clang] For stmt atom (PR #134646)

https://github.com/OCHyams edited https://github.com/llvm/llvm-project/pull/134646 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [KeyInstr][Clang] While stmt atom (PR #134645)

https://github.com/OCHyams closed https://github.com/llvm/llvm-project/pull/134645 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [KeyInstr][Clang] While stmt atom (PR #134645)

https://github.com/OCHyams updated https://github.com/llvm/llvm-project/pull/134645 >From 984039ede0eb3626feaeaa74f875165f4c5d91d1 Mon Sep 17 00:00:00 2001 From: Orlando Cazalet-Hyams Date: Thu, 3 Apr 2025 18:49:32 +0100 Subject: [PATCH 1/3] [KeyInstr][Clang] While stmt atom See test comment f

[clang] [KeyInstr][Clang] While stmt atom (PR #134645)

https://github.com/OCHyams ready_for_review https://github.com/llvm/llvm-project/pull/134645 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [KeyInstr][Clang] While stmt atom (PR #134645)

https://github.com/OCHyams updated https://github.com/llvm/llvm-project/pull/134645 >From 984039ede0eb3626feaeaa74f875165f4c5d91d1 Mon Sep 17 00:00:00 2001 From: Orlando Cazalet-Hyams Date: Thu, 3 Apr 2025 18:49:32 +0100 Subject: [PATCH 1/2] [KeyInstr][Clang] While stmt atom See test comment f

[clang] [KeyInstr][Clang] While stmt atom (PR #134645)

https://github.com/OCHyams converted_to_draft https://github.com/llvm/llvm-project/pull/134645 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [KeyInstr][Clang] While stmt atom (PR #134645)

https://github.com/OCHyams edited https://github.com/llvm/llvm-project/pull/134645 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [KeyInstr][Clang] Do stmt atom (PR #134644)

https://github.com/OCHyams closed https://github.com/llvm/llvm-project/pull/134644 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [KeyInstr][Clang] Do stmt atom (PR #134644)

@@ -1242,9 +1242,17 @@ void CodeGenFunction::EmitDoStmt(const DoStmt &S, // As long as the condition is true, iterate the loop. if (EmitBoolCondBranch) { uint64_t BackedgeCount = getProfileCount(S.getBody()) - ParentCount; -Builder.CreateCondBr( +auto *I = Build

[clang] [KeyInstr][Clang] Do stmt atom (PR #134644)

@@ -0,0 +1,33 @@ +// RUN: %clang_cc1 -gkey-instructions -x c++ -std=c++17 %s -debug-info-kind=line-tables-only -emit-llvm -o - \ +// RUN: | FileCheck %s --implicit-check-not atomGroup --implicit-check-not atomRank + +// RUN: %clang_cc1 -gkey-instructions -x c %s -debug-info-kin

[clang] [KeyInstr][Clang] Do stmt atom (PR #134644)

https://github.com/OCHyams ready_for_review https://github.com/llvm/llvm-project/pull/134644 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [KeyInstr][Clang] Do stmt atom (PR #134644)

@@ -0,0 +1,33 @@ +// RUN: %clang_cc1 -gkey-instructions -x c++ -std=c++17 %s -debug-info-kind=line-tables-only -emit-llvm -o - \ +// RUN: | FileCheck %s --implicit-check-not atomGroup --implicit-check-not atomRank + +// RUN: %clang_cc1 -gkey-instructions -x c %s -debug-info-kin

[clang] [KeyInstr][Clang] Do stmt atom (PR #134644)

@@ -1242,9 +1242,17 @@ void CodeGenFunction::EmitDoStmt(const DoStmt &S, // As long as the condition is true, iterate the loop. if (EmitBoolCondBranch) { uint64_t BackedgeCount = getProfileCount(S.getBody()) - ParentCount; -Builder.CreateCondBr( +auto *I = Build

[clang] [KeyInstr][Clang] Do stmt atom (PR #134644)

https://github.com/OCHyams updated https://github.com/llvm/llvm-project/pull/134644 >From fece69dc87e3c303aaba742f322377fd361e21ce Mon Sep 17 00:00:00 2001 From: Orlando Cazalet-Hyams Date: Thu, 3 Apr 2025 18:53:31 +0100 Subject: [PATCH 1/3] [KeyInstr][Clang] Do stmt atom See test comment for

[clang] [KeyInstr][Clang] Do stmt atom (PR #134644)

https://github.com/OCHyams updated https://github.com/llvm/llvm-project/pull/134644 >From fece69dc87e3c303aaba742f322377fd361e21ce Mon Sep 17 00:00:00 2001 From: Orlando Cazalet-Hyams Date: Thu, 3 Apr 2025 18:53:31 +0100 Subject: [PATCH 1/2] [KeyInstr][Clang] Do stmt atom See test comment for

[clang] 123bf5f - [KeyInstr][Clang] If stmt atom (#134642)

Author: Orlando Cazalet-Hyams Date: 2025-05-23T13:46:37+01:00 New Revision: 123bf5f46c31a016768b7ecd9b164bde5ef881d9 URL: https://github.com/llvm/llvm-project/commit/123bf5f46c31a016768b7ecd9b164bde5ef881d9 DIFF: https://github.com/llvm/llvm-project/commit/123bf5f46c31a016768b7ecd9b164bde5ef881

[clang] [KeyInstr][Clang] Catch variable init atom (PR #134641)

https://github.com/OCHyams ready_for_review https://github.com/llvm/llvm-project/pull/134641 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [KeyInstr][Clang] Catch variable init atom (PR #134641)

@@ -5055,6 +5055,7 @@ void ItaniumCXXABI::emitBeginCatch(CodeGenFunction &CGF, // Emit the local. CodeGenFunction::AutoVarEmission var = CGF.EmitAutoVarAlloca(*CatchParam); + ApplyAtomGroup Grp(CGF.getDebugInfo()); InitCatchParam(CGF, *CatchParam, var.getObjectAddress(

[clang] [KeyInstr][Clang] Catch variable init atom (PR #134641)

https://github.com/OCHyams updated https://github.com/llvm/llvm-project/pull/134641 >From 7c86cc1b0b0bfaba4c304a31b5b0f2a1f391ad63 Mon Sep 17 00:00:00 2001 From: Orlando Cazalet-Hyams Date: Thu, 3 Apr 2025 17:31:32 +0100 Subject: [PATCH 1/2] [KeyInstr][Clang] Catch variable init atom This patc

[clang] [KeyInstr][Clang] Catch variable init atom (PR #134641)

https://github.com/OCHyams converted_to_draft https://github.com/llvm/llvm-project/pull/134641 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 435a542 - [KeyInstr] Fix clang tests

Author: Orlando Cazalet-Hyams Date: 2025-05-23T11:19:30+01:00 New Revision: 435a542009d45d85fbd9a2ff0df735572d5cc276 URL: https://github.com/llvm/llvm-project/commit/435a542009d45d85fbd9a2ff0df735572d5cc276 DIFF: https://github.com/llvm/llvm-project/commit/435a542009d45d85fbd9a2ff0df735572d5cc2

[clang] [KeyInstr][Clang] Do stmt atom (PR #134644)

https://github.com/OCHyams updated https://github.com/llvm/llvm-project/pull/134644 >From 1219e5b01cd9cc38fe85d3377354c6e56e51134a Mon Sep 17 00:00:00 2001 From: Orlando Cazalet-Hyams Date: Thu, 3 Apr 2025 18:53:31 +0100 Subject: [PATCH 1/2] [KeyInstr][Clang] Do stmt atom See test comment for

[clang] [KeyInstr][Clang] Do stmt atom (PR #134644)

https://github.com/OCHyams edited https://github.com/llvm/llvm-project/pull/134644 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [KeyInstr][Clang] Catch variable init atom (PR #134641)

https://github.com/OCHyams edited https://github.com/llvm/llvm-project/pull/134641 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [KeyInstr][Clang] Switch stmt atom (PR #134643)

https://github.com/OCHyams ready_for_review https://github.com/llvm/llvm-project/pull/134643 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [KeyInstr][Clang] Switch stmt atom (PR #134643)

https://github.com/OCHyams edited https://github.com/llvm/llvm-project/pull/134643 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [KeyInstr][Clang] Catch variable init atom (PR #134641)

https://github.com/OCHyams updated https://github.com/llvm/llvm-project/pull/134641 >From ae032c5dd3537662508d77bbb447808f52481f5d Mon Sep 17 00:00:00 2001 From: Orlando Cazalet-Hyams Date: Tue, 1 Apr 2025 11:59:24 +0100 Subject: [PATCH 01/33] [KeyInstr][Clang] Add ApplyAtomGroup This is a sco

[clang] [KeyInstr] Complex assignment atoms (PR #134638)

OCHyams wrote: Sorry to all that were added... grappling with messed-up graphite internal state, GitHub enjoys adding reviewers for me when I change base. https://github.com/llvm/llvm-project/pull/134638 ___ cfe-commits mailing list cfe-commits@lists.

[clang] [KeyInstr][Clang] Member initalization atom (PR #134640)

https://github.com/OCHyams closed https://github.com/llvm/llvm-project/pull/134640 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [KeyInstr][Clang] Member initalization atom (PR #134640)

https://github.com/OCHyams updated https://github.com/llvm/llvm-project/pull/134640 >From 58615d2b93f4644bc7574d86b580d05edf1ca03c Mon Sep 17 00:00:00 2001 From: Orlando Cazalet-Hyams Date: Thu, 3 Apr 2025 17:00:09 +0100 Subject: [PATCH 1/2] [KeyInstr][Clang] Member initalization atom This pat

[clang] [KeyInstr][Clang] Assignment atom group (PR #134637)

https://github.com/OCHyams closed https://github.com/llvm/llvm-project/pull/134637 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [KeyInstr] Complex assignment atoms (PR #134638)

https://github.com/OCHyams edited https://github.com/llvm/llvm-project/pull/134638 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [KeyInstr][Clang] Assignment atom group (PR #134637)

https://github.com/OCHyams updated https://github.com/llvm/llvm-project/pull/134637 >From 5f5c881e69776978ef8e237932feed403cc2 Mon Sep 17 00:00:00 2001 From: Orlando Cazalet-Hyams Date: Wed, 2 Apr 2025 18:01:48 +0100 Subject: [PATCH 01/12] [KeyInstr][Clang] Assignment atom group This patch

[clang] [KeyInstr][Clang] Static variable init atom (PR #134636)

https://github.com/OCHyams closed https://github.com/llvm/llvm-project/pull/134636 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [KeyInstr][Clang] Assignment atom group (PR #134637)

https://github.com/OCHyams edited https://github.com/llvm/llvm-project/pull/134637 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [KeyInstr][Clang] Static variable init atom (PR #134636)

https://github.com/OCHyams updated https://github.com/llvm/llvm-project/pull/134636 >From b1b2e0d6e0924ac273c832696ddcc233cd18aa24 Mon Sep 17 00:00:00 2001 From: Orlando Cazalet-Hyams Date: Wed, 2 Apr 2025 17:42:48 +0100 Subject: [PATCH 1/2] [KeyInstr][Clang] Static variable init atom This pat

[clang] [KeyInstr][Clang] Static variable init atom (PR #134636)

https://github.com/OCHyams edited https://github.com/llvm/llvm-project/pull/134636 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [KeyInstr][Clang] Agg init atom (PR #134635)

https://github.com/OCHyams closed https://github.com/llvm/llvm-project/pull/134635 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [KeyInstr][Clang] Agg init atom (PR #134635)

https://github.com/OCHyams updated https://github.com/llvm/llvm-project/pull/134635 >From c4029c3503f565ab6c2faa9cdec129c79133ff4f Mon Sep 17 00:00:00 2001 From: Orlando Cazalet-Hyams Date: Tue, 1 Apr 2025 15:40:58 +0100 Subject: [PATCH 1/7] [KeyInstr][Clang] Agg init atom This patch is part o

[clang] [KeyInstr][Clang] Agg init atom (PR #134635)

https://github.com/OCHyams edited https://github.com/llvm/llvm-project/pull/134635 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [KeyInstr][Clang] Scalar init atom (PR #134633)

https://github.com/OCHyams closed https://github.com/llvm/llvm-project/pull/134633 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [KeyInstr][Clang] Scalar init atom (PR #134633)

https://github.com/OCHyams updated https://github.com/llvm/llvm-project/pull/134633 >From c64f3e7363dae15d09188ec22d618be9841d8784 Mon Sep 17 00:00:00 2001 From: Orlando Cazalet-Hyams Date: Tue, 1 Apr 2025 14:50:41 +0100 Subject: [PATCH 1/2] [KeyInstr][Clang] Scalar init atom This patch is par

[clang] [KeyInstr][Clang] Add ApplyAtomGroup (PR #134632)

https://github.com/OCHyams updated https://github.com/llvm/llvm-project/pull/134632 >From ae032c5dd3537662508d77bbb447808f52481f5d Mon Sep 17 00:00:00 2001 From: Orlando Cazalet-Hyams Date: Tue, 1 Apr 2025 11:59:24 +0100 Subject: [PATCH 1/4] [KeyInstr][Clang] Add ApplyAtomGroup This is a scope

[clang] [KeyInstr][Clang] Add ApplyAtomGroup (PR #134632)

OCHyams wrote: I jumped forward to the `ret` patch and found a simpler solution. I haven't updated the `ret` pull request just yet (will get to it soon), but it basically just involves passing an atom group number through a single specific function to pass to `addInstToSpecificSourceAtom`. Ho

[clang] [KeyInstr][Clang] Add ApplyAtomGroup (PR #134632)

https://github.com/OCHyams updated https://github.com/llvm/llvm-project/pull/134632 >From ae032c5dd3537662508d77bbb447808f52481f5d Mon Sep 17 00:00:00 2001 From: Orlando Cazalet-Hyams Date: Tue, 1 Apr 2025 11:59:24 +0100 Subject: [PATCH 1/3] [KeyInstr][Clang] Add ApplyAtomGroup This is a scope

[clang] [KeyInstr][Clang] Add Clang option -g[no-]key-instructions (PR #134627)

OCHyams wrote: Thanks for the reviews. > Looks good; I understand we have to support driver flags forever because they > get baked into peoples build systems. Would we be able to get away with a cc1 > flag instead? > I suppose this strays into the topic of "how are we going to deploy this",

[clang] [KeyInstr][Clang] Add Clang option -g[no-]key-instructions (PR #134627)

@@ -4767,6 +4767,13 @@ renderDebugOptions(const ToolChain &TC, const Driver &D, const llvm::Triple &T, CmdArgs.push_back("-gembed-source"); } + if (Args.hasFlag(options::OPT_gkey_instructions, + options::OPT_gno_key_instructions, false)) { +CmdA

[clang] [KeyInstr][Clang] Add Clang option -g[no-]key-instructions (PR #134627)

https://github.com/OCHyams updated https://github.com/llvm/llvm-project/pull/134627 >From 4d6e182ae2b6fea246492cd80c9fce75d1c7397d Mon Sep 17 00:00:00 2001 From: Orlando Cazalet-Hyams Date: Mon, 31 Mar 2025 15:14:51 +0100 Subject: [PATCH 1/2] [KeyInstr][Clang] Add Clang option -g[no-]key-instr

[clang] [llvm] [KeyInstr] Add docs (PR #137991)

https://github.com/OCHyams created https://github.com/llvm/llvm-project/pull/137991 These documents explain the core ideas and some implementation details of the Key Instructions project. The LLVM document also outlines the two main limitations of our approach. RFC: https://discourse.llvm.or

[clang] [clang] fix unresolved dependent template specialization mangling (PR #135111)

@@ -399,3 +399,20 @@ namespace type_qualifier { // CHECK: @_ZN14type_qualifier1gIPiEEvDTcmcvv_ELi1EE template void g(int); } + +namespace unresolved_template_specialization_type { + template struct enable_if {}; + struct Foo { +static const int value = true; + }; +

[clang] 3086546 - [Clang][NFC] Move some static functions into CodeGenFunction (#134634)

Author: Orlando Cazalet-Hyams Date: 2025-04-08T08:44:10+01:00 New Revision: 308654608cb8bc5bbd5d4b3779cb7d92920dd6b7 URL: https://github.com/llvm/llvm-project/commit/308654608cb8bc5bbd5d4b3779cb7d92920dd6b7 DIFF: https://github.com/llvm/llvm-project/commit/308654608cb8bc5bbd5d4b3779cb7d92920dd6

[clang] [llvm] [Assignment Tracking] Replace `undef` debug info with `poison` (PR #129755)

https://github.com/OCHyams approved this pull request. LGTM, thanks https://github.com/llvm/llvm-project/pull/129755 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [DebugInfo] Update DIBuilder insertion to take InsertPosition (PR #126059)

@@ -1686,7 +1686,8 @@ LLVMDbgRecordRef LLVMDIBuilderInsertDeclareRecordBefore( DbgInstPtr DbgInst = unwrap(Builder)->insertDeclare( unwrap(Storage), unwrap(VarInfo), unwrap(Expr), unwrap(DL), - unwrap(Instr)); + Instr ? InsertPosition(unwrap(Instr)->getI

[clang] [llvm] [DebugInfo] Update DIBuilder insertion to take InsertPosition (PR #126059)

@@ -1686,7 +1686,8 @@ LLVMDbgRecordRef LLVMDIBuilderInsertDeclareRecordBefore( DbgInstPtr DbgInst = unwrap(Builder)->insertDeclare( unwrap(Storage), unwrap(VarInfo), unwrap(Expr), unwrap(DL), - unwrap(Instr)); + Instr ? InsertPosition(unwrap(Instr)->getI

[clang] [llvm] [DebugInfo] Update DIBuilder insertion to take InsertPosition (PR #126059)

https://github.com/OCHyams commented: > @OCHyams I believe you did the C API changes, are there any additional > concerns in this area? SGTM, just one inline question https://github.com/llvm/llvm-project/pull/126059 ___ cfe-commits mailing list cfe-c

  1   2   >