[clang] [clang] Move opt level in clang toolchain to clang::ConstructJob start (PR #141036)

2025-05-28 Thread Omar Ahmed via cfe-commits
omarahmed wrote: @Artem-B @tarunprabhu Could you merge it for me as I don't have access, Thanks! https://github.com/llvm/llvm-project/pull/141036 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinf

[clang] [clang] Move opt level in clang toolchain to clang::ConstructJob start (PR #141036)

2025-05-22 Thread Omar Ahmed via cfe-commits
omarahmed wrote: @tarunprabhu @florianhumblot @alexey-bataev @RKSimon @phoebewang Not sure who to as for review, so please review or if you could mention who is responsible for reviewing this code, Thanks! https://github.com/llvm/llvm-project/pull/141036 ___

[clang] [clang] Move opt level in clang toolchain to clang::ConstructJob start (PR #141036)

2025-05-22 Thread Omar Ahmed via cfe-commits
https://github.com/omarahmed edited https://github.com/llvm/llvm-project/pull/141036 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Move opt level in clang toolchain to clang::ConstructJob start (PR #141036)

2025-05-22 Thread Omar Ahmed via cfe-commits
https://github.com/omarahmed updated https://github.com/llvm/llvm-project/pull/141036 >From 0eb754713a8c2994144417f9d5ce12cbfefe19d0 Mon Sep 17 00:00:00 2001 From: omarahmed Date: Thu, 22 May 2025 11:19:53 +0100 Subject: [PATCH] [Clang] Move opt level in clang toolchain to beginning --

[clang] [Clang] Move opt level in clang toolchain to clang::ConstructJob start (PR #141036)

2025-05-22 Thread Omar Ahmed via cfe-commits
https://github.com/omarahmed edited https://github.com/llvm/llvm-project/pull/141036 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Move opt level in clang toolchain to beginning (PR #141036)

2025-05-22 Thread Omar Ahmed via cfe-commits
https://github.com/omarahmed created https://github.com/llvm/llvm-project/pull/141036 We currently transfer the opt level from the user clang call to CC1 args at the end of the `ConstructJob` function, this might lead to bugs as `ConstructJob` is a big function and we easily could add a ch

[clang] Pass -offload-lto instead of -lto for cuda/hip kernels (PR #125243)

2025-02-14 Thread Omar Ahmed via cfe-commits
https://github.com/omarahmed closed https://github.com/llvm/llvm-project/pull/125243 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Pass -offload-lto instead of -lto for cuda/hip kernels (PR #125243)

2025-02-04 Thread Omar Ahmed via cfe-commits
@@ -498,12 +498,16 @@ Expected clang(ArrayRef InputFiles, const ArgList &Args) { }; // Forward all of the `--offload-opt` and similar options to the device. - CmdArgs.push_back("-flto"); for (auto &Arg : Args.filtered(OPT_offload_opt_eq_minus, OPT_mllvm)) CmdArgs

[clang] Pass -offload-lto instead of -lto for cuda/hip kernels (PR #125243)

2025-02-04 Thread Omar Ahmed via cfe-commits
@@ -498,12 +498,16 @@ Expected clang(ArrayRef InputFiles, const ArgList &Args) { }; // Forward all of the `--offload-opt` and similar options to the device. - CmdArgs.push_back("-flto"); for (auto &Arg : Args.filtered(OPT_offload_opt_eq_minus, OPT_mllvm)) CmdArgs

[clang] Pass -offload-lto instead of -lto for cuda/hip kernels (PR #125243)

2025-02-04 Thread Omar Ahmed via cfe-commits
@@ -498,12 +498,16 @@ Expected clang(ArrayRef InputFiles, const ArgList &Args) { }; // Forward all of the `--offload-opt` and similar options to the device. - CmdArgs.push_back("-flto"); for (auto &Arg : Args.filtered(OPT_offload_opt_eq_minus, OPT_mllvm)) CmdArgs

[clang] Pass -offload-lto instead of -lto for cuda/hip kernels (PR #125243)

2025-02-03 Thread Omar Ahmed via cfe-commits
@@ -498,12 +498,16 @@ Expected clang(ArrayRef InputFiles, const ArgList &Args) { }; // Forward all of the `--offload-opt` and similar options to the device. - CmdArgs.push_back("-flto"); for (auto &Arg : Args.filtered(OPT_offload_opt_eq_minus, OPT_mllvm)) CmdArgs

[clang] Pass -offload-lto instead of -lto for cuda/hip kernels (PR #125243)

2025-02-03 Thread Omar Ahmed via cfe-commits
@@ -498,12 +498,16 @@ Expected clang(ArrayRef InputFiles, const ArgList &Args) { }; // Forward all of the `--offload-opt` and similar options to the device. - CmdArgs.push_back("-flto"); for (auto &Arg : Args.filtered(OPT_offload_opt_eq_minus, OPT_mllvm)) CmdArgs

[clang] Pass -offload-lto instead of -lto for cuda/hip kernels (PR #125243)

2025-02-03 Thread Omar Ahmed via cfe-commits
https://github.com/omarahmed updated https://github.com/llvm/llvm-project/pull/125243 >From f3d466bffc2113b54d62e9a45370c643800b218c Mon Sep 17 00:00:00 2001 From: omarahmed Date: Fri, 31 Jan 2025 15:42:11 + Subject: [PATCH] Pass -offload-lto instead of -lto for cuda/hip kernels --

[clang] Pass -offload-lto instead of -lto for cuda/hip kernels (PR #125243)

2025-02-03 Thread Omar Ahmed via cfe-commits
@@ -498,12 +498,17 @@ Expected clang(ArrayRef InputFiles, const ArgList &Args) { }; // Forward all of the `--offload-opt` and similar options to the device. - CmdArgs.push_back("-flto"); for (auto &Arg : Args.filtered(OPT_offload_opt_eq_minus, OPT_mllvm)) CmdArgs

[clang] Pass -offload-lto instead of -lto for cuda/hip kernels (PR #125243)

2025-01-31 Thread Omar Ahmed via cfe-commits
https://github.com/omarahmed updated https://github.com/llvm/llvm-project/pull/125243 >From fcfe4fafa937b6320e779f56c2ba42327df143d4 Mon Sep 17 00:00:00 2001 From: omarahmed Date: Fri, 31 Jan 2025 15:42:11 + Subject: [PATCH] Pass -offload-lto instead of -lto for cuda/hip kernels --

[clang] Pass -offload-lto instead of -lto for cuda/hip kernels (PR #125243)

2025-01-31 Thread Omar Ahmed via cfe-commits
https://github.com/omarahmed created https://github.com/llvm/llvm-project/pull/125243 ClangLinkerWrapper tool in one of its clang commands to generate ptx kernel binary from llvm bitcode kernel was using -flto option which should be only used for cpu code not gpu kernel code. This PR fixes