tupos added a comment.
Hi,
could you please provide a code review again?
Thanks.
With best regards,
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D140275/new/
https://reviews.llvm.org/D140275
___
cfe-c
tupos added a comment.
Could you please also advice me what else need to be done for the ObjC, since
there were many years since I wrote ObjC last time I'm not sure what else need
to be done there.
Thanks.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm
tupos added inline comments.
Comment at: clang-tools-extra/clangd/refactor/tweaks/AddDoxygenComment.cpp:24
+namespace clang {
+namespace clangd {
+namespace {
tschuett wrote:
> You can merge this into `namespace clang::clangd`.
I prefer not to do it, because all
tupos updated this revision to Diff 506220.
tupos marked 11 inline comments as done.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D140275/new/
https://reviews.llvm.org/D140275
Files:
clang-tools-extra/clangd/refactor/tweaks/AddDoxygenComment.cpp
tupos added a comment.
Hi,
sorry for the long delay, but actually in this particular moment I was working
on addressing the comments.
Therefore, I will push the updated patch soon.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D140275/new/
https:
tupos added a comment.
Also I tried to use it now, and I'm not sure where it is a good idea to allow
this tweak from within a function body. Because it is quite annoying that in
every function you get this code action.
On the other hand maybe it is ok to allow it from within the body, but the
tupos added a comment.
I do not know but maybe it makes sence to make configurable the style of the
comment, e.g instead of `@brief` use `\brief` and the same for `/*!` to `/**`
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D140275/new/
https://rev
tupos created this revision.
tupos added reviewers: sammccall, njames93.
tupos added a project: clang-tools-extra.
Herald added subscribers: kadircet, arphaman.
Herald added a project: All.
tupos requested review of this revision.
Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov.
Repo
tupos created this revision.
tupos added reviewers: sammccall, njames93.
tupos added a project: clang-tools-extra.
Herald added subscribers: kadircet, arphaman.
Herald added a project: All.
tupos requested review of this revision.
Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov.
Repo